Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable thermostat init function #12800

Closed
wants to merge 5 commits into from
Closed

Enable thermostat init function #12800

wants to merge 5 commits into from

Conversation

andy31415
Copy link
Contributor

Problem

Thermostat init function not used/enabled.

Change overview

Enable thermostat init callback function.
Fix signatures
Sort enabling list
Use attribute store to keep featuremap value (but unsure if this is correct or works)
Fix code compilation

Testing

Not tested, hence draft.

@boring-cyborg boring-cyborg bot added the app label Dec 9, 2021
@andy31415 andy31415 mentioned this pull request Dec 9, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12800: Size comparison from a8b7f4b to 55607ae

Increases (4 builds for esp32, linux, p6)
platform target config section a8b7f4b 55607ae change % change
esp32 all-clusters-app c3devkit (read only) 860328 860364 36 0.0
(read/write) 1307034 1307050 16 0.0
.dram0.data 14124 14132 8 0.1
.flash.text 860328 860364 36 0.0
m5stack (read only) 964299 964331 32 0.0
.flash.text 958915 958947 32 0.0
linux thermostat-no-ble arm64 (read only) 1935956 1936100 144 0.0
.data.rel.ro 69800 69808 8 0.0
.text 1604944 1605040 96 0.0
p6 all-clusters-app default (read/write) 2357576 2357608 32 0.0
.text 1315840 1315872 32 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a8b7f4b 55607ae change % change
efr32 lighting-app BRD4161A (read only) 806372 806372 0 0.0
(read/write) 123004 123004 0 0.0
.bss 121184 121184 0 0.0
.data 1820 1820 0 0.0
.text 806364 806364 0 0.0
BRD4161A+rpc (read only) 794008 794008 0 0.0
(read/write) 139688 139688 0 0.0
.bss 137760 137760 0 0.0
.data 1928 1928 0 0.0
.text 794000 794000 0 0.0
window-app BRD4161A (read only) 783124 783124 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 783116 783116 0 0.0
esp32 all-clusters-app c3devkit (read only) 860328 860364 36 0.0
(read/write) 1307034 1307050 16 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14132 8 0.1
.flash.rodata 172232 172232 0 0.0
.flash.text 860328 860364 36 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964299 964331 32 0.0
(read/write) 451332 451332 0 0.0
.dram0.bss 75008 75008 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210488 210488 0 0.0
.flash.text 958915 958947 32 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 726284 726284 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 637384 637384 0 0.0
lock-app k32w061+debug (read/write) 617444 617444 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 537912 537912 0 0.0
shell k32w061+debug (read/write) 680684 680684 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 591480 591480 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6765708 6765708 0 0.0
(read/write) 317057 317057 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207832 207832 0 0.0
.dynamic 560 560 0 0.0
.got 52912 52912 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363372 363372 0 0.0
.text 5726612 5726612 0 0.0
thermostat-no-ble arm64 (read only) 1935956 1936100 144 0.0
(read/write) 136401 136401 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69800 69808 8 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 125092 125092 0 0.0
.text 1604944 1605040 96 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321408 2321408 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1283984 1283984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307200 2307200 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1269800 1269800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279992 2279992 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1242592 1242592 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047904 2047904 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010504 1010504 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904895 904895 0 0.0
bss 116184 116184 0 0.0
rodata 101448 101448 0 0.0
text 611708 611708 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 867919 867919 0 0.0
bss 112532 112532 0 0.0
rodata 92744 92744 0 0.0
text 586436 586436 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830886 830886 0 0.0
bss 117560 117560 0 0.0
rodata 96704 96704 0 0.0
text 542136 542136 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 877171 877171 0 0.0
bss 113448 113448 0 0.0
rodata 97564 97564 0 0.0
text 590768 590768 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803406 803406 0 0.0
bss 114856 114856 0 0.0
rodata 92856 92856 0 0.0
text 521288 521288 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 882087 882087 0 0.0
bss 113360 113360 0 0.0
rodata 98920 98920 0 0.0
text 594356 594356 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875263 875263 0 0.0
bss 113236 113236 0 0.0
rodata 97056 97056 0 0.0
text 589520 589520 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782067 782067 0 0.0
bss 109560 109560 0 0.0
rodata 74288 74288 0 0.0
text 523708 523708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697146 697146 0 0.0
bss 110540 110540 0 0.0
rodata 68932 68932 0 0.0
text 444352 444352 0 0.0
p6 all-clusters-app default (read/write) 2357576 2357608 32 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1315840 1315872 32 0.0
light-app default (read/write) 2291856 2291856 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1250120 1250120 0 0.0
lock-app default (read/write) 2267728 2267728 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1225992 1225992 0 0.0
qpg lighting-app qpg6100+debug (read only) 519580 519580 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82632 82632 0 0.0
.data 956 956 0 0.0
.text 514260 514260 0 0.0
lock-app qpg6100+debug (read only) 493572 493572 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81768 81768 0 0.0
.data 912 912 0 0.0
.text 488252 488252 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808882 808882 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 564614 564614 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12800: Size comparison from 7cc071f to e7004d9

Increases above 0.2%:

platform target config section 7cc071f e7004d9 change % change
esp32 all-clusters-app c3devkit .flash.rodata 172232 172696 464 0.3
linux chip-tool-ipv6only arm64 (read only) 6765708 6784316 18608 0.3
.data.rel.ro 207832 208360 528 0.3
.text 5726612 5743028 16416 0.3
mbed shell CY8CPROTO_062_4343W+release (read/write) 2047904 2053344 5440 0.3
.text 1010504 1015944 5440 0.5
Increases (11 builds for esp32, linux, mbed, p6)
platform target config section 7cc071f e7004d9 change % change
esp32 all-clusters-app c3devkit (read only) 860328 861532 1204 0.1
.dram0.data 14124 14132 8 0.1
.flash.rodata 172232 172696 464 0.3
.flash.text 860328 861532 1204 0.1
m5stack (read only) 964299 964523 224 0.0
.flash.text 958915 959139 224 0.0
linux chip-tool-ipv6only arm64 (read only) 6765708 6784316 18608 0.3
(read/write) 317057 317777 720 0.2
.bss 51633 51681 48 0.1
.data.rel.ro 207832 208360 528 0.3
.got 52912 52992 80 0.2
.rodata 363372 363596 224 0.1
.text 5726612 5743028 16416 0.3
thermostat-no-ble arm64 .data.rel.ro 69800 69808 8 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2321408 2322944 1536 0.1
.heap 844320 846240 1920 0.2
.text 1283984 1285520 1536 0.1
lighting-app CY8CPROTO_062_4343W+release .heap 855256 855272 16 0.0
lock-app CY8CPROTO_062_4343W+release .heap 856216 856232 16 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2047904 2053344 5440 0.3
.bss 156564 156892 328 0.2
.text 1010504 1015944 5440 0.5
p6 all-clusters-app default (read/write) 2357576 2359512 1936 0.1
.heap 917704 917720 16 0.0
.text 1315840 1317776 1936 0.1
light-app default .heap 930120 930136 16 0.0
lock-app default .heap 931280 931296 16 0.0
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7cc071f e7004d9 change % change
efr32 lighting-app BRD4161A (read only) 806372 806260 -112 -0.0
(read/write) 123004 122980 -24 -0.0
.bss 121184 121160 -24 -0.0
.text 806364 806252 -112 -0.0
BRD4161A+rpc (read only) 794008 793896 -112 -0.0
(read/write) 139688 139664 -24 -0.0
.bss 137760 137736 -24 -0.0
.text 794000 793888 -112 -0.0
window-app BRD4161A (read only) 783124 783004 -120 -0.0
(read/write) 121136 121112 -24 -0.0
.bss 119352 119328 -24 -0.0
.text 783116 782996 -120 -0.0
esp32 all-clusters-app c3devkit (read/write) 1307034 1305562 -1472 -0.1
.dram0.bss 67640 65696 -1944 -2.9
m5stack (read/write) 451332 451248 -84 -0.0
.dram0.bss 75008 74992 -16 -0.0
.flash.rodata 210488 210420 -68 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 667856 667732 -124 -0.0
.bss 73768 73744 -24 -0.0
.text 586436 586336 -100 -0.0
lock-app k32w061+debug (read/write) 617444 617324 -120 -0.0
.bss 71912 71896 -16 -0.0
.text 537912 537808 -104 -0.0
shell k32w061+debug (read/write) 622528 622400 -128 -0.0
.bss 74132 74124 -8 -0.0
.text 540804 540684 -120 -0.0
linux thermostat-no-ble arm64 (read only) 1935988 1935268 -720 -0.0
(read/write) 136401 136369 -32 -0.0
.bss 59441 59409 -32 -0.1
.got 3520 3512 -8 -0.2
.rodata 125092 124996 -96 -0.1
.text 1604976 1604320 -656 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 186892 184972 -1920 -1.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2307200 2307128 -72 -0.0
.bss 175704 175688 -16 -0.0
.text 1269800 1269728 -72 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2279992 2279856 -136 -0.0
.bss 174744 174728 -16 -0.0
.text 1242592 1242456 -136 -0.0
shell CY8CPROTO_062_4343W+release .heap 875016 874688 -328 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904895 904791 -104 -0.0
bss 116184 116168 -16 -0.0
rodata 101448 101440 -8 -0.0
text 611708 611608 -100 -0.0
nrf52840dk_nrf52840+rpc (read/write) 867919 867819 -100 -0.0
bss 112532 112516 -16 -0.0
rodata 92744 92740 -4 -0.0
text 586436 586336 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830886 830786 -100 -0.0
bss 117560 117544 -16 -0.0
rodata 96704 96700 -4 -0.0
text 542136 542036 -100 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 877171 877023 -148 -0.0
bss 113448 113432 -16 -0.0
rodata 97564 97560 -4 -0.0
text 590768 590668 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803406 803270 -136 -0.0
bss 114856 114840 -16 -0.0
rodata 92856 92848 -8 -0.0
text 521288 521188 -100 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 882087 881951 -136 -0.0
bss 113360 113344 -16 -0.0
rodata 98920 98912 -8 -0.0
text 594356 594256 -100 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875263 875159 -104 -0.0
bss 113236 113220 -16 -0.0
rodata 97056 97048 -8 -0.0
text 589520 589420 -100 -0.0
shell nrf52840dk_nrf52840 (read/write) 782067 781947 -120 -0.0
bss 109560 109544 -16 -0.0
rodata 74288 74280 -8 -0.0
text 523708 523604 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697146 696994 -152 -0.0
bss 110540 110524 -16 -0.0
rodata 68932 68924 -8 -0.0
text 444352 444244 -108 -0.0
p6 all-clusters-app default .bss 113124 113108 -16 -0.0
light-app default (read/write) 2291856 2291752 -104 -0.0
.bss 100896 100880 -16 -0.0
.text 1250120 1250016 -104 -0.0
lock-app default (read/write) 2267728 2267616 -112 -0.0
.bss 99776 99760 -16 -0.0
.text 1225992 1225880 -112 -0.0
qpg lighting-app qpg6100+debug (read only) 519580 519472 -108 -0.0
.bss 82632 82616 -16 -0.0
.text 514260 514152 -108 -0.0
lock-app qpg6100+debug (read only) 493572 493464 -108 -0.0
.bss 81768 81752 -16 -0.0
.text 488252 488144 -108 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808882 808702 -180 -0.0
bss 82756 82736 -20 -0.0
text 564614 564470 -144 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7cc071f e7004d9 change % change
efr32 lighting-app BRD4161A (read only) 806372 806260 -112 -0.0
(read/write) 123004 122980 -24 -0.0
.bss 121184 121160 -24 -0.0
.data 1820 1820 0 0.0
.text 806364 806252 -112 -0.0
BRD4161A+rpc (read only) 794008 793896 -112 -0.0
(read/write) 139688 139664 -24 -0.0
.bss 137760 137736 -24 -0.0
.data 1928 1928 0 0.0
.text 794000 793888 -112 -0.0
window-app BRD4161A (read only) 783124 783004 -120 -0.0
(read/write) 121136 121112 -24 -0.0
.bss 119352 119328 -24 -0.0
.data 1784 1784 0 0.0
.text 783116 782996 -120 -0.0
esp32 all-clusters-app c3devkit (read only) 860328 861532 1204 0.1
(read/write) 1307034 1305562 -1472 -0.1
.dram0.bss 67640 65696 -1944 -2.9
.dram0.data 14124 14132 8 0.1
.flash.rodata 172232 172696 464 0.3
.flash.text 860328 861532 1204 0.1
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964299 964523 224 0.0
(read/write) 451332 451248 -84 -0.0
.dram0.bss 75008 74992 -16 -0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210488 210420 -68 -0.0
.flash.text 958915 959139 224 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667856 667732 -124 -0.0
.bss 73768 73744 -24 -0.0
.data 1852 1852 0 0.0
.text 586436 586336 -100 -0.0
lock-app k32w061+debug (read/write) 617444 617324 -120 -0.0
.bss 71912 71896 -16 -0.0
.data 1820 1820 0 0.0
.text 537912 537808 -104 -0.0
shell k32w061+debug (read/write) 622528 622400 -128 -0.0
.bss 74132 74124 -8 -0.0
.data 1792 1792 0 0.0
.text 540804 540684 -120 -0.0
linux chip-tool-ipv6only arm64 (read only) 6765708 6784316 18608 0.3
(read/write) 317057 317777 720 0.2
.bss 51633 51681 48 0.1
.data 1048 1048 0 0.0
.data.rel.ro 207832 208360 528 0.3
.dynamic 560 560 0 0.0
.got 52912 52992 80 0.2
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363372 363596 224 0.1
.text 5726612 5743028 16416 0.3
thermostat-no-ble arm64 (read only) 1935988 1935268 -720 -0.0
(read/write) 136401 136369 -32 -0.0
.bss 59441 59409 -32 -0.1
.data 776 776 0 0.0
.data.rel.ro 69800 69808 8 0.0
.dynamic 560 560 0 0.0
.got 3520 3512 -8 -0.2
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 125092 124996 -96 -0.1
.text 1604976 1604320 -656 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321408 2322944 1536 0.1
.bss 186892 184972 -1920 -1.0
.data 5232 5232 0 0.0
.heap 844320 846240 1920 0.2
.text 1283984 1285520 1536 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307200 2307128 -72 -0.0
.bss 175704 175688 -16 -0.0
.data 5488 5488 0 0.0
.heap 855256 855272 16 0.0
.text 1269800 1269728 -72 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279992 2279856 -136 -0.0
.bss 174744 174728 -16 -0.0
.data 5488 5488 0 0.0
.heap 856216 856232 16 0.0
.text 1242592 1242456 -136 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047904 2053344 5440 0.3
.bss 156564 156892 328 0.2
.data 4864 4864 0 0.0
.heap 875016 874688 -328 -0.0
.text 1010504 1015944 5440 0.5
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904895 904791 -104 -0.0
bss 116184 116168 -16 -0.0
rodata 101448 101440 -8 -0.0
text 611708 611608 -100 -0.0
nrf52840dk_nrf52840+rpc (read/write) 867919 867819 -100 -0.0
bss 112532 112516 -16 -0.0
rodata 92744 92740 -4 -0.0
text 586436 586336 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830886 830786 -100 -0.0
bss 117560 117544 -16 -0.0
rodata 96704 96700 -4 -0.0
text 542136 542036 -100 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 877171 877023 -148 -0.0
bss 113448 113432 -16 -0.0
rodata 97564 97560 -4 -0.0
text 590768 590668 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803406 803270 -136 -0.0
bss 114856 114840 -16 -0.0
rodata 92856 92848 -8 -0.0
text 521288 521188 -100 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 882087 881951 -136 -0.0
bss 113360 113344 -16 -0.0
rodata 98920 98912 -8 -0.0
text 594356 594256 -100 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875263 875159 -104 -0.0
bss 113236 113220 -16 -0.0
rodata 97056 97048 -8 -0.0
text 589520 589420 -100 -0.0
shell nrf52840dk_nrf52840 (read/write) 782067 781947 -120 -0.0
bss 109560 109544 -16 -0.0
rodata 74288 74280 -8 -0.0
text 523708 523604 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697146 696994 -152 -0.0
bss 110540 110524 -16 -0.0
rodata 68932 68924 -8 -0.0
text 444352 444244 -108 -0.0
p6 all-clusters-app default (read/write) 2357576 2359512 1936 0.1
.bss 113124 113108 -16 -0.0
.data 2512 2512 0 0.0
.heap 917704 917720 16 0.0
.text 1315840 1317776 1936 0.1
light-app default (read/write) 2291856 2291752 -104 -0.0
.bss 100896 100880 -16 -0.0
.data 2328 2328 0 0.0
.heap 930120 930136 16 0.0
.text 1250120 1250016 -104 -0.0
lock-app default (read/write) 2267728 2267616 -112 -0.0
.bss 99776 99760 -16 -0.0
.data 2288 2288 0 0.0
.heap 931280 931296 16 0.0
.text 1225992 1225880 -112 -0.0
qpg lighting-app qpg6100+debug (read only) 519580 519472 -108 -0.0
(read/write) 122332 122332 0 0.0
.bss 82632 82616 -16 -0.0
.data 956 956 0 0.0
.text 514260 514152 -108 -0.0
lock-app qpg6100+debug (read only) 493572 493464 -108 -0.0
(read/write) 122336 122336 0 0.0
.bss 81768 81752 -16 -0.0
.data 912 912 0 0.0
.text 488252 488144 -108 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808882 808702 -180 -0.0
bss 82756 82736 -20 -0.0
noinit 37160 37160 0 0.0
text 564614 564470 -144 -0.0

@chrisbeach59
Copy link
Contributor

Suggest to Kill this PR.
I made the helper.js and rebuilt and made the desired thermostat functionality in PR 12863.
Made sure that Andrei and Boris are both on as approvers for review

@andy31415 andy31415 closed this Dec 13, 2021
@andy31415 andy31415 deleted the enable_thermostat_init_function branch June 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@chrisbeach59 chrisbeach59 Awaiting requested review from chrisbeach59

Assignees
No one assigned
Labels
app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @chrisbeach59 @bzbarsky-apple