Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subject descriptor plumbing #12756

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Add subject descriptor plumbing #12756

merged 2 commits into from
Dec 10, 2021

Conversation

mlepage-google
Copy link
Contributor

Problem

SubjectDescriptor needs to be provided by messaging session layers, through
interation model, down to cluster data handlers (ReadSingleClusterData,
WriteSingleClusterData), to be consumed by AccessControl.

Change overview

This PR adds the plumbing of SubjectDescriptor from the messaging session layers,
through the interaction model, down to cluster data handlers.

It does not properly populate the SubjectDescriptor fields, and it does not do
anything with the SubjectDescriptor after it reaches its destination.

Testing

Built. Read and wrote a few attributes.

@todo
Copy link

todo bot commented Dec 8, 2021

fill subject descriptor with proper fields

connectedhomeip/src/transport/SessionHandle.cpp

Lines 31 to 37 in 88e09ed

// TODO: fill subject descriptor with proper fields
return subjectDescriptor;
}
const PeerAddress * SessionHandle::GetPeerAddress(SessionManager * sessionManager) const
{
if (IsSecure())

This comment was generated by todo based on a TODO comment in 88e09ed in #12756. cc @mlepage-google.

@mlepage-google mlepage-google marked this pull request as draft December 8, 2021 22:30
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12756: Size comparison from 4584707 to 88e09ed

Increases above 0.2%:

platform target config section 4584707 88e09ed change % change
linux chip-tool-ipv6only arm64 .bss 51633 51809 176 0.3
thermostat-no-ble arm64 .bss 59425 59601 176 0.3
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4584707 88e09ed change % change
efr32 lighting-app BRD4161A (read only) 803988 804340 352 0.0
(read/write) 122980 123108 128 0.1
.bss 121160 121288 128 0.1
.text 803980 804332 352 0.0
BRD4161A+rpc (read only) 791600 791952 352 0.0
(read/write) 139664 139792 128 0.1
.bss 137736 137864 128 0.1
.text 791592 791944 352 0.0
window-app BRD4161A (read only) 780716 781052 336 0.0
(read/write) 121120 121248 128 0.1
.bss 119336 119464 128 0.1
.text 780708 781044 336 0.0
esp32 all-clusters-app c3devkit (read only) 859230 859428 198 0.0
(read/write) 1306602 1306810 208 0.0
.dram0.bss 67632 67760 128 0.2
.flash.rodata 171816 171896 80 0.0
.flash.text 859230 859428 198 0.0
m5stack (read only) 962527 962679 152 0.0
(read/write) 450860 451060 200 0.0
.dram0.bss 74984 75112 128 0.2
.flash.rodata 210040 210112 72 0.0
.flash.text 957143 957295 152 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724636 724876 240 0.0
.bss 81232 81360 128 0.2
.text 635752 635864 112 0.0
lock-app k32w061+debug (read/write) 615796 616036 240 0.0
.bss 71896 72024 128 0.2
.text 536280 536392 112 0.0
shell k32w061+debug (read/write) 679052 679292 240 0.0
.bss 81596 81724 128 0.2
.text 589864 589976 112 0.0
linux chip-tool-ipv6only arm64 (read only) 6786028 6786316 288 0.0
(read/write) 312337 312513 176 0.1
.bss 51633 51809 176 0.3
.rodata 342380 342460 80 0.0
.text 5782004 5782212 208 0.0
thermostat-no-ble arm64 (read only) 1932068 1932340 272 0.0
(read/write) 136321 136497 176 0.1
.bss 59425 59601 176 0.3
.rodata 124820 124900 80 0.1
.text 1601520 1601712 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2320032 2320240 208 0.0
.bss 186884 187012 128 0.1
.text 1282608 1282816 208 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2305928 2306136 208 0.0
.bss 175696 175824 128 0.1
.text 1268528 1268736 208 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2278720 2278928 208 0.0
.bss 174736 174864 128 0.1
.text 1241320 1241528 208 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903283 903615 332 0.0
bss 116168 116296 128 0.1
rodata 101164 101240 76 0.1
text 610376 610512 136 0.0
nrf52840dk_nrf52840+rpc (read/write) 866307 866655 348 0.0
bss 112516 112644 128 0.1
rodata 92460 92536 76 0.1
text 585104 585240 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829274 829610 336 0.0
bss 117544 117672 128 0.1
rodata 96420 96500 80 0.1
text 540804 540940 136 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875863 336 0.0
bss 113432 113560 128 0.1
rodata 97280 97360 80 0.1
text 589440 589576 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801758 802110 352 0.0
bss 114840 114968 128 0.1
rodata 92568 92648 80 0.1
text 519964 520100 136 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880791 336 0.0
bss 113344 113472 128 0.1
rodata 98632 98712 80 0.1
text 593032 593168 136 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873651 873999 348 0.0
bss 113220 113348 128 0.1
rodata 96772 96848 76 0.1
text 588192 588328 136 0.0
p6 all-clusters-app default (read/write) 2356128 2356480 352 0.0
.bss 113116 113244 128 0.1
.text 1314392 1314744 352 0.0
light-app default (read/write) 2290512 2290864 352 0.0
.bss 100888 101016 128 0.1
.text 1248776 1249128 352 0.0
lock-app default (read/write) 2266376 2266712 336 0.0
.bss 99768 99896 128 0.1
.text 1224640 1224976 336 0.0
qpg lighting-app qpg6100+debug (read only) 517944 518048 104 0.0
.bss 82616 82712 96 0.1
.text 512624 512728 104 0.0
lock-app qpg6100+debug (read only) 491944 492048 104 0.0
.bss 81752 81848 96 0.1
.text 486624 486728 104 0.0
telink lighting-app tlsr9518adk80d (read/write) 807462 807854 392 0.0
bss 82748 82876 128 0.2
text 563528 563710 182 0.0
Decreases (6 builds for mbed, p6)
platform target config section 4584707 88e09ed change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 844328 844200 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855264 855136 -128 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856224 856096 -128 -0.0
p6 all-clusters-app default .heap 917712 917584 -128 -0.0
light-app default .heap 930128 930000 -128 -0.0
lock-app default .heap 931288 931160 -128 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4584707 88e09ed change % change
efr32 lighting-app BRD4161A (read only) 803988 804340 352 0.0
(read/write) 122980 123108 128 0.1
.bss 121160 121288 128 0.1
.data 1820 1820 0 0.0
.text 803980 804332 352 0.0
BRD4161A+rpc (read only) 791600 791952 352 0.0
(read/write) 139664 139792 128 0.1
.bss 137736 137864 128 0.1
.data 1928 1928 0 0.0
.text 791592 791944 352 0.0
window-app BRD4161A (read only) 780716 781052 336 0.0
(read/write) 121120 121248 128 0.1
.bss 119336 119464 128 0.1
.data 1784 1784 0 0.0
.text 780708 781044 336 0.0
esp32 all-clusters-app c3devkit (read only) 859230 859428 198 0.0
(read/write) 1306602 1306810 208 0.0
.dram0.bss 67632 67760 128 0.2
.dram0.data 14124 14124 0 0.0
.flash.rodata 171816 171896 80 0.0
.flash.text 859230 859428 198 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962527 962679 152 0.0
(read/write) 450860 451060 200 0.0
.dram0.bss 74984 75112 128 0.2
.dram0.data 34048 34048 0 0.0
.flash.rodata 210040 210112 72 0.0
.flash.text 957143 957295 152 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724636 724876 240 0.0
.bss 81232 81360 128 0.2
.data 1852 1852 0 0.0
.text 635752 635864 112 0.0
lock-app k32w061+debug (read/write) 615796 616036 240 0.0
.bss 71896 72024 128 0.2
.data 1820 1820 0 0.0
.text 536280 536392 112 0.0
shell k32w061+debug (read/write) 679052 679292 240 0.0
.bss 81596 81724 128 0.2
.data 1792 1792 0 0.0
.text 589864 589976 112 0.0
linux chip-tool-ipv6only arm64 (read only) 6786028 6786316 288 0.0
(read/write) 312337 312513 176 0.1
.bss 51633 51809 176 0.3
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342380 342460 80 0.0
.text 5782004 5782212 208 0.0
thermostat-no-ble arm64 (read only) 1932068 1932340 272 0.0
(read/write) 136321 136497 176 0.1
.bss 59425 59601 176 0.3
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124900 80 0.1
.text 1601520 1601712 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320032 2320240 208 0.0
.bss 186884 187012 128 0.1
.data 5232 5232 0 0.0
.heap 844328 844200 -128 -0.0
.text 1282608 1282816 208 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305928 2306136 208 0.0
.bss 175696 175824 128 0.1
.data 5488 5488 0 0.0
.heap 855264 855136 -128 -0.0
.text 1268528 1268736 208 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278928 208 0.0
.bss 174736 174864 128 0.1
.data 5488 5488 0 0.0
.heap 856224 856096 -128 -0.0
.text 1241320 1241528 208 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903283 903615 332 0.0
bss 116168 116296 128 0.1
rodata 101164 101240 76 0.1
text 610376 610512 136 0.0
nrf52840dk_nrf52840+rpc (read/write) 866307 866655 348 0.0
bss 112516 112644 128 0.1
rodata 92460 92536 76 0.1
text 585104 585240 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829274 829610 336 0.0
bss 117544 117672 128 0.1
rodata 96420 96500 80 0.1
text 540804 540940 136 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875863 336 0.0
bss 113432 113560 128 0.1
rodata 97280 97360 80 0.1
text 589440 589576 136 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801758 802110 352 0.0
bss 114840 114968 128 0.1
rodata 92568 92648 80 0.1
text 519964 520100 136 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880791 336 0.0
bss 113344 113472 128 0.1
rodata 98632 98712 80 0.1
text 593032 593168 136 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873651 873999 348 0.0
bss 113220 113348 128 0.1
rodata 96772 96848 76 0.1
text 588192 588328 136 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2356128 2356480 352 0.0
.bss 113116 113244 128 0.1
.data 2512 2512 0 0.0
.heap 917712 917584 -128 -0.0
.text 1314392 1314744 352 0.0
light-app default (read/write) 2290512 2290864 352 0.0
.bss 100888 101016 128 0.1
.data 2328 2328 0 0.0
.heap 930128 930000 -128 -0.0
.text 1248776 1249128 352 0.0
lock-app default (read/write) 2266376 2266712 336 0.0
.bss 99768 99896 128 0.1
.data 2288 2288 0 0.0
.heap 931288 931160 -128 -0.0
.text 1224640 1224976 336 0.0
qpg lighting-app qpg6100+debug (read only) 517944 518048 104 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82712 96 0.1
.data 956 956 0 0.0
.text 512624 512728 104 0.0
lock-app qpg6100+debug (read only) 491944 492048 104 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81848 96 0.1
.data 912 912 0 0.0
.text 486624 486728 104 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807462 807854 392 0.0
bss 82748 82876 128 0.2
noinit 37160 37160 0 0.0
text 563528 563710 182 0.0

@mlepage-google mlepage-google marked this pull request as ready for review December 9, 2021 18:20
jmartinez-silabs
jmartinez-silabs approved these changes Dec 9, 2021
View reviewed changes
src/app/util/ember-compatibility-functions.cpp Outdated Show resolved Hide resolved
src/app/util/ember-compatibility-functions.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12756: Size comparison from 0089995 to 295215d

Increases above 0.2%:

platform target config section 0089995 295215d change % change
linux chip-tool-ipv6only arm64 .bss 51713 51857 144 0.3
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0089995 295215d change % change
efr32 lighting-app BRD4161A (read only) 807484 807724 240 0.0
(read/write) 123008 123136 128 0.1
.bss 121160 121288 128 0.1
.text 807476 807716 240 0.0
BRD4161A+rpc (read only) 795120 795344 224 0.0
(read/write) 139696 139824 128 0.1
.bss 137736 137864 128 0.1
.text 795112 795336 224 0.0
window-app BRD4161A (read only) 784460 784700 240 0.0
(read/write) 121140 121268 128 0.1
.bss 119328 119456 128 0.1
.text 784452 784692 240 0.0
esp32 all-clusters-app c3devkit (read only) 862060 862218 158 0.0
(read/write) 1305602 1305730 128 0.0
.dram0.bss 65696 65824 128 0.2
.flash.text 862060 862218 158 0.0
m5stack (read only) 965247 965407 160 0.0
(read/write) 451296 451424 128 0.0
.dram0.bss 74992 75120 128 0.2
.flash.text 959863 960023 160 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668756 224 0.0
.bss 73744 73872 128 0.2
.text 587108 587204 96 0.0
lock-app k32w061+debug (read/write) 618492 618716 224 0.0
.bss 71896 72024 128 0.2
.text 538948 539044 96 0.0
shell k32w061+debug (read/write) 623584 623808 224 0.0
.bss 74124 74252 128 0.2
.text 541840 541936 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6792876 80 0.0
(read/write) 318273 318417 144 0.0
.bss 51713 51857 144 0.3
.text 5749972 5750052 80 0.0
thermostat-no-ble arm64 (read only) 1943364 1943444 80 0.0
(read/write) 136865 137009 144 0.1
.bss 59441 59585 144 0.2
.text 1610912 1610992 80 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2323376 2323440 64 0.0
.bss 184972 185100 128 0.1
.text 1285952 1286016 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308008 2308072 64 0.0
.bss 175688 175816 128 0.1
.text 1270608 1270672 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2281120 2281184 64 0.0
.bss 174728 174856 128 0.1
.text 1243720 1243784 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905659 905883 224 0.0
bss 116168 116296 128 0.1
text 612212 612308 96 0.0
nrf52840dk_nrf52840+rpc (read/write) 868683 868907 224 0.0
bss 112516 112644 128 0.1
text 586940 587036 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831650 831874 224 0.0
bss 117544 117672 128 0.1
text 542640 542736 96 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878271 878495 224 0.0
bss 113432 113560 128 0.1
text 591656 591752 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804518 804742 224 0.0
bss 114840 114968 128 0.1
text 522176 522272 96 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883199 883423 224 0.0
bss 113344 113472 128 0.1
text 595244 595340 96 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876443 876667 224 0.0
bss 113220 113348 128 0.1
text 590444 590540 96 0.0
p6 all-clusters-app default (read/write) 2360184 2360424 240 0.0
.bss 113108 113236 128 0.1
.text 1318448 1318688 240 0.0
light-app default (read/write) 2292984 2293208 224 0.0
.bss 100880 101008 128 0.1
.text 1251248 1251472 224 0.0
lock-app default (read/write) 2269048 2269288 240 0.0
.bss 99760 99888 128 0.1
.text 1227312 1227552 240 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520420 96 0.0
.bss 82616 82712 96 0.1
.text 515004 515100 96 0.0
lock-app qpg6100+debug (read only) 494700 494796 96 0.0
.bss 81752 81848 96 0.1
.text 489380 489476 96 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 810042 272 0.0
bss 82736 82864 128 0.2
text 565274 565414 140 0.0
Decreases (6 builds for mbed, p6)
platform target config section 0089995 295215d change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846240 846112 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855240 855112 -128 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856200 856072 -128 -0.0
p6 all-clusters-app default .heap 917720 917592 -128 -0.0
light-app default .heap 930112 929984 -128 -0.0
lock-app default .heap 931264 931136 -128 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0089995 295215d change % change
efr32 lighting-app BRD4161A (read only) 807484 807724 240 0.0
(read/write) 123008 123136 128 0.1
.bss 121160 121288 128 0.1
.data 1848 1848 0 0.0
.text 807476 807716 240 0.0
BRD4161A+rpc (read only) 795120 795344 224 0.0
(read/write) 139696 139824 128 0.1
.bss 137736 137864 128 0.1
.data 1956 1956 0 0.0
.text 795112 795336 224 0.0
window-app BRD4161A (read only) 784460 784700 240 0.0
(read/write) 121140 121268 128 0.1
.bss 119328 119456 128 0.1
.data 1812 1812 0 0.0
.text 784452 784692 240 0.0
esp32 all-clusters-app c3devkit (read only) 862060 862218 158 0.0
(read/write) 1305602 1305730 128 0.0
.dram0.bss 65696 65824 128 0.2
.dram0.data 14124 14124 0 0.0
.flash.rodata 172752 172752 0 0.0
.flash.text 862060 862218 158 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965247 965407 160 0.0
(read/write) 451296 451424 128 0.0
.dram0.bss 74992 75120 128 0.2
.dram0.data 34048 34048 0 0.0
.flash.rodata 210468 210468 0 0.0
.flash.text 959863 960023 160 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668532 668756 224 0.0
.bss 73744 73872 128 0.2
.data 1880 1880 0 0.0
.text 587108 587204 96 0.0
lock-app k32w061+debug (read/write) 618492 618716 224 0.0
.bss 71896 72024 128 0.2
.data 1848 1848 0 0.0
.text 538948 539044 96 0.0
shell k32w061+debug (read/write) 623584 623808 224 0.0
.bss 74124 74252 128 0.2
.data 1820 1820 0 0.0
.text 541840 541936 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6792796 6792876 80 0.0
(read/write) 318273 318417 144 0.0
.bss 51713 51857 144 0.3
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363884 363884 0 0.0
.text 5749972 5750052 80 0.0
thermostat-no-ble arm64 (read only) 1943364 1943444 80 0.0
(read/write) 136865 137009 144 0.1
.bss 59441 59585 144 0.2
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125300 125300 0 0.0
.text 1610912 1610992 80 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323376 2323440 64 0.0
.bss 184972 185100 128 0.1
.data 5232 5232 0 0.0
.heap 846240 846112 -128 -0.0
.text 1285952 1286016 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308008 2308072 64 0.0
.bss 175688 175816 128 0.1
.data 5520 5520 0 0.0
.heap 855240 855112 -128 -0.0
.text 1270608 1270672 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281120 2281184 64 0.0
.bss 174728 174856 128 0.1
.data 5520 5520 0 0.0
.heap 856200 856072 -128 -0.0
.text 1243720 1243784 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905659 905883 224 0.0
bss 116168 116296 128 0.1
rodata 101676 101676 0 0.0
text 612212 612308 96 0.0
nrf52840dk_nrf52840+rpc (read/write) 868683 868907 224 0.0
bss 112516 112644 128 0.1
rodata 92972 92972 0 0.0
text 586940 587036 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831650 831874 224 0.0
bss 117544 117672 128 0.1
rodata 96932 96932 0 0.0
text 542640 542736 96 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878271 878495 224 0.0
bss 113432 113560 128 0.1
rodata 97792 97792 0 0.0
text 591656 591752 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804518 804742 224 0.0
bss 114840 114968 128 0.1
rodata 93080 93080 0 0.0
text 522176 522272 96 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 883199 883423 224 0.0
bss 113344 113472 128 0.1
rodata 99144 99144 0 0.0
text 595244 595340 96 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876443 876667 224 0.0
bss 113220 113348 128 0.1
rodata 97284 97284 0 0.0
text 590444 590540 96 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2360184 2360424 240 0.0
.bss 113108 113236 128 0.1
.data 2512 2512 0 0.0
.heap 917720 917592 -128 -0.0
.text 1318448 1318688 240 0.0
light-app default (read/write) 2292984 2293208 224 0.0
.bss 100880 101008 128 0.1
.data 2352 2352 0 0.0
.heap 930112 929984 -128 -0.0
.text 1251248 1251472 224 0.0
lock-app default (read/write) 2269048 2269288 240 0.0
.bss 99760 99888 128 0.1
.data 2320 2320 0 0.0
.heap 931264 931136 -128 -0.0
.text 1227312 1227552 240 0.0
qpg lighting-app qpg6100+debug (read only) 520324 520420 96 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82712 96 0.1
.data 984 984 0 0.0
.text 515004 515100 96 0.0
lock-app qpg6100+debug (read only) 494700 494796 96 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81848 96 0.1
.data 940 940 0 0.0
.text 489380 489476 96 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809770 810042 272 0.0
bss 82736 82864 128 0.2
noinit 37160 37160 0 0.0
text 565274 565414 140 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Dec 10, 2021
View reviewed changes
src/transport/SessionHandle.cpp Show resolved Hide resolved
src/transport/SessionHandle.h Show resolved Hide resolved
src/app/ReadHandler.cpp Show resolved Hide resolved
@bzbarsky-apple
Copy link
Contributor

/rebase

@mlepage-google @bzbarsky-apple
Add subject descriptor plumbing
07664fb 
Add plumbing to pass SubjectDescriptor from the session through the IM
to its use in ReadSingleClusterData and WriteSingleClusterData.

It isn't properly populated yet, and its values aren't properly
consumed. But the plumbing has to be there first, those will come later.
@mlepage-google @bzbarsky-apple
Remove errant log statements
989dee5
@woody-apple woody-apple force-pushed the subject-descriptor-plumbing branch from 295215d to 989dee5 Compare December 10, 2021 03:01
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12756: Size comparison from 55b7aba to 989dee5

Increases above 0.2%:

platform target config section 55b7aba 989dee5 change % change
linux chip-tool-ipv6only arm64 .bss 51713 51873 160 0.3
thermostat-no-ble arm64 .bss 59441 59601 160 0.3
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 55b7aba 989dee5 change % change
efr32 lighting-app BRD4161A (read only) 808964 809204 240 0.0
(read/write) 123020 123148 128 0.1
.bss 121160 121288 128 0.1
.text 808956 809196 240 0.0
BRD4161A+rpc (read only) 796600 796824 224 0.0
(read/write) 139696 139824 128 0.1
.bss 137736 137864 128 0.1
.text 796592 796816 224 0.0
window-app BRD4161A (read only) 785940 786180 240 0.0
(read/write) 121152 121280 128 0.1
.bss 119328 119456 128 0.1
.text 785932 786172 240 0.0
esp32 all-clusters-app c3devkit (read only) 862634 862792 158 0.0
(read/write) 1305930 1306058 128 0.0
.dram0.bss 65704 65832 128 0.2
.flash.text 862634 862792 158 0.0
m5stack (read only) 965887 966015 128 0.0
(read/write) 451616 451744 128 0.0
.dram0.bss 75000 75128 128 0.2
.flash.text 960503 960631 128 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669336 669560 224 0.0
.bss 73744 73872 128 0.2
.text 587900 587996 96 0.0
lock-app k32w061+debug (read/write) 619284 619508 224 0.0
.bss 71896 72024 128 0.2
.text 539736 539832 96 0.0
shell k32w061+debug (read/write) 624384 624608 224 0.0
.bss 74124 74252 128 0.2
.text 542628 542724 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6856796 6856876 80 0.0
(read/write) 318225 318385 160 0.1
.bss 51713 51873 160 0.3
.text 5814164 5814244 80 0.0
thermostat-no-ble arm64 (read only) 1947348 1947428 80 0.0
(read/write) 137041 137201 160 0.1
.bss 59441 59601 160 0.3
.text 1614336 1614416 80 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324264 2324328 64 0.0
.bss 184980 185108 128 0.1
.text 1286840 1286904 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308880 2308944 64 0.0
.bss 175696 175824 128 0.1
.text 1271480 1271544 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282000 2282064 64 0.0
.bss 174736 174864 128 0.1
.text 1244600 1244664 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906523 906747 224 0.0
bss 116168 116296 128 0.1
text 612780 612876 96 0.0
nrf52840dk_nrf52840+rpc (read/write) 869571 869795 224 0.0
bss 112516 112644 128 0.1
text 587508 587604 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832538 832762 224 0.0
bss 117544 117672 128 0.1
text 543208 543304 96 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879151 879375 224 0.0
bss 113432 113560 128 0.1
text 592224 592320 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805410 805634 224 0.0
bss 114840 114968 128 0.1
text 522744 522840 96 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884091 884315 224 0.0
bss 113344 113472 128 0.1
text 595816 595912 96 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877331 877555 224 0.0
bss 113220 113348 128 0.1
text 591012 591108 96 0.0
p6 all-clusters-app default (read/write) 2361664 2361904 240 0.0
.bss 113116 113244 128 0.1
.text 1319928 1320168 240 0.0
light-app default (read/write) 2294480 2294704 224 0.0
.bss 100888 101016 128 0.1
.text 1252744 1252968 224 0.0
lock-app default (read/write) 2270544 2270784 240 0.0
.bss 99768 99896 128 0.1
.text 1228808 1229048 240 0.0
qpg lighting-app qpg6100+debug (read only) 521224 521320 96 0.0
.bss 82616 82712 96 0.1
.text 515904 516000 96 0.0
lock-app qpg6100+debug (read only) 495592 495688 96 0.0
.bss 81752 81848 96 0.1
.text 490272 490368 96 0.0
telink lighting-app tlsr9518adk80d (read/write) 810690 810954 264 0.0
bss 82736 82864 128 0.2
text 565866 566006 140 0.0
Decreases (6 builds for mbed, p6)
platform target config section 55b7aba 989dee5 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846224 846096 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855224 855096 -128 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 856192 856064 -128 -0.0
p6 all-clusters-app default .heap 917704 917576 -128 -0.0
light-app default .heap 930096 929968 -128 -0.0
lock-app default .heap 931248 931120 -128 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 55b7aba 989dee5 change % change
efr32 lighting-app BRD4161A (read only) 808964 809204 240 0.0
(read/write) 123020 123148 128 0.1
.bss 121160 121288 128 0.1
.data 1860 1860 0 0.0
.text 808956 809196 240 0.0
BRD4161A+rpc (read only) 796600 796824 224 0.0
(read/write) 139696 139824 128 0.1
.bss 137736 137864 128 0.1
.data 1960 1960 0 0.0
.text 796592 796816 224 0.0
window-app BRD4161A (read only) 785940 786180 240 0.0
(read/write) 121152 121280 128 0.1
.bss 119328 119456 128 0.1
.data 1824 1824 0 0.0
.text 785932 786172 240 0.0
esp32 all-clusters-app c3devkit (read only) 862634 862792 158 0.0
(read/write) 1305930 1306058 128 0.0
.dram0.bss 65704 65832 128 0.2
.dram0.data 14124 14124 0 0.0
.flash.rodata 173064 173064 0 0.0
.flash.text 862634 862792 158 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965887 966015 128 0.0
(read/write) 451616 451744 128 0.0
.dram0.bss 75000 75128 128 0.2
.dram0.data 34056 34056 0 0.0
.flash.rodata 210772 210772 0 0.0
.flash.text 960503 960631 128 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669336 669560 224 0.0
.bss 73744 73872 128 0.2
.data 1892 1892 0 0.0
.text 587900 587996 96 0.0
lock-app k32w061+debug (read/write) 619284 619508 224 0.0
.bss 71896 72024 128 0.2
.data 1852 1852 0 0.0
.text 539736 539832 96 0.0
shell k32w061+debug (read/write) 624384 624608 224 0.0
.bss 74124 74252 128 0.2
.data 1832 1832 0 0.0
.text 542628 542724 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6856796 6856876 80 0.0
(read/write) 318225 318385 160 0.1
.bss 51713 51873 160 0.3
.data 1096 1096 0 0.0
.data.rel.ro 208696 208696 0 0.0
.dynamic 560 560 0 0.0
.got 53024 53024 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363836 363836 0 0.0
.text 5814164 5814244 80 0.0
thermostat-no-ble arm64 (read only) 1947348 1947428 80 0.0
(read/write) 137041 137201 160 0.1
.bss 59441 59601 160 0.3
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 125508 0 0.0
.text 1614336 1614416 80 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324264 2324328 64 0.0
.bss 184980 185108 128 0.1
.data 5240 5240 0 0.0
.heap 846224 846096 -128 -0.0
.text 1286840 1286904 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308880 2308944 64 0.0
.bss 175696 175824 128 0.1
.data 5528 5528 0 0.0
.heap 855224 855096 -128 -0.0
.text 1271480 1271544 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282000 2282064 64 0.0
.bss 174736 174864 128 0.1
.data 5520 5520 0 0.0
.heap 856192 856064 -128 -0.0
.text 1244600 1244664 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906523 906747 224 0.0
bss 116168 116296 128 0.1
rodata 101980 101980 0 0.0
text 612780 612876 96 0.0
nrf52840dk_nrf52840+rpc (read/write) 869571 869795 224 0.0
bss 112516 112644 128 0.1
rodata 93276 93276 0 0.0
text 587508 587604 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832538 832762 224 0.0
bss 117544 117672 128 0.1
rodata 97236 97236 0 0.0
text 543208 543304 96 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879151 879375 224 0.0
bss 113432 113560 128 0.1
rodata 98096 98096 0 0.0
text 592224 592320 96 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805410 805634 224 0.0
bss 114840 114968 128 0.1
rodata 93388 93388 0 0.0
text 522744 522840 96 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884091 884315 224 0.0
bss 113344 113472 128 0.1
rodata 99452 99452 0 0.0
text 595816 595912 96 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877331 877555 224 0.0
bss 113220 113348 128 0.1
rodata 97588 97588 0 0.0
text 591012 591108 96 0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2361664 2361904 240 0.0
.bss 113116 113244 128 0.1
.data 2520 2520 0 0.0
.heap 917704 917576 -128 -0.0
.text 1319928 1320168 240 0.0
light-app default (read/write) 2294480 2294704 224 0.0
.bss 100888 101016 128 0.1
.data 2360 2360 0 0.0
.heap 930096 929968 -128 -0.0
.text 1252744 1252968 224 0.0
lock-app default (read/write) 2270544 2270784 240 0.0
.bss 99768 99896 128 0.1
.data 2328 2328 0 0.0
.heap 931248 931120 -128 -0.0
.text 1228808 1229048 240 0.0
qpg lighting-app qpg6100+debug (read only) 521224 521320 96 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82712 96 0.1
.data 992 992 0 0.0
.text 515904 516000 96 0.0
lock-app qpg6100+debug (read only) 495592 495688 96 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81848 96 0.1
.data 948 948 0 0.0
.text 490272 490368 96 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810690 810954 264 0.0
bss 82736 82864 128 0.2
noinit 37160 37160 0 0.0
text 565866 566006 140 0.0

@woody-apple woody-apple merged commit 2400884 into project-chip:master Dec 10, 2021
@todo todo bot mentioned this pull request Dec 10, 2021
Closed
@mlepage-google mlepage-google deleted the subject-descriptor-plumbing branch December 10, 2021 15:02
@mlepage-google mlepage-google mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlepage-google @bzbarsky-apple @mrjerryjohns @woody-apple @jmartinez-silabs