Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing __APPLE_USE_RFC_3542 #12753

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Fix missing __APPLE_USE_RFC_3542 #12753

merged 3 commits into from
Dec 8, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

In splitting UDPEndPoint.cpp by implementation (#12688), the definition of __APPLE_USE_RFC_3542 was lost, which caused IPV6_PKTINFO to not be defined and corresponding parts of UDPEndPoint not to be built.

Change overview

Add #define __APPLE_USE_RFC_3542 to the top of UDPEndPointImplSockets.cpp, as it had been in UDPEndPoint.cpp.

Testing

CI

@kpschoedel
Fix missing __APPLE_USE_RFC_3542
0557184 
#### Problem

In splitting `UDPEndPoint.cpp` by implementation, the definition
of `__APPLE_USE_RFC_3542` was lost, which caused `IPV6_PKTINFO`
to not be defined and corresponding parts of `UDPEndPoint` not to
be built.

#### Change overview

Add `#define __APPLE_USE_RFC_3542` to the top of
`UDPEndPointImplSockets.cpp`, as it had been in
`UDPEndPoint.cpp`.

#### Testing

CI
@boring-cyborg boring-cyborg bot added the inet label Dec 8, 2021
@andy31415 @tcarmelveilleux
Update src/inet/UDPEndPointImplSockets.cpp
4f51166 
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@restyled-io restyled-io bot mentioned this pull request Dec 8, 2021
Closed
@andy31415
Copy link
Contributor

fast track: small delta, issue found and validated during QA

@andy31415 andy31415 merged commit 88085b2 into project-chip:master Dec 8, 2021
@kpschoedel kpschoedel deleted the darwin-rfc3542 branch December 8, 2021 22:03
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12753: Size comparison from 8622381 to c6070c6

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8622381 c6070c6 change % change
efr32 lighting-app BRD4161A (read only) 803884 803884 0 0.0
(read/write) 122996 122996 0 0.0
.bss 121176 121176 0 0.0
.data 1820 1820 0 0.0
.text 803876 803876 0 0.0
BRD4161A+rpc (read only) 791496 791496 0 0.0
(read/write) 139680 139680 0 0.0
.bss 137752 137752 0 0.0
.data 1928 1928 0 0.0
.text 791488 791488 0 0.0
window-app BRD4161A (read only) 780836 780836 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 780828 780828 0 0.0
esp32 all-clusters-app c3devkit (read only) 858576 858576 0 0.0
(read/write) 1306658 1306658 0 0.0
.dram0.bss 67648 67648 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171856 171856 0 0.0
.flash.text 858576 858576 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 961835 961835 0 0.0
(read/write) 450948 450948 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210112 210112 0 0.0
.flash.text 956451 956451 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724500 724500 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 635600 635600 0 0.0
lock-app k32w061+debug (read/write) 615836 615836 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 536304 536304 0 0.0
shell k32w061+debug (read/write) 679092 679092 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 589888 589888 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6732068 6732068 0 0.0
(read/write) 310977 310977 0 0.0
.bss 51665 51665 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 206592 206592 0 0.0
.dynamic 560 560 0 0.0
.got 48040 48040 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 341796 341796 0 0.0
.text 5731972 5731972 0 0.0
thermostat-no-ble arm64 (read only) 1932004 1932004 0 0.0
(read/write) 136465 136465 0 0.0
.bss 59457 59457 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69840 69840 0 0.0
.dynamic 560 560 0 0.0
.got 3528 3528 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124980 124980 0 0.0
.text 1601056 1601056 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319536 2319536 0 0.0
.bss 186900 186900 0 0.0
.data 5232 5232 0 0.0
.heap 844312 844312 0 0.0
.text 1282112 1282112 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305736 2305736 0 0.0
.bss 175712 175712 0 0.0
.data 5488 5488 0 0.0
.heap 855248 855248 0 0.0
.text 1268336 1268336 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174752 174752 0 0.0
.data 5488 5488 0 0.0
.heap 856208 856208 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903071 903071 0 0.0
bss 116184 116184 0 0.0
rodata 101208 101208 0 0.0
text 610124 610124 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866095 866095 0 0.0
bss 112532 112532 0 0.0
rodata 92504 92504 0 0.0
text 584852 584852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829062 829062 0 0.0
bss 117560 117560 0 0.0
rodata 96464 96464 0 0.0
text 540552 540552 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875539 875539 0 0.0
bss 113448 113448 0 0.0
rodata 97324 97324 0 0.0
text 589380 589380 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801786 801786 0 0.0
bss 114856 114856 0 0.0
rodata 92612 92612 0 0.0
text 519904 519904 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880387 880387 0 0.0
bss 113360 113360 0 0.0
rodata 98676 98676 0 0.0
text 592900 592900 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873615 873615 0 0.0
bss 113236 113236 0 0.0
rodata 96816 96816 0 0.0
text 588116 588116 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2355608 2355608 0 0.0
.bss 113132 113132 0 0.0
.data 2512 2512 0 0.0
.heap 917696 917696 0 0.0
.text 1313872 1313872 0 0.0
light-app default (read/write) 2290392 2290392 0 0.0
.bss 100904 100904 0 0.0
.data 2328 2328 0 0.0
.heap 930112 930112 0 0.0
.text 1248656 1248656 0 0.0
lock-app default (read/write) 2266496 2266496 0 0.0
.bss 99784 99784 0 0.0
.data 2288 2288 0 0.0
.heap 931272 931272 0 0.0
.text 1224760 1224760 0 0.0
qpg lighting-app qpg6100+debug (read only) 517768 517768 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82624 0 0.0
.data 956 956 0 0.0
.text 512448 512448 0 0.0
lock-app qpg6100+debug (read only) 491968 491968 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81760 0 0.0
.data 912 912 0 0.0
.text 486648 486648 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807106 807106 0 0.0
bss 82764 82764 0 0.0
noinit 37160 37160 0 0.0
text 563106 563106 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
fast track inet review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpschoedel @andy31415 @tcarmelveilleux @bzbarsky-apple