Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable client-side accessor generation for strongly typed enum attributes #12731

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Enable client-side accessor generation for strongly typed enum attributes #12731

merged 1 commit into from
Dec 8, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

Attributes whose types are named enums did not have client-side codegen working right, so had it disabled.

Change overview

Enable it.

Testing

Manually verified that we are now generating the relevant accessor code on the client side.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12731: Size comparison from a7dd25e to 9ea2ac0

Increases above 0.2%:

platform target config section a7dd25e 9ea2ac0 change % change
linux chip-tool-ipv6only arm64 (read only) 6664644 6720116 55472 0.8
(read/write) 305201 306817 1616 0.5
.data.rel.ro 201888 203152 1264 0.6
.got 46984 47336 352 0.7
.text 5681828 5732756 50928 0.9
Increases (1 build for linux)
platform target config section a7dd25e 9ea2ac0 change % change
linux chip-tool-ipv6only arm64 (read only) 6664644 6720116 55472 0.8
(read/write) 305201 306817 1616 0.5
.data.rel.ro 201888 203152 1264 0.6
.got 46984 47336 352 0.7
.rodata 338532 339284 752 0.2
.text 5681828 5732756 50928 0.9
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section a7dd25e 9ea2ac0 change % change
efr32 lighting-app BRD4161A (read only) 794800 794800 0 0.0
(read/write) 122992 122992 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 794792 794792 0 0.0
BRD4161A+rpc (read only) 782412 782412 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 782404 782404 0 0.0
window-app BRD4161A (read only) 771736 771736 0 0.0
(read/write) 121128 121128 0 0.0
.bss 119344 119344 0 0.0
.data 1784 1784 0 0.0
.text 771728 771728 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731980 731980 0 0.0
.bss 81240 81240 0 0.0
.data 1852 1852 0 0.0
.text 643088 643088 0 0.0
lock-app k32w061+debug (read/write) 622564 622564 0 0.0
.bss 71904 71904 0 0.0
.data 1820 1820 0 0.0
.text 543040 543040 0 0.0
shell k32w061+debug (read/write) 685656 685656 0 0.0
.bss 81604 81604 0 0.0
.data 1792 1792 0 0.0
.text 596460 596460 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6664644 6720116 55472 0.8
(read/write) 305201 306817 1616 0.5
.bss 51649 51649 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 201888 203152 1264 0.6
.dynamic 560 560 0 0.0
.got 46984 47336 352 0.7
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 338532 339284 752 0.2
.text 5681828 5732756 50928 0.9
thermostat-no-ble arm64 (read only) 1905756 1905756 0 0.0
(read/write) 135825 135825 0 0.0
.bss 59457 59457 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69280 69280 0 0.0
.dynamic 560 560 0 0.0
.got 3456 3456 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 123932 123932 0 0.0
.text 1576976 1576976 0 0.0
p6 all-clusters-app default (read/write) 2350096 2350096 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1308360 1308360 0 0.0
light-app default (read/write) 2281176 2281176 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1239440 1239440 0 0.0
lock-app default (read/write) 2257264 2257264 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1215528 1215528 0 0.0
qpg lighting-app qpg6100+debug (read only) 511812 511812 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 506492 506492 0 0.0
lock-app qpg6100+debug (read only) 486004 486004 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 480684 480684 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800142 800142 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 557242 557242 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12731: Size comparison from 1f4024a to 770fbf1

Increases above 0.2%:

platform target config section 1f4024a 770fbf1 change % change
linux chip-tool-ipv6only arm64 (read only) 6665652 6721108 55456 0.8
(read/write) 305217 306833 1616 0.5
.data.rel.ro 201888 203152 1264 0.6
.got 46984 47336 352 0.7
.rodata 338548 339300 752 0.2
.text 5682820 5733732 50912 0.9
Increases (1 build for linux)
platform target config section 1f4024a 770fbf1 change % change
linux chip-tool-ipv6only arm64 (read only) 6665652 6721108 55456 0.8
(read/write) 305217 306833 1616 0.5
.data.rel.ro 201888 203152 1264 0.6
.got 46984 47336 352 0.7
.rodata 338548 339300 752 0.2
.text 5682820 5733732 50912 0.9
Full report (12 builds for k32w, linux, p6, qpg, telink)
platform target config section 1f4024a 770fbf1 change % change
k32w lighting-app k32w061+se05x+release (read/write) 732132 732132 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 643232 643232 0 0.0
lock-app k32w061+debug (read/write) 622716 622716 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 543184 543184 0 0.0
shell k32w061+debug (read/write) 685808 685808 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 596604 596604 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6665652 6721108 55456 0.8
(read/write) 305217 306833 1616 0.5
.bss 51665 51665 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 201888 203152 1264 0.6
.dynamic 560 560 0 0.0
.got 46984 47336 352 0.7
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 338548 339300 752 0.2
.text 5682820 5733732 50912 0.9
thermostat-no-ble arm64 (read only) 1906556 1906556 0 0.0
(read/write) 135825 135825 0 0.0
.bss 59457 59457 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69280 69280 0 0.0
.dynamic 560 560 0 0.0
.got 3456 3456 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 123964 123964 0 0.0
.text 1577744 1577744 0 0.0
p6 all-clusters-app default (read/write) 2350400 2350400 0 0.0
.bss 113132 113132 0 0.0
.data 2512 2512 0 0.0
.heap 917696 917696 0 0.0
.text 1308664 1308664 0 0.0
light-app default (read/write) 2281464 2281464 0 0.0
.bss 100904 100904 0 0.0
.data 2328 2328 0 0.0
.heap 930112 930112 0 0.0
.text 1239728 1239728 0 0.0
lock-app default (read/write) 2257568 2257568 0 0.0
.bss 99784 99784 0 0.0
.data 2288 2288 0 0.0
.heap 931272 931272 0 0.0
.text 1215832 1215832 0 0.0
qpg lighting-app qpg6100+debug (read only) 511948 511948 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82624 0 0.0
.data 956 956 0 0.0
.text 506628 506628 0 0.0
lock-app qpg6100+debug (read only) 486140 486140 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81760 0 0.0
.data 912 912 0 0.0
.text 480820 480820 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800386 800386 0 0.0
bss 82764 82764 0 0.0
noinit 37160 37160 0 0.0
text 557446 557446 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12731: Size comparison from 1f4024a to b73c868

Increases above 0.2%:

platform target config section 1f4024a b73c868 change % change
linux chip-tool-ipv6only arm64 (read only) 6665652 6721108 55456 0.8
(read/write) 305217 306833 1616 0.5
.data.rel.ro 201888 203152 1264 0.6
.got 46984 47336 352 0.7
.text 5682820 5733732 50912 0.9
Increases (1 build for linux)
platform target config section 1f4024a b73c868 change % change
linux chip-tool-ipv6only arm64 (read only) 6665652 6721108 55456 0.8
(read/write) 305217 306833 1616 0.5
.data.rel.ro 201888 203152 1264 0.6
.got 46984 47336 352 0.7
.rodata 338548 339300 752 0.2
.text 5682820 5733732 50912 0.9
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1f4024a b73c868 change % change
efr32 lighting-app BRD4161A (read only) 794956 794956 0 0.0
(read/write) 122996 122996 0 0.0
.bss 121176 121176 0 0.0
.data 1820 1820 0 0.0
.text 794948 794948 0 0.0
BRD4161A+rpc (read only) 782552 782552 0 0.0
(read/write) 139680 139680 0 0.0
.bss 137752 137752 0 0.0
.data 1928 1928 0 0.0
.text 782544 782544 0 0.0
window-app BRD4161A (read only) 771908 771908 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 771900 771900 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732132 732132 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 643232 643232 0 0.0
lock-app k32w061+debug (read/write) 622716 622716 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 543184 543184 0 0.0
shell k32w061+debug (read/write) 685808 685808 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 596604 596604 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6665652 6721108 55456 0.8
(read/write) 305217 306833 1616 0.5
.bss 51665 51665 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 201888 203152 1264 0.6
.dynamic 560 560 0 0.0
.got 46984 47336 352 0.7
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 338548 339300 752 0.2
.text 5682820 5733732 50912 0.9
thermostat-no-ble arm64 (read only) 1906556 1906556 0 0.0
(read/write) 135825 135825 0 0.0
.bss 59457 59457 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69280 69280 0 0.0
.dynamic 560 560 0 0.0
.got 3456 3456 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 123964 123964 0 0.0
.text 1577744 1577744 0 0.0
p6 all-clusters-app default (read/write) 2350400 2350400 0 0.0
.bss 113132 113132 0 0.0
.data 2512 2512 0 0.0
.heap 917696 917696 0 0.0
.text 1308664 1308664 0 0.0
light-app default (read/write) 2281464 2281464 0 0.0
.bss 100904 100904 0 0.0
.data 2328 2328 0 0.0
.heap 930112 930112 0 0.0
.text 1239728 1239728 0 0.0
lock-app default (read/write) 2257568 2257568 0 0.0
.bss 99784 99784 0 0.0
.data 2288 2288 0 0.0
.heap 931272 931272 0 0.0
.text 1215832 1215832 0 0.0
qpg lighting-app qpg6100+debug (read only) 511948 511948 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82624 0 0.0
.data 956 956 0 0.0
.text 506628 506628 0 0.0
lock-app qpg6100+debug (read only) 486140 486140 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81760 0 0.0
.data 912 912 0 0.0
.text 480820 480820 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800386 800386 0 0.0
bss 82764 82764 0 0.0
noinit 37160 37160 0 0.0
text 557446 557446 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the strongly-typed-enums branch 2 times, most recently from c70e51a to 82e1da2 Compare December 8, 2021 18:32
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12731: Size comparison from b1d7073 to 82e1da2

Increases above 0.2%:

platform target config section b1d7073 82e1da2 change % change
linux chip-tool-ipv6only arm64 (read only) 6732084 6787556 55472 0.8
(read/write) 310977 312593 1616 0.5
.data.rel.ro 206592 207856 1264 0.6
.got 48040 48392 352 0.7
.text 5731988 5782916 50928 0.9
Increases (1 build for linux)
platform target config section b1d7073 82e1da2 change % change
linux chip-tool-ipv6only arm64 (read only) 6732084 6787556 55472 0.8
(read/write) 310977 312593 1616 0.5
.data.rel.ro 206592 207856 1264 0.6
.got 48040 48392 352 0.7
.rodata 341796 342548 752 0.2
.text 5731988 5782916 50928 0.9
Full report (12 builds for efr32, linux, p6, qpg, telink)
platform target config section b1d7073 82e1da2 change % change
efr32 lighting-app BRD4161A (read only) 803900 803900 0 0.0
(read/write) 122996 122996 0 0.0
.bss 121176 121176 0 0.0
.data 1820 1820 0 0.0
.text 803892 803892 0 0.0
BRD4161A+rpc (read only) 791512 791512 0 0.0
(read/write) 139680 139680 0 0.0
.bss 137752 137752 0 0.0
.data 1928 1928 0 0.0
.text 791504 791504 0 0.0
window-app BRD4161A (read only) 780852 780852 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 780844 780844 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6732084 6787556 55472 0.8
(read/write) 310977 312593 1616 0.5
.bss 51665 51665 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 206592 207856 1264 0.6
.dynamic 560 560 0 0.0
.got 48040 48392 352 0.7
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 341796 342548 752 0.2
.text 5731988 5782916 50928 0.9
thermostat-no-ble arm64 (read only) 1932044 1932044 0 0.0
(read/write) 136465 136465 0 0.0
.bss 59457 59457 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69840 69840 0 0.0
.dynamic 560 560 0 0.0
.got 3528 3528 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124988 124988 0 0.0
.text 1601088 1601088 0 0.0
p6 all-clusters-app default (read/write) 2355624 2355624 0 0.0
.bss 113132 113132 0 0.0
.data 2512 2512 0 0.0
.heap 917696 917696 0 0.0
.text 1313888 1313888 0 0.0
light-app default (read/write) 2290408 2290408 0 0.0
.bss 100904 100904 0 0.0
.data 2328 2328 0 0.0
.heap 930112 930112 0 0.0
.text 1248672 1248672 0 0.0
lock-app default (read/write) 2266512 2266512 0 0.0
.bss 99784 99784 0 0.0
.data 2288 2288 0 0.0
.heap 931272 931272 0 0.0
.text 1224776 1224776 0 0.0
qpg lighting-app qpg6100+debug (read only) 517744 517744 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82624 0 0.0
.data 956 956 0 0.0
.text 512424 512424 0 0.0
lock-app qpg6100+debug (read only) 491944 491944 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81760 0 0.0
.data 912 912 0 0.0
.text 486624 486624 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807090 807090 0 0.0
bss 82764 82764 0 0.0
noinit 37160 37160 0 0.0
text 563090 563090 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

/rebase

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12731: Size comparison from e4f3246 to c02618b

Increases above 0.2%:

platform target config section e4f3246 c02618b change % change
linux chip-tool-ipv6only arm64 (read only) 6732084 6787556 55472 0.8
(read/write) 310977 312593 1616 0.5
.data.rel.ro 206592 207856 1264 0.6
.got 48040 48392 352 0.7
.text 5731988 5782916 50928 0.9
Increases (1 build for linux)
platform target config section e4f3246 c02618b change % change
linux chip-tool-ipv6only arm64 (read only) 6732084 6787556 55472 0.8
(read/write) 310977 312593 1616 0.5
.data.rel.ro 206592 207856 1264 0.6
.got 48040 48392 352 0.7
.rodata 341796 342548 752 0.2
.text 5731988 5782916 50928 0.9
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e4f3246 c02618b change % change
efr32 lighting-app BRD4161A (read only) 803900 803900 0 0.0
(read/write) 122996 122996 0 0.0
.bss 121176 121176 0 0.0
.data 1820 1820 0 0.0
.text 803892 803892 0 0.0
BRD4161A+rpc (read only) 791512 791512 0 0.0
(read/write) 139680 139680 0 0.0
.bss 137752 137752 0 0.0
.data 1928 1928 0 0.0
.text 791504 791504 0 0.0
window-app BRD4161A (read only) 780852 780852 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 780844 780844 0 0.0
esp32 all-clusters-app c3devkit (read only) 858566 858566 0 0.0
(read/write) 1306658 1306658 0 0.0
.dram0.bss 67648 67648 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171856 171856 0 0.0
.flash.text 858566 858566 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 961835 961835 0 0.0
(read/write) 450948 450948 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210112 210112 0 0.0
.flash.text 956451 956451 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724516 724516 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 635616 635616 0 0.0
lock-app k32w061+debug (read/write) 615868 615868 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 536336 536336 0 0.0
shell k32w061+debug (read/write) 679124 679124 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 589920 589920 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6732084 6787556 55472 0.8
(read/write) 310977 312593 1616 0.5
.bss 51665 51665 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 206592 207856 1264 0.6
.dynamic 560 560 0 0.0
.got 48040 48392 352 0.7
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 341796 342548 752 0.2
.text 5731988 5782916 50928 0.9
thermostat-no-ble arm64 (read only) 1932044 1932044 0 0.0
(read/write) 136465 136465 0 0.0
.bss 59457 59457 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69840 69840 0 0.0
.dynamic 560 560 0 0.0
.got 3528 3528 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124988 124988 0 0.0
.text 1601088 1601088 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319536 2319536 0 0.0
.bss 186900 186900 0 0.0
.data 5232 5232 0 0.0
.heap 844312 844312 0 0.0
.text 1282112 1282112 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305736 2305736 0 0.0
.bss 175712 175712 0 0.0
.data 5488 5488 0 0.0
.heap 855248 855248 0 0.0
.text 1268336 1268336 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174752 174752 0 0.0
.data 5488 5488 0 0.0
.heap 856208 856208 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903055 903055 0 0.0
bss 116184 116184 0 0.0
rodata 101208 101208 0 0.0
text 610104 610104 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866079 866079 0 0.0
bss 112532 112532 0 0.0
rodata 92504 92504 0 0.0
text 584832 584832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829046 829046 0 0.0
bss 117560 117560 0 0.0
rodata 96464 96464 0 0.0
text 540532 540532 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875523 875523 0 0.0
bss 113448 113448 0 0.0
rodata 97324 97324 0 0.0
text 589364 589364 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801754 801754 0 0.0
bss 114856 114856 0 0.0
rodata 92612 92612 0 0.0
text 519884 519884 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880371 880371 0 0.0
bss 113360 113360 0 0.0
rodata 98676 98676 0 0.0
text 592880 592880 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873599 873599 0 0.0
bss 113236 113236 0 0.0
rodata 96816 96816 0 0.0
text 588100 588100 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2355624 2355624 0 0.0
.bss 113132 113132 0 0.0
.data 2512 2512 0 0.0
.heap 917696 917696 0 0.0
.text 1313888 1313888 0 0.0
light-app default (read/write) 2290408 2290408 0 0.0
.bss 100904 100904 0 0.0
.data 2328 2328 0 0.0
.heap 930112 930112 0 0.0
.text 1248672 1248672 0 0.0
lock-app default (read/write) 2266512 2266512 0 0.0
.bss 99784 99784 0 0.0
.data 2288 2288 0 0.0
.heap 931272 931272 0 0.0
.text 1224776 1224776 0 0.0
qpg lighting-app qpg6100+debug (read only) 517744 517744 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82624 0 0.0
.data 956 956 0 0.0
.text 512424 512424 0 0.0
lock-app qpg6100+debug (read only) 491944 491944 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81760 0 0.0
.data 912 912 0 0.0
.text 486624 486624 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807090 807090 0 0.0
bss 82764 82764 0 0.0
noinit 37160 37160 0 0.0
text 563090 563090 0 0.0

@andy31415
Copy link
Contributor

fast track: change created and approved by domain owners

@bzbarsky-apple bzbarsky-apple merged commit 3e3195c into project-chip:master Dec 8, 2021
@bzbarsky-apple bzbarsky-apple deleted the strongly-typed-enums branch December 9, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @mrjerryjohns