Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android]-Custom CommissioningFlow - Redirect back to ChipTool after commissioning #12712

Merged
merged 3 commits into from
Dec 9, 2021
Merged

[Android]-Custom CommissioningFlow - Redirect back to ChipTool after commissioning #12712

merged 3 commits into from
Dec 9, 2021

Conversation

lijujayakumar
Copy link
Contributor

Custom CommissioningFlow - Redirect back to ChipTool after commissioning

Change overview

This PR defines a URI to the android app, such that 3P apps can redirect back the users to ChipTool as part of Custom CommissioningFlow Implementation.

Testing

How was this tested? (at least one bullet point required)

  • If manually tested, using the following URI - mt://modelinfo?payload=eyJjb21taXNzaW9uaW5nRmxvdyI6MCwiZGlzY292ZXJ5Q2FwYWJpbGl0aWVzIjpbIkJMRSJdLCJk aXNjcmltaW5hdG9yIjozODQwLCJvcHRpb25hbFFyQ29kZUluZm9NYXAiOnt9LCJwcm9kdWN0SWQi OjY1Mjc5LCJzZXR1cFBpbkNvZGUiOjIwMjAyMDIxLCJ2ZW5kb3JJZCI6OTA1MCwidmVyc2lvbiI6 MH0=

Screenshots

  • Landing page when redirected using the URI

Landing

* Device Info page (Payload parsed from the URI)

DeviceInfo

@boring-cyborg boring-cyborg bot added the android label Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12712: Size comparison from 8c04dce to 5b09ba9

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8c04dce 5b09ba9 change % change
efr32 lighting-app BRD4161A (read only) 794736 794736 0 0.0
(read/write) 122992 122992 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 794728 794728 0 0.0
BRD4161A+rpc (read only) 782348 782348 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 782340 782340 0 0.0
window-app BRD4161A (read only) 771672 771672 0 0.0
(read/write) 121128 121128 0 0.0
.bss 119344 119344 0 0.0
.data 1784 1784 0 0.0
.text 771664 771664 0 0.0
esp32 all-clusters-app c3devkit (read only) 855576 855576 0 0.0
(read/write) 1305994 1305994 0 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171192 171192 0 0.0
.flash.text 855576 855576 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958299 958299 0 0.0
(read/write) 450236 450236 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209400 209400 0 0.0
.flash.text 952915 952915 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731948 731948 0 0.0
.bss 81240 81240 0 0.0
.data 1852 1852 0 0.0
.text 643056 643056 0 0.0
lock-app k32w061+debug (read/write) 622532 622532 0 0.0
.bss 71904 71904 0 0.0
.data 1820 1820 0 0.0
.text 543008 543008 0 0.0
shell k32w061+debug (read/write) 685624 685624 0 0.0
.bss 81604 81604 0 0.0
.data 1792 1792 0 0.0
.text 596428 596428 0 0.0
linux all-clusters-app debug (read only) 1904073 1904073 0 0.0
(read/write) 131584 131584 0 0.0
.bss 56688 56688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 68240 68240 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155684 155684 0 0.0
.text 1602626 1602626 0 0.0
bridge-app debug+rpc (read only) 1447877 1447877 0 0.0
(read/write) 77712 77712 0 0.0
.bss 39120 39120 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 31800 31800 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123460 123460 0 0.0
.text 1219205 1219205 0 0.0
chip-tool debug (read only) 6690005 6690005 0 0.0
(read/write) 202336 202336 0 0.0
.bss 35272 35272 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160360 160360 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335657 335657 0 0.0
.text 5945253 5945253 0 0.0
lighting-app debug+rpc (read only) 1735633 1735633 0 0.0
(read/write) 110776 110776 0 0.0
.bss 44816 44816 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 59312 59312 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144348 144348 0 0.0
.text 1448306 1448306 0 0.0
ota-provider-app debug (read only) 1412313 1412313 0 0.0
(read/write) 75688 75688 0 0.0
.bss 41600 41600 0 0.0
.data 896 896 0 0.0
.data.rel.ro 28008 28008 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124894 124894 0 0.0
.text 1182514 1182514 0 0.0
ota-requestor-app debug (read only) 1517033 1517033 0 0.0
(read/write) 80704 80704 0 0.0
.bss 44768 44768 0 0.0
.data 960 960 0 0.0
.data.rel.ro 29768 29768 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137583 137583 0 0.0
.text 1270642 1270642 0 0.0
shell debug (read only) 828593 828593 0 0.0
(read/write) 60608 60608 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39000 39000 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85970 85970 0 0.0
.text 635522 635522 0 0.0
tv-app debug (read only) 2044289 2044289 0 0.0
(read/write) 324120 324120 0 0.0
.bss 251160 251160 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 64408 64408 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176444 176444 0 0.0
.text 1712818 1712818 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316128 2316128 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1278704 1278704 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298776 2298776 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1261376 1261376 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271688 2271688 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1234288 1234288 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047992 2047992 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010592 1010592 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896779 896779 0 0.0
bss 116176 116176 0 0.0
rodata 100132 100132 0 0.0
text 604904 604904 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 859803 0 0.0
bss 112524 112524 0 0.0
rodata 91428 91428 0 0.0
text 579632 579632 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822706 0 0.0
bss 117552 117552 0 0.0
rodata 95388 95388 0 0.0
text 535276 535276 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869215 869215 0 0.0
bss 113440 113440 0 0.0
rodata 96248 96248 0 0.0
text 584160 584160 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795402 795402 0 0.0
bss 114848 114848 0 0.0
rodata 91540 91540 0 0.0
text 514624 514624 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874099 0 0.0
bss 113352 113352 0 0.0
rodata 97604 97604 0 0.0
text 587676 587676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867323 0 0.0
bss 113228 113228 0 0.0
rodata 95740 95740 0 0.0
text 582896 582896 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523268 523268 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443908 443908 0 0.0
p6 all-clusters-app default (read/write) 2349808 2349808 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1308072 1308072 0 0.0
light-app default (read/write) 2281112 2281112 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1239376 1239376 0 0.0
lock-app default (read/write) 2257200 2257200 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1215464 1215464 0 0.0
qpg lighting-app qpg6100+debug (read only) 511772 511772 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 506452 506452 0 0.0
lock-app qpg6100+debug (read only) 485956 485956 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 480636 480636 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800102 800102 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 557204 557204 0 0.0

@andy31415
Copy link
Contributor

@austinh0 @xylophone21 ?

@woody-apple woody-apple merged commit 6fa971a into project-chip:master Dec 9, 2021
@lijujayakumar lijujayakumar mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinh0 austinh0 austinh0 approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@woody-apple woody-apple woody-apple approved these changes

@chrisbeach59 chrisbeach59 chrisbeach59 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
android review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lijujayakumar @andy31415 @chrisbeach59 @woody-apple @chrisdecenzo @austinh0