Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanups #12694

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Small cleanups #12694

merged 1 commit into from
Dec 7, 2021

Conversation

kpschoedel
Copy link
Contributor

  • Fix debug logging in src/ble/BtpEngine.cpp.

  • Fix Transport::PeerAddress::kMaxToStringSize to use Inet::IPAddress::kMaxStringLength for the result of Inet::IPAddress::ToString().

  • Fix some Doxygen.

@kpschoedel
Small cleanups
a24754a 
- Fix debug logging in `src/ble/BtpEngine.cpp`.

- Fix `Transport::PeerAddress::kMaxToStringSize` to use
  `Inet::IPAddress::kMaxStringLength` for the result of
  `Inet::IPAddress::ToString()`.

- Fix some Doxygen.
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12694: Size comparison from 051685b to a24754a

Increases (3 builds for linux)
platform target config section 051685b a24754a change % change
linux lighting-app debug+rpc (read only) 1742289 1742305 16 0.0
.text 1454610 1454626 16 0.0
ota-provider-app debug (read only) 1411953 1411969 16 0.0
.text 1181794 1181810 16 0.0
ota-requestor-app debug (read only) 1516705 1516721 16 0.0
.text 1269922 1269938 16 0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 051685b a24754a change % change
efr32 lighting-app BRD4161A (read only) 798156 798156 0 0.0
(read/write) 120548 120548 0 0.0
.bss 118720 118720 0 0.0
.data 1828 1828 0 0.0
.text 798148 798148 0 0.0
BRD4161A+rpc (read only) 826116 826116 0 0.0
(read/write) 138856 138856 0 0.0
.bss 136920 136920 0 0.0
.data 1936 1936 0 0.0
.text 826108 826108 0 0.0
lock-app BRD4161A (read only) 772832 772832 0 0.0
(read/write) 118488 118488 0 0.0
.bss 116696 116696 0 0.0
.data 1788 1788 0 0.0
.text 772824 772824 0 0.0
window-app BRD4161A (read only) 775104 775104 0 0.0
(read/write) 118688 118688 0 0.0
.bss 116896 116896 0 0.0
.data 1792 1792 0 0.0
.text 775096 775096 0 0.0
esp32 all-clusters-app c3devkit (read only) 856796 856796 0 0.0
(read/write) 1298938 1298938 0 0.0
.dram0.bss 61096 61096 0 0.0
.dram0.data 14132 14132 0 0.0
.flash.rodata 170664 170664 0 0.0
.flash.text 856796 856796 0 0.0
.iram0.text 62028 62028 0 0.0
m5stack (read only) 960115 960115 0 0.0
(read/write) 443244 443244 0 0.0
.dram0.bss 68448 68448 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 208952 208952 0 0.0
.flash.text 954731 954731 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732484 732484 0 0.0
.bss 79296 79296 0 0.0
.data 1860 1860 0 0.0
.text 645528 645528 0 0.0
lock-app k32w061+debug (read/write) 623164 623164 0 0.0
.bss 69960 69960 0 0.0
.data 1828 1828 0 0.0
.text 545576 545576 0 0.0
shell k32w061+debug (read/write) 689084 689084 0 0.0
.bss 81596 81596 0 0.0
.data 1800 1800 0 0.0
.text 599888 599888 0 0.0
linux all-clusters-app debug (read only) 1907689 1907689 0 0.0
(read/write) 128896 128896 0 0.0
.bss 54032 54032 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 68192 68192 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 156277 156277 0 0.0
.text 1605570 1605570 0 0.0
bridge-app debug+rpc (read only) 1456485 1456485 0 0.0
(read/write) 75088 75088 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31824 31824 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123932 123932 0 0.0
.text 1227173 1227173 0 0.0
chip-tool debug (read only) 6687597 6687597 0 0.0
(read/write) 201728 201728 0 0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160376 160376 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335721 335721 0 0.0
.text 5942613 5942613 0 0.0
lighting-app debug+rpc (read only) 1742289 1742305 16 0.0
(read/write) 108152 108152 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59344 59344 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144529 144529 0 0.0
.text 1454610 1454626 16 0.0
ota-provider-app debug (read only) 1411953 1411969 16 0.0
(read/write) 73096 73096 0 0.0
.bss 38976 38976 0 0.0
.data 928 928 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 125086 0 0.0
.text 1181794 1181810 16 0.0
ota-requestor-app debug (read only) 1516705 1516721 16 0.0
(read/write) 78144 78144 0 0.0
.bss 42144 42144 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29784 29784 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137807 0 0.0
.text 1269922 1269938 16 0.0
shell debug (read only) 827345 827345 0 0.0
(read/write) 60640 60640 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39032 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85714 0 0.0
.text 634530 634530 0 0.0
tv-app debug (read only) 2056201 2056201 0 0.0
(read/write) 320504 320504 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64432 64432 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176828 176828 0 0.0
.text 1724178 1724178 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317160 2317160 0 0.0
.bss 184444 184444 0 0.0
.data 5240 5240 0 0.0
.heap 846760 846760 0 0.0
.text 1279736 1279736 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300992 2300992 0 0.0
.bss 173248 173248 0 0.0
.data 5496 5496 0 0.0
.heap 857704 857704 0 0.0
.text 1263592 1263592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274032 2274032 0 0.0
.bss 172296 172296 0 0.0
.data 5496 5496 0 0.0
.heap 858656 858656 0 0.0
.text 1236632 1236632 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048008 2048008 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010608 1010608 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896707 896707 0 0.0
bss 113724 113724 0 0.0
rodata 100308 100308 0 0.0
text 607112 607112 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859643 859643 0 0.0
bss 110072 110072 0 0.0
rodata 91500 91500 0 0.0
text 581848 581848 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822638 822638 0 0.0
bss 115100 115100 0 0.0
rodata 95568 95568 0 0.0
text 537480 537480 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869275 869275 0 0.0
bss 110988 110988 0 0.0
rodata 96428 96428 0 0.0
text 586468 586468 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795458 795458 0 0.0
bss 112396 112396 0 0.0
rodata 91716 91716 0 0.0
text 516932 516932 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874027 874027 0 0.0
bss 110900 110900 0 0.0
rodata 97780 97780 0 0.0
text 589884 589884 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867235 867235 0 0.0
bss 110776 110776 0 0.0
rodata 95916 95916 0 0.0
text 585092 585092 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781643 781643 0 0.0
bss 109552 109552 0 0.0
rodata 74296 74296 0 0.0
text 523284 523284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696718 696718 0 0.0
bss 110532 110532 0 0.0
rodata 68936 68936 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2353392 2353392 0 0.0
.bss 110668 110668 0 0.0
.data 2520 2520 0 0.0
.heap 920152 920152 0 0.0
.text 1311656 1311656 0 0.0
light-app default (read/write) 2284536 2284536 0 0.0
.bss 98440 98440 0 0.0
.data 2336 2336 0 0.0
.heap 932568 932568 0 0.0
.text 1242800 1242800 0 0.0
lock-app default (read/write) 2260688 2260688 0 0.0
.bss 97320 97320 0 0.0
.data 2296 2296 0 0.0
.heap 933728 933728 0 0.0
.text 1218952 1218952 0 0.0
qpg lighting-app qpg6100+debug (read only) 514144 514144 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80168 80168 0 0.0
.data 964 964 0 0.0
.text 508824 508824 0 0.0
lock-app qpg6100+debug (read only) 488448 488448 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79304 79304 0 0.0
.data 920 920 0 0.0
.text 483128 483128 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799870 799870 0 0.0
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 559130 559130 0 0.0

@andy31415 andy31415 merged commit fcd9785 into project-chip:master Dec 7, 2021
@kpschoedel kpschoedel deleted the cleanup-misc branch December 8, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
ble controller fast track platform review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpschoedel @andy31415 @saurabhst