Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send optional MRP parameters in PASE messages #12638

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Send optional MRP parameters in PASE messages #12638

merged 5 commits into from
Dec 7, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

Change overview

Include MRP parameters in PBKDF param request and response messages.
Add unit tests in TestPASESession to check that the parameters are received correctly.

Testing

Added three new unit tests to TestPASESession

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12638: Size comparison from d5e9b66 to fe87b2e

Increases above 0.2%:

platform target config section d5e9b66 fe87b2e change % change
linux bridge-app debug+rpc .text 1217541 1220261 2720 0.2
ota-provider-app debug .text 1173922 1176626 2704 0.2
ota-requestor-app debug .text 1266402 1269106 2704 0.2
tv-app debug (read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
Increases (16 builds for k32w, linux, p6, qpg, telink)
platform target config section d5e9b66 fe87b2e change % change
k32w lighting-app k32w061+se05x+release (read/write) 731576 731860 284 0.0
.bss 79408 79416 8 0.0
.text 644508 644784 276 0.0
lock-app k32w061+debug (read/write) 622292 622576 284 0.0
.bss 70072 70080 8 0.0
.text 544592 544868 276 0.1
shell k32w061+debug (read/write) 688184 688464 280 0.0
.bss 81720 81728 8 0.0
.text 598864 599136 272 0.0
linux all-clusters-app debug (read only) 1865497 1868305 2808 0.2
.rodata 152917 153024 107 0.1
.text 1569282 1571986 2704 0.2
bridge-app debug+rpc (read only) 1444525 1447333 2808 0.2
.rodata 121916 122002 86 0.1
.text 1217541 1220261 2720 0.2
chip-tool debug (read only) 6646077 6649445 3368 0.1
.rodata 313112 313200 88 0.0
.text 5928069 5931349 3280 0.1
lighting-app debug+rpc (read only) 1730329 1733129 2800 0.2
.rodata 142513 142596 83 0.1
.text 1444978 1447698 2720 0.2
ota-provider-app debug (read only) 1402049 1404849 2800 0.2
.rodata 123272 123368 96 0.1
.text 1173922 1176626 2704 0.2
ota-requestor-app debug (read only) 1511225 1514001 2776 0.2
.rodata 136016 136088 72 0.1
.text 1266402 1269106 2704 0.2
tv-app debug (read only) 2046321 2049689 3368 0.2
(read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
.rodata 174768 174872 104 0.1
.text 1716642 1719906 3264 0.2
p6 all-clusters-app default (read/write) 2346600 2347048 448 0.0
.bss 107692 107700 8 0.0
.text 1304864 1305312 448 0.0
light-app default (read/write) 2283848 2284280 432 0.0
.bss 98632 98640 8 0.0
.text 1242112 1242544 432 0.0
lock-app default (read/write) 2259984 2260432 448 0.0
.bss 97512 97520 8 0.0
.text 1218248 1218696 448 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513552 276 0.1
.bss 80360 80368 8 0.0
.text 507956 508232 276 0.1
lock-app qpg6100+debug (read only) 487580 487856 276 0.1
.bss 79496 79504 8 0.0
.text 482260 482536 276 0.1
telink lighting-app tlsr9518adk80d (read/write) 798390 798734 344 0.0
bss 80428 80436 8 0.0
text 557996 558226 230 0.0
Decreases (3 builds for p6)
platform target config section d5e9b66 fe87b2e change % change
p6 all-clusters-app default .heap 923184 923176 -8 -0.0
light-app default .heap 932376 932368 -8 -0.0
lock-app default .heap 933536 933528 -8 -0.0
Full report (18 builds for k32w, linux, p6, qpg, telink)
platform target config section d5e9b66 fe87b2e change % change
k32w lighting-app k32w061+se05x+release (read/write) 731576 731860 284 0.0
.bss 79408 79416 8 0.0
.data 1860 1860 0 0.0
.text 644508 644784 276 0.0
lock-app k32w061+debug (read/write) 622292 622576 284 0.0
.bss 70072 70080 8 0.0
.data 1828 1828 0 0.0
.text 544592 544868 276 0.1
shell k32w061+debug (read/write) 688184 688464 280 0.0
.bss 81720 81728 8 0.0
.data 1800 1800 0 0.0
.text 598864 599136 272 0.0
linux all-clusters-app debug (read only) 1865497 1868305 2808 0.2
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152917 153024 107 0.1
.text 1569282 1571986 2704 0.2
bridge-app debug+rpc (read only) 1444525 1447333 2808 0.2
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121916 122002 86 0.1
.text 1217541 1220261 2720 0.2
chip-tool debug (read only) 6646077 6649445 3368 0.1
(read/write) 200040 200040 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158600 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313112 313200 88 0.0
.text 5928069 5931349 3280 0.1
lighting-app debug+rpc (read only) 1730329 1733129 2800 0.2
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142513 142596 83 0.1
.text 1444978 1447698 2720 0.2
ota-provider-app debug (read only) 1402049 1404849 2800 0.2
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 123272 123368 96 0.1
.text 1173922 1176626 2704 0.2
ota-requestor-app debug (read only) 1511225 1514001 2776 0.2
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136016 136088 72 0.1
.text 1266402 1269106 2704 0.2
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046321 2049689 3368 0.2
(read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
.data 2768 2768 0 0.0
.data.rel.ro 64240 64240 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174768 174872 104 0.1
.text 1716642 1719906 3264 0.2
p6 all-clusters-app default (read/write) 2346600 2347048 448 0.0
.bss 107692 107700 8 0.0
.data 2464 2464 0 0.0
.heap 923184 923176 -8 -0.0
.text 1304864 1305312 448 0.0
light-app default (read/write) 2283848 2284280 432 0.0
.bss 98632 98640 8 0.0
.data 2336 2336 0 0.0
.heap 932376 932368 -8 -0.0
.text 1242112 1242544 432 0.0
lock-app default (read/write) 2259984 2260432 448 0.0
.bss 97512 97520 8 0.0
.data 2296 2296 0 0.0
.heap 933536 933528 -8 -0.0
.text 1218248 1218696 448 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513552 276 0.1
(read/write) 122332 122332 0 0.0
.bss 80360 80368 8 0.0
.data 964 964 0 0.0
.text 507956 508232 276 0.1
lock-app qpg6100+debug (read only) 487580 487856 276 0.1
(read/write) 122336 122336 0 0.0
.bss 79496 79504 8 0.0
.data 920 920 0 0.0
.text 482260 482536 276 0.1
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798734 344 0.0
bss 80428 80436 8 0.0
noinit 37160 37160 0 0.0
text 557996 558226 230 0.0

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12638: Size comparison from f929d1c to fcaa6b5

Increases above 0.2%:

platform target config section f929d1c fcaa6b5 change % change
linux tv-app debug (read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f929d1c fcaa6b5 change % change
efr32 lighting-app BRD4161A (read only) 797548 797980 432 0.1
(read/write) 120740 120748 8 0.0
.bss 118912 118920 8 0.0
.text 797540 797972 432 0.1
BRD4161A+rpc (read only) 825516 825948 432 0.1
(read/write) 139048 139056 8 0.0
.bss 137112 137120 8 0.0
.text 825508 825940 432 0.1
lock-app BRD4161A (read only) 772216 772664 448 0.1
(read/write) 118680 118688 8 0.0
.bss 116888 116896 8 0.0
.text 772208 772656 448 0.1
window-app BRD4161A (read only) 774504 774932 428 0.1
(read/write) 118880 118888 8 0.0
.bss 117088 117096 8 0.0
.text 774496 774924 428 0.1
esp32 all-clusters-app c3devkit (read only) 852296 852758 462 0.1
(read/write) 1295154 1295242 88 0.0
.dram0.bss 58232 58240 8 0.0
.dram0.data 14084 14092 8 0.1
.flash.rodata 169792 169880 88 0.1
.flash.text 852296 852758 462 0.1
m5stack (read only) 956495 956879 384 0.0
(read/write) 439528 439624 96 0.0
.dram0.bss 65592 65600 8 0.0
.flash.rodata 208132 208220 88 0.0
.flash.text 951111 951495 384 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731860 284 0.0
.bss 79408 79416 8 0.0
.text 644508 644784 276 0.0
lock-app k32w061+debug (read/write) 622292 622576 284 0.0
.bss 70072 70080 8 0.0
.text 544592 544868 276 0.1
shell k32w061+debug (read/write) 688184 688464 280 0.0
.bss 81720 81728 8 0.0
.text 598864 599136 272 0.0
linux all-clusters-app debug (read only) 1865497 1868305 2808 0.2
.rodata 152917 153024 107 0.1
.text 1569282 1571986 2704 0.2
bridge-app debug+rpc (read only) 1444525 1447333 2808 0.2
.rodata 121916 122002 86 0.1
.text 1217541 1220261 2720 0.2
chip-tool debug (read only) 6646077 6649445 3368 0.1
.rodata 313112 313200 88 0.0
.text 5928069 5931349 3280 0.1
lighting-app debug+rpc (read only) 1730329 1733129 2800 0.2
.rodata 142513 142596 83 0.1
.text 1444978 1447698 2720 0.2
ota-provider-app debug (read only) 1402049 1404849 2800 0.2
.rodata 123272 123368 96 0.1
.text 1173922 1176626 2704 0.2
ota-requestor-app debug (read only) 1511225 1514001 2776 0.2
.rodata 136016 136088 72 0.1
.text 1266402 1269106 2704 0.2
tv-app debug (read only) 2046321 2049689 3368 0.2
(read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
.rodata 174768 174872 104 0.1
.text 1716642 1719906 3264 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2312192 2312824 632 0.0
.bss 181412 181420 8 0.0
.text 1274768 1275400 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2300032 2300664 632 0.0
.bss 173400 173408 8 0.0
.text 1262632 1263264 632 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2273072 2273704 632 0.0
.bss 172440 172448 8 0.0
.text 1235672 1236304 632 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 895011 408 0.0
bss 113852 113860 8 0.0
rodata 99676 99764 88 0.1
text 605532 605808 276 0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 858339 360 0.0
bss 110200 110208 8 0.0
rodata 91036 91124 88 0.1
text 580528 580804 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820878 376 0.0
bss 115224 115232 8 0.0
rodata 94936 95024 88 0.1
text 535856 536140 284 0.1
lock-app nrf52840dk_nrf52840 (read/write) 867203 867563 360 0.0
bss 111112 111120 8 0.0
rodata 95796 95884 88 0.1
text 584904 585180 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793714 376 0.0
bss 112524 112532 8 0.0
rodata 91084 91172 88 0.1
text 515324 515608 284 0.1
pump-app nrf52840dk_nrf52840 (read/write) 871939 872299 360 0.0
bss 111024 111032 8 0.0
rodata 97148 97236 88 0.1
text 588304 588580 276 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865507 360 0.0
bss 110904 110912 8 0.0
rodata 95284 95372 88 0.1
text 583512 583788 276 0.0
p6 all-clusters-app default (read/write) 2346600 2347048 448 0.0
.bss 107692 107700 8 0.0
.text 1304864 1305312 448 0.0
light-app default (read/write) 2283848 2284280 432 0.0
.bss 98632 98640 8 0.0
.text 1242112 1242544 432 0.0
lock-app default (read/write) 2259984 2260432 448 0.0
.bss 97512 97520 8 0.0
.text 1218248 1218696 448 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513552 276 0.1
.bss 80360 80368 8 0.0
.text 507956 508232 276 0.1
lock-app qpg6100+debug (read only) 487580 487856 276 0.1
.bss 79496 79504 8 0.0
.text 482260 482536 276 0.1
telink lighting-app tlsr9518adk80d (read/write) 798390 798734 344 0.0
bss 80428 80436 8 0.0
text 557996 558226 230 0.0
Decreases (6 builds for mbed, p6)
platform target config section f929d1c fcaa6b5 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 849840 849832 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 857552 857544 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 858512 858504 -8 -0.0
p6 all-clusters-app default .heap 923184 923176 -8 -0.0
light-app default .heap 932376 932368 -8 -0.0
lock-app default .heap 933536 933528 -8 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f929d1c fcaa6b5 change % change
efr32 lighting-app BRD4161A (read only) 797548 797980 432 0.1
(read/write) 120740 120748 8 0.0
.bss 118912 118920 8 0.0
.data 1828 1828 0 0.0
.text 797540 797972 432 0.1
BRD4161A+rpc (read only) 825516 825948 432 0.1
(read/write) 139048 139056 8 0.0
.bss 137112 137120 8 0.0
.data 1936 1936 0 0.0
.text 825508 825940 432 0.1
lock-app BRD4161A (read only) 772216 772664 448 0.1
(read/write) 118680 118688 8 0.0
.bss 116888 116896 8 0.0
.data 1788 1788 0 0.0
.text 772208 772656 448 0.1
window-app BRD4161A (read only) 774504 774932 428 0.1
(read/write) 118880 118888 8 0.0
.bss 117088 117096 8 0.0
.data 1792 1792 0 0.0
.text 774496 774924 428 0.1
esp32 all-clusters-app c3devkit (read only) 852296 852758 462 0.1
(read/write) 1295154 1295242 88 0.0
.dram0.bss 58232 58240 8 0.0
.dram0.data 14084 14092 8 0.1
.flash.rodata 169792 169880 88 0.1
.flash.text 852296 852758 462 0.1
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956495 956879 384 0.0
(read/write) 439528 439624 96 0.0
.dram0.bss 65592 65600 8 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208220 88 0.0
.flash.text 951111 951495 384 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731860 284 0.0
.bss 79408 79416 8 0.0
.data 1860 1860 0 0.0
.text 644508 644784 276 0.0
lock-app k32w061+debug (read/write) 622292 622576 284 0.0
.bss 70072 70080 8 0.0
.data 1828 1828 0 0.0
.text 544592 544868 276 0.1
shell k32w061+debug (read/write) 688184 688464 280 0.0
.bss 81720 81728 8 0.0
.data 1800 1800 0 0.0
.text 598864 599136 272 0.0
linux all-clusters-app debug (read only) 1865497 1868305 2808 0.2
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152917 153024 107 0.1
.text 1569282 1571986 2704 0.2
bridge-app debug+rpc (read only) 1444525 1447333 2808 0.2
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121916 122002 86 0.1
.text 1217541 1220261 2720 0.2
chip-tool debug (read only) 6646077 6649445 3368 0.1
(read/write) 200040 200040 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158600 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313112 313200 88 0.0
.text 5928069 5931349 3280 0.1
lighting-app debug+rpc (read only) 1730329 1733129 2800 0.2
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142513 142596 83 0.1
.text 1444978 1447698 2720 0.2
ota-provider-app debug (read only) 1402049 1404849 2800 0.2
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 123272 123368 96 0.1
.text 1173922 1176626 2704 0.2
ota-requestor-app debug (read only) 1511225 1514001 2776 0.2
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136016 136088 72 0.1
.text 1266402 1269106 2704 0.2
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046321 2049689 3368 0.2
(read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
.data 2768 2768 0 0.0
.data.rel.ro 64240 64240 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174768 174872 104 0.1
.text 1716642 1719906 3264 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2312824 632 0.0
.bss 181412 181420 8 0.0
.data 5192 5192 0 0.0
.heap 849840 849832 -8 -0.0
.text 1274768 1275400 632 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300664 632 0.0
.bss 173400 173408 8 0.0
.data 5496 5496 0 0.0
.heap 857552 857544 -8 -0.0
.text 1262632 1263264 632 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273704 632 0.0
.bss 172440 172448 8 0.0
.data 5496 5496 0 0.0
.heap 858512 858504 -8 -0.0
.text 1235672 1236304 632 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 895011 408 0.0
bss 113852 113860 8 0.0
rodata 99676 99764 88 0.1
text 605532 605808 276 0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 858339 360 0.0
bss 110200 110208 8 0.0
rodata 91036 91124 88 0.1
text 580528 580804 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820878 376 0.0
bss 115224 115232 8 0.0
rodata 94936 95024 88 0.1
text 535856 536140 284 0.1
lock-app nrf52840dk_nrf52840 (read/write) 867203 867563 360 0.0
bss 111112 111120 8 0.0
rodata 95796 95884 88 0.1
text 584904 585180 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793714 376 0.0
bss 112524 112532 8 0.0
rodata 91084 91172 88 0.1
text 515324 515608 284 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 872299 360 0.0
bss 111024 111032 8 0.0
rodata 97148 97236 88 0.1
text 588304 588580 276 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865507 360 0.0
bss 110904 110912 8 0.0
rodata 95284 95372 88 0.1
text 583512 583788 276 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346600 2347048 448 0.0
.bss 107692 107700 8 0.0
.data 2464 2464 0 0.0
.heap 923184 923176 -8 -0.0
.text 1304864 1305312 448 0.0
light-app default (read/write) 2283848 2284280 432 0.0
.bss 98632 98640 8 0.0
.data 2336 2336 0 0.0
.heap 932376 932368 -8 -0.0
.text 1242112 1242544 432 0.0
lock-app default (read/write) 2259984 2260432 448 0.0
.bss 97512 97520 8 0.0
.data 2296 2296 0 0.0
.heap 933536 933528 -8 -0.0
.text 1218248 1218696 448 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513552 276 0.1
(read/write) 122332 122332 0 0.0
.bss 80360 80368 8 0.0
.data 964 964 0 0.0
.text 507956 508232 276 0.1
lock-app qpg6100+debug (read only) 487580 487856 276 0.1
(read/write) 122336 122336 0 0.0
.bss 79496 79504 8 0.0
.data 920 920 0 0.0
.text 482260 482536 276 0.1
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798734 344 0.0
bss 80428 80436 8 0.0
noinit 37160 37160 0 0.0
text 557996 558226 230 0.0

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12638: Size comparison from a1cb341 to bc7a34a

Increases above 0.2%:

platform target config section a1cb341 bc7a34a change % change
linux tv-app debug (read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a1cb341 bc7a34a change % change
efr32 lighting-app BRD4161A (read only) 797548 798184 636 0.1
(read/write) 120740 120752 12 0.0
.bss 118912 118920 8 0.0
.text 797540 798176 636 0.1
BRD4161A+rpc (read only) 825516 826152 636 0.1
(read/write) 139048 139056 8 0.0
.bss 137112 137120 8 0.0
.text 825508 826144 636 0.1
lock-app BRD4161A (read only) 772216 772868 652 0.1
(read/write) 118680 118684 4 0.0
.bss 116888 116896 8 0.0
.text 772208 772860 652 0.1
window-app BRD4161A (read only) 774504 775136 632 0.1
(read/write) 118880 118888 8 0.0
.bss 117088 117096 8 0.0
.text 774496 775128 632 0.1
esp32 all-clusters-app c3devkit (read only) 852296 852802 506 0.1
(read/write) 1295154 1295242 88 0.0
.dram0.bss 58232 58240 8 0.0
.flash.rodata 169792 169880 88 0.1
.flash.text 852296 852802 506 0.1
m5stack (read only) 956539 956983 444 0.0
(read/write) 439528 439616 88 0.0
.dram0.bss 65592 65600 8 0.0
.flash.rodata 208132 208212 80 0.0
.flash.text 951155 951599 444 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 732064 488 0.1
.bss 79408 79416 8 0.0
.text 644508 644988 480 0.1
lock-app k32w061+debug (read/write) 622292 622764 472 0.1
.bss 70072 70080 8 0.0
.text 544592 545056 464 0.1
shell k32w061+debug (read/write) 688184 688672 488 0.1
.bss 81720 81728 8 0.0
.text 598864 599344 480 0.1
linux all-clusters-app debug (read only) 1871337 1874273 2936 0.2
.rodata 153717 153956 239 0.2
.text 1574322 1577026 2704 0.2
bridge-app debug+rpc (read only) 1450341 1453301 2960 0.2
.rodata 122692 122932 240 0.2
.text 1222581 1225301 2720 0.2
chip-tool debug (read only) 6652053 6655557 3504 0.1
.rodata 313873 314097 224 0.1
.text 5933285 5936565 3280 0.1
lighting-app debug+rpc (read only) 1736201 1739137 2936 0.2
.rodata 143345 143580 235 0.2
.text 1450018 1452722 2704 0.2
ota-provider-app debug (read only) 1407897 1410873 2976 0.2
.rodata 124078 124350 272 0.2
.text 1178962 1181666 2704 0.2
ota-requestor-app debug (read only) 1517249 1520193 2944 0.2
.rodata 136823 137063 240 0.2
.text 1271618 1274322 2704 0.2
tv-app debug (read only) 2052297 2055793 3496 0.2
(read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
.rodata 175532 175764 232 0.1
.text 1721858 1725122 3264 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2312192 2313008 816 0.0
.bss 181412 181420 8 0.0
.text 1274768 1275584 816 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2300032 2300848 816 0.0
.bss 173400 173408 8 0.0
.text 1262632 1263448 816 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2273072 2273952 880 0.0
.bss 172440 172448 8 0.0
.text 1235672 1236552 880 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 895231 628 0.1
bss 113852 113860 8 0.0
rodata 99676 99760 84 0.1
text 605532 606036 504 0.1
nrf52840dk_nrf52840+rpc (read/write) 857979 858575 596 0.1
bss 110200 110208 8 0.0
rodata 91036 91120 84 0.1
text 580528 581032 504 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820502 821098 596 0.1
bss 115224 115232 8 0.0
rodata 94936 95020 84 0.1
text 535856 536360 504 0.1
lock-app nrf52840dk_nrf52840 (read/write) 867203 867783 580 0.1
bss 111112 111120 8 0.0
rodata 95796 95880 84 0.1
text 584904 585408 504 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793918 580 0.1
bss 112524 112532 8 0.0
rodata 91084 91168 84 0.1
text 515324 515828 504 0.1
pump-app nrf52840dk_nrf52840 (read/write) 871939 872519 580 0.1
bss 111024 111032 8 0.0
rodata 97148 97232 84 0.1
text 588304 588808 504 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865743 596 0.1
bss 110904 110912 8 0.0
rodata 95284 95368 84 0.1
text 583512 584016 504 0.1
p6 all-clusters-app default (read/write) 2346600 2347256 656 0.0
.bss 107692 107700 8 0.0
.text 1304864 1305520 656 0.1
light-app default (read/write) 2283848 2284488 640 0.0
.bss 98632 98640 8 0.0
.text 1242112 1242752 640 0.1
lock-app default (read/write) 2259984 2260640 656 0.0
.bss 97512 97520 8 0.0
.text 1218248 1218904 656 0.1
qpg lighting-app qpg6100+debug (read only) 513276 513748 472 0.1
.bss 80360 80368 8 0.0
.text 507956 508428 472 0.1
lock-app qpg6100+debug (read only) 487580 488052 472 0.1
.bss 79496 79504 8 0.0
.text 482260 482732 472 0.1
telink lighting-app tlsr9518adk80d (read/write) 798390 798990 600 0.1
bss 80428 80436 8 0.0
text 557996 558492 496 0.1
Decreases (6 builds for mbed, p6)
platform target config section a1cb341 bc7a34a change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 849840 849832 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 857552 857544 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 858512 858504 -8 -0.0
p6 all-clusters-app default .heap 923184 923176 -8 -0.0
light-app default .heap 932376 932368 -8 -0.0
lock-app default .heap 933536 933528 -8 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a1cb341 bc7a34a change % change
efr32 lighting-app BRD4161A (read only) 797548 798184 636 0.1
(read/write) 120740 120752 12 0.0
.bss 118912 118920 8 0.0
.data 1828 1828 0 0.0
.text 797540 798176 636 0.1
BRD4161A+rpc (read only) 825516 826152 636 0.1
(read/write) 139048 139056 8 0.0
.bss 137112 137120 8 0.0
.data 1936 1936 0 0.0
.text 825508 826144 636 0.1
lock-app BRD4161A (read only) 772216 772868 652 0.1
(read/write) 118680 118684 4 0.0
.bss 116888 116896 8 0.0
.data 1788 1788 0 0.0
.text 772208 772860 652 0.1
window-app BRD4161A (read only) 774504 775136 632 0.1
(read/write) 118880 118888 8 0.0
.bss 117088 117096 8 0.0
.data 1792 1792 0 0.0
.text 774496 775128 632 0.1
esp32 all-clusters-app c3devkit (read only) 852296 852802 506 0.1
(read/write) 1295154 1295242 88 0.0
.dram0.bss 58232 58240 8 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169880 88 0.1
.flash.text 852296 852802 506 0.1
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956539 956983 444 0.0
(read/write) 439528 439616 88 0.0
.dram0.bss 65592 65600 8 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208212 80 0.0
.flash.text 951155 951599 444 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 732064 488 0.1
.bss 79408 79416 8 0.0
.data 1860 1860 0 0.0
.text 644508 644988 480 0.1
lock-app k32w061+debug (read/write) 622292 622764 472 0.1
.bss 70072 70080 8 0.0
.data 1828 1828 0 0.0
.text 544592 545056 464 0.1
shell k32w061+debug (read/write) 688184 688672 488 0.1
.bss 81720 81728 8 0.0
.data 1800 1800 0 0.0
.text 598864 599344 480 0.1
linux all-clusters-app debug (read only) 1871337 1874273 2936 0.2
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 153717 153956 239 0.2
.text 1574322 1577026 2704 0.2
bridge-app debug+rpc (read only) 1450341 1453301 2960 0.2
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 122692 122932 240 0.2
.text 1222581 1225301 2720 0.2
chip-tool debug (read only) 6652053 6655557 3504 0.1
(read/write) 200040 200040 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158600 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313873 314097 224 0.1
.text 5933285 5936565 3280 0.1
lighting-app debug+rpc (read only) 1736201 1739137 2936 0.2
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143345 143580 235 0.2
.text 1450018 1452722 2704 0.2
ota-provider-app debug (read only) 1407897 1410873 2976 0.2
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124078 124350 272 0.2
.text 1178962 1181666 2704 0.2
ota-requestor-app debug (read only) 1517249 1520193 2944 0.2
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136823 137063 240 0.2
.text 1271618 1274322 2704 0.2
shell debug (read only) 823577 823577 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84754 84754 0 0.0
.text 631986 631986 0 0.0
tv-app debug (read only) 2052297 2055793 3496 0.2
(read/write) 320320 321344 1024 0.3
.bss 247480 248504 1024 0.4
.data 2768 2768 0 0.0
.data.rel.ro 64240 64240 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175532 175764 232 0.1
.text 1721858 1725122 3264 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2313008 816 0.0
.bss 181412 181420 8 0.0
.data 5192 5192 0 0.0
.heap 849840 849832 -8 -0.0
.text 1274768 1275584 816 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300848 816 0.0
.bss 173400 173408 8 0.0
.data 5496 5496 0 0.0
.heap 857552 857544 -8 -0.0
.text 1262632 1263448 816 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273952 880 0.0
.bss 172440 172448 8 0.0
.data 5496 5496 0 0.0
.heap 858512 858504 -8 -0.0
.text 1235672 1236552 880 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 895231 628 0.1
bss 113852 113860 8 0.0
rodata 99676 99760 84 0.1
text 605532 606036 504 0.1
nrf52840dk_nrf52840+rpc (read/write) 857979 858575 596 0.1
bss 110200 110208 8 0.0
rodata 91036 91120 84 0.1
text 580528 581032 504 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820502 821098 596 0.1
bss 115224 115232 8 0.0
rodata 94936 95020 84 0.1
text 535856 536360 504 0.1
lock-app nrf52840dk_nrf52840 (read/write) 867203 867783 580 0.1
bss 111112 111120 8 0.0
rodata 95796 95880 84 0.1
text 584904 585408 504 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793918 580 0.1
bss 112524 112532 8 0.0
rodata 91084 91168 84 0.1
text 515324 515828 504 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 872519 580 0.1
bss 111024 111032 8 0.0
rodata 97148 97232 84 0.1
text 588304 588808 504 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865743 596 0.1
bss 110904 110912 8 0.0
rodata 95284 95368 84 0.1
text 583512 584016 504 0.1
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346600 2347256 656 0.0
.bss 107692 107700 8 0.0
.data 2464 2464 0 0.0
.heap 923184 923176 -8 -0.0
.text 1304864 1305520 656 0.1
light-app default (read/write) 2283848 2284488 640 0.0
.bss 98632 98640 8 0.0
.data 2336 2336 0 0.0
.heap 932376 932368 -8 -0.0
.text 1242112 1242752 640 0.1
lock-app default (read/write) 2259984 2260640 656 0.0
.bss 97512 97520 8 0.0
.data 2296 2296 0 0.0
.heap 933536 933528 -8 -0.0
.text 1218248 1218904 656 0.1
qpg lighting-app qpg6100+debug (read only) 513276 513748 472 0.1
(read/write) 122332 122332 0 0.0
.bss 80360 80368 8 0.0
.data 964 964 0 0.0
.text 507956 508428 472 0.1
lock-app qpg6100+debug (read only) 487580 488052 472 0.1
(read/write) 122336 122336 0 0.0
.bss 79496 79504 8 0.0
.data 920 920 0 0.0
.text 482260 482732 472 0.1
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798990 600 0.1
bss 80428 80436 8 0.0
noinit 37160 37160 0 0.0
text 557996 558492 496 0.1

andy31415
andy31415 reviewed Dec 7, 2021
View reviewed changes
src/transport/PairingSession.cpp Outdated Show resolved Hide resolved
src/transport/PairingSession.h Outdated Show resolved Hide resolved
@pan-apple pan-apple requested a review from andy31415 December 7, 2021 16:56
@restyled-io restyled-io bot mentioned this pull request Dec 7, 2021
Closed
@andy31415
Copy link
Contributor

fast track: solid unit testing, has several checkmarks, change made by a domain owner.

@pan-apple pan-apple merged commit 9e0baa5 into project-chip:master Dec 7, 2021
@pan-apple pan-apple deleted the pase-mrp-params branch December 7, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billwatersiii billwatersiii billwatersiii approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller fast track review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

- Add optional MRP parameter support to PASE
5 participants
@pan-apple @woody-apple @andy31415 @billwatersiii @restyled-commits