-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generated profile id and device id in endpoint_config.h #12612
Merged
woody-apple
merged 18 commits into
project-chip:master
from
vivien-apple:ZAP_DeviceProfileAndId
Dec 6, 2021
Merged
Update generated profile id and device id in endpoint_config.h #12612
woody-apple
merged 18 commits into
project-chip:master
from
vivien-apple:ZAP_DeviceProfileAndId
Dec 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple and
saurabhst
December 6, 2021 11:33
PR #12612: Size comparison from bfdbd45 to 637f90d Increases (14 builds for esp32, k32w, nrfconnect, p6, telink)
Full report (35 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…common/ota-provider-app.zap
…r-common/ota-requestor-app.zap
…common/all-clusters-app.zap
…emperature-measurement-app/esp32/main/temperature-measurement.za
…p-controller-common/pump-controller-app.zap
…idge-common/bridge-app.zap
…del/controller-clusters.zap
vivien-apple
force-pushed
the
ZAP_DeviceProfileAndId
branch
from
December 6, 2021 14:32
637f90d
to
bdddc0e
Compare
vivien-apple
force-pushed
the
ZAP_DeviceProfileAndId
branch
from
December 6, 2021 14:39
bdddc0e
to
2a5ac5f
Compare
jmartinez-silabs
approved these changes
Dec 6, 2021
PR #12612: Size comparison from 675d9f5 to 2a5ac5f Increases (17 builds for efr32, esp32, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 6, 2021
Fast tracking as this is blocking tests being added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The device identifier and profile identifier generated into the various
endpoint_config.h
is either wrong or null. As a result the descriptor cluster returns incorrect information, or updating ZAP results into incorrectly formattedendpoint_config.h
file.Change overview
.zap
file and update them accordingly to the content ofmatter-devices.xml
convert.py
on all of them to make sure everything is generated properly./scripts/tools/zap_regen_all.py
Testing
It was manually tested by reading the descriptor cluster device-list using
chip-tool