Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup IM #12606

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Cleanup IM #12606

merged 1 commit into from
Dec 6, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Dec 5, 2021 •
edited
Loading

Problem

--Move ConstructCommandPath function from Command class into CommandPathIB, update all usages across the codes.
--Use reference declaration for all uages on Create* functions from IM MessageDef, update all usages across the codes.
--Update the missing error-check for IM messageDef.

Change overview

See above

Testing

The existing test covers.

@boring-cyborg boring-cyborg bot added the app label Dec 5, 2021
@yunhanw-google yunhanw-google force-pushed the feature/cleanup_im branch 2 times, most recently from 80972ca to 88e811f Compare December 5, 2021 08:13
@github-actions
Copy link

github-actions bot commented Dec 5, 2021 •
edited
Loading

PR #12606: Size comparison from b1e0023 to 88e811f

Decreases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b1e0023 88e811f change % change
efr32 lighting-app BRD4161A (read only) 751672 751176 -496 -0.1
.text 751664 751168 -496 -0.1
BRD4161A+rpc (read only) 780344 779856 -488 -0.1
.text 780336 779848 -488 -0.1
lock-app BRD4161A (read only) 726496 726008 -488 -0.1
.text 726488 726000 -488 -0.1
window-app BRD4161A (read only) 729000 728512 -488 -0.1
.text 728992 728504 -488 -0.1
esp32 all-clusters-app c3devkit (read only) 847922 847636 -286 -0.0
(read/write) 1222786 1222706 -80 -0.0
.flash.rodata 167920 167840 -80 -0.0
.flash.text 847922 847636 -286 -0.0
m5stack (read only) 918319 917915 -404 -0.0
(read/write) 421756 421668 -88 -0.0
.flash.rodata 195724 195636 -88 -0.0
.flash.text 912935 912531 -404 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728264 -432 -0.1
.text 641724 641292 -432 -0.1
lock-app k32w061+debug (read/write) 618736 618340 -396 -0.1
.text 541132 540736 -396 -0.1
shell k32w061+debug (read/write) 684644 684252 -392 -0.1
.text 595420 595028 -392 -0.1
linux all-clusters-app debug (read only) 1851521 1848257 -3264 -0.2
.text 1557154 1553890 -3264 -0.2
bridge-app debug+rpc (read only) 1432645 1429397 -3248 -0.2
.text 1205797 1202549 -3248 -0.3
chip-tool debug (read only) 6619645 6615933 -3712 -0.1
.text 5905173 5901461 -3712 -0.1
lighting-app debug+rpc (read only) 1717761 1714481 -3280 -0.2
.text 1432514 1429234 -3280 -0.2
ota-provider-app debug (read only) 1393289 1390153 -3136 -0.2
.text 1165810 1162674 -3136 -0.3
ota-requestor-app debug (read only) 1502561 1499409 -3152 -0.2
.text 1258418 1255266 -3152 -0.3
tv-app debug (read only) 2031625 2028409 -3216 -0.2
.text 1701538 1698322 -3216 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2307096 2306400 -696 -0.0
.text 1269672 1268976 -696 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2296296 2295728 -568 -0.0
.text 1258896 1258328 -568 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2270288 2269664 -624 -0.0
.text 1232888 1232264 -624 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891331 -384 -0.0
rodata 99588 99540 -48 -0.0
text 602824 602488 -336 -0.1
nrf52840dk_nrf52840+rpc (read/write) 855091 854707 -384 -0.0
rodata 90948 90900 -48 -0.1
text 577820 577484 -336 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 817610 817230 -380 -0.0
rodata 94844 94800 -44 -0.0
text 533156 532820 -336 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 863639 863275 -364 -0.0
rodata 95704 95660 -44 -0.0
text 581540 581216 -324 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789426 -368 -0.0
rodata 90996 90948 -48 -0.1
text 511964 511640 -324 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 868523 868155 -368 -0.0
rodata 97060 97012 -48 -0.0
text 585080 584756 -324 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861395 -368 -0.0
rodata 95196 95148 -48 -0.1
text 580312 579988 -324 -0.1
p6 all-clusters-app default (read/write) 2340160 2339704 -456 -0.0
.text 1298424 1297968 -456 -0.0
light-app default (read/write) 2279680 2279208 -472 -0.0
.text 1237944 1237472 -472 -0.0
lock-app default (read/write) 2255984 2255536 -448 -0.0
.text 1214248 1213800 -448 -0.0
qpg lighting-app qpg6100+debug (read only) 510464 510060 -404 -0.1
.text 505144 504740 -404 -0.1
lock-app qpg6100+debug (read only) 484132 483732 -400 -0.1
.text 478812 478412 -400 -0.1
telink lighting-app tlsr9518adk80d (read/write) 794746 794482 -264 -0.0
text 554540 554318 -222 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b1e0023 88e811f change % change
efr32 lighting-app BRD4161A (read only) 751672 751176 -496 -0.1
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751664 751168 -496 -0.1
BRD4161A+rpc (read only) 780344 779856 -488 -0.1
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780336 779848 -488 -0.1
lock-app BRD4161A (read only) 726496 726008 -488 -0.1
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726488 726000 -488 -0.1
window-app BRD4161A (read only) 729000 728512 -488 -0.1
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728992 728504 -488 -0.1
esp32 all-clusters-app c3devkit (read only) 847922 847636 -286 -0.0
(read/write) 1222786 1222706 -80 -0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167920 167840 -80 -0.0
.flash.text 847922 847636 -286 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918319 917915 -404 -0.0
(read/write) 421756 421668 -88 -0.0
.dram0.bss 60736 60736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195724 195636 -88 -0.0
.flash.text 912935 912531 -404 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728264 -432 -0.1
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641292 -432 -0.1
lock-app k32w061+debug (read/write) 618736 618340 -396 -0.1
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 540736 -396 -0.1
shell k32w061+debug (read/write) 684644 684252 -392 -0.1
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595028 -392 -0.1
linux all-clusters-app debug (read only) 1851521 1848257 -3264 -0.2
(read/write) 123344 123344 0 0.0
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 151285 151285 0 0.0
.text 1557154 1553890 -3264 -0.2
bridge-app debug+rpc (read only) 1432645 1429397 -3248 -0.2
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121948 121948 0 0.0
.text 1205797 1202549 -3248 -0.3
chip-tool debug (read only) 6619645 6615933 -3712 -0.1
(read/write) 199688 199688 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158456 158456 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 309912 309912 0 0.0
.text 5905173 5901461 -3712 -0.1
lighting-app debug+rpc (read only) 1717761 1714481 -3280 -0.2
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142577 142577 0 0.0
.text 1432514 1429234 -3280 -0.2
ota-provider-app debug (read only) 1393289 1390153 -3136 -0.2
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122792 122792 0 0.0
.text 1165810 1162674 -3136 -0.3
ota-requestor-app debug (read only) 1502561 1499409 -3152 -0.2
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135504 135504 0 0.0
.text 1258418 1255266 -3152 -0.3
shell debug (read only) 823129 823129 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84338 84338 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2031625 2028409 -3216 -0.2
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175344 175344 0 0.0
.text 1701538 1698322 -3216 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307096 2306400 -696 -0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269672 1268976 -696 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2295728 -568 -0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258328 -568 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270288 2269664 -624 -0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232888 1232264 -624 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891331 -384 -0.0
bss 113756 113756 0 0.0
rodata 99588 99540 -48 -0.0
text 602824 602488 -336 -0.1
nrf52840dk_nrf52840+rpc (read/write) 855091 854707 -384 -0.0
bss 110104 110104 0 0.0
rodata 90948 90900 -48 -0.1
text 577820 577484 -336 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 817610 817230 -380 -0.0
bss 115128 115128 0 0.0
rodata 94844 94800 -44 -0.0
text 533156 532820 -336 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 863639 863275 -364 -0.0
bss 111016 111016 0 0.0
rodata 95704 95660 -44 -0.0
text 581540 581216 -324 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789426 -368 -0.0
bss 112428 112428 0 0.0
rodata 90996 90948 -48 -0.1
text 511964 511640 -324 -0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868155 -368 -0.0
bss 110928 110928 0 0.0
rodata 97060 97012 -48 -0.0
text 585080 584756 -324 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861395 -368 -0.0
bss 110808 110808 0 0.0
rodata 95196 95148 -48 -0.1
text 580312 579988 -324 -0.1
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2340160 2339704 -456 -0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1298424 1297968 -456 -0.0
light-app default (read/write) 2279680 2279208 -472 -0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1237944 1237472 -472 -0.0
lock-app default (read/write) 2255984 2255536 -448 -0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214248 1213800 -448 -0.0
qpg lighting-app qpg6100+debug (read only) 510464 510060 -404 -0.1
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505144 504740 -404 -0.1
lock-app qpg6100+debug (read only) 484132 483732 -400 -0.1
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478812 478412 -400 -0.1
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794746 794482 -264 -0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554540 554318 -222 -0.0

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12606: Size comparison from bfdbd45 to 74970da

Decreases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bfdbd45 74970da change % change
efr32 lighting-app BRD4161A (read only) 758896 758456 -440 -0.1
.text 758888 758448 -440 -0.1
BRD4161A+rpc (read only) 787544 787096 -448 -0.1
.text 787536 787088 -448 -0.1
lock-app BRD4161A (read only) 733952 733512 -440 -0.1
.text 733944 733504 -440 -0.1
window-app BRD4161A (read only) 736224 735784 -440 -0.1
.text 736216 735776 -440 -0.1
esp32 all-clusters-app c3devkit (read only) 852538 852264 -274 -0.0
(read/write) 1290914 1290834 -80 -0.0
.flash.rodata 169520 169440 -80 -0.0
.flash.text 852538 852264 -274 -0.0
m5stack (read only) 922399 922063 -336 -0.0
(read/write) 424356 424276 -80 -0.0
.flash.rodata 197324 197244 -80 -0.0
.flash.text 917015 916679 -336 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 731908 731556 -352 -0.0
.text 644936 644584 -352 -0.1
lock-app k32w061+debug (read/write) 622076 621728 -348 -0.1
.text 544472 544124 -348 -0.1
shell k32w061+debug (read/write) 687968 687636 -332 -0.0
.text 598744 598412 -332 -0.1
linux all-clusters-app debug (read only) 1872825 1870937 -1888 -0.1
.rodata 152117 152085 -32 -0.0
.text 1577602 1575746 -1856 -0.1
bridge-app debug+rpc (read only) 1444277 1442453 -1824 -0.1
.text 1217877 1216053 -1824 -0.1
chip-tool debug (read only) 6628165 6625925 -2240 -0.0
.text 5912661 5910421 -2240 -0.0
lighting-app debug+rpc (read only) 1729441 1727553 -1888 -0.1
.rodata 142161 142129 -32 -0.0
.text 1444610 1442754 -1856 -0.1
ota-provider-app debug (read only) 1400953 1399193 -1760 -0.1
.rodata 122856 122824 -32 -0.0
.text 1173410 1171682 -1728 -0.1
ota-requestor-app debug (read only) 1510209 1508433 -1776 -0.1
.rodata 135600 135568 -32 -0.0
.text 1265970 1264226 -1744 -0.1
tv-app debug (read only) 2046473 2044665 -1808 -0.1
.text 1717378 1715570 -1808 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313152 2312576 -576 -0.0
.text 1275728 1275152 -576 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2299096 2298584 -512 -0.0
.text 1261696 1261184 -512 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2273088 2272648 -440 -0.0
.text 1235688 1235248 -440 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 894559 -320 -0.0
rodata 99680 99632 -48 -0.0
text 605896 605628 -268 -0.0
nrf52840dk_nrf52840+rpc (read/write) 858255 857935 -320 -0.0
rodata 91040 90992 -48 -0.1
text 580892 580624 -268 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820790 820474 -316 -0.0
rodata 94936 94892 -44 -0.0
text 536232 535964 -268 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 866899 866599 -300 -0.0
rodata 95796 95752 -44 -0.0
text 584708 584452 -256 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793050 792750 -300 -0.0
rodata 91084 91040 -44 -0.0
text 515132 514876 -256 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 871683 871383 -300 -0.0
rodata 97148 97104 -44 -0.0
text 588156 587900 -256 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 864623 -304 -0.0
rodata 95288 95240 -48 -0.1
text 583388 583132 -256 -0.0
p6 all-clusters-app default (read/write) 2349448 2349040 -408 -0.0
.text 1307712 1307304 -408 -0.0
light-app default (read/write) 2284072 2283640 -432 -0.0
.text 1242336 1241904 -432 -0.0
lock-app default (read/write) 2260624 2260208 -416 -0.0
.text 1218888 1218472 -416 -0.0
qpg lighting-app qpg6100+debug (read only) 513724 513368 -356 -0.1
.text 508404 508048 -356 -0.1
lock-app qpg6100+debug (read only) 487464 487120 -344 -0.1
.text 482144 481800 -344 -0.1
telink lighting-app tlsr9518adk80d (read/write) 798382 798134 -248 -0.0
text 558088 557874 -214 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bfdbd45 74970da change % change
efr32 lighting-app BRD4161A (read only) 758896 758456 -440 -0.1
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 758888 758448 -440 -0.1
BRD4161A+rpc (read only) 787544 787096 -448 -0.1
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 787536 787088 -448 -0.1
lock-app BRD4161A (read only) 733952 733512 -440 -0.1
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 733944 733504 -440 -0.1
window-app BRD4161A (read only) 736224 735784 -440 -0.1
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 736216 735776 -440 -0.1
esp32 all-clusters-app c3devkit (read only) 852538 852264 -274 -0.0
(read/write) 1290914 1290834 -80 -0.0
.dram0.bss 56352 56352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 169520 169440 -80 -0.0
.flash.text 852538 852264 -274 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 922399 922063 -336 -0.0
(read/write) 424356 424276 -80 -0.0
.dram0.bss 61736 61736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 197324 197244 -80 -0.0
.flash.text 917015 916679 -336 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731908 731556 -352 -0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644936 644584 -352 -0.1
lock-app k32w061+debug (read/write) 622076 621728 -348 -0.1
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544472 544124 -348 -0.1
shell k32w061+debug (read/write) 687968 687636 -332 -0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598744 598412 -332 -0.1
linux all-clusters-app debug (read only) 1872825 1870937 -1888 -0.1
(read/write) 124336 124336 0 0.0
.bss 50672 50672 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152117 152085 -32 -0.0
.text 1577602 1575746 -1856 -0.1
bridge-app debug+rpc (read only) 1444277 1442453 -1824 -0.1
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121500 121500 0 0.0
.text 1217877 1216053 -1824 -0.1
chip-tool debug (read only) 6628165 6625925 -2240 -0.0
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 310776 310776 0 0.0
.text 5912661 5910421 -2240 -0.0
lighting-app debug+rpc (read only) 1729441 1727553 -1888 -0.1
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142161 142129 -32 -0.0
.text 1444610 1442754 -1856 -0.1
ota-provider-app debug (read only) 1400953 1399193 -1760 -0.1
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122856 122824 -32 -0.0
.text 1173410 1171682 -1728 -0.1
ota-requestor-app debug (read only) 1510209 1508433 -1776 -0.1
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135600 135568 -32 -0.0
.text 1265970 1264226 -1744 -0.1
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046473 2044665 -1808 -0.1
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174352 174352 0 0.0
.text 1717378 1715570 -1808 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313152 2312576 -576 -0.0
.bss 179404 179404 0 0.0
.data 5184 5184 0 0.0
.heap 851856 851856 0 0.0
.text 1275728 1275152 -576 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299096 2298584 -512 -0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1261696 1261184 -512 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273088 2272648 -440 -0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1235688 1235248 -440 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 894559 -320 -0.0
bss 113756 113756 0 0.0
rodata 99680 99632 -48 -0.0
text 605896 605628 -268 -0.0
nrf52840dk_nrf52840+rpc (read/write) 858255 857935 -320 -0.0
bss 110104 110104 0 0.0
rodata 91040 90992 -48 -0.1
text 580892 580624 -268 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820790 820474 -316 -0.0
bss 115128 115128 0 0.0
rodata 94936 94892 -44 -0.0
text 536232 535964 -268 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 866899 866599 -300 -0.0
bss 111016 111016 0 0.0
rodata 95796 95752 -44 -0.0
text 584708 584452 -256 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793050 792750 -300 -0.0
bss 112428 112428 0 0.0
rodata 91084 91040 -44 -0.0
text 515132 514876 -256 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871683 871383 -300 -0.0
bss 110928 110928 0 0.0
rodata 97148 97104 -44 -0.0
text 588156 587900 -256 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 864623 -304 -0.0
bss 110808 110808 0 0.0
rodata 95288 95240 -48 -0.1
text 583388 583132 -256 -0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2349448 2349040 -408 -0.0
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307712 1307304 -408 -0.0
light-app default (read/write) 2284072 2283640 -432 -0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242336 1241904 -432 -0.0
lock-app default (read/write) 2260624 2260208 -416 -0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218888 1218472 -416 -0.0
qpg lighting-app qpg6100+debug (read only) 513724 513368 -356 -0.1
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508404 508048 -356 -0.1
lock-app qpg6100+debug (read only) 487464 487120 -344 -0.1
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482144 481800 -344 -0.1
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798382 798134 -248 -0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 558088 557874 -214 -0.0

erjiaqing
erjiaqing approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@erjiaqing erjiaqing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of trivial changes, to other reviewers: check "Hide whitespace" for better review experience.

src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12606: Size comparison from f350919 to 608655d

Decreases (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section f350919 608655d change % change
efr32 lighting-app BRD4161A (read only) 798568 798120 -448 -0.1
.text 798560 798112 -448 -0.1
BRD4161A+rpc (read only) 826536 826096 -440 -0.1
.text 826528 826088 -440 -0.1
lock-app BRD4161A (read only) 773636 773212 -424 -0.1
.text 773628 773204 -424 -0.1
window-app BRD4161A (read only) 775892 775452 -440 -0.1
.text 775884 775444 -440 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 731812 731444 -368 -0.1
.text 644840 644472 -368 -0.1
lock-app k32w061+debug (read/write) 621980 621632 -348 -0.1
.text 544376 544028 -348 -0.1
shell k32w061+debug (read/write) 687872 687524 -348 -0.1
.text 598648 598300 -348 -0.1
linux all-clusters-app debug (read only) 1872649 1870809 -1840 -0.1
.text 1577298 1575458 -1840 -0.1
bridge-app debug+rpc (read only) 1444117 1442277 -1840 -0.1
.text 1217589 1215749 -1840 -0.2
chip-tool debug (read only) 6638421 6636133 -2288 -0.0
.rodata 311544 311512 -32 -0.0
.text 5922149 5919893 -2256 -0.0
lighting-app debug+rpc (read only) 1729265 1727377 -1888 -0.1
.rodata 142289 142257 -32 -0.0
.text 1444306 1442450 -1856 -0.1
ota-provider-app debug (read only) 1400777 1399049 -1728 -0.1
.text 1173106 1171378 -1728 -0.1
ota-requestor-app debug (read only) 1510033 1508305 -1728 -0.1
.text 1265666 1263938 -1728 -0.1
tv-app debug (read only) 2046297 2044489 -1808 -0.1
.text 1717074 1715266 -1808 -0.1
p6 all-clusters-app default (read/write) 2349264 2348840 -424 -0.0
.text 1307528 1307104 -424 -0.0
light-app default (read/write) 2283888 2283456 -432 -0.0
.text 1242152 1241720 -432 -0.0
lock-app default (read/write) 2260424 2260008 -416 -0.0
.text 1218688 1218272 -416 -0.0
qpg lighting-app qpg6100+debug (read only) 513612 513264 -348 -0.1
.text 508292 507944 -348 -0.1
lock-app qpg6100+debug (read only) 487352 487024 -328 -0.1
.text 482032 481704 -328 -0.1
telink lighting-app tlsr9518adk80d (read/write) 798158 797902 -256 -0.0
text 557858 557644 -214 -0.0
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section f350919 608655d change % change
efr32 lighting-app BRD4161A (read only) 798568 798120 -448 -0.1
(read/write) 120648 120648 0 0.0
.bss 118816 118816 0 0.0
.data 1828 1828 0 0.0
.text 798560 798112 -448 -0.1
BRD4161A+rpc (read only) 826536 826096 -440 -0.1
(read/write) 138952 138952 0 0.0
.bss 137016 137016 0 0.0
.data 1936 1936 0 0.0
.text 826528 826088 -440 -0.1
lock-app BRD4161A (read only) 773636 773212 -424 -0.1
(read/write) 118580 118580 0 0.0
.bss 116792 116792 0 0.0
.data 1788 1788 0 0.0
.text 773628 773204 -424 -0.1
window-app BRD4161A (read only) 775892 775452 -440 -0.1
(read/write) 118784 118784 0 0.0
.bss 116992 116992 0 0.0
.data 1792 1792 0 0.0
.text 775884 775444 -440 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 731812 731444 -368 -0.1
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644840 644472 -368 -0.1
lock-app k32w061+debug (read/write) 621980 621632 -348 -0.1
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544376 544028 -348 -0.1
shell k32w061+debug (read/write) 687872 687524 -348 -0.1
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598648 598300 -348 -0.1
linux all-clusters-app debug (read only) 1872649 1870809 -1840 -0.1
(read/write) 124336 124336 0 0.0
.bss 50672 50672 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152245 152245 0 0.0
.text 1577298 1575458 -1840 -0.1
bridge-app debug+rpc (read only) 1444117 1442277 -1840 -0.1
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121628 121628 0 0.0
.text 1217589 1215749 -1840 -0.2
chip-tool debug (read only) 6638421 6636133 -2288 -0.0
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 311544 311512 -32 -0.0
.text 5922149 5919893 -2256 -0.0
lighting-app debug+rpc (read only) 1729265 1727377 -1888 -0.1
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142289 142257 -32 -0.0
.text 1444306 1442450 -1856 -0.1
ota-provider-app debug (read only) 1400777 1399049 -1728 -0.1
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122984 122984 0 0.0
.text 1173106 1171378 -1728 -0.1
ota-requestor-app debug (read only) 1510033 1508305 -1728 -0.1
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135728 135728 0 0.0
.text 1265666 1263938 -1728 -0.1
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046297 2044489 -1808 -0.1
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174480 174480 0 0.0
.text 1717074 1715266 -1808 -0.1
p6 all-clusters-app default (read/write) 2349264 2348840 -424 -0.0
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307528 1307104 -424 -0.0
light-app default (read/write) 2283888 2283456 -432 -0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242152 1241720 -432 -0.0
lock-app default (read/write) 2260424 2260008 -416 -0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218688 1218272 -416 -0.0
qpg lighting-app qpg6100+debug (read only) 513612 513264 -348 -0.1
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508292 507944 -348 -0.1
lock-app qpg6100+debug (read only) 487352 487024 -328 -0.1
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482032 481704 -328 -0.1
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798158 797902 -256 -0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 557858 557644 -214 -0.0

@yunhanw-google
Cleanup IM
dd9f581 
--Move ConstructCommandPath function into CommandPathIB, update all usage across the codes.
--Use reference delcartion for usages on all Create* functions from IM MessageDef, update all usage across the code.
--Update the missing error-check for IM messageDef.
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12606: Size comparison from f350919 to dd9f581

Decreases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f350919 dd9f581 change % change
efr32 lighting-app BRD4161A (read only) 798568 795576 -2992 -0.4
.text 798560 795568 -2992 -0.4
BRD4161A+rpc (read only) 826536 823552 -2984 -0.4
.text 826528 823544 -2984 -0.4
lock-app BRD4161A (read only) 773636 770620 -3016 -0.4
.text 773628 770612 -3016 -0.4
window-app BRD4161A (read only) 775892 772908 -2984 -0.4
.text 775884 772900 -2984 -0.4
esp32 all-clusters-app c3devkit (read only) 852314 851636 -678 -0.1
(read/write) 1290914 1225298 -65616 -5.1
.flash.rodata 169520 169440 -80 -0.0
.flash.text 852314 851636 -678 -0.1
m5stack (read only) 922223 921367 -856 -0.1
(read/write) 424356 424276 -80 -0.0
.flash.rodata 197324 197244 -80 -0.0
.flash.text 916839 915983 -856 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 731812 731188 -624 -0.1
.text 644840 644216 -624 -0.1
lock-app k32w061+debug (read/write) 621980 621408 -572 -0.1
.text 544376 543804 -572 -0.1
shell k32w061+debug (read/write) 687872 687300 -572 -0.1
.text 598648 598076 -572 -0.1
linux all-clusters-app debug (read only) 1872649 1868729 -3920 -0.2
.text 1577298 1573378 -3920 -0.2
bridge-app debug+rpc (read only) 1444117 1440725 -3392 -0.2
.text 1217589 1214197 -3392 -0.3
chip-tool debug (read only) 6638421 6636133 -2288 -0.0
.rodata 311544 311512 -32 -0.0
.text 5922149 5919893 -2256 -0.0
lighting-app debug+rpc (read only) 1729265 1725825 -3440 -0.2
.rodata 142289 142257 -32 -0.0
.text 1444306 1440898 -3408 -0.2
ota-provider-app debug (read only) 1400777 1398281 -2496 -0.2
.text 1173106 1170610 -2496 -0.2
ota-requestor-app debug (read only) 1510033 1507521 -2512 -0.2
.text 1265666 1263154 -2512 -0.2
tv-app debug (read only) 2046297 2042569 -3728 -0.2
.text 1717074 1713346 -3728 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313024 2312064 -960 -0.0
.text 1275600 1274640 -960 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2298968 2298200 -768 -0.0
.text 1261568 1260800 -768 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2272960 2272264 -696 -0.0
.text 1235560 1234864 -696 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894783 894175 -608 -0.1
rodata 99680 99632 -48 -0.0
text 605796 605244 -552 -0.1
nrf52840dk_nrf52840+rpc (read/write) 858159 857551 -608 -0.1
rodata 91040 90992 -48 -0.1
text 580792 580240 -552 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820678 820090 -588 -0.1
rodata 94936 94892 -44 -0.0
text 536128 535576 -552 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 866803 866263 -540 -0.1
rodata 95796 95752 -44 -0.0
text 584604 584116 -488 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 792938 792414 -524 -0.1
rodata 91084 91040 -44 -0.0
text 515028 514540 -488 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 871587 870999 -588 -0.1
rodata 97148 97104 -44 -0.0
text 588052 587512 -540 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 864831 864239 -592 -0.1
rodata 95288 95240 -48 -0.1
text 583284 582744 -540 -0.1
p6 all-clusters-app default (read/write) 2349264 2346696 -2568 -0.1
.text 1307528 1304960 -2568 -0.2
light-app default (read/write) 2283888 2281872 -2016 -0.1
.text 1242152 1240136 -2016 -0.2
lock-app default (read/write) 2260424 2258392 -2032 -0.1
.text 1218688 1216656 -2032 -0.2
qpg lighting-app qpg6100+debug (read only) 513612 513000 -612 -0.1
.text 508292 507680 -612 -0.1
lock-app qpg6100+debug (read only) 487352 486808 -544 -0.1
.text 482032 481488 -544 -0.1
telink lighting-app tlsr9518adk80d (read/write) 798158 797638 -520 -0.1
text 557858 557380 -478 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f350919 dd9f581 change % change
efr32 lighting-app BRD4161A (read only) 798568 795576 -2992 -0.4
(read/write) 120648 120648 0 0.0
.bss 118816 118816 0 0.0
.data 1828 1828 0 0.0
.text 798560 795568 -2992 -0.4
BRD4161A+rpc (read only) 826536 823552 -2984 -0.4
(read/write) 138952 138952 0 0.0
.bss 137016 137016 0 0.0
.data 1936 1936 0 0.0
.text 826528 823544 -2984 -0.4
lock-app BRD4161A (read only) 773636 770620 -3016 -0.4
(read/write) 118580 118580 0 0.0
.bss 116792 116792 0 0.0
.data 1788 1788 0 0.0
.text 773628 770612 -3016 -0.4
window-app BRD4161A (read only) 775892 772908 -2984 -0.4
(read/write) 118784 118784 0 0.0
.bss 116992 116992 0 0.0
.data 1792 1792 0 0.0
.text 775884 772900 -2984 -0.4
esp32 all-clusters-app c3devkit (read only) 852314 851636 -678 -0.1
(read/write) 1290914 1225298 -65616 -5.1
.dram0.bss 56352 56352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 169520 169440 -80 -0.0
.flash.text 852314 851636 -678 -0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 922223 921367 -856 -0.1
(read/write) 424356 424276 -80 -0.0
.dram0.bss 61736 61736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 197324 197244 -80 -0.0
.flash.text 916839 915983 -856 -0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731812 731188 -624 -0.1
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644840 644216 -624 -0.1
lock-app k32w061+debug (read/write) 621980 621408 -572 -0.1
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544376 543804 -572 -0.1
shell k32w061+debug (read/write) 687872 687300 -572 -0.1
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598648 598076 -572 -0.1
linux all-clusters-app debug (read only) 1872649 1868729 -3920 -0.2
(read/write) 124336 124336 0 0.0
.bss 50672 50672 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152245 152245 0 0.0
.text 1577298 1573378 -3920 -0.2
bridge-app debug+rpc (read only) 1444117 1440725 -3392 -0.2
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121628 121628 0 0.0
.text 1217589 1214197 -3392 -0.3
chip-tool debug (read only) 6638421 6636133 -2288 -0.0
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 311544 311512 -32 -0.0
.text 5922149 5919893 -2256 -0.0
lighting-app debug+rpc (read only) 1729265 1725825 -3440 -0.2
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142289 142257 -32 -0.0
.text 1444306 1440898 -3408 -0.2
ota-provider-app debug (read only) 1400777 1398281 -2496 -0.2
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122984 122984 0 0.0
.text 1173106 1170610 -2496 -0.2
ota-requestor-app debug (read only) 1510033 1507521 -2512 -0.2
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135728 135728 0 0.0
.text 1265666 1263154 -2512 -0.2
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046297 2042569 -3728 -0.2
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174480 174480 0 0.0
.text 1717074 1713346 -3728 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313024 2312064 -960 -0.0
.bss 179404 179404 0 0.0
.data 5184 5184 0 0.0
.heap 851856 851856 0 0.0
.text 1275600 1274640 -960 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298968 2298200 -768 -0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1261568 1260800 -768 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272960 2272264 -696 -0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1235560 1234864 -696 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894783 894175 -608 -0.1
bss 113756 113756 0 0.0
rodata 99680 99632 -48 -0.0
text 605796 605244 -552 -0.1
nrf52840dk_nrf52840+rpc (read/write) 858159 857551 -608 -0.1
bss 110104 110104 0 0.0
rodata 91040 90992 -48 -0.1
text 580792 580240 -552 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820678 820090 -588 -0.1
bss 115128 115128 0 0.0
rodata 94936 94892 -44 -0.0
text 536128 535576 -552 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 866803 866263 -540 -0.1
bss 111016 111016 0 0.0
rodata 95796 95752 -44 -0.0
text 584604 584116 -488 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 792938 792414 -524 -0.1
bss 112428 112428 0 0.0
rodata 91084 91040 -44 -0.0
text 515028 514540 -488 -0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871587 870999 -588 -0.1
bss 110928 110928 0 0.0
rodata 97148 97104 -44 -0.0
text 588052 587512 -540 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 864831 864239 -592 -0.1
bss 110808 110808 0 0.0
rodata 95288 95240 -48 -0.1
text 583284 582744 -540 -0.1
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2349264 2346696 -2568 -0.1
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307528 1304960 -2568 -0.2
light-app default (read/write) 2283888 2281872 -2016 -0.1
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242152 1240136 -2016 -0.2
lock-app default (read/write) 2260424 2258392 -2032 -0.1
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218688 1216656 -2032 -0.2
qpg lighting-app qpg6100+debug (read only) 513612 513000 -612 -0.1
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508292 507680 -612 -0.1
lock-app qpg6100+debug (read only) 487352 486808 -544 -0.1
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482032 481488 -544 -0.1
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798158 797638 -520 -0.1
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 557858 557380 -478 -0.1

@yunhanw-google yunhanw-google merged commit 299393b into project-chip:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@erjiaqing erjiaqing erjiaqing approved these changes

@LuDuda LuDuda LuDuda approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunhanw-google @LuDuda @erjiaqing @yufengwangca @jmartinez-silabs