Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle [msg] Initialize session counters with random per spec. #12518

Closed
wants to merge 2 commits into from
Closed

Restyle [msg] Initialize session counters with random per spec. #12518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f69222e
[msg] Initialize session counters with random per spec.
turon Nov 10, 2021
1d2bda9
Restyled by clang-format
restyled-commits Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/transport/MessageCounter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*/
#pragma once

#include <crypto/RandUtils.h>
#include <lib/support/PersistedCounter.h>

namespace chip {
Expand Down Expand Up @@ -106,8 +107,12 @@ class GlobalEncryptedMessageCounter : public MessageCounter
class LocalSessionMessageCounter : public MessageCounter
{
public:
static constexpr uint32_t kInitialValue = 1;
LocalSessionMessageCounter() : value(kInitialValue) {}
static constexpr uint32_t kInitialValue = 1; ///< Used for initializing peer counter

/**
* Initialize a local message counter with random value between [0, 2^28-1].
*/
LocalSessionMessageCounter() { value = Crypto::GetRandU32() & 0x0FFFFFFF; }

Type GetType() override { return Session; }
uint32_t Value() override { return value; }
Expand Down