-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msg] Initialize session counters with random per spec. #12517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #12517: Size comparison from 7cba51d to f69222e Increases (3 builds for qpg, telink)
Full report (4 builds for qpg, telink)
|
emargolis
reviewed
Dec 2, 2021
turon
force-pushed
the
msg/counter-init
branch
from
December 2, 2021 23:38
f69222e
to
0babc91
Compare
emargolis
approved these changes
Dec 2, 2021
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller and
woody-apple
December 2, 2021 23:39
yunhanw-google
approved these changes
Dec 2, 2021
PR #12517: Size comparison from ae57e32 to 0babc91 Increases (10 builds for efr32, linux, p6, qpg, telink)
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 3, 2021
PR #12517: Size comparison from ae57e32 to c4d723f Increases above 0.2%:
Increases (18 builds for efr32, k32w, linux, qpg, telink)
Full report (19 builds for efr32, k32w, linux, qpg, telink)
|
turon
force-pushed
the
msg/counter-init
branch
from
December 3, 2021 01:39
c4d723f
to
7489169
Compare
PR #12517: Size comparison from 1ad526b to 7489169 Increases (4 builds for k32w, qpg, telink)
Full report (7 builds for k32w, qpg, telink)
|
turon
force-pushed
the
msg/counter-init
branch
from
December 3, 2021 02:16
7489169
to
e95bf3f
Compare
PR #12517: Size comparison from a484e4c to e95bf3f Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Dec 3, 2021
billwatersiii
pushed a commit
to billwatersiii/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spec says to initialize session counters with random from [0, 2^28-1].
Change overview
Implement the specified behavior.
Testing
unit tests, CI, and manual observation on sniffer.