-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QPG6100] Patch linkerscript for size issues #12047 #12480
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
tima-q:qpg6100/size_patch_for_12047
Dec 2, 2021
Merged
[QPG6100] Patch linkerscript for size issues #12047 #12480
jepenven-silabs
merged 1 commit into
project-chip:master
from
tima-q:qpg6100/size_patch_for_12047
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon and
vijs
December 2, 2021 17:07
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
December 2, 2021 17:07
jepenven-silabs
approved these changes
Dec 2, 2021
fast tracked since platform specific submodule update |
woody-apple
approved these changes
Dec 2, 2021
PR #12480: Size comparison from a5513c2 to f3d191e Full report (33 builds for efr32, esp32, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#12047 introduced additional flash and RAM use, reaching QPG6100 limits.
This PR was however merged, with failing CI for QPG6100 (and K32W)
Failing CI:
https://github.com/project-chip/connectedhomeip/runs/4397616649?check_suite_focus=true
Change overview
Temporary patch of QPG6100 linkerscript to allow CHIP dev to continue.
Investigation to mitigate size limits and removal of patch scheduled as internal follow-up
Testing