Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K32W0] Read General Diagnostics cluster attribute at runtime #12468

Merged
merged 2 commits into from
Jan 4, 2022
Merged

[K32W0] Read General Diagnostics cluster attribute at runtime #12468

merged 2 commits into from
Jan 4, 2022

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Dec 2, 2021

Problem

  • General Diagnostics cluster implementation was missing on K32W0 platform

Change overview

  • Add General Diagnostics cluster implementation on K32W0

Testing

  • manually tested using chip-tool

@restyled-io restyled-io bot mentioned this pull request Dec 2, 2021
Closed
@doru91 doru91 mentioned this pull request Dec 2, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12468: Size comparison from 7b214c9 to 0110e30

Increases (3 builds for k32w)
platform target config section 7b214c9 0110e30 change % change
k32w lighting-app k32w061+se05x+release (read/write) 727908 728380 472 0.1
.bss 79012 79020 8 0.0
.text 641252 641716 464 0.1
lock-app k32w061+debug (read/write) 616896 617352 456 0.1
.bss 69452 69460 8 0.0
.text 539836 540284 448 0.1
shell k32w061+debug (read/write) 682784 683240 456 0.1
.bss 81108 81116 8 0.0
.text 594096 594544 448 0.1
Full report (29 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 7b214c9 0110e30 change % change
efr32 lighting-app BRD4161A (read only) 730024 730024 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730016 730016 0 0.0
BRD4161A+rpc (read only) 758672 758672 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758664 758664 0 0.0
lock-app BRD4161A (read only) 703900 703900 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703892 703892 0 0.0
window-app BRD4161A (read only) 706996 706996 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 706988 706988 0 0.0
esp32 all-clusters-app c3devkit (read only) 839092 839092 0 0.0
(read/write) 1225074 1225074 0 0.0
.dram0.bss 58824 58824 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166968 166968 0 0.0
.flash.text 839092 839092 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910767 910767 0 0.0
(read/write) 424304 424304 0 0.0
.dram0.bss 64224 64224 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194800 194800 0 0.0
.flash.text 905383 905383 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727908 728380 472 0.1
.bss 79012 79020 8 0.0
.data 1844 1844 0 0.0
.text 641252 641716 464 0.1
lock-app k32w061+debug (read/write) 616896 617352 456 0.1
.bss 69452 69460 8 0.0
.data 1808 1808 0 0.0
.text 539836 540284 448 0.1
shell k32w061+debug (read/write) 682784 683240 456 0.1
.bss 81108 81116 8 0.0
.data 1780 1780 0 0.0
.text 594096 594544 448 0.1
linux all-clusters-app debug (read only) 1796985 1796985 0 0.0
(read/write) 125992 125992 0 0.0
.bss 53456 53456 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510738 1510738 0 0.0
bridge-app debug+rpc (read only) 1367205 1367205 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147509 1147509 0 0.0
chip-tool debug (read only) 6528205 6528205 0 0.0
(read/write) 199760 199760 0 0.0
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 304984 0 0.0
.text 5816613 5816613 0 0.0
lighting-app debug+rpc (read only) 1651033 1651033 0 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373842 1373842 0 0.0
ota-provider-app debug (read only) 1327801 1327801 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106434 1106434 0 0.0
ota-requestor-app debug (read only) 1427857 1427857 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191106 1191106 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944721 1944721 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168680 168680 0 0.0
.text 1626882 1626882 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299368 2299368 0 0.0
.bss 181892 181892 0 0.0
.data 5168 5168 0 0.0
.heap 849384 849384 0 0.0
.text 1261968 1261968 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284096 2284096 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246696 1246696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257128 2257128 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219728 1219728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
p6 all-clusters-app default (read/write) 2320800 2320800 0 0.0
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1279064 1279064 0 0.0
light-app default (read/write) 2256600 2256600 0 0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214864 1214864 0 0.0
lock-app default (read/write) 2231944 2231944 0 0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1190208 1190208 0 0.0
qpg lighting-app qpg6100+debug (read only) 499780 499780 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494460 494460 0 0.0
lock-app qpg6100+debug (read only) 472592 472592 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467272 467272 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782718 782718 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543954 543954 0 0.0

woody-apple
woody-apple approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given this is a platform maintainer updating their platform.

@woody-apple
Copy link
Contributor

/rebase

1 similar comment
@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the feature/k32w0_general_diag branch from 0110e30 to 2d19feb Compare December 6, 2021 21:24
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12468: Size comparison from db6d572 to 2d19feb

Increases (3 builds for k32w)
platform target config section db6d572 2d19feb change % change
k32w lighting-app k32w061+se05x+release (read/write) 731576 732048 472 0.1
.bss 79408 79416 8 0.0
.text 644508 644972 464 0.1
lock-app k32w061+debug (read/write) 622292 622748 456 0.1
.bss 70072 70080 8 0.0
.text 544592 545040 448 0.1
shell k32w061+debug (read/write) 688184 688656 472 0.1
.bss 81720 81728 8 0.0
.text 598864 599328 464 0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
platform target config section db6d572 2d19feb change % change
efr32 lighting-app BRD4161A (read only) 797548 797548 0 0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 797540 797540 0 0.0
BRD4161A+rpc (read only) 825516 825516 0 0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 825508 825508 0 0.0
lock-app BRD4161A (read only) 772216 772216 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772208 772208 0 0.0
window-app BRD4161A (read only) 774504 774504 0 0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774496 774496 0 0.0
esp32 all-clusters-app c3devkit (read only) 852296 852296 0 0.0
(read/write) 1295154 1295154 0 0.0
.dram0.bss 58232 58232 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169792 0 0.0
.flash.text 852296 852296 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956495 956495 0 0.0
(read/write) 439528 439528 0 0.0
.dram0.bss 65592 65592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208132 0 0.0
.flash.text 951111 951111 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 732048 472 0.1
.bss 79408 79416 8 0.0
.data 1860 1860 0 0.0
.text 644508 644972 464 0.1
lock-app k32w061+debug (read/write) 622292 622748 456 0.1
.bss 70072 70080 8 0.0
.data 1828 1828 0 0.0
.text 544592 545040 448 0.1
shell k32w061+debug (read/write) 688184 688656 472 0.1
.bss 81720 81728 8 0.0
.data 1800 1800 0 0.0
.text 598864 599328 464 0.1
linux all-clusters-app debug (read only) 1865497 1865497 0 0.0
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152917 152917 0 0.0
.text 1569282 1569282 0 0.0
bridge-app debug+rpc (read only) 1444525 1444525 0 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121916 121916 0 0.0
.text 1217541 1217541 0 0.0
chip-tool debug (read only) 6646077 6646077 0 0.0
(read/write) 200040 200040 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158600 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 313112 313112 0 0.0
.text 5928069 5928069 0 0.0
lighting-app debug+rpc (read only) 1730329 1730329 0 0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142513 142513 0 0.0
.text 1444978 1444978 0 0.0
ota-provider-app debug (read only) 1402049 1402049 0 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 123272 123272 0 0.0
.text 1173922 1173922 0 0.0
ota-requestor-app debug (read only) 1511225 1511225 0 0.0
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136016 136016 0 0.0
.text 1266402 1266402 0 0.0
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046321 2046321 0 0.0
(read/write) 320320 320320 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64240 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174768 174768 0 0.0
.text 1716642 1716642 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2312192 0 0.0
.bss 181412 181412 0 0.0
.data 5192 5192 0 0.0
.heap 849840 849840 0 0.0
.text 1274768 1274768 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300032 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262632 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 894603 0 0.0
bss 113852 113852 0 0.0
rodata 99676 99676 0 0.0
text 605532 605532 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 857979 0 0.0
bss 110200 110200 0 0.0
rodata 91036 91036 0 0.0
text 580528 580528 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820502 0 0.0
bss 115224 115224 0 0.0
rodata 94936 94936 0 0.0
text 535856 535856 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 867203 867203 0 0.0
bss 111112 111112 0 0.0
rodata 95796 95796 0 0.0
text 584904 584904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793338 0 0.0
bss 112524 112524 0 0.0
rodata 91084 91084 0 0.0
text 515324 515324 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 871939 0 0.0
bss 111024 111024 0 0.0
rodata 97148 97148 0 0.0
text 588304 588304 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865147 0 0.0
bss 110904 110904 0 0.0
rodata 95284 95284 0 0.0
text 583512 583512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346600 2346600 0 0.0
.bss 107692 107692 0 0.0
.data 2464 2464 0 0.0
.heap 923184 923184 0 0.0
.text 1304864 1304864 0 0.0
light-app default (read/write) 2283848 2283848 0 0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242112 1242112 0 0.0
lock-app default (read/write) 2259984 2259984 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218248 1218248 0 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513276 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507956 507956 0 0.0
lock-app qpg6100+debug (read only) 487580 487580 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482260 482260 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the feature/k32w0_general_diag branch from 2d19feb to ba91e5e Compare December 10, 2021 06:40
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12468: Size comparison from 586aca7 to ba91e5e

Increases (3 builds for k32w)
platform target config section 586aca7 ba91e5e change % change
k32w lighting-app k32w061+se05x+release (read/write) 669560 670040 480 0.1
.bss 73872 73888 16 0.0
.text 587996 588460 464 0.1
lock-app k32w061+debug (read/write) 619508 619988 480 0.1
.bss 72024 72040 16 0.0
.text 539832 540296 464 0.1
shell k32w061+debug (read/write) 624608 625088 480 0.1
.bss 74252 74268 16 0.0
.text 542724 543188 464 0.1
Full report (29 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 586aca7 ba91e5e change % change
esp32 all-clusters-app c3devkit (read only) 862792 862792 0 0.0
(read/write) 1306058 1306058 0 0.0
.dram0.bss 65832 65832 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 173064 173064 0 0.0
.flash.text 862792 862792 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 966015 966015 0 0.0
(read/write) 451744 451744 0 0.0
.dram0.bss 75128 75128 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 210772 210772 0 0.0
.flash.text 960631 960631 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669560 670040 480 0.1
.bss 73872 73888 16 0.0
.data 1892 1892 0 0.0
.text 587996 588460 464 0.1
lock-app k32w061+debug (read/write) 619508 619988 480 0.1
.bss 72024 72040 16 0.0
.data 1852 1852 0 0.0
.text 539832 540296 464 0.1
shell k32w061+debug (read/write) 624608 625088 480 0.1
.bss 74252 74268 16 0.0
.data 1832 1832 0 0.0
.text 542724 543188 464 0.1
linux chip-tool-ipv6only arm64 (read only) 6864988 6864988 0 0.0
(read/write) 318785 318785 0 0.0
.bss 51985 51985 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208776 208776 0 0.0
.dynamic 560 560 0 0.0
.got 53096 53096 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364764 364764 0 0.0
.text 5820564 5820564 0 0.0
thermostat-no-ble arm64 (read only) 1947444 1947444 0 0.0
(read/write) 137201 137201 0 0.0
.bss 59601 59601 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125508 125508 0 0.0
.text 1614432 1614432 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2324328 0 0.0
.bss 185108 185108 0 0.0
.data 5240 5240 0 0.0
.heap 846096 846096 0 0.0
.text 1286904 1286904 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2308944 0 0.0
.bss 175824 175824 0 0.0
.data 5528 5528 0 0.0
.heap 855096 855096 0 0.0
.text 1271544 1271544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282064 0 0.0
.bss 174864 174864 0 0.0
.data 5520 5520 0 0.0
.heap 856064 856064 0 0.0
.text 1244664 1244664 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906747 906747 0 0.0
bss 116296 116296 0 0.0
rodata 101980 101980 0 0.0
text 612876 612876 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 869795 869795 0 0.0
bss 112644 112644 0 0.0
rodata 93276 93276 0 0.0
text 587604 587604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832762 832762 0 0.0
bss 117672 117672 0 0.0
rodata 97236 97236 0 0.0
text 543304 543304 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879375 879375 0 0.0
bss 113560 113560 0 0.0
rodata 98096 98096 0 0.0
text 592320 592320 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805634 805634 0 0.0
bss 114968 114968 0 0.0
rodata 93388 93388 0 0.0
text 522840 522840 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884315 884315 0 0.0
bss 113472 113472 0 0.0
rodata 99452 99452 0 0.0
text 595912 595912 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877555 877555 0 0.0
bss 113348 113348 0 0.0
rodata 97588 97588 0 0.0
text 591108 591108 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2361904 2361904 0 0.0
.bss 113244 113244 0 0.0
.data 2520 2520 0 0.0
.heap 917576 917576 0 0.0
.text 1320168 1320168 0 0.0
light-app default (read/write) 2294704 2294704 0 0.0
.bss 101016 101016 0 0.0
.data 2360 2360 0 0.0
.heap 929968 929968 0 0.0
.text 1252968 1252968 0 0.0
lock-app default (read/write) 2270784 2270784 0 0.0
.bss 99896 99896 0 0.0
.data 2328 2328 0 0.0
.heap 931120 931120 0 0.0
.text 1229048 1229048 0 0.0
qpg lighting-app qpg6100+debug (read only) 521320 521320 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82712 0 0.0
.data 992 992 0 0.0
.text 516000 516000 0 0.0
lock-app qpg6100+debug (read only) 495688 495688 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81848 81848 0 0.0
.data 948 948 0 0.0
.text 490368 490368 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810954 810954 0 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 566006 566006 0 0.0

@stale
Copy link

stale bot commented Dec 17, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 17, 2021
@doru91 doru91 force-pushed the feature/k32w0_general_diag branch from ba91e5e to dcb8ad8 Compare December 24, 2021 08:20
@stale stale bot removed the stale Stale issue or PR label Dec 24, 2021
@doru91
Copy link
Contributor Author

doru91 commented Dec 24, 2021

Rebased.

@github-actions
Copy link

github-actions bot commented Dec 24, 2021 •
edited
Loading

PR #12468: Size comparison from 3a617aa to dcb8ad8

Increases (2 builds for k32w)
platform target config section 3a617aa dcb8ad8 change % change
k32w light k32w061+release (read/write) 647440 647904 464 0.1
.bss 76184 76200 16 0.0
.text 563552 564000 448 0.1
lock k32w061+release (read/write) 632264 632728 464 0.1
.bss 75896 75912 16 0.0
.text 548708 549156 448 0.1
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3a617aa dcb8ad8 change % change
efr32 lighting-app BRD4161A (read only) 828924 828924 0 0.0
(read/write) 127052 127052 0 0.0
.bss 125176 125176 0 0.0
.data 1876 1876 0 0.0
.text 828916 828916 0 0.0
BRD4161A+rpc (read only) 816552 816552 0 0.0
(read/write) 143720 143720 0 0.0
.bss 141744 141744 0 0.0
.data 1976 1976 0 0.0
.text 816544 816544 0 0.0
window-app BRD4161A (read only) 802372 802372 0 0.0
(read/write) 125992 125992 0 0.0
.bss 124160 124160 0 0.0
.data 1832 1832 0 0.0
.text 802364 802364 0 0.0
esp32 all-clusters-app c3devkit (read only) 882558 882558 0 0.0
(read/write) 1312482 1312482 0 0.0
.dram0.bss 69104 69104 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 176104 176104 0 0.0
.flash.text 882558 882558 0 0.0
.iram0.text 62254 62254 0 0.0
m5stack (read only) 943035 943035 0 0.0
(read/write) 441592 441592 0 0.0
.dram0.bss 73600 73600 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 202928 202928 0 0.0
.flash.text 937651 937651 0 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 647440 647904 464 0.1
.bss 76184 76200 16 0.0
.data 1904 1904 0 0.0
.text 563552 564000 448 0.1
lock k32w061+release (read/write) 632264 632728 464 0.1
.bss 75896 75912 16 0.0
.data 1860 1860 0 0.0
.text 548708 549156 448 0.1
linux chip-tool-ipv6only arm64 (read only) 7010188 7010188 0 0.0
(read/write) 324849 324849 0 0.0
.bss 54209 54209 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208960 208960 0 0.0
.dynamic 560 560 0 0.0
.got 56880 56880 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 383300 383300 0 0.0
.text 5934516 5934516 0 0.0
thermostat-no-ble arm64 (read only) 2021852 2021852 0 0.0
(read/write) 143937 143937 0 0.0
.bss 63985 63985 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72200 72200 0 0.0
.dynamic 560 560 0 0.0
.got 3936 3936 0 0.0
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128476 128476 0 0.0
.text 1680848 1680848 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338744 2338744 0 0.0
.bss 188364 188364 0 0.0
.data 5272 5272 0 0.0
.text 1301320 1301320 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2329040 2329040 0 0.0
.bss 180608 180608 0 0.0
.data 5552 5552 0 0.0
.text 1291640 1291640 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302200 2302200 0 0.0
.bss 179656 179656 0 0.0
.data 5544 5544 0 0.0
.text 1264800 1264800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053888 2053888 0 0.0
.bss 156972 156972 0 0.0
.data 4864 4864 0 0.0
.text 1016488 1016488 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 935247 935247 0 0.0
bss 118172 118172 0 0.0
rodata 107996 107996 0 0.0
text 631528 631528 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 921651 921651 0 0.0
bss 115216 115216 0 0.0
rodata 101416 101416 0 0.0
text 626840 626840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859014 859014 0 0.0
bss 116456 116456 0 0.0
rodata 102924 102924 0 0.0
text 558964 558964 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 907507 907507 0 0.0
bss 117360 117360 0 0.0
rodata 103304 103304 0 0.0
text 609460 609460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831422 831422 0 0.0
bss 115672 115672 0 0.0
rodata 98268 98268 0 0.0
text 536940 536940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 908739 908739 0 0.0
bss 117120 117120 0 0.0
rodata 103520 103520 0 0.0
text 610676 610676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 905587 905587 0 0.0
bss 117148 117148 0 0.0
rodata 102776 102776 0 0.0
text 608208 608208 0 0.0
shell nrf52840dk_nrf52840 (read/write) 796871 796871 0 0.0
bss 109536 109536 0 0.0
rodata 78200 78200 0 0.0
text 532680 532680 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 709502 709502 0 0.0
bss 107424 107424 0 0.0
rodata 72500 72500 0 0.0
text 450172 450172 0 0.0
p6 all-clusters-app default (read/write) 2390856 2390856 0 0.0
.bss 116564 116564 0 0.0
.data 2552 2552 0 0.0
.text 1349120 1349120 0 0.0
light-app default (read/write) 2323680 2323680 0 0.0
.bss 105856 105856 0 0.0
.data 2384 2384 0 0.0
.text 1281944 1281944 0 0.0
lock-app default (read/write) 2295880 2295880 0 0.0
.bss 104736 104736 0 0.0
.data 2336 2336 0 0.0
.text 1254144 1254144 0 0.0
qpg lighting-app qpg6105+debug (read only) 531096 531096 0 0.0
(read/write) 146936 146936 0 0.0
.bss 86656 86656 0 0.0
.data 1004 1004 0 0.0
.text 525776 525776 0 0.0
lock-app qpg6105+debug (read only) 502876 502876 0 0.0
(read/write) 146940 146940 0 0.0
.bss 85792 85792 0 0.0
.data 952 952 0 0.0
.text 497556 497556 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 831754 831754 0 0.0
bss 86840 86840 0 0.0
noinit 37160 37160 0 0.0
text 580232 580232 0 0.0

@stale
Copy link

stale bot commented Dec 31, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 31, 2021
@andy31415 andy31415 merged commit 55ef4b8 into project-chip:master Jan 4, 2022
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@doru91 @restyled-commits @step0035
[K32W0] Read General Diagnostics cluster attribute at runtime (projec…
cd9c46a 
…t-chip#12468)

* [K32W0] Read General Diagnostics cluster attribute at runtime

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
fast track platform review - pending stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doru91 @woody-apple @andy31415 @restyled-commits