-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IM client-side APIs to allow timed invoke. #12465
Fix IM client-side APIs to allow timed invoke. #12465
Conversation
figure out where to get useful timeout values here. Forconnectedhomeip/examples/chip-tool/templates/commands.zapt Lines 450 to 457 in 3034579
This comment was generated by todo based on a
|
Maybe we should change PacketBufferTLVWriter so we can finalize itconnectedhomeip/src/app/CommandSender.h Lines 248 to 257 in 3034579
This comment was generated by todo based on a
|
Fix Java API to pass in this information. For now, 10 seconds.}}connectedhomeip/src/controller/java/templates/CHIPClusters-JNI.zapt Lines 74 to 80 in 3034579
This comment was generated by todo based on a
|
Fix Darwin API to pass in this information. For now, 10 seconds.}}connectedhomeip/src/darwin/Framework/CHIP/templates/CHIPClustersObjc-src.zapt Lines 76 to 82 in 3034579
This comment was generated by todo based on a
|
PR #12465: Size comparison from dc10c82 to 96e4995 Increases above 0.2%:
Increases (19 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
|
e405eae
to
4aa907b
Compare
PR #12465: Size comparison from dc10c82 to 4aa907b Increases (1 build for telink)
Full report (1 build for telink)
|
4aa907b
to
cbfe5ac
Compare
PR #12465: Size comparison from dc10c82 to cbfe5ac Increases above 0.2%:
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
c21949d
to
8f01730
Compare
PR #12465: Size comparison from 803f3b8 to 8f01730 Increases above 0.2%:
Increases (20 builds for k32w, linux, nrfconnect, p6, qpg, telink)
Full report (28 builds for k32w, linux, nrfconnect, p6, qpg, telink)
|
8f01730
to
4711edd
Compare
PR #12465: Size comparison from 803f3b8 to 4711edd Increases above 0.2%:
Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
* Fix IM client-side APIs to allow timed invoke. * Add timedInteractionTimeoutMs optional argument to chip-tool commands Co-authored-by: Vivien Nicolas <[email protected]>
Problem
Client side of timed invoke not implemented.
Change overview
Implement it out to the CHIPClusters/InvokeInteraction API surface. Also adds yaml support and some yaml tests exercising it.
Testing
Yaml tests added that test several possible scenarios here.