-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a random discriminator for test runs. #12449
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:test-unique-discriminator
Dec 2, 2021
Merged
Use a random discriminator for test runs. #12449
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:test-unique-discriminator
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're getting cross-talk, maybe this will help.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
December 2, 2021 00:03
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
December 2, 2021 00:03
tcarmelveilleux
approved these changes
Dec 2, 2021
PR #12449: Size comparison from 6f3b5a0 to 0962785 Increases (5 builds for linux)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 2, 2021
yunhanw-google
approved these changes
Dec 2, 2021
andy31415
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're getting cross-talk, maybe this will help.
Problem
All of our test instances use the same onboarding info, so if we are in fact getting cross-talk the chip-tool of one test can end up talking to the all-clusters-app of a different test.
Change overview
Try using a randomly generated discriminator to work around that potential problem.
The switch from qrcode to onnetwork-long is to avoid needing to parse the QR code out from the all-clusters-app log, since it would no longer be constant.
Testing
Ran test locally and things worked.