[Demo] [ESP32] Enable the BLE stack and get the code to compile

[vivien-apple]

Problem

Turning on CHIPoBLE on menuconfig for the ESP32 does not work.

Summary of Changes

• Rename WoBLE to CHIPoBLE where it has been forgotten
• Add missing headers
• Add missing inheritances for ConfigurationManager
• Add missing code for linking

The proposed patch get the M5Stack demo to advertise BLE. It will still needs some love in order to communicate with an app.

fixes #1240

[BroderickCarlin]

I don't think we want to move this exit:

[vivien-apple]

I agree this is hacky but I moved it on purposes. The main reason is that the current code does not compile if CHIP_DEVICE_CONFIG_LOG_PROVISIONING_HASH is not defined since the only call sites that call 'exit' are inside it and the compiler complains otherwise.

The solutions I have handy are:

• Do what I did
• Remove the code inside CHIP_DEVICE_CONFIG_LOG_PROVISIONING
• remove the 'exit:' label and rewrite the code accordingly

[BroderickCarlin]

There seems to be a lot of removed code in this PR that I'm not seeing as directly related to "enabling the BLE stack". Were these changes intended to be included in the PR?

[vivien-apple]

That's a fair point. This file was not used and so there was a lot of dead code that does not even compile and was not used.
For example CHIP does not have all those namespaces:
::chip::Profiles::Security::AppKeys;
::chip::Profiles::NetworkProvisioning;
::chip::Profiles::DeviceDescription

I was unsure about what is the best strategy with this code.
Should I remove it, or should I just try to go and fix it, even if this code is completely unrelated to the BLE thing ?

[woody-apple]

I think removing is fine, as long as we annotate why here.

[vivien-apple]

For the record, while digging into the opened PR I realised that this PR shares some similarities with #1192 since both bring ConfigurationManagerImpl into the build (#1192 for nRF5 and this one for ESP32).

I believe the comments related to GroupKeyStoreImpl there will apply here: basically, add a TODO with an issue #

[vivien-apple]

I opened #1266 for the GroupKeyStore part and will add a TODO in my next update to the code.

[andy31415]

Is the 300+ KB increase on .text and +79KB .data increase for the ESP32 examples really correct? OUCH!

[kedars]

Is the 300+ KB increase on .text and +79KB .data increase for the ESP32 examples really correct? OUCH!

That's likely due to Bluedroid as BT got pulled in. I am working on a NimBLE implementation for the BT layer, that should help bring this down. Hopefully will raise a PR early next week.

[vivien-apple]

OK I was wondering why the ESP32 build suddenly fails on CI but not locally. It ends up that I got a working sdkconfig that uses the right parameters while CI has been broken by #1248. Hopefully once #1299 lands I should be able to have a green CI.

[woody-apple]

@vivien-apple merge conflicts

[vivien-apple]

Rebased and the ESP32 CI is finally green...

[chip-bot]

Size increase report for "Build Examples [nRF]"

File	Section	File	VM
chip-nrf52840-lock-example.out	.text	4768	4768
chip-nrf52840-lock-example.out	.bss	0	16
chip-nrf52840-lock-example.out	.data	8	8

Full report output

Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_info,0,84180
.debug_line,0,21933
.debug_loc,0,14079
.debug_macro,0,8619
.debug_abbrev,0,7270
.text,4768,4768
.debug_str,0,3919
.strtab,0,2285
.debug_frame,0,1980
.debug_ranges,0,1840
.symtab,0,1840
.debug_aranges,0,752
.bss,16,0
.data,8,8
[Unmapped],0,-4765

[chip-bot]

Size increase report for "Build Examples [main-build]"

File	Section	File	VM

Full report output

Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

sections,vmsize,filesize

[chip-bot]

Size increase report for "Build Examples [ESP32]"

File	Section	File	VM
chip-wifi-echo.elf	.flash.text	298560	298560
chip-wifi-echo.elf	.flash.rodata	78584	78584
chip-wifi-echo.elf	.dram0.bss	0	28368
chip-wifi-echo.elf	.iram0.text	27488	27488
chip-wifi-echo.elf	.dram0.data	1360	1360

Full report output

Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_info,0,2224454
.debug_line,0,918167
.debug_loc,0,343933
.flash.text,298560,298560
.debug_str,0,187402
.debug_abbrev,0,132251
.flash.rodata,78584,78584
.strtab,0,75078
.debug_frame,0,62444
.symtab,0,54704
.debug_ranges,0,29136
.dram0.bss,28368,0
.iram0.text,27488,27488
.debug_aranges,0,22944
.shstrtab,0,4633
[106 Others],0,2508
.dram0.data,1360,1360
.xt.lit._ZNKSt13__facet_shims12__any_stringcvSbIT_St11char_traitsIS1_ESaIS1_EEIcEEv,0,360
.xt.prop._ZNSt13__facet_shims12__any_stringaSIcEERS0_RKSbIT_St11char_traitsIS3_ESaIS3_EE,0,360
.xt.lit._ZNKSt7num_getIcSt19istreambuf_iteratorIcSt11char_traitsIcEEE14_M_extract_intItEES3_S3_S3_RSt8ios_baseRSt12_Ios_IostateRT_,0,328
[Unmapped],0,-930

[vivien-apple]

Ok. It is fully green now.