Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement run time value to the General diagnostics attributes for EFR32 platform #12376

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Implement run time value to the General diagnostics attributes for EFR32 platform #12376

merged 2 commits into from
Dec 1, 2021

Conversation

jmartinez-silabs
Copy link
Member

Problem

EFR32 platform do not provide run time value to the General diagnostics attributes.

Change overview

Implement the getters and logic in EFR32 DiagnosticDataProviderImpl.cpp and ConfigurationManagerImpl.cpp

Testing

Manual testing with chip-tool
./out/standalone/chip-tool generaldiagnostics read up-time 2145 0
./out/standalone/chip-tool generaldiagnostics read network-interfaces 2145 0
./out/standalone/chip-tool generaldiagnostics read reboot-count 2145 0
./out/standalone/chip-tool generaldiagnostics read boot-reasons 2145 0
./out/standalone/chip-tool generaldiagnostics read total-operational-hours 2145 0

@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

PR #12376: Size comparison from ee824af to 79eadb1

Increases (4 builds for efr32)
platform target config section ee824af 79eadb1 change % change
efr32 lighting-app BRD4161A (read only) 763016 763592 576 0.1
(read/write) 120300 120316 16 0.0
.bss 118476 118500 24 0.0
.text 763008 763584 576 0.1
BRD4161A+rpc (read only) 791512 792104 592 0.1
(read/write) 138596 138620 24 0.0
.bss 136676 136700 24 0.0
.text 791504 792096 592 0.1
lock-app BRD4161A (read only) 736896 737472 576 0.1
(read/write) 118004 118028 24 0.0
.bss 116228 116252 24 0.0
.text 736888 737464 576 0.1
window-app BRD4161A (read only) 739984 740576 592 0.1
(read/write) 118436 118460 24 0.0
.bss 116652 116676 24 0.0
.text 739976 740568 592 0.1
Decreases (4 builds for efr32)
platform target config section ee824af 79eadb1 change % change
efr32 lighting-app BRD4161A .data 1820 1816 -4 -0.2
BRD4161A+rpc .data 1920 1916 -4 -0.2
lock-app BRD4161A .data 1776 1772 -4 -0.2
window-app BRD4161A .data 1784 1780 -4 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ee824af 79eadb1 change % change
efr32 lighting-app BRD4161A (read only) 763016 763592 576 0.1
(read/write) 120300 120316 16 0.0
.bss 118476 118500 24 0.0
.data 1820 1816 -4 -0.2
.text 763008 763584 576 0.1
BRD4161A+rpc (read only) 791512 792104 592 0.1
(read/write) 138596 138620 24 0.0
.bss 136676 136700 24 0.0
.data 1920 1916 -4 -0.2
.text 791504 792096 592 0.1
lock-app BRD4161A (read only) 736896 737472 576 0.1
(read/write) 118004 118028 24 0.0
.bss 116228 116252 24 0.0
.data 1776 1772 -4 -0.2
.text 736888 737464 576 0.1
window-app BRD4161A (read only) 739984 740576 592 0.1
(read/write) 118436 118460 24 0.0
.bss 116652 116676 24 0.0
.data 1784 1780 -4 -0.2
.text 739976 740568 592 0.1
esp32 all-clusters-app c3devkit (read only) 836580 836580 0 0.0
(read/write) 1225258 1225258 0 0.0
.dram0.bss 59608 59608 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 166400 166400 0 0.0
.flash.text 836580 836580 0 0.0
.iram0.text 61390 61390 0 0.0
m5stack (read only) 908587 908587 0 0.0
(read/write) 424484 424484 0 0.0
.dram0.bss 65000 65000 0 0.0
.dram0.data 33960 33960 0 0.0
.flash.rodata 194244 194244 0 0.0
.flash.text 903203 903203 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724356 724356 0 0.0
.bss 78756 78756 0 0.0
.data 1844 1844 0 0.0
.text 637956 637956 0 0.0
lock-app k32w061+debug (read/write) 613348 613348 0 0.0
.bss 69204 69204 0 0.0
.data 1808 1808 0 0.0
.text 536536 536536 0 0.0
shell k32w061+debug (read/write) 679128 679128 0 0.0
.bss 80780 80780 0 0.0
.data 1780 1780 0 0.0
.text 590768 590768 0 0.0
linux all-clusters-app debug (read only) 1779889 1779889 0 0.0
(read/write) 131960 131960 0 0.0
.bss 60688 60688 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 139957 139957 0 0.0
.text 1500914 1500914 0 0.0
bridge-app debug+rpc (read only) 1353061 1353061 0 0.0
(read/write) 78400 78400 0 0.0
.bss 42288 42288 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113820 113820 0 0.0
.text 1139125 1139125 0 0.0
chip-tool debug (read only) 6137333 6137333 0 0.0
(read/write) 199576 199576 0 0.0
.bss 40640 40640 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 152336 152336 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 294408 294408 0 0.0
.text 5452773 5452773 0 0.0
lighting-app debug+rpc (read only) 1633129 1633129 0 0.0
(read/write) 111520 111520 0 0.0
.bss 47984 47984 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 132305 132305 0 0.0
.text 1363010 1363010 0 0.0
ota-provider-app debug (read only) 1313409 1313409 0 0.0
(read/write) 76856 76856 0 0.0
.bss 44864 44864 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114960 114960 0 0.0
.text 1098098 1098098 0 0.0
ota-requestor-app debug (read only) 1413425 1413425 0 0.0
(read/write) 80752 80752 0 0.0
.bss 46976 46976 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126816 126816 0 0.0
.text 1182818 1182818 0 0.0
shell debug (read only) 821761 821761 0 0.0
(read/write) 67288 67288 0 0.0
.bss 23976 23976 0 0.0
.data 224 224 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79218 79218 0 0.0
.text 635858 635858 0 0.0
tv-app debug (read only) 1927729 1927729 0 0.0
(read/write) 321152 321152 0 0.0
.bss 252376 252376 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61608 61608 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161448 161448 0 0.0
.text 1617842 1617842 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296160 2296160 0 0.0
.bss 182348 182348 0 0.0
.data 5128 5128 0 0.0
.heap 848968 848968 0 0.0
.text 1258760 1258760 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281096 2281096 0 0.0
.bss 172956 172956 0 0.0
.data 5488 5488 0 0.0
.heap 858000 858000 0 0.0
.text 1243696 1243696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254192 2254192 0 0.0
.bss 171772 171772 0 0.0
.data 5472 5472 0 0.0
.heap 859200 859200 0 0.0
.text 1216792 1216792 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051232 2051232 0 0.0
.bss 156920 156920 0 0.0
.data 4872 4872 0 0.0
.heap 874656 874656 0 0.0
.text 1013832 1013832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876639 876639 0 0.0
bss 113124 113124 0 0.0
rodata 97344 97344 0 0.0
text 590620 590620 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 839087 839087 0 0.0
bss 109476 109476 0 0.0
rodata 88608 88608 0 0.0
text 564788 564788 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801674 801674 0 0.0
bss 114500 114500 0 0.0
rodata 92604 92604 0 0.0
text 520076 520076 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847467 847467 0 0.0
bss 110164 110164 0 0.0
rodata 93084 93084 0 0.0
text 568872 568872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772738 772738 0 0.0
bss 111572 111572 0 0.0
rodata 88372 88372 0 0.0
text 498420 498420 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853479 853479 0 0.0
bss 110300 110300 0 0.0
rodata 94816 94816 0 0.0
text 572940 572940 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846559 846559 0 0.0
bss 110176 110176 0 0.0
rodata 92952 92952 0 0.0
text 568000 568000 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779043 779043 0 0.0
bss 109604 109604 0 0.0
rodata 73192 73192 0 0.0
text 521724 521724 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694058 694058 0 0.0
bss 110588 110588 0 0.0
rodata 67836 67836 0 0.0
text 442332 442332 0 0.0
p6 all-clusters-app default (read/write) 2317928 2317928 0 0.0
.bss 115256 115256 0 0.0
.data 2424 2424 0 0.0
.heap 915664 915664 0 0.0
.text 1276192 1276192 0 0.0
lock-app default (read/write) 2229400 2229400 0 0.0
.bss 101552 101552 0 0.0
.data 2288 2288 0 0.0
.heap 929504 929504 0 0.0
.text 1187664 1187664 0 0.0
qpg lighting-app qpg6100+debug (read only) 496712 496712 0 0.0
(read/write) 114144 114144 0 0.0
.bss 79640 79640 0 0.0
.data 944 944 0 0.0
.text 491392 491392 0 0.0
lock-app qpg6100+debug (read only) 469316 469316 0 0.0
(read/write) 114144 114144 0 0.0
.bss 78552 78552 0 0.0
.data 896 896 0 0.0
.text 463996 463996 0 0.0
persistent-storage-app qpg6100+debug (read only) 108076 108076 0 0.0
(read/write) 114144 114144 0 0.0
.bss 36864 36864 0 0.0
.data 296 296 0 0.0
.text 102756 102756 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778454 778454 0 0.0
bss 79700 79700 0 0.0
noinit 37160 37160 0 0.0
text 541270 541270 0 0.0

@andy31415
Copy link
Contributor

fast track: platform specific changes, PR created by platform owner

@jmartinez-silabs jmartinez-silabs merged commit 18f959b into project-chip:master Dec 1, 2021
@jmartinez-silabs jmartinez-silabs deleted the gen_diag branch December 1, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
efr32 fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartinez-silabs @andy31415 @yufengwangca