-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rotating device id by default #12199
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:disable_rid_by_default
Nov 24, 2021
Merged
Disable rotating device id by default #12199
andy31415
merged 2 commits into
project-chip:master
from
andy31415:disable_rid_by_default
Nov 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
November 24, 2021 14:15
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 24, 2021 14:15
fast track: trivial change in default build flags (disables an optional feature) |
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Damian-Nordic
approved these changes
Nov 24, 2021
jmartinez-silabs
approved these changes
Nov 24, 2021
tcarmelveilleux
approved these changes
Nov 24, 2021
Removed fast track: sufficient checkmars, not really using the fast track path. |
PR #12199: Size comparison from 8f73103 to d92e15c Increases above 0.2%:
Increases (18 builds for efr32, esp32, k32w, linux, mbed, p6)
Decreases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rotating device ID is an optional feature that makes flash usage bigger and increases mDNS reply sizes. Disable it by default to ensure constrained devices can run without it (qpg already disables it)
Change overview
Set the RDID false by default
Testing
CI will cover this.