Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable rotating device id by default #12199

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Disable rotating device id by default #12199

merged 2 commits into from
Nov 24, 2021

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Nov 24, 2021 •
edited
Loading

Problem

Rotating device ID is an optional feature that makes flash usage bigger and increases mDNS reply sizes. Disable it by default to ensure constrained devices can run without it (qpg already disables it)

Change overview

Set the RDID false by default

Testing

CI will cover this.

@andy31415
Copy link
Contributor Author

fast track: trivial change in default build flags (disables an optional feature)

@andy31415 @tcarmelveilleux
Update src/platform/BUILD.gn
d92e15c 
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
@andy31415
Copy link
Contributor Author

Removed fast track: sufficient checkmars, not really using the fast track path.

@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

PR #12199: Size comparison from 8f73103 to d92e15c

Increases above 0.2%:

platform target config section 8f73103 d92e15c change % change
linux all-clusters-app debug .data 1138 1170 32 2.8
lighting-app debug+rpc .data 1330 1362 32 2.4
ota-provider-app debug .data 880 912 32 3.6
ota-requestor-app debug .data 944 976 32 3.4
p6 all-clusters-app default .data 2536 2544 8 0.3
Increases (18 builds for efr32, esp32, k32w, linux, mbed, p6)
platform target config section 8f73103 d92e15c change % change
efr32 lighting-app BRD4161A .data 1812 1816 4 0.2
BRD4161A+rpc .data 1936 1940 4 0.2
lock-app BRD4161A .data 1768 1772 4 0.2
window-app BRD4161A .data 1776 1780 4 0.2
esp32 all-clusters-app m5stack .dram0.data 34064 34072 8 0.0
k32w lighting-app k32w061+se05x+release .data 1924 1928 4 0.2
lock-app k32w061+debug .data 1892 1896 4 0.2
shell k32w061+debug .data 1860 1864 4 0.2
linux all-clusters-app debug .data 1138 1170 32 2.8
lighting-app debug+rpc .data 1330 1362 32 2.4
ota-provider-app debug .data 880 912 32 3.6
ota-requestor-app debug .data 944 976 32 3.4
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 850808 850824 16 0.0
lighting-app CY8CPROTO_062_4343W+release .data 5592 5600 8 0.1
.heap 858560 858568 8 0.0
lock-app CY8CPROTO_062_4343W+release .data 5576 5584 8 0.1
.heap 859760 859768 8 0.0
shell CY8CPROTO_062_4343W+release .heap 875144 875160 16 0.0
p6 all-clusters-app default .data 2536 2544 8 0.3
.heap 917424 917432 8 0.0
lock-app default .heap 929960 929976 16 0.0
Decreases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8f73103 d92e15c change % change
efr32 lighting-app BRD4161A (read only) 757712 757048 -664 -0.1
(read/write) 119796 119780 -16 -0.0
.bss 117980 117964 -16 -0.0
.text 757704 757040 -664 -0.1
BRD4161A+rpc (read only) 745172 744508 -664 -0.1
(read/write) 136420 136408 -12 -0.0
.bss 134484 134468 -16 -0.0
.text 745164 744500 -664 -0.1
lock-app BRD4161A (read only) 733568 732920 -648 -0.1
(read/write) 117508 117500 -8 -0.0
.bss 115740 115724 -16 -0.0
.text 733560 732912 -648 -0.1
window-app BRD4161A (read only) 737016 736352 -664 -0.1
(read/write) 117868 117860 -8 -0.0
.bss 116092 116076 -16 -0.0
.text 737008 736344 -664 -0.1
esp32 all-clusters-app c3devkit (read only) 836066 835272 -794 -0.1
(read/write) 1222698 1222362 -336 -0.0
.dram0.bss 57840 57824 -16 -0.0
.flash.rodata 165504 165184 -320 -0.2
.flash.text 836066 835272 -794 -0.1
m5stack (read only) 907519 906691 -828 -0.1
(read/write) 422004 421676 -328 -0.1
.dram0.bss 63232 63216 -16 -0.0
.flash.rodata 193428 193108 -320 -0.2
.flash.text 902135 901307 -828 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 711916 710956 -960 -0.1
.bss 77316 77300 -16 -0.0
.text 626876 625928 -948 -0.2
lock-app k32w061+debug (read/write) 602112 601168 -944 -0.2
.bss 67756 67740 -16 -0.0
.text 526664 525732 -932 -0.2
shell k32w061+debug (read/write) 667608 666652 -956 -0.1
.bss 78916 78900 -16 -0.0
.text 581032 580088 -944 -0.2
linux all-clusters-app debug (read only) 1768145 1765289 -2856 -0.2
(read/write) 129496 129432 -64 -0.0
.bss 58608 58576 -32 -0.1
.data.rel.ro 64432 64384 -48 -0.1
.rodata 138485 138357 -128 -0.1
.text 1491602 1488946 -2656 -0.2
bridge-app debug+rpc (read only) 1343661 1340813 -2848 -0.2
(read/write) 77408 77312 -96 -0.1
.bss 41488 41456 -32 -0.1
.data.rel.ro 29200 29152 -48 -0.2
.rodata 113044 112924 -120 -0.1
.text 1130837 1128181 -2656 -0.2
chip-tool debug (read only) 5959917 5957085 -2832 -0.0
(read/write) 197224 197104 -120 -0.1
.bss 39896 39840 -56 -0.1
.data.rel.ro 149368 149320 -48 -0.0
.rodata 283954 283848 -106 -0.0
.text 5292597 5289941 -2656 -0.1
lighting-app debug+rpc (read only) 1616945 1614089 -2856 -0.2
(read/write) 110688 110624 -64 -0.1
.bss 47216 47184 -32 -0.1
.data.rel.ro 56800 56752 -48 -0.1
.rodata 131409 131281 -128 -0.1
.text 1348130 1345474 -2656 -0.2
ota-provider-app debug (read only) 1307833 1304977 -2856 -0.2
(read/write) 75928 75864 -64 -0.1
.bss 44128 44064 -64 -0.1
.data.rel.ro 25784 25736 -48 -0.2
.rodata 114831 114704 -127 -0.1
.text 1092962 1090306 -2656 -0.2
ota-requestor-app debug (read only) 1404337 1401513 -2824 -0.2
(read/write) 79792 79728 -64 -0.1
.bss 46592 46528 -64 -0.1
.data.rel.ro 27112 27064 -48 -0.2
.rodata 126240 126144 -96 -0.1
.text 1175266 1172610 -2656 -0.2
shell debug (read only) 820345 818721 -1624 -0.2
(read/write) 66584 66520 -64 -0.1
.bss 23272 23240 -32 -0.1
.data.rel.ro 38440 38392 -48 -0.1
.rodata 79119 78991 -128 -0.2
.text 634802 633378 -1424 -0.2
tv-app debug (read only) 1913497 1910657 -2840 -0.1
(read/write) 319704 319624 -80 -0.0
.bss 249976 249928 -48 -0.0
.data.rel.ro 61184 61136 -48 -0.1
.rodata 159317 159208 -109 -0.1
.text 1606290 1603634 -2656 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294768 2293808 -960 -0.0
.bss 180396 180380 -16 -0.0
.text 1257368 1256408 -960 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2278944 2277984 -960 -0.0
.bss 172292 172276 -16 -0.0
.text 1241544 1240584 -960 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2253264 2252368 -896 -0.0
.bss 171108 171092 -16 -0.0
.text 1215864 1214968 -896 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2051224 2050648 -576 -0.0
.bss 156320 156304 -16 -0.0
.text 1013824 1013248 -576 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 871847 870899 -948 -0.1
bss 112640 112624 -16 -0.0
rodata 96784 96476 -308 -0.3
text 586792 586156 -636 -0.1
nrf52840dk_nrf52840+rpc (read/write) 834215 833267 -948 -0.1
bss 108992 108976 -16 -0.0
rodata 87968 87660 -308 -0.4
text 560960 560324 -636 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 796886 795942 -944 -0.1
bss 114012 113996 -16 -0.0
rodata 92040 91736 -304 -0.3
text 516260 515616 -644 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 843963 842991 -972 -0.1
bss 109672 109656 -16 -0.0
rodata 92788 92480 -308 -0.3
text 566036 565400 -636 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 769234 768262 -972 -0.1
bss 111084 111068 -16 -0.0
rodata 88076 87768 -308 -0.3
text 495596 494952 -644 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 850071 849123 -948 -0.1
bss 109812 109796 -16 -0.0
rodata 94496 94188 -308 -0.3
text 570220 569580 -640 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 843663 842683 -980 -0.1
bss 109708 109692 -16 -0.0
rodata 92744 92436 -308 -0.3
text 565656 565020 -636 -0.1
shell nrf52840dk_nrf52840 (read/write) 778907 778311 -596 -0.1
bss 109184 109168 -16 -0.0
rodata 73304 72996 -308 -0.4
text 521828 521532 -296 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 693962 693350 -612 -0.1
bss 110168 110152 -16 -0.0
rodata 67948 67640 -308 -0.5
text 442436 442140 -296 -0.1
p6 all-clusters-app default (read/write) 2309800 2309128 -672 -0.0
.bss 113384 113368 -16 -0.0
.text 1268064 1267392 -672 -0.1
lock-app default (read/write) 2221784 2221104 -680 -0.0
.bss 100968 100952 -16 -0.0
.text 1180048 1179368 -680 -0.1
telink lighting-app tlsr9518adk80d (read/write) 773510 772274 -1236 -0.2
bss 79216 79200 -16 -0.0
text 537292 536388 -904 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8f73103 d92e15c change % change
efr32 lighting-app BRD4161A (read only) 757712 757048 -664 -0.1
(read/write) 119796 119780 -16 -0.0
.bss 117980 117964 -16 -0.0
.data 1812 1816 4 0.2
.text 757704 757040 -664 -0.1
BRD4161A+rpc (read only) 745172 744508 -664 -0.1
(read/write) 136420 136408 -12 -0.0
.bss 134484 134468 -16 -0.0
.data 1936 1940 4 0.2
.text 745164 744500 -664 -0.1
lock-app BRD4161A (read only) 733568 732920 -648 -0.1
(read/write) 117508 117500 -8 -0.0
.bss 115740 115724 -16 -0.0
.data 1768 1772 4 0.2
.text 733560 732912 -648 -0.1
window-app BRD4161A (read only) 737016 736352 -664 -0.1
(read/write) 117868 117860 -8 -0.0
.bss 116092 116076 -16 -0.0
.data 1776 1780 4 0.2
.text 737008 736344 -664 -0.1
esp32 all-clusters-app c3devkit (read only) 836066 835272 -794 -0.1
(read/write) 1222698 1222362 -336 -0.0
.dram0.bss 57840 57824 -16 -0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165504 165184 -320 -0.2
.flash.text 836066 835272 -794 -0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907519 906691 -828 -0.1
(read/write) 422004 421676 -328 -0.1
.dram0.bss 63232 63216 -16 -0.0
.dram0.data 34064 34072 8 0.0
.flash.rodata 193428 193108 -320 -0.2
.flash.text 902135 901307 -828 -0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 711916 710956 -960 -0.1
.bss 77316 77300 -16 -0.0
.data 1924 1928 4 0.2
.text 626876 625928 -948 -0.2
lock-app k32w061+debug (read/write) 602112 601168 -944 -0.2
.bss 67756 67740 -16 -0.0
.data 1892 1896 4 0.2
.text 526664 525732 -932 -0.2
shell k32w061+debug (read/write) 667608 666652 -956 -0.1
.bss 78916 78900 -16 -0.0
.data 1860 1864 4 0.2
.text 581032 580088 -944 -0.2
linux all-clusters-app debug (read only) 1768145 1765289 -2856 -0.2
(read/write) 129496 129432 -64 -0.0
.bss 58608 58576 -32 -0.1
.data 1138 1170 32 2.8
.data.rel.ro 64432 64384 -48 -0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138485 138357 -128 -0.1
.text 1491602 1488946 -2656 -0.2
bridge-app debug+rpc (read only) 1343661 1340813 -2848 -0.2
(read/write) 77408 77312 -96 -0.1
.bss 41488 41456 -32 -0.1
.data 1680 1680 0 0.0
.data.rel.ro 29200 29152 -48 -0.2
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113044 112924 -120 -0.1
.text 1130837 1128181 -2656 -0.2
chip-tool debug (read only) 5959917 5957085 -2832 -0.0
(read/write) 197224 197104 -120 -0.1
.bss 39896 39840 -56 -0.1
.data 2384 2384 0 0.0
.data.rel.ro 149368 149320 -48 -0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283954 283848 -106 -0.0
.text 5292597 5289941 -2656 -0.1
lighting-app debug+rpc (read only) 1616945 1614089 -2856 -0.2
(read/write) 110688 110624 -64 -0.1
.bss 47216 47184 -32 -0.1
.data 1330 1362 32 2.4
.data.rel.ro 56800 56752 -48 -0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131409 131281 -128 -0.1
.text 1348130 1345474 -2656 -0.2
ota-provider-app debug (read only) 1307833 1304977 -2856 -0.2
(read/write) 75928 75864 -64 -0.1
.bss 44128 44064 -64 -0.1
.data 880 912 32 3.6
.data.rel.ro 25784 25736 -48 -0.2
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114831 114704 -127 -0.1
.text 1092962 1090306 -2656 -0.2
ota-requestor-app debug (read only) 1404337 1401513 -2824 -0.2
(read/write) 79792 79728 -64 -0.1
.bss 46592 46528 -64 -0.1
.data 944 976 32 3.4
.data.rel.ro 27112 27064 -48 -0.2
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126240 126144 -96 -0.1
.text 1175266 1172610 -2656 -0.2
shell debug (read only) 820345 818721 -1624 -0.2
(read/write) 66584 66520 -64 -0.1
.bss 23272 23240 -32 -0.1
.data 338 338 0 0.0
.data.rel.ro 38440 38392 -48 -0.1
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79119 78991 -128 -0.2
.text 634802 633378 -1424 -0.2
tv-app debug (read only) 1913497 1910657 -2840 -0.1
(read/write) 319704 319624 -80 -0.0
.bss 249976 249928 -48 -0.0
.data 2880 2880 0 0.0
.data.rel.ro 61184 61136 -48 -0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159317 159208 -109 -0.1
.text 1606290 1603634 -2656 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294768 2293808 -960 -0.0
.bss 180396 180380 -16 -0.0
.data 5240 5240 0 0.0
.heap 850808 850824 16 0.0
.text 1257368 1256408 -960 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278944 2277984 -960 -0.0
.bss 172292 172276 -16 -0.0
.data 5592 5600 8 0.1
.heap 858560 858568 8 0.0
.text 1241544 1240584 -960 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253264 2252368 -896 -0.0
.bss 171108 171092 -16 -0.0
.data 5576 5584 8 0.1
.heap 859760 859768 8 0.0
.text 1215864 1214968 -896 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051224 2050648 -576 -0.0
.bss 156320 156304 -16 -0.0
.data 4984 4984 0 0.0
.heap 875144 875160 16 0.0
.text 1013824 1013248 -576 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 871847 870899 -948 -0.1
bss 112640 112624 -16 -0.0
rodata 96784 96476 -308 -0.3
text 586792 586156 -636 -0.1
nrf52840dk_nrf52840+rpc (read/write) 834215 833267 -948 -0.1
bss 108992 108976 -16 -0.0
rodata 87968 87660 -308 -0.4
text 560960 560324 -636 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 796886 795942 -944 -0.1
bss 114012 113996 -16 -0.0
rodata 92040 91736 -304 -0.3
text 516260 515616 -644 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 843963 842991 -972 -0.1
bss 109672 109656 -16 -0.0
rodata 92788 92480 -308 -0.3
text 566036 565400 -636 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 769234 768262 -972 -0.1
bss 111084 111068 -16 -0.0
rodata 88076 87768 -308 -0.3
text 495596 494952 -644 -0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 850071 849123 -948 -0.1
bss 109812 109796 -16 -0.0
rodata 94496 94188 -308 -0.3
text 570220 569580 -640 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 843663 842683 -980 -0.1
bss 109708 109692 -16 -0.0
rodata 92744 92436 -308 -0.3
text 565656 565020 -636 -0.1
shell nrf52840dk_nrf52840 (read/write) 778907 778311 -596 -0.1
bss 109184 109168 -16 -0.0
rodata 73304 72996 -308 -0.4
text 521828 521532 -296 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 693962 693350 -612 -0.1
bss 110168 110152 -16 -0.0
rodata 67948 67640 -308 -0.5
text 442436 442140 -296 -0.1
p6 all-clusters-app default (read/write) 2309800 2309128 -672 -0.0
.bss 113384 113368 -16 -0.0
.data 2536 2544 8 0.3
.heap 917424 917432 8 0.0
.text 1268064 1267392 -672 -0.1
lock-app default (read/write) 2221784 2221104 -680 -0.0
.bss 100968 100952 -16 -0.0
.data 2416 2416 0 0.0
.heap 929960 929976 16 0.0
.text 1180048 1179368 -680 -0.1
qpg lighting-app qpg6100+debug (read only) 498644 498644 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50360 0 0.0
.data 1020 1020 0 0.0
.text 493324 493324 0 0.0
lock-app qpg6100+debug (read only) 472548 472548 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49232 0 0.0
.data 976 976 0 0.0
.text 467228 467228 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 773510 772274 -1236 -0.2
bss 79216 79200 -16 -0.0
noinit 37160 37160 0 0.0
text 537292 536388 -904 -0.2

@andy31415 andy31415 merged commit e0a8db7 into project-chip:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andy31415 @tcarmelveilleux @msandstedt @Damian-Nordic @jmartinez-silabs