Get rid of the non-spec EMBER_ZCL_STATUS_INVALID_ARGUMENT value. #12192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
vivien-apple
pullapprove
bot
requested review from
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #12192: Size comparison from 2e85d48 to 5f2a580 Increases (3 builds for linux)
Decreases (4 builds for efr32, linux, mbed)
Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
This is not quite true. INVALID_ARGUMENT was there after 1st ballot, but got removed when the language was tightened for INVALID_COMMAND and CONSTRAINT_ERROR. |
tcarmelveilleux
approved these changes
Nov 24, 2021
Ah, this makes a lot of sense, ok. |
bzbarsky-apple
force-pushed
the
get-rid-of-invalid-argument-enum
branch
from
5f2a580 to
d3caec8
Compare
It used to be in the spec, but was then removed in favor of INVALID_COMMAND or CONSTRAINT_ERROR. The value we are using for it collides with the spec-defined NEEDS_TIMED_INTERACTION value.
bzbarsky-apple
force-pushed
the
get-rid-of-invalid-argument-enum
branch
from
d3caec8 to
c0c43a7
Compare
|
PR #12192: Size comparison from 8bfdc13 to c0c43a7 Increases (3 builds for linux)
Decreases (5 builds for efr32, linux, mbed, nrfconnect)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
holbrookt
approved these changes
Nov 24, 2021
yunhanw-google
approved these changes
Nov 25, 2021
vivien-apple
approved these changes
Nov 25, 2021
andy31415
approved these changes
Nov 25, 2021
|
fast track: several checkmarks, PR up for a while, straight forward update/rename. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be in the spec, but was then removed in favor of
INVALID_COMMAND or CONSTRAINT_ERROR. The value we are using for it
collides with the spec-defined NEEDS_TIMED_INTERACTION value.
Problem
See above.
Change overview
See above.
Testing
No behavior changes intended other than which error status is returned in some cases. I'm trying to stand up a way to test that via YAML right now, which is how I ran into this.