-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use separate udp endpoint (with separate ephemeral port) for minmdns unicast queries #12161
Use separate udp endpoint (with separate ephemeral port) for minmdns unicast queries #12161
Conversation
…ction (bound to a random port)
PR #12161: Size comparison from 71a3fb2 to b4499ef Increases (2 builds for p6)
Decreases (2 builds for p6)
Full report (9 builds for k32w, p6, qpg, telink)
|
…ast replies will include the query)
PR #12161: Size comparison from 2490197 to cd16ea4 Increases above 0.2%:
Increases (16 builds for esp32, linux, mbed, p6)
Decreases (13 builds for linux, mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #12161: Size comparison from 8f73103 to 3f67479 Increases above 0.2%:
Increases (10 builds for linux, p6)
Decreases (9 builds for linux, p6)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #12161: Size comparison from e0a8db7 to f3afbcf Increases above 0.2%:
Increases (16 builds for esp32, linux, mbed, p6)
Decreases (13 builds for linux, mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: change has been up for sufficient time for cross-timezone review, has several checkmarks and minmdns functionality is exercised a lot during CI (all yaml intergration tests use mdns for provisioning and discovery) |
Problem
Unicast queries on 5353 is not ideal: it can conflict with other mdns servers listening on 5353 (including other chip applications running on the same machine)
Change overview
Bind a separate 'unicast query' minmdns udp port and use it for unicast queries.
Ignore 'query' section in a reply because unicast replies will include a query section.
Testing
Tested via minmdns client/server example.
CI will validate chip-tool and all-clusters-app on linux.