Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate udp endpoint (with separate ephemeral port) for minmdns unicast queries #12161

Merged
merged 12 commits into from
Nov 24, 2021
Merged

Use separate udp endpoint (with separate ephemeral port) for minmdns unicast queries #12161

merged 12 commits into from
Nov 24, 2021

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Nov 23, 2021 •
edited
Loading

Problem

Unicast queries on 5353 is not ideal: it can conflict with other mdns servers listening on 5353 (including other chip applications running on the same machine)

Change overview

Bind a separate 'unicast query' minmdns udp port and use it for unicast queries.
Ignore 'query' section in a reply because unicast replies will include a query section.

Testing

Tested via minmdns client/server example.
CI will validate chip-tool and all-clusters-app on linux.

@github-actions
Copy link

PR #12161: Size comparison from 71a3fb2 to b4499ef

Increases (2 builds for p6)
platform target config section 71a3fb2 b4499ef change % change
p6 all-clusters-app default (read/write) 2304784 2305152 368 0.0
.bss 113360 113480 120 0.1
.text 1263048 1263416 368 0.0
lock-app default (read/write) 2217952 2218320 368 0.0
.bss 100952 101072 120 0.1
.text 1176216 1176584 368 0.0
Decreases (2 builds for p6)
platform target config section 71a3fb2 b4499ef change % change
p6 all-clusters-app default .heap 917448 917328 -120 -0.0
lock-app default .heap 929984 929864 -120 -0.0
Full report (9 builds for k32w, p6, qpg, telink)
platform target config section 71a3fb2 b4499ef change % change
k32w lock-app k32w061+debug (read/write) 600000 600000 0 0.0
.bss 67724 67724 0 0.0
.data 1888 1888 0 0.0
.text 524588 524588 0 0.0
shell k32w061+debug (read/write) 665380 665380 0 0.0
.bss 78884 78884 0 0.0
.data 1856 1856 0 0.0
.text 578840 578840 0 0.0
lighting-app k32w061+se05x+release (read/write) 708668 708668 0 0.0
.bss 77284 77284 0 0.0
.data 1920 1920 0 0.0
.text 623664 623664 0 0.0
p6 all-clusters-app default (read/write) 2304784 2305152 368 0.0
.bss 113360 113480 120 0.1
.data 2536 2536 0 0.0
.heap 917448 917328 -120 -0.0
.text 1263048 1263416 368 0.0
lock-app default (read/write) 2217952 2218320 368 0.0
.bss 100952 101072 120 0.1
.data 2408 2408 0 0.0
.heap 929984 929864 -120 -0.0
.text 1176216 1176584 368 0.0
qpg lighting-app qpg6100+debug (read only) 495344 495344 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50328 50328 0 0.0
.data 1016 1016 0 0.0
.text 490024 490024 0 0.0
lock-app qpg6100+debug (read only) 470288 470288 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 972 972 0 0.0
.text 464968 464968 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769898 769898 0 0.0
bss 79200 79200 0 0.0
noinit 37160 37160 0 0.0
text 534636 534636 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #12161: Size comparison from 2490197 to cd16ea4

Increases above 0.2%:

platform target config section 2490197 cd16ea4 change % change
esp32 all-clusters-app c3devkit .dram0.bss 57832 57952 120 0.2
linux all-clusters-app debug (read/write) 128944 129360 416 0.3
.bss 58640 58864 224 0.4
.data.rel.ro 63952 64144 192 0.3
bridge-app debug+rpc (read/write) 76920 77336 416 0.5
.bss 41552 41776 224 0.5
.data.rel.ro 28752 28952 200 0.7
chip-tool debug .bss 39896 40120 224 0.6
lighting-app debug+rpc (read/write) 110168 110552 384 0.3
.bss 47280 47504 224 0.5
.data.rel.ro 56336 56496 160 0.3
ota-provider-app debug (read/write) 75376 75792 416 0.6
.bss 44128 44352 224 0.5
.data.rel.ro 25336 25512 176 0.7
ota-requestor-app debug (read/write) 79240 79656 416 0.5
.bss 46592 46816 224 0.5
.data.rel.ro 26664 26840 176 0.7
shell debug (read/write) 66160 66576 416 0.6
.bss 23336 23592 256 1.1
.data.rel.ro 38008 38176 168 0.4
tv-app debug .data.rel.ro 60712 60880 168 0.3
Increases (16 builds for esp32, linux, mbed, p6)
platform target config section 2490197 cd16ea4 change % change
esp32 all-clusters-app c3devkit (read only) 834250 834282 32 0.0
(read/write) 1222370 1222554 184 0.0
.dram0.bss 57832 57952 120 0.2
.flash.rodata 165176 165248 72 0.0
.flash.text 834250 834282 32 0.0
m5stack (read only) 905215 905331 116 0.0
(read/write) 421648 421800 152 0.0
.dram0.bss 63192 63312 120 0.2
.flash.rodata 193112 193144 32 0.0
.flash.text 899831 899947 116 0.0
linux all-clusters-app debug (read only) 1751481 1752937 1456 0.1
(read/write) 128944 129360 416 0.3
.bss 58640 58864 224 0.4
.data.rel.ro 63952 64144 192 0.3
.text 1476162 1477314 1152 0.1
bridge-app debug+rpc (read only) 1330957 1332477 1520 0.1
(read/write) 76920 77336 416 0.5
.bss 41552 41776 224 0.5
.data.rel.ro 28752 28952 200 0.7
.text 1119269 1120453 1184 0.1
chip-tool debug (read only) 5916677 5918101 1424 0.0
(read/write) 196224 196608 384 0.2
.bss 39896 40120 224 0.6
.data.rel.ro 148480 148648 168 0.1
.text 5251829 5252981 1152 0.0
lighting-app debug+rpc (read only) 1600857 1602265 1408 0.1
(read/write) 110168 110552 384 0.3
.bss 47280 47504 224 0.5
.data.rel.ro 56336 56496 160 0.3
.text 1333186 1334322 1136 0.1
ota-provider-app debug (read only) 1280873 1282281 1408 0.1
(read/write) 75376 75792 416 0.6
.bss 44128 44352 224 0.5
.data.rel.ro 25336 25512 176 0.7
.text 1067202 1068338 1136 0.1
ota-requestor-app debug (read only) 1377457 1378865 1408 0.1
(read/write) 79240 79656 416 0.5
.bss 46592 46816 224 0.5
.data.rel.ro 26664 26840 176 0.7
.text 1149586 1150722 1136 0.1
shell debug (read only) 804641 806049 1408 0.2
(read/write) 66160 66576 416 0.6
.bss 23336 23592 256 1.1
.data.rel.ro 38008 38176 168 0.4
.text 620258 621394 1136 0.2
tv-app debug (read only) 1892929 1894353 1424 0.1
(read/write) 319120 319504 384 0.1
.bss 249944 250168 224 0.1
.data.rel.ro 60712 60880 168 0.3
.text 1586930 1588082 1152 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291296 2291496 200 0.0
.bss 180380 180500 120 0.1
.text 1253896 1254096 200 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2275512 2275712 200 0.0
.bss 172284 172404 120 0.1
.text 1238112 1238312 200 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2251312 2251512 200 0.0
.bss 171100 171220 120 0.1
.text 1213912 1214112 200 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2050936 2051024 88 0.0
.bss 156280 156400 120 0.1
.text 1013536 1013624 88 0.0
p6 all-clusters-app default (read/write) 2304824 2305192 368 0.0
.bss 113368 113488 120 0.1
.text 1263088 1263456 368 0.0
lock-app default (read/write) 2217992 2218360 368 0.0
.bss 100960 101080 120 0.1
.text 1176256 1176624 368 0.0
Decreases (13 builds for linux, mbed, p6)
platform target config section 2490197 cd16ea4 change % change
linux all-clusters-app debug .rodata 138677 138645 -32 -0.0
chip-tool debug .rodata 283930 283866 -64 -0.0
lighting-app debug+rpc .rodata 131633 131569 -64 -0.0
ota-provider-app debug .rodata 114999 114935 -64 -0.1
ota-requestor-app debug .rodata 126408 126344 -64 -0.1
shell debug .rodata 79279 79215 -64 -0.1
tv-app debug .rodata 159549 159485 -64 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 850832 850712 -120 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858576 858456 -120 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859768 859648 -120 -0.0
shell CY8CPROTO_062_4343W+release .heap 875192 875072 -120 -0.0
p6 all-clusters-app default .heap 917440 917320 -120 -0.0
lock-app default .heap 929976 929856 -120 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2490197 cd16ea4 change % change
efr32 lighting-app BRD4161A (read only) 752584 752584 0 0.0
(read/write) 119764 119764 0 0.0
.bss 117956 117956 0 0.0
.data 1808 1808 0 0.0
.text 752576 752576 0 0.0
BRD4161A+rpc (read only) 740068 740068 0 0.0
(read/write) 136392 136392 0 0.0
.bss 134460 134460 0 0.0
.data 1932 1932 0 0.0
.text 740060 740060 0 0.0
lock-app BRD4161A (read only) 729584 729584 0 0.0
(read/write) 117484 117484 0 0.0
.bss 115716 115716 0 0.0
.data 1764 1764 0 0.0
.text 729576 729576 0 0.0
window-app BRD4161A (read only) 733032 733032 0 0.0
(read/write) 117844 117844 0 0.0
.bss 116068 116068 0 0.0
.data 1772 1772 0 0.0
.text 733024 733024 0 0.0
esp32 all-clusters-app c3devkit (read only) 834250 834282 32 0.0
(read/write) 1222370 1222554 184 0.0
.dram0.bss 57832 57952 120 0.2
.dram0.data 14100 14100 0 0.0
.flash.rodata 165176 165248 72 0.0
.flash.text 834250 834282 32 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 905215 905331 116 0.0
(read/write) 421648 421800 152 0.0
.dram0.bss 63192 63312 120 0.2
.dram0.data 34064 34064 0 0.0
.flash.rodata 193112 193144 32 0.0
.flash.text 899831 899947 116 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708716 708716 0 0.0
.bss 77292 77292 0 0.0
.data 1920 1920 0 0.0
.text 623704 623704 0 0.0
lock-app k32w061+debug (read/write) 600048 600048 0 0.0
.bss 67732 67732 0 0.0
.data 1888 1888 0 0.0
.text 524628 524628 0 0.0
shell k32w061+debug (read/write) 665428 665428 0 0.0
.bss 78892 78892 0 0.0
.data 1856 1856 0 0.0
.text 578880 578880 0 0.0
linux all-clusters-app debug (read only) 1751481 1752937 1456 0.1
(read/write) 128944 129360 416 0.3
.bss 58640 58864 224 0.4
.data 1042 1042 0 0.0
.data.rel.ro 63952 64144 192 0.3
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 138677 138645 -32 -0.0
.text 1476162 1477314 1152 0.1
bridge-app debug+rpc (read only) 1330957 1332477 1520 0.1
(read/write) 76920 77336 416 0.5
.bss 41552 41776 224 0.5
.data 1584 1584 0 0.0
.data.rel.ro 28752 28952 200 0.7
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 113276 113276 0 0.0
.text 1119269 1120453 1184 0.1
chip-tool debug (read only) 5916677 5918101 1424 0.0
(read/write) 196224 196608 384 0.2
.bss 39896 40120 224 0.6
.data 2288 2288 0 0.0
.data.rel.ro 148480 148648 168 0.1
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 283930 283866 -64 -0.0
.text 5251829 5252981 1152 0.0
lighting-app debug+rpc (read only) 1600857 1602265 1408 0.1
(read/write) 110168 110552 384 0.3
.bss 47280 47504 224 0.5
.data 1234 1234 0 0.0
.data.rel.ro 56336 56496 160 0.3
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 131633 131569 -64 -0.0
.text 1333186 1334322 1136 0.1
ota-provider-app debug (read only) 1280873 1282281 1408 0.1
(read/write) 75376 75792 416 0.6
.bss 44128 44352 224 0.5
.data 800 800 0 0.0
.data.rel.ro 25336 25512 176 0.7
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 456 456 0 0.0
.rodata 114999 114935 -64 -0.1
.text 1067202 1068338 1136 0.1
ota-requestor-app debug (read only) 1377457 1378865 1408 0.1
(read/write) 79240 79656 416 0.5
.bss 46592 46816 224 0.5
.data 864 864 0 0.0
.data.rel.ro 26664 26840 176 0.7
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 126408 126344 -64 -0.1
.text 1149586 1150722 1136 0.1
shell debug (read only) 804641 806049 1408 0.2
(read/write) 66160 66576 416 0.6
.bss 23336 23592 256 1.1
.data 274 274 0 0.0
.data.rel.ro 38008 38176 168 0.4
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 352 352 0 0.0
.rodata 79279 79215 -64 -0.1
.text 620258 621394 1136 0.2
tv-app debug (read only) 1892929 1894353 1424 0.1
(read/write) 319120 319504 384 0.1
.bss 249944 250168 224 0.1
.data 2784 2784 0 0.0
.data.rel.ro 60712 60880 168 0.3
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159549 159485 -64 -0.0
.text 1586930 1588082 1152 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291296 2291496 200 0.0
.bss 180380 180500 120 0.1
.data 5232 5232 0 0.0
.heap 850832 850712 -120 -0.0
.text 1253896 1254096 200 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275512 2275712 200 0.0
.bss 172284 172404 120 0.1
.data 5584 5584 0 0.0
.heap 858576 858456 -120 -0.0
.text 1238112 1238312 200 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251312 2251512 200 0.0
.bss 171100 171220 120 0.1
.data 5576 5576 0 0.0
.heap 859768 859648 -120 -0.0
.text 1213912 1214112 200 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2051024 88 0.0
.bss 156280 156400 120 0.1
.data 4976 4976 0 0.0
.heap 875192 875072 -120 -0.0
.text 1013536 1013624 88 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 868635 868635 0 0.0
bss 112616 112616 0 0.0
rodata 96180 96180 0 0.0
text 584192 584192 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 831003 831003 0 0.0
bss 108968 108968 0 0.0
rodata 87364 87364 0 0.0
text 558360 558360 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793674 793674 0 0.0
bss 113988 113988 0 0.0
rodata 91436 91436 0 0.0
text 513660 513660 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841755 841755 0 0.0
bss 109648 109648 0 0.0
rodata 92612 92612 0 0.0
text 564044 564044 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 767062 767062 0 0.0
bss 111060 111060 0 0.0
rodata 87920 87920 0 0.0
text 493604 493604 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847867 847867 0 0.0
bss 109788 109788 0 0.0
rodata 94324 94324 0 0.0
text 568228 568228 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841459 841459 0 0.0
bss 109684 109684 0 0.0
rodata 92572 92572 0 0.0
text 563664 563664 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778671 778671 0 0.0
bss 109160 109160 0 0.0
rodata 73196 73196 0 0.0
text 521696 521696 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693678 693678 0 0.0
bss 110144 110144 0 0.0
rodata 67840 67840 0 0.0
text 442304 442304 0 0.0
p6 all-clusters-app default (read/write) 2304824 2305192 368 0.0
.bss 113368 113488 120 0.1
.data 2536 2536 0 0.0
.heap 917440 917320 -120 -0.0
.text 1263088 1263456 368 0.0
lock-app default (read/write) 2217992 2218360 368 0.0
.bss 100960 101080 120 0.1
.data 2408 2408 0 0.0
.heap 929976 929856 -120 -0.0
.text 1176256 1176624 368 0.0
qpg lighting-app qpg6100+debug (read only) 495384 495384 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1016 1016 0 0.0
.text 490064 490064 0 0.0
lock-app qpg6100+debug (read only) 470328 470328 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49208 49208 0 0.0
.data 972 972 0 0.0
.text 465008 465008 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769954 769954 0 0.0
bss 79208 79208 0 0.0
noinit 37160 37160 0 0.0
text 534636 534636 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

PR #12161: Size comparison from 8f73103 to 3f67479

Increases above 0.2%:

platform target config section 8f73103 3f67479 change % change
linux all-clusters-app debug (read/write) 129496 129912 416 0.3
.bss 58608 58832 224 0.4
.data.rel.ro 64432 64624 192 0.3
bridge-app debug+rpc (read/write) 77408 77824 416 0.5
.bss 41488 41712 224 0.5
.data.rel.ro 29200 29400 200 0.7
chip-tool debug (read/write) 197224 197640 416 0.2
.bss 39896 40120 224 0.6
lighting-app debug+rpc (read/write) 110688 111072 384 0.3
.bss 47216 47440 224 0.5
.data.rel.ro 56800 56960 160 0.3
ota-provider-app debug (read/write) 75928 76344 416 0.5
.bss 44128 44352 224 0.5
.data.rel.ro 25784 25960 176 0.7
ota-requestor-app debug (read/write) 79792 80208 416 0.5
.bss 46592 46816 224 0.5
.data.rel.ro 27112 27288 176 0.6
shell debug (read/write) 66584 67032 448 0.7
.bss 23272 23528 256 1.1
.data.rel.ro 38440 38608 168 0.4
tv-app debug .data.rel.ro 61184 61384 200 0.3
Increases (10 builds for linux, p6)
platform target config section 8f73103 3f67479 change % change
linux all-clusters-app debug (read only) 1768145 1769569 1424 0.1
(read/write) 129496 129912 416 0.3
.bss 58608 58832 224 0.4
.data.rel.ro 64432 64624 192 0.3
.text 1491602 1492754 1152 0.1
bridge-app debug+rpc (read only) 1343661 1345181 1520 0.1
(read/write) 77408 77824 416 0.5
.bss 41488 41712 224 0.5
.data.rel.ro 29200 29400 200 0.7
.text 1130837 1132021 1184 0.1
chip-tool debug (read only) 5959917 5961341 1424 0.0
(read/write) 197224 197640 416 0.2
.bss 39896 40120 224 0.6
.data.rel.ro 149368 149568 200 0.1
.text 5292597 5293749 1152 0.0
lighting-app debug+rpc (read only) 1616945 1618369 1424 0.1
(read/write) 110688 111072 384 0.3
.bss 47216 47440 224 0.5
.data.rel.ro 56800 56960 160 0.3
.text 1348130 1349282 1152 0.1
ota-provider-app debug (read only) 1307833 1309257 1424 0.1
(read/write) 75928 76344 416 0.5
.bss 44128 44352 224 0.5
.data.rel.ro 25784 25960 176 0.7
.text 1092962 1094114 1152 0.1
ota-requestor-app debug (read only) 1404337 1405761 1424 0.1
(read/write) 79792 80208 416 0.5
.bss 46592 46816 224 0.5
.data.rel.ro 27112 27288 176 0.6
.text 1175266 1176418 1152 0.1
shell debug (read only) 820345 821753 1408 0.2
(read/write) 66584 67032 448 0.7
.bss 23272 23528 256 1.1
.data.rel.ro 38440 38608 168 0.4
.text 634802 635938 1136 0.2
tv-app debug (read only) 1913497 1914953 1456 0.1
(read/write) 319704 320152 448 0.1
.bss 249976 250200 224 0.1
.data.rel.ro 61184 61384 200 0.3
.text 1606290 1607442 1152 0.1
p6 all-clusters-app default (read/write) 2309800 2310168 368 0.0
.bss 113384 113504 120 0.1
.text 1268064 1268432 368 0.0
lock-app default (read/write) 2221784 2222152 368 0.0
.bss 100968 101088 120 0.1
.text 1180048 1180416 368 0.0
Decreases (9 builds for linux, p6)
platform target config section 8f73103 3f67479 change % change
linux all-clusters-app debug .rodata 138485 138421 -64 -0.0
chip-tool debug .rodata 283954 283890 -64 -0.0
lighting-app debug+rpc .rodata 131409 131345 -64 -0.0
ota-provider-app debug .rodata 114831 114767 -64 -0.1
ota-requestor-app debug .rodata 126240 126176 -64 -0.1
shell debug .rodata 79119 79055 -64 -0.1
tv-app debug .rodata 159317 159285 -32 -0.0
p6 all-clusters-app default .heap 917424 917304 -120 -0.0
lock-app default .heap 929960 929840 -120 -0.0
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 8f73103 3f67479 change % change
efr32 lighting-app BRD4161A (read only) 757712 757712 0 0.0
(read/write) 119796 119796 0 0.0
.bss 117980 117980 0 0.0
.data 1812 1812 0 0.0
.text 757704 757704 0 0.0
BRD4161A+rpc (read only) 745172 745172 0 0.0
(read/write) 136420 136420 0 0.0
.bss 134484 134484 0 0.0
.data 1936 1936 0 0.0
.text 745164 745164 0 0.0
lock-app BRD4161A (read only) 733568 733568 0 0.0
(read/write) 117508 117508 0 0.0
.bss 115740 115740 0 0.0
.data 1768 1768 0 0.0
.text 733560 733560 0 0.0
window-app BRD4161A (read only) 737016 737016 0 0.0
(read/write) 117868 117868 0 0.0
.bss 116092 116092 0 0.0
.data 1776 1776 0 0.0
.text 737008 737008 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 711916 711916 0 0.0
.bss 77316 77316 0 0.0
.data 1924 1924 0 0.0
.text 626876 626876 0 0.0
lock-app k32w061+debug (read/write) 602112 602112 0 0.0
.bss 67756 67756 0 0.0
.data 1892 1892 0 0.0
.text 526664 526664 0 0.0
shell k32w061+debug (read/write) 667608 667608 0 0.0
.bss 78916 78916 0 0.0
.data 1860 1860 0 0.0
.text 581032 581032 0 0.0
linux all-clusters-app debug (read only) 1768145 1769569 1424 0.1
(read/write) 129496 129912 416 0.3
.bss 58608 58832 224 0.4
.data 1138 1138 0 0.0
.data.rel.ro 64432 64624 192 0.3
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138485 138421 -64 -0.0
.text 1491602 1492754 1152 0.1
bridge-app debug+rpc (read only) 1343661 1345181 1520 0.1
(read/write) 77408 77824 416 0.5
.bss 41488 41712 224 0.5
.data 1680 1680 0 0.0
.data.rel.ro 29200 29400 200 0.7
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113044 113044 0 0.0
.text 1130837 1132021 1184 0.1
chip-tool debug (read only) 5959917 5961341 1424 0.0
(read/write) 197224 197640 416 0.2
.bss 39896 40120 224 0.6
.data 2384 2384 0 0.0
.data.rel.ro 149368 149568 200 0.1
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283954 283890 -64 -0.0
.text 5292597 5293749 1152 0.0
lighting-app debug+rpc (read only) 1616945 1618369 1424 0.1
(read/write) 110688 111072 384 0.3
.bss 47216 47440 224 0.5
.data 1330 1330 0 0.0
.data.rel.ro 56800 56960 160 0.3
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131409 131345 -64 -0.0
.text 1348130 1349282 1152 0.1
ota-provider-app debug (read only) 1307833 1309257 1424 0.1
(read/write) 75928 76344 416 0.5
.bss 44128 44352 224 0.5
.data 880 880 0 0.0
.data.rel.ro 25784 25960 176 0.7
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114831 114767 -64 -0.1
.text 1092962 1094114 1152 0.1
ota-requestor-app debug (read only) 1404337 1405761 1424 0.1
(read/write) 79792 80208 416 0.5
.bss 46592 46816 224 0.5
.data 944 944 0 0.0
.data.rel.ro 27112 27288 176 0.6
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126240 126176 -64 -0.1
.text 1175266 1176418 1152 0.1
shell debug (read only) 820345 821753 1408 0.2
(read/write) 66584 67032 448 0.7
.bss 23272 23528 256 1.1
.data 338 338 0 0.0
.data.rel.ro 38440 38608 168 0.4
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79119 79055 -64 -0.1
.text 634802 635938 1136 0.2
tv-app debug (read only) 1913497 1914953 1456 0.1
(read/write) 319704 320152 448 0.1
.bss 249976 250200 224 0.1
.data 2880 2880 0 0.0
.data.rel.ro 61184 61384 200 0.3
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159317 159285 -32 -0.0
.text 1606290 1607442 1152 0.1
p6 all-clusters-app default (read/write) 2309800 2310168 368 0.0
.bss 113384 113504 120 0.1
.data 2536 2536 0 0.0
.heap 917424 917304 -120 -0.0
.text 1268064 1268432 368 0.0
lock-app default (read/write) 2221784 2222152 368 0.0
.bss 100968 101088 120 0.1
.data 2416 2416 0 0.0
.heap 929960 929840 -120 -0.0
.text 1180048 1180416 368 0.0
qpg lighting-app qpg6100+debug (read only) 498644 498644 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50360 0 0.0
.data 1020 1020 0 0.0
.text 493324 493324 0 0.0
lock-app qpg6100+debug (read only) 472548 472548 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49232 0 0.0
.data 976 976 0 0.0
.text 467228 467228 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 773510 773510 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 537292 537292 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

PR #12161: Size comparison from e0a8db7 to f3afbcf

Increases above 0.2%:

platform target config section e0a8db7 f3afbcf change % change
esp32 all-clusters-app c3devkit .dram0.bss 57824 57944 120 0.2
linux all-clusters-app debug (read/write) 129432 129848 416 0.3
.bss 58576 58800 224 0.4
.data.rel.ro 64384 64576 192 0.3
bridge-app debug+rpc (read/write) 77312 77760 448 0.6
.bss 41456 41680 224 0.5
.data.rel.ro 29152 29352 200 0.7
chip-tool debug .bss 39840 40064 224 0.6
lighting-app debug+rpc (read/write) 110624 111008 384 0.3
.bss 47184 47408 224 0.5
.data.rel.ro 56752 56912 160 0.3
ota-provider-app debug (read/write) 75864 76248 384 0.5
.bss 44064 44288 224 0.5
.data.rel.ro 25736 25912 176 0.7
ota-requestor-app debug (read/write) 79728 80112 384 0.5
.bss 46528 46752 224 0.5
.data.rel.ro 27064 27240 176 0.7
shell debug (read/write) 66520 66936 416 0.6
.bss 23240 23496 256 1.1
.data.rel.ro 38392 38560 168 0.4
tv-app debug .data.rel.ro 61136 61336 200 0.3
Increases (16 builds for esp32, linux, mbed, p6)
platform target config section e0a8db7 f3afbcf change % change
esp32 all-clusters-app c3devkit (read only) 835272 835304 32 0.0
(read/write) 1222362 1222570 208 0.0
.dram0.bss 57824 57944 120 0.2
.flash.rodata 165184 165264 80 0.0
.flash.text 835272 835304 32 0.0
m5stack (read only) 906691 906815 124 0.0
(read/write) 421676 421828 152 0.0
.dram0.bss 63216 63336 120 0.2
.flash.rodata 193108 193140 32 0.0
.flash.text 901307 901431 124 0.0
linux all-clusters-app debug (read only) 1765289 1766713 1424 0.1
(read/write) 129432 129848 416 0.3
.bss 58576 58800 224 0.4
.data.rel.ro 64384 64576 192 0.3
.text 1488946 1490098 1152 0.1
bridge-app debug+rpc (read only) 1340813 1342333 1520 0.1
(read/write) 77312 77760 448 0.6
.bss 41456 41680 224 0.5
.data.rel.ro 29152 29352 200 0.7
.text 1128181 1129365 1184 0.1
chip-tool debug (read only) 5957085 5958509 1424 0.0
(read/write) 197104 197552 448 0.2
.bss 39840 40064 224 0.6
.data.rel.ro 149320 149520 200 0.1
.text 5289941 5291093 1152 0.0
lighting-app debug+rpc (read only) 1614089 1615513 1424 0.1
(read/write) 110624 111008 384 0.3
.bss 47184 47408 224 0.5
.data.rel.ro 56752 56912 160 0.3
.text 1345474 1346626 1152 0.1
ota-provider-app debug (read only) 1304977 1306401 1424 0.1
(read/write) 75864 76248 384 0.5
.bss 44064 44288 224 0.5
.data.rel.ro 25736 25912 176 0.7
.text 1090306 1091458 1152 0.1
ota-requestor-app debug (read only) 1401513 1402937 1424 0.1
(read/write) 79728 80112 384 0.5
.bss 46528 46752 224 0.5
.data.rel.ro 27064 27240 176 0.7
.text 1172610 1173762 1152 0.1
shell debug (read only) 818721 820129 1408 0.2
(read/write) 66520 66936 416 0.6
.bss 23240 23496 256 1.1
.data.rel.ro 38392 38560 168 0.4
.text 633378 634514 1136 0.2
tv-app debug (read only) 1910657 1912113 1456 0.1
(read/write) 319624 320056 432 0.1
.bss 249928 250168 240 0.1
.data.rel.ro 61136 61336 200 0.3
.text 1603634 1604786 1152 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293808 2294016 208 0.0
.bss 180380 180500 120 0.1
.text 1256408 1256616 208 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2277984 2278248 264 0.0
.bss 172276 172396 120 0.1
.text 1240584 1240848 264 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252368 2252568 200 0.0
.bss 171092 171212 120 0.1
.text 1214968 1215168 200 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2050648 2050800 152 0.0
.bss 156304 156424 120 0.1
.text 1013248 1013400 152 0.0
p6 all-clusters-app default (read/write) 2309128 2309496 368 0.0
.bss 113368 113488 120 0.1
.text 1267392 1267760 368 0.0
lock-app default (read/write) 2221104 2221472 368 0.0
.bss 100952 101072 120 0.1
.text 1179368 1179736 368 0.0
Decreases (13 builds for linux, mbed, p6)
platform target config section e0a8db7 f3afbcf change % change
linux all-clusters-app debug .rodata 138357 138293 -64 -0.0
chip-tool debug .rodata 283848 283784 -64 -0.0
lighting-app debug+rpc .rodata 131281 131217 -64 -0.0
ota-provider-app debug .rodata 114704 114640 -64 -0.1
ota-requestor-app debug .rodata 126144 126080 -64 -0.1
shell debug .rodata 78991 78927 -64 -0.1
tv-app debug .rodata 159208 159176 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 850824 850704 -120 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858568 858448 -120 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859768 859648 -120 -0.0
shell CY8CPROTO_062_4343W+release .heap 875160 875040 -120 -0.0
p6 all-clusters-app default .heap 917432 917312 -120 -0.0
lock-app default .heap 929976 929856 -120 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e0a8db7 f3afbcf change % change
efr32 lighting-app BRD4161A (read only) 757048 757048 0 0.0
(read/write) 119780 119780 0 0.0
.bss 117964 117964 0 0.0
.data 1816 1816 0 0.0
.text 757040 757040 0 0.0
BRD4161A+rpc (read only) 744508 744508 0 0.0
(read/write) 136408 136408 0 0.0
.bss 134468 134468 0 0.0
.data 1940 1940 0 0.0
.text 744500 744500 0 0.0
lock-app BRD4161A (read only) 732920 732920 0 0.0
(read/write) 117500 117500 0 0.0
.bss 115724 115724 0 0.0
.data 1772 1772 0 0.0
.text 732912 732912 0 0.0
window-app BRD4161A (read only) 736352 736352 0 0.0
(read/write) 117860 117860 0 0.0
.bss 116076 116076 0 0.0
.data 1780 1780 0 0.0
.text 736344 736344 0 0.0
esp32 all-clusters-app c3devkit (read only) 835272 835304 32 0.0
(read/write) 1222362 1222570 208 0.0
.dram0.bss 57824 57944 120 0.2
.dram0.data 14100 14100 0 0.0
.flash.rodata 165184 165264 80 0.0
.flash.text 835272 835304 32 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 906691 906815 124 0.0
(read/write) 421676 421828 152 0.0
.dram0.bss 63216 63336 120 0.2
.dram0.data 34072 34072 0 0.0
.flash.rodata 193108 193140 32 0.0
.flash.text 901307 901431 124 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 710956 710956 0 0.0
.bss 77300 77300 0 0.0
.data 1928 1928 0 0.0
.text 625928 625928 0 0.0
lock-app k32w061+debug (read/write) 601168 601168 0 0.0
.bss 67740 67740 0 0.0
.data 1896 1896 0 0.0
.text 525732 525732 0 0.0
shell k32w061+debug (read/write) 666652 666652 0 0.0
.bss 78900 78900 0 0.0
.data 1864 1864 0 0.0
.text 580088 580088 0 0.0
linux all-clusters-app debug (read only) 1765289 1766713 1424 0.1
(read/write) 129432 129848 416 0.3
.bss 58576 58800 224 0.4
.data 1170 1170 0 0.0
.data.rel.ro 64384 64576 192 0.3
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138357 138293 -64 -0.0
.text 1488946 1490098 1152 0.1
bridge-app debug+rpc (read only) 1340813 1342333 1520 0.1
(read/write) 77312 77760 448 0.6
.bss 41456 41680 224 0.5
.data 1680 1680 0 0.0
.data.rel.ro 29152 29352 200 0.7
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 112924 112924 0 0.0
.text 1128181 1129365 1184 0.1
chip-tool debug (read only) 5957085 5958509 1424 0.0
(read/write) 197104 197552 448 0.2
.bss 39840 40064 224 0.6
.data 2384 2384 0 0.0
.data.rel.ro 149320 149520 200 0.1
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283848 283784 -64 -0.0
.text 5289941 5291093 1152 0.0
lighting-app debug+rpc (read only) 1614089 1615513 1424 0.1
(read/write) 110624 111008 384 0.3
.bss 47184 47408 224 0.5
.data 1362 1362 0 0.0
.data.rel.ro 56752 56912 160 0.3
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131281 131217 -64 -0.0
.text 1345474 1346626 1152 0.1
ota-provider-app debug (read only) 1304977 1306401 1424 0.1
(read/write) 75864 76248 384 0.5
.bss 44064 44288 224 0.5
.data 912 912 0 0.0
.data.rel.ro 25736 25912 176 0.7
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114704 114640 -64 -0.1
.text 1090306 1091458 1152 0.1
ota-requestor-app debug (read only) 1401513 1402937 1424 0.1
(read/write) 79728 80112 384 0.5
.bss 46528 46752 224 0.5
.data 976 976 0 0.0
.data.rel.ro 27064 27240 176 0.7
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126144 126080 -64 -0.1
.text 1172610 1173762 1152 0.1
shell debug (read only) 818721 820129 1408 0.2
(read/write) 66520 66936 416 0.6
.bss 23240 23496 256 1.1
.data 338 338 0 0.0
.data.rel.ro 38392 38560 168 0.4
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78991 78927 -64 -0.1
.text 633378 634514 1136 0.2
tv-app debug (read only) 1910657 1912113 1456 0.1
(read/write) 319624 320056 432 0.1
.bss 249928 250168 240 0.1
.data 2880 2880 0 0.0
.data.rel.ro 61136 61336 200 0.3
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159208 159176 -32 -0.0
.text 1603634 1604786 1152 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293808 2294016 208 0.0
.bss 180380 180500 120 0.1
.data 5240 5240 0 0.0
.heap 850824 850704 -120 -0.0
.text 1256408 1256616 208 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277984 2278248 264 0.0
.bss 172276 172396 120 0.1
.data 5600 5600 0 0.0
.heap 858568 858448 -120 -0.0
.text 1240584 1240848 264 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252368 2252568 200 0.0
.bss 171092 171212 120 0.1
.data 5584 5584 0 0.0
.heap 859768 859648 -120 -0.0
.text 1214968 1215168 200 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050648 2050800 152 0.0
.bss 156304 156424 120 0.1
.data 4984 4984 0 0.0
.heap 875160 875040 -120 -0.0
.text 1013248 1013400 152 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 870899 870899 0 0.0
bss 112624 112624 0 0.0
rodata 96476 96476 0 0.0
text 586156 586156 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 833267 833267 0 0.0
bss 108976 108976 0 0.0
rodata 87660 87660 0 0.0
text 560324 560324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795942 795942 0 0.0
bss 113996 113996 0 0.0
rodata 91736 91736 0 0.0
text 515616 515616 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 842991 842991 0 0.0
bss 109656 109656 0 0.0
rodata 92480 92480 0 0.0
text 565400 565400 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 768262 768262 0 0.0
bss 111068 111068 0 0.0
rodata 87768 87768 0 0.0
text 494952 494952 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 849123 849123 0 0.0
bss 109796 109796 0 0.0
rodata 94188 94188 0 0.0
text 569580 569580 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 842683 842683 0 0.0
bss 109692 109692 0 0.0
rodata 92436 92436 0 0.0
text 565020 565020 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778311 778311 0 0.0
bss 109168 109168 0 0.0
rodata 72996 72996 0 0.0
text 521532 521532 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693350 693350 0 0.0
bss 110152 110152 0 0.0
rodata 67640 67640 0 0.0
text 442140 442140 0 0.0
p6 all-clusters-app default (read/write) 2309128 2309496 368 0.0
.bss 113368 113488 120 0.1
.data 2544 2544 0 0.0
.heap 917432 917312 -120 -0.0
.text 1267392 1267760 368 0.0
lock-app default (read/write) 2221104 2221472 368 0.0
.bss 100952 101072 120 0.1
.data 2416 2416 0 0.0
.heap 929976 929856 -120 -0.0
.text 1179368 1179736 368 0.0
qpg lighting-app qpg6100+debug (read only) 498644 498644 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50360 0 0.0
.data 1020 1020 0 0.0
.text 493324 493324 0 0.0
lock-app qpg6100+debug (read only) 472548 472548 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49232 0 0.0
.data 976 976 0 0.0
.text 467228 467228 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 772274 772274 0 0.0
bss 79200 79200 0 0.0
noinit 37160 37160 0 0.0
text 536388 536388 0 0.0

@andy31415
Copy link
Contributor Author

fast track: change has been up for sufficient time for cross-timezone review, has several checkmarks and minmdns functionality is exercised a lot during CI (all yaml intergration tests use mdns for provisioning and discovery)

@andy31415 andy31415 merged commit 8bfdc13 into project-chip:master Nov 24, 2021
@andy31415 andy31415 mentioned this pull request Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tcarmelveilleux @msandstedt @yunhanw-google