Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transitional support to access control #12110

Merged

Conversation

mlepage-google
Copy link
Contributor

During development, let access control delegates declare they are
transitional, so access is allowed. This is the default for now,
but won't be once the rest of the system is in place.

In particular, unit tests are not transitional and do test functional
access control (allow and deny).

During development, let access control delegates declare they are
transitional, so access is allowed. This is the default for now,
but won't be once the rest of the system is in place.

In particular, unit tests are not transitional and do test functional
access control (allow and deny).
@github-actions
Copy link

github-actions bot commented Nov 22, 2021

PR #12110: Size comparison from 63ea01b to 387af13

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 63ea01b 387af13 change % change
efr32 lighting-app BRD4161A (read only) 750752 750752 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750744 750744 0 0.0
BRD4161A+rpc (read only) 738292 738292 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 738284 738284 0 0.0
lock-app BRD4161A (read only) 727824 727824 0 0.0
(read/write) 117476 117476 0 0.0
.bss 115716 115716 0 0.0
.data 1756 1756 0 0.0
.text 727816 727816 0 0.0
window-app BRD4161A (read only) 731272 731272 0 0.0
(read/write) 117836 117836 0 0.0
.bss 116068 116068 0 0.0
.data 1764 1764 0 0.0
.text 731264 731264 0 0.0
esp32 all-clusters-app c3devkit (read only) 833422 833422 0 0.0
(read/write) 1221938 1221938 0 0.0
.dram0.bss 57752 57752 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 164840 164840 0 0.0
.flash.text 833422 833422 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904443 904443 0 0.0
(read/write) 421232 421232 0 0.0
.dram0.bss 63112 63112 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192784 192784 0 0.0
.flash.text 899059 899059 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707544 707544 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622620 622620 0 0.0
lock-app k32w061+debug (read/write) 598976 598976 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523580 523580 0 0.0
shell k32w061+debug (read/write) 664352 664352 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577828 577828 0 0.0
linux all-clusters-app debug (read only) 1746633 1746633 0 0.0
(read/write) 128392 128392 0 0.0
.bss 58544 58544 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63504 63504 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 137781 137781 0 0.0
.text 1473218 1473218 0 0.0
bridge-app debug+rpc (read only) 1326445 1326445 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112316 112316 0 0.0
.text 1116725 1116725 0 0.0
chip-tool debug (read only) 5867333 5867333 0 0.0
(read/write) 195496 195496 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 147872 147872 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 278122 278122 0 0.0
.text 5210181 5210181 0 0.0
lighting-app debug+rpc (read only) 1595553 1595553 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129937 129937 0 0.0
.text 1330610 1330610 0 0.0
ota-provider-app debug (read only) 1273993 1273993 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114335 114335 0 0.0
.text 1062066 1062066 0 0.0
ota-requestor-app debug (read only) 1370241 1370241 0 0.0
(read/write) 78912 78912 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26408 26408 0 0.0
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125736 125736 0 0.0
.text 1144130 1144130 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1888169 1888169 0 0.0
(read/write) 318520 318520 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158629 158629 0 0.0
.text 1584098 1584098 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290256 2290256 0 0.0
.bss 180308 180308 0 0.0
.data 5224 5224 0 0.0
.heap 850912 850912 0 0.0
.text 1252856 1252856 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274384 2274384 0 0.0
.bss 172204 172204 0 0.0
.data 5576 5576 0 0.0
.heap 858664 858664 0 0.0
.text 1236984 1236984 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250224 2250224 0 0.0
.bss 171092 171092 0 0.0
.data 5568 5568 0 0.0
.heap 859784 859784 0 0.0
.text 1212824 1212824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050544 2050544 0 0.0
.bss 156280 156280 0 0.0
.data 4968 4968 0 0.0
.heap 875200 875200 0 0.0
.text 1013144 1013144 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865267 865267 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 583212 583212 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827635 827635 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557380 557380 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790322 790322 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512684 512684 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840667 840667 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563308 563308 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765970 765970 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492868 492868 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846807 846807 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567488 567488 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840367 840367 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562928 562928 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2303048 2303048 0 0.0
.bss 113280 113280 0 0.0
.data 2528 2528 0 0.0
.heap 917536 917536 0 0.0
.text 1261312 1261312 0 0.0
lock-app default (read/write) 2216248 2216248 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174512 1174512 0 0.0
qpg lighting-app qpg6100+debug (read only) 494320 494320 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 489000 489000 0 0.0
lock-app qpg6100+debug (read only) 469276 469276 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463956 463956 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768698 768698 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533836 533836 0 0.0

@andy31415
Copy link
Contributor

fast track : trivial change created by a domain owner

@andy31415 andy31415 merged commit 53721c0 into project-chip:master Nov 22, 2021
@mlepage-google mlepage-google deleted the access-control-transitional branch February 15, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants