Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to ask a CommandHandler for a fabric index. #12005

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Add a way to ask a CommandHandler for a fabric index. #12005

merged 1 commit into from
Nov 22, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

This returns the accessing fabric index.

Problem

People have to keep doing the "get exchange context, get session, etc" bits. This is implementation detail that should not be relevant.

Change overview

Expose GetFabricIndex() directly on CommandHandler.

Testing

No behavior changes.

@boring-cyborg boring-cyborg bot added the app label Nov 18, 2021
@github-actions
Copy link

github-actions bot commented Nov 19, 2021 •
edited
Loading

PR #12005: Size comparison from ebadd33 to 617b11e

Increases (1 build for esp32)
platform target config section ebadd33 617b11e change % change
esp32 all-clusters-app m5stack (read only) 899595 899599 4 0.0
.flash.text 894211 894215 4 0.0
Decreases (23 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section ebadd33 617b11e change % change
efr32 lighting-app BRD4161A (read only) 749960 749944 -16 -0.0
.text 749952 749936 -16 -0.0
window-app BRD4161A (read only) 728000 727984 -16 -0.0
.text 727992 727976 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 828538 828524 -14 -0.0
.flash.text 828538 828524 -14 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 706872 706856 -16 -0.0
.text 621996 621980 -16 -0.0
lock-app k32w061+debug (read/write) 598312 598280 -32 -0.0
.text 522956 522924 -32 -0.0
shell k32w061+debug (read/write) 663656 663624 -32 -0.0
.text 577204 577172 -32 -0.0
linux all-clusters-app debug (read only) 1726153 1726121 -32 -0.0
.text 1455538 1455506 -32 -0.0
bridge-app debug+rpc (read only) 1321181 1321165 -16 -0.0
.text 1111845 1111829 -16 -0.0
lighting-app debug+rpc (read only) 1590289 1590273 -16 -0.0
.text 1325730 1325714 -16 -0.0
ota-provider-app debug (read only) 1268729 1268713 -16 -0.0
.text 1057186 1057170 -16 -0.0
ota-requestor-app debug (read only) 1354465 1354449 -16 -0.0
.text 1129522 1129506 -16 -0.0
tv-app debug (read only) 1872785 1872769 -16 -0.0
.text 1569762 1569746 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2249456 2249392 -64 -0.0
.text 1212056 1211992 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864595 864579 -16 -0.0
text 582604 582580 -24 -0.0
nrf52840dk_nrf52840+rpc (read/write) 826995 826979 -16 -0.0
text 556772 556748 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789650 789618 -32 -0.0
text 512076 512052 -24 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840027 839995 -32 -0.0
text 562696 562672 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765330 765298 -32 -0.0
text 492260 492236 -24 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 846135 846119 -16 -0.0
text 566880 566856 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839727 839695 -32 -0.0
text 562316 562292 -24 -0.0
qpg lighting-app qpg6100+debug (read only) 493688 493656 -32 -0.0
.text 488368 488336 -32 -0.0
lock-app qpg6100+debug (read only) 468652 468636 -16 -0.0
.text 463332 463316 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 768010 767994 -16 -0.0
text 533194 533182 -12 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ebadd33 617b11e change % change
efr32 lighting-app BRD4161A (read only) 749960 749944 -16 -0.0
(read/write) 115540 115540 0 0.0
.bss 113740 113740 0 0.0
.data 1800 1800 0 0.0
.text 749952 749936 -16 -0.0
BRD4161A+rpc (read only) 737484 737484 0 0.0
(read/write) 132168 132168 0 0.0
.bss 130244 130244 0 0.0
.data 1924 1924 0 0.0
.text 737476 737476 0 0.0
lock-app BRD4161A (read only) 727016 727016 0 0.0
(read/write) 113324 113324 0 0.0
.bss 111564 111564 0 0.0
.data 1756 1756 0 0.0
.text 727008 727008 0 0.0
window-app BRD4161A (read only) 728000 727984 -16 -0.0
(read/write) 113644 113644 0 0.0
.bss 111884 111884 0 0.0
.data 1760 1760 0 0.0
.text 727992 727976 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 828538 828524 -14 -0.0
(read/write) 1220178 1220178 0 0.0
.dram0.bss 56688 56688 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164152 164152 0 0.0
.flash.text 828538 828524 -14 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899595 899599 4 0.0
(read/write) 419492 419492 0 0.0
.dram0.bss 62040 62040 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192116 192116 0 0.0
.flash.text 894211 894215 4 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706872 706856 -16 -0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 621996 621980 -16 -0.0
lock-app k32w061+debug (read/write) 598312 598280 -32 -0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 522956 522924 -32 -0.0
shell k32w061+debug (read/write) 663656 663624 -32 -0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 577204 577172 -32 -0.0
linux all-clusters-app debug (read only) 1726153 1726121 -32 -0.0
(read/write) 126816 126816 0 0.0
.bss 57392 57392 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136661 136661 0 0.0
.text 1455538 1455506 -32 -0.0
bridge-app debug+rpc (read only) 1321181 1321165 -16 -0.0
(read/write) 77008 77008 0 0.0
.bss 42096 42096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111932 111932 0 0.0
.text 1111845 1111829 -16 -0.0
chip-tool debug (read only) 4986061 4986061 0 0.0
(read/write) 166888 166888 0 0.0
.bss 40456 40456 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118672 118672 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268458 268458 0 0.0
.text 4407093 4407093 0 0.0
lighting-app debug+rpc (read only) 1590289 1590273 -16 -0.0
(read/write) 110224 110224 0 0.0
.bss 47760 47760 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129553 129553 0 0.0
.text 1325730 1325714 -16 -0.0
ota-provider-app debug (read only) 1268729 1268713 -16 -0.0
(read/write) 75656 75656 0 0.0
.bss 44704 44704 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113951 113951 0 0.0
.text 1057186 1057170 -16 -0.0
ota-requestor-app debug (read only) 1354465 1354449 -16 -0.0
(read/write) 79392 79392 0 0.0
.bss 47168 47168 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124968 124968 0 0.0
.text 1129522 1129506 -16 -0.0
shell debug (read only) 798801 798801 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616082 616082 0 0.0
tv-app debug (read only) 1872785 1872769 -16 -0.0
(read/write) 318968 318968 0 0.0
.bss 250376 250376 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60144 60144 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157893 157893 0 0.0
.text 1569762 1569746 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287616 2287616 0 0.0
.bss 179284 179284 0 0.0
.data 5216 5216 0 0.0
.heap 851944 851944 0 0.0
.text 1250216 1250216 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273552 2273552 0 0.0
.bss 172148 172148 0 0.0
.data 5576 5576 0 0.0
.heap 858720 858720 0 0.0
.text 1236152 1236152 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249456 2249392 -64 -0.0
.bss 171036 171036 0 0.0
.data 5568 5568 0 0.0
.heap 859840 859840 0 0.0
.text 1212056 1211992 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864595 864579 -16 -0.0
bss 110560 110560 0 0.0
rodata 95828 95828 0 0.0
text 582604 582580 -24 -0.0
nrf52840dk_nrf52840+rpc (read/write) 826995 826979 -16 -0.0
bss 106916 106916 0 0.0
rodata 87012 87012 0 0.0
text 556772 556748 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789650 789618 -32 -0.0
bss 111936 111936 0 0.0
rodata 91084 91084 0 0.0
text 512076 512052 -24 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840027 839995 -32 -0.0
bss 109584 109584 0 0.0
rodata 92300 92300 0 0.0
text 562696 562672 -24 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765330 765298 -32 -0.0
bss 110996 110996 0 0.0
rodata 87604 87604 0 0.0
text 492260 492236 -24 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846135 846119 -16 -0.0
bss 109724 109724 0 0.0
rodata 94008 94008 0 0.0
text 566880 566856 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839727 839695 -32 -0.0
bss 109620 109620 0 0.0
rodata 92256 92256 0 0.0
text 562316 562292 -24 -0.0
shell nrf52840dk_nrf52840 (read/write) 777971 777971 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521236 521236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693026 693026 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441848 441848 0 0.0
p6 all-clusters-app default (read/write) 2297968 2297968 0 0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1256232 1256232 0 0.0
lock-app default (read/write) 2215456 2215456 0 0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1173720 1173720 0 0.0
qpg lighting-app qpg6100+debug (read only) 493688 493656 -32 -0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488368 488336 -32 -0.0
lock-app qpg6100+debug (read only) 468652 468636 -16 -0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463332 463316 -16 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768010 767994 -16 -0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 533194 533182 -12 -0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 19, 2021
Closed
@bzbarsky-apple
Copy link
Contributor Author

Note: Going to change the name to GetAccessingFabricIndex.

@bzbarsky-apple
Add a way to ask a CommandHandler for a fabric index.
0592332 
This returns the accessing fabric index.
@bzbarsky-apple bzbarsky-apple force-pushed the add-command-fabric-index branch from 617b11e to 0592332 Compare November 19, 2021 16:51
@mlepage-google
Copy link
Contributor

FYI the fabric index is a member of the SubjectDescriptor which is provided for checking Access Control. You can see it is being added in my "access control hookup PR" #10581

@github-actions
Copy link

github-actions bot commented Nov 19, 2021 •
edited
Loading

PR #12005: Size comparison from dcca930 to 0592332

Increases (7 builds for linux)
platform target config section dcca930 0592332 change % change
linux all-clusters-app debug (read only) 1729401 1729545 144 0.0
.rodata 136757 136917 160 0.1
bridge-app debug+rpc (read only) 1324429 1324541 112 0.0
.rodata 112028 112156 128 0.1
chip-tool debug (read only) 4985837 4985965 128 0.0
.rodata 268458 268586 128 0.0
lighting-app debug+rpc (read only) 1593521 1593665 144 0.0
.rodata 129617 129777 160 0.1
ota-provider-app debug (read only) 1271993 1272089 96 0.0
.rodata 114047 114175 128 0.1
ota-requestor-app debug (read only) 1357729 1357841 112 0.0
.rodata 125064 125192 128 0.1
tv-app debug (read only) 1875841 1875953 112 0.0
.rodata 157989 158117 128 0.1
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dcca930 0592332 change % change
efr32 lighting-app BRD4161A (read only) 750408 750280 -128 -0.0
.text 750400 750272 -128 -0.0
BRD4161A+rpc (read only) 737948 737820 -128 -0.0
.text 737940 737812 -128 -0.0
lock-app BRD4161A (read only) 727464 727352 -112 -0.0
.text 727456 727344 -112 -0.0
window-app BRD4161A (read only) 728448 728320 -128 -0.0
.text 728440 728312 -128 -0.0
esp32 all-clusters-app c3devkit (read only) 828870 828858 -12 -0.0
.flash.text 828870 828858 -12 -0.0
m5stack (read only) 899875 899867 -8 -0.0
.flash.text 894491 894483 -8 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 707240 707208 -32 -0.0
.text 622364 622332 -32 -0.0
lock-app k32w061+debug (read/write) 598680 598648 -32 -0.0
.text 523324 523292 -32 -0.0
shell k32w061+debug (read/write) 664024 663992 -32 -0.0
.text 577572 577540 -32 -0.0
linux all-clusters-app debug .text 1458690 1458674 -16 -0.0
bridge-app debug+rpc .text 1114997 1114981 -16 -0.0
lighting-app debug+rpc .text 1328898 1328882 -16 -0.0
ota-provider-app debug .text 1060354 1060322 -32 -0.0
ota-requestor-app debug .text 1132690 1132674 -16 -0.0
tv-app debug .text 1572722 1572706 -16 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2249840 2249776 -64 -0.0
.text 1212440 1212376 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864963 864931 -32 -0.0
text 582960 582932 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 827363 827331 -32 -0.0
text 557128 557100 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790002 789970 -32 -0.0
text 512432 512404 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840379 840347 -32 -0.0
text 563056 563024 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765682 765650 -32 -0.0
text 492620 492588 -32 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 846487 846471 -16 -0.0
text 567236 567208 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840079 840047 -32 -0.0
text 562676 562644 -32 -0.0
p6 all-clusters-app default (read/write) 2298416 2298304 -112 -0.0
.text 1256680 1256568 -112 -0.0
lock-app default (read/write) 2215904 2215776 -128 -0.0
.text 1174168 1174040 -128 -0.0
qpg lighting-app qpg6100+debug (read only) 494072 494040 -32 -0.0
.text 488752 488720 -32 -0.0
lock-app qpg6100+debug (read only) 469036 469004 -32 -0.0
.text 463716 463684 -32 -0.0
telink lighting-app tlsr9518adk80d (read/write) 768346 768330 -16 -0.0
text 533530 533518 -12 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dcca930 0592332 change % change
efr32 lighting-app BRD4161A (read only) 750408 750280 -128 -0.0
(read/write) 119644 119644 0 0.0
.bss 117844 117844 0 0.0
.data 1800 1800 0 0.0
.text 750400 750272 -128 -0.0
BRD4161A+rpc (read only) 737948 737820 -128 -0.0
(read/write) 136272 136272 0 0.0
.bss 134348 134348 0 0.0
.data 1924 1924 0 0.0
.text 737940 737812 -128 -0.0
lock-app BRD4161A (read only) 727464 727352 -112 -0.0
(read/write) 113332 113332 0 0.0
.bss 111572 111572 0 0.0
.data 1756 1756 0 0.0
.text 727456 727344 -112 -0.0
window-app BRD4161A (read only) 728448 728320 -128 -0.0
(read/write) 113652 113652 0 0.0
.bss 111892 111892 0 0.0
.data 1760 1760 0 0.0
.text 728440 728312 -128 -0.0
esp32 all-clusters-app c3devkit (read only) 828870 828858 -12 -0.0
(read/write) 1220178 1220178 0 0.0
.dram0.bss 56688 56688 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164152 164152 0 0.0
.flash.text 828870 828858 -12 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899875 899867 -8 -0.0
(read/write) 419492 419492 0 0.0
.dram0.bss 62040 62040 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192116 192116 0 0.0
.flash.text 894491 894483 -8 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707240 707208 -32 -0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 622364 622332 -32 -0.0
lock-app k32w061+debug (read/write) 598680 598648 -32 -0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 523324 523292 -32 -0.0
shell k32w061+debug (read/write) 664024 663992 -32 -0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 577572 577540 -32 -0.0
linux all-clusters-app debug (read only) 1729401 1729545 144 0.0
(read/write) 126816 126816 0 0.0
.bss 57392 57392 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136757 136917 160 0.1
.text 1458690 1458674 -16 -0.0
bridge-app debug+rpc (read only) 1324429 1324541 112 0.0
(read/write) 77008 77008 0 0.0
.bss 42096 42096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112028 112156 128 0.1
.text 1114997 1114981 -16 -0.0
chip-tool debug (read only) 4985837 4985965 128 0.0
(read/write) 166888 166888 0 0.0
.bss 40456 40456 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118672 118672 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268458 268586 128 0.0
.text 4406869 4406869 0 0.0
lighting-app debug+rpc (read only) 1593521 1593665 144 0.0
(read/write) 110224 110224 0 0.0
.bss 47760 47760 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129617 129777 160 0.1
.text 1328898 1328882 -16 -0.0
ota-provider-app debug (read only) 1271993 1272089 96 0.0
(read/write) 75656 75656 0 0.0
.bss 44704 44704 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114047 114175 128 0.1
.text 1060354 1060322 -32 -0.0
ota-requestor-app debug (read only) 1357729 1357841 112 0.0
(read/write) 79392 79392 0 0.0
.bss 47168 47168 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125064 125192 128 0.1
.text 1132690 1132674 -16 -0.0
shell debug (read only) 798801 798801 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616082 616082 0 0.0
tv-app debug (read only) 1875841 1875953 112 0.0
(read/write) 318968 318968 0 0.0
.bss 250376 250376 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60144 60144 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157989 158117 128 0.1
.text 1572722 1572706 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288000 2288000 0 0.0
.bss 179284 179284 0 0.0
.data 5216 5216 0 0.0
.heap 851944 851944 0 0.0
.text 1250600 1250600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273936 2273936 0 0.0
.bss 172148 172148 0 0.0
.data 5576 5576 0 0.0
.heap 858720 858720 0 0.0
.text 1236536 1236536 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249840 2249776 -64 -0.0
.bss 171036 171036 0 0.0
.data 5568 5568 0 0.0
.heap 859840 859840 0 0.0
.text 1212440 1212376 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864963 864931 -32 -0.0
bss 110560 110560 0 0.0
rodata 95828 95828 0 0.0
text 582960 582932 -28 -0.0
nrf52840dk_nrf52840+rpc (read/write) 827363 827331 -32 -0.0
bss 106916 106916 0 0.0
rodata 87012 87012 0 0.0
text 557128 557100 -28 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790002 789970 -32 -0.0
bss 111936 111936 0 0.0
rodata 91084 91084 0 0.0
text 512432 512404 -28 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840379 840347 -32 -0.0
bss 109584 109584 0 0.0
rodata 92300 92300 0 0.0
text 563056 563024 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765682 765650 -32 -0.0
bss 110996 110996 0 0.0
rodata 87604 87604 0 0.0
text 492620 492588 -32 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846487 846471 -16 -0.0
bss 109724 109724 0 0.0
rodata 94008 94008 0 0.0
text 567236 567208 -28 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840079 840047 -32 -0.0
bss 109620 109620 0 0.0
rodata 92256 92256 0 0.0
text 562676 562644 -32 -0.0
shell nrf52840dk_nrf52840 (read/write) 777971 777971 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521236 521236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693026 693026 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441848 441848 0 0.0
p6 all-clusters-app default (read/write) 2298416 2298304 -112 -0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1256680 1256568 -112 -0.0
lock-app default (read/write) 2215904 2215776 -128 -0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1174168 1174040 -128 -0.0
qpg lighting-app qpg6100+debug (read only) 494072 494040 -32 -0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488752 488720 -32 -0.0
lock-app qpg6100+debug (read only) 469036 469004 -32 -0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463716 463684 -32 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768346 768330 -16 -0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 533530 533518 -12 -0.0

@mrjerryjohns mrjerryjohns linked an issue Nov 19, 2021 that may be closed by this pull request
Utility method for getting FabricIndex from CommandHandler #10944
Closed
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 19, 2021
Merged
@andy31415
Copy link
Contributor

Fast track: several checkmarks, created and reviewed by domain owners.

@andy31415 andy31415 merged commit befd208 into project-chip:master Nov 22, 2021
@bzbarsky-apple bzbarsky-apple deleted the add-command-fabric-index branch November 22, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utility method for getting FabricIndex from CommandHandler
6 participants
@bzbarsky-apple @mlepage-google @andy31415 @msandstedt @mrjerryjohns @yunhanw-google