-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't call into AttributeAccessInterface for attributes that don't exist #11997
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-read-nonexistent
Nov 24, 2021
Merged
Don't call into AttributeAccessInterface for attributes that don't exist #11997
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-read-nonexistent
Nov 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic and
vivien-apple
November 18, 2021 22:23
pullapprove
bot
requested review from
wbschiller,
woody-apple and
yunhanw-google
November 18, 2021 22:23
bzbarsky-apple
force-pushed
the
fix-read-nonexistent
branch
from
November 18, 2021 22:24
a2be8f0
to
b370f06
Compare
PR #11997: Size comparison from ef6455d to b370f06 Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
approved these changes
Nov 20, 2021
bzbarsky-apple
force-pushed
the
fix-read-nonexistent
branch
from
November 20, 2021 10:06
b370f06
to
86efbdc
Compare
PR #11997: Size comparison from 55349a5 to 86efbdc Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-read-nonexistent
branch
from
November 22, 2021 16:52
86efbdc
to
29a2387
Compare
PR #11997: Size comparison from aa8a6d0 to 29a2387 Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Nov 22, 2021
bzbarsky-apple
force-pushed
the
fix-read-nonexistent
branch
from
November 24, 2021 01:30
29a2387
to
248498b
Compare
PR #11997: Size comparison from 2e85d48 to 248498b Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-read-nonexistent
branch
from
November 24, 2021 03:14
248498b
to
9fb46bb
Compare
PR #11997: Size comparison from 2e85d48 to 9fb46bb Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…ist. In particular, writes already had this check, but we need it for reads. Fixes project-chip#10389
bzbarsky-apple
force-pushed
the
fix-read-nonexistent
branch
from
November 24, 2021 06:33
9fb46bb
to
078f96a
Compare
PR #11997: Size comparison from 2e85d48 to 078f96a Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 24, 2021
fast track: PR open for quite a while now, has several checkmarks, created and approved by a domain owner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, writes already had this check, but we need it for reads.
Fixes #10389
Problem
Can read attributes that are not there.
Change overview
Check our attribute metadata before reading.
Testing
See yaml test.