-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mbed] Fix WiFi provisioning #11982
Merged
andy31415
merged 3 commits into
project-chip:master
from
ARMmbed:mbed-fix-wifi-provisioning
Nov 22, 2021
Merged
[Mbed] Fix WiFi provisioning #11982
andy31415
merged 3 commits into
project-chip:master
from
ARMmbed:mbed-fix-wifi-provisioning
Nov 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tecimovic
November 18, 2021 16:34
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 18, 2021 16:34
PR #11982: Size comparison from ef6455d to 5d38fc1 Increases (4 builds for mbed)
Decreases (4 builds for mbed)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Improve get default network interface
ATmobica
force-pushed
the
mbed-fix-wifi-provisioning
branch
from
November 19, 2021 14:44
5d38fc1
to
924dcf9
Compare
PR #11982: Size comparison from ebadd33 to 924dcf9 Increases (4 builds for mbed)
Decreases (4 builds for mbed)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
reviewed
Nov 19, 2021
2 tasks
msandstedt
approved these changes
Nov 19, 2021
PR #11982: Size comparison from dcca930 to 66b2eb0 Increases (4 builds for mbed)
Decreases (4 builds for mbed)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 20, 2021
andy31415
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The WiFi provisioning with the device controller stops working for Mbed examples. After checking some internal improvements were needed.
Change overview
Update mbed-os-posix-socket lib
Improve get default network interface in ConfigurationManagerImpl and ConnectivityManagerImpl
Increase session establishment timeout in CHIPDeviceController to 40s - for Mbed examples it takes more time to establish a new session.
Testing
Build and run lock-app and lighting-app examples manually. Provisioning WiFi using Python device controller app