Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scripts/build/gn_build.sh #11905

Merged
merged 8 commits into from
Nov 18, 2021
Merged

Remove scripts/build/gn_build.sh #11905

merged 8 commits into from
Nov 18, 2021

Conversation

andy31415
Copy link
Contributor

Problem

We have two scripts named gn_build.sh: one in root and one in scripts/build. The one in scripts is basically ninja -C out/$BUILD_TYPE (with auto selection of build environment). Having scripts named the same is confusiong, having a wrapper script on top of ninja just adds complexity.

Change overview

Remove scripts/build/gn_build.sh and replace its usage with direct ninja invocations.

Testing

CI was the only one using this, this will get validated by CI.

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11905: Size comparison from cbd3e95 to 319157f

Full report (9 builds for k32w, p6, qpg, telink)
platform target config section cbd3e95 319157f change % change
k32w lighting-app k32w061+se05x+release (read/write) 703856 703856 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 619156 619156 0 0.0
lock-app k32w061+debug (read/write) 595300 595300 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 520120 520120 0 0.0
shell k32w061+debug (read/write) 660532 660532 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574320 574320 0 0.0
p6 all-clusters-app default (read/write) 2292832 2292832 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1251096 1251096 0 0.0
lock-app default (read/write) 2210320 2210320 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168584 1168584 0 0.0
qpg lighting-app qpg6100+debug (read only) 490080 490080 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484760 484760 0 0.0
lock-app qpg6100+debug (read only) 465044 465044 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459724 459724 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 763250 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529344 529344 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11905: Size comparison from e338b6e to 7b120c4

Full report (17 builds for k32w, linux, p6, qpg, telink)
platform target config section e338b6e 7b120c4 change % change
k32w lighting-app k32w061+se05x+release (read/write) 703888 703888 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 619188 619188 0 0.0
lock-app k32w061+debug (read/write) 595332 595332 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 520152 520152 0 0.0
shell k32w061+debug (read/write) 660564 660564 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574352 574352 0 0.0
linux all-clusters-app debug (read only) 1702945 1702945 0 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135349 0 0.0
.text 1434146 1434146 0 0.0
bridge-app debug+rpc (read only) 1298117 1298117 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 110764 0 0.0
.text 1090453 1090453 0 0.0
chip-tool debug (read only) 4957053 4957053 0 0.0
(read/write) 166504 166504 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118136 118136 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267186 267186 0 0.0
.text 4380437 4380437 0 0.0
lighting-app debug+rpc (read only) 1567209 1567209 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128401 128401 0 0.0
.text 1304306 1304306 0 0.0
ota-provider-app debug (read only) 1253449 1253449 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 113063 0 0.0
.text 1043298 1043298 0 0.0
ota-requestor-app debug (read only) 1337025 1337025 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124112 124112 0 0.0
.text 1113490 1113490 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1846089 1846089 0 0.0
(read/write) 318136 318136 0 0.0
.bss 249960 249960 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156653 156653 0 0.0
.text 1544882 1544882 0 0.0
p6 all-clusters-app default (read/write) 2292864 2292864 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1251128 1251128 0 0.0
lock-app default (read/write) 2210336 2210336 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168600 1168600 0 0.0
qpg lighting-app qpg6100+debug (read only) 490096 490096 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484776 484776 0 0.0
lock-app qpg6100+debug (read only) 465076 465076 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459756 459756 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763282 763282 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529372 529372 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11905: Size comparison from 09f38cd to c6e766f

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 09f38cd c6e766f change % change
efr32 lighting-app BRD4161A (read only) 747208 747208 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 747200 747200 0 0.0
BRD4161A+rpc (read only) 734740 734740 0 0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 734732 734732 0 0.0
lock-app BRD4161A (read only) 724296 724296 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 724288 724288 0 0.0
window-app BRD4161A (read only) 725256 725256 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 725248 725248 0 0.0
esp32 all-clusters-app c3devkit (read only) 826248 826248 0 0.0
(read/write) 1219938 1219938 0 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164088 164088 0 0.0
.flash.text 826248 826248 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 897327 897327 0 0.0
(read/write) 419260 419260 0 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192060 192060 0 0.0
.flash.text 891943 891943 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 704872 704872 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 620172 620172 0 0.0
lock-app k32w061+debug (read/write) 596316 596316 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 521136 521136 0 0.0
shell k32w061+debug (read/write) 661564 661564 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 575352 575352 0 0.0
linux all-clusters-app debug (read only) 1711905 1711905 0 0.0
(read/write) 126880 126880 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63040 63040 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135541 135541 0 0.0
.text 1442338 1442338 0 0.0
bridge-app debug+rpc (read only) 1307037 1307037 0 0.0
(read/write) 77104 77104 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28312 28312 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110916 110916 0 0.0
.text 1098645 1098645 0 0.0
chip-tool debug (read only) 4963565 4963565 0 0.0
(read/write) 166920 166920 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118552 118552 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267466 267466 0 0.0
.text 4385589 4385589 0 0.0
lighting-app debug+rpc (read only) 1576185 1576185 0 0.0
(read/write) 110320 110320 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55872 55872 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128561 128561 0 0.0
.text 1312546 1312546 0 0.0
ota-provider-app debug (read only) 1255153 1255153 0 0.0
(read/write) 75752 75752 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25032 25032 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113055 113055 0 0.0
.text 1044434 1044434 0 0.0
ota-requestor-app debug (read only) 1338713 1338713 0 0.0
(read/write) 79456 79456 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26216 26216 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124104 124104 0 0.0
.text 1114610 1114610 0 0.0
shell debug (read only) 796345 796345 0 0.0
(read/write) 66280 66280 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37712 37712 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78447 78447 0 0.0
.text 613810 613810 0 0.0
tv-app debug (read only) 1855025 1855025 0 0.0
(read/write) 318424 318424 0 0.0
.bss 249960 249960 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60008 60008 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156805 156805 0 0.0
.text 1553090 1553090 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2286112 2286112 0 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1248712 1248712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272048 2272048 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1234648 1234648 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247888 2247888 0 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1210488 1210488 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050704 2050704 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1013304 1013304 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862559 862559 0 0.0
bss 110384 110384 0 0.0
rodata 95760 95760 0 0.0
text 580788 580788 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824931 824931 0 0.0
bss 106740 106740 0 0.0
rodata 86948 86948 0 0.0
text 554956 554956 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787602 787602 0 0.0
bss 111760 111760 0 0.0
rodata 91020 91020 0 0.0
text 510256 510256 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837943 837943 0 0.0
bss 109408 109408 0 0.0
rodata 92232 92232 0 0.0
text 560880 560880 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763278 763278 0 0.0
bss 110820 110820 0 0.0
rodata 87536 87536 0 0.0
text 490444 490444 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844099 844099 0 0.0
bss 109548 109548 0 0.0
rodata 93940 93940 0 0.0
text 565064 565064 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837675 837675 0 0.0
bss 109444 109444 0 0.0
rodata 92188 92188 0 0.0
text 560500 560500 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777691 777691 0 0.0
bss 109004 109004 0 0.0
rodata 73088 73088 0 0.0
text 521000 521000 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692746 692746 0 0.0
bss 109988 109988 0 0.0
rodata 67732 67732 0 0.0
text 441608 441608 0 0.0
p6 all-clusters-app default (read/write) 2295056 2295056 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1253320 1253320 0 0.0
lock-app default (read/write) 2212544 2212544 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1170808 1170808 0 0.0
qpg lighting-app qpg6100+debug (read only) 491984 491984 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 486664 486664 0 0.0
lock-app qpg6100+debug (read only) 466948 466948 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 461628 461628 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 765534 765534 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 530960 530960 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 2a7eaf0 into project-chip:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
github review - approved scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @yunhanw-google @bzbarsky-apple @jmartinez-silabs