separate out gn fake platform declaration #11860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
|
Changed to draft: darwin rpc_console compilation compiles after this change (cannot find device.gni) |
|
Fast track: hotfix really, tested with builds on linux and darwin. |
…p did not show hidden paths
cecille
approved these changes
Nov 16, 2021
andy31415
changed the title
mspang
requested changes
Nov 16, 2021
…the top level gn file (but will not be seen in example apps unless they explicitly ask for it)
andy31415
changed the title
mspang
approved these changes
Nov 16, 2021
|
PR #11860: Size comparison from 1d76b09 to da0f7c1 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 18, 2021
* Remove unused script with duplicate name, fix typo in enable/disable of build.gn * Include the correct gni to declare chip_fake_platform * Split out fake platform argument in separate gni that lives under the build system * Restyle fixes * Resurrect gn_build.sh: apparently used by CI workflows (and by ripgrep did not show hidden paths * Switch fake platform into its separate toolchain that is included in the top level gn file (but will not be seen in example apps unless they explicitly ask for it) * Restyle fixes * Undo some not needed changes
raqbit
pushed a commit
to raqbit/connectedhomeip
that referenced
this pull request
Nov 19, 2021
* Remove unused script with duplicate name, fix typo in enable/disable of build.gn * Include the correct gni to declare chip_fake_platform * Split out fake platform argument in separate gni that lives under the build system * Restyle fixes * Resurrect gn_build.sh: apparently used by CI workflows (and by ripgrep did not show hidden paths * Switch fake platform into its separate toolchain that is included in the top level gn file (but will not be seen in example apps unless they explicitly ask for it) * Restyle fixes * Undo some not needed changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
./gn_build.shdoes not run anymore due to fake platform dependenciesChange overview
Create separate fake toolchain and only include that in the top level build.gn (example builds will not pick it up as a viable platform unless they include top level or explicitly add the platform.
Testing
Ran
./gn_build.shon linuxbuild rpc_console on darwin using build_examples.py