-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Certificate Declaration payload validation #11838
Added Certificate Declaration payload validation #11838
Conversation
Retrieve these IDs from Basic Information Clusterconnectedhomeip/src/credentials/examples/DeviceAttestationVerifierExample.cpp Lines 298 to 308 in 05ae943
This comment was generated by todo based on a
|
check if version_number field in Certification Declaration matches the one in Firmware Information.connectedhomeip/src/credentials/examples/DeviceAttestationVerifierExample.cpp Lines 342 to 352 in 05ae943
This comment was generated by todo based on a
|
PR #11838: Size comparison from 3724938 to 05ae943 Increases above 0.2%:
Increases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Retrieve vendorId and ProductId from Basic Information Clusterconnectedhomeip/src/credentials/examples/DeviceAttestationVerifierExample.cpp Lines 299 to 309 in d0f7bb1
This comment was generated by todo based on a
|
…rporate PR-11838 review comments.
PR #11838: Size comparison from a249805 to 9cddb31 Increases above 0.2%:
Increases (5 builds for efr32, linux)
Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #11838: Size comparison from 2e16d32 to b5f45aa Increases above 0.2%:
Increases (4 builds for efr32, linux)
Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #11838: Size comparison from 71a3fb2 to 92dd5d5 Increases above 0.2%:
Increases (5 builds for efr32, linux)
Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Change overview
Testing