Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing optional attributes for general diagnostics cluster #11801

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Implement missing optional attributes for general diagnostics cluster #11801

merged 3 commits into from
Nov 17, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • We have three left optional attributes which need implementation in general diagnostic cluster

Change overview

Implement missing optional attributes for general diagnostic cluster

Testing

How was this tested? (at least one bullet point required)

yufengw@yufengw-SEi:~/connectedhomeip/out/debug/standalone$ ./chip-tool generaldiagnostics read active-hardware-faults 12344321 0
[1637006901.600958][50024:50029] CHIP:DMG: ReportDataMessage =
[1637006901.600962][50024:50029] CHIP:DMG: {
[1637006901.600966][50024:50029] CHIP:DMG: 	AttributeReportIBs =
[1637006901.600970][50024:50029] CHIP:DMG: 	[
[1637006901.600973][50024:50029] CHIP:DMG: 		AttributeReportIB =
[1637006901.600977][50024:50029] CHIP:DMG: 		{
[1637006901.600981][50024:50029] CHIP:DMG: 			AttributeDataIB =
[1637006901.600985][50024:50029] CHIP:DMG: 			{
[1637006901.600989][50024:50029] CHIP:DMG: 				AttributePathIB =
[1637006901.600996][50024:50029] CHIP:DMG: 				{
[1637006901.601001][50024:50029] CHIP:DMG: 					Endpoint = 0x0,
[1637006901.601006][50024:50029] CHIP:DMG: 					Cluster = 0x33,
[1637006901.601011][50024:50029] CHIP:DMG: 					Attribute = 0x0000_0005,
[1637006901.601016][50024:50029] CHIP:DMG: 				}
[1637006901.601021][50024:50029] CHIP:DMG: 					
[1637006901.601026][50024:50029] CHIP:DMG: 					Data = [
[1637006901.601032][50024:50029] CHIP:DMG: 						1, 2, 5, 8, 
[1637006901.601037][50024:50029] CHIP:DMG: 					],
[1637006901.601041][50024:50029] CHIP:DMG: 				DataVersion = 0x0,
[1637006901.601045][50024:50029] CHIP:DMG: 			},
[1637006901.601051][50024:50029] CHIP:DMG: 			
[1637006901.601054][50024:50029] CHIP:DMG: 		},
[1637006901.601059][50024:50029] CHIP:DMG: 		
[1637006901.601063][50024:50029] CHIP:DMG: 	],
[1637006901.601070][50024:50029] CHIP:DMG: 	
[1637006901.601073][50024:50029] CHIP:DMG: }
[1637006901.601099][50024:50029] CHIP:ZCL: ReadAttributesResponse:
[1637006901.601102][50024:50029] CHIP:ZCL:   ClusterId: 0x0000_0033
[1637006901.601106][50024:50029] CHIP:ZCL:   attributeId: 0x0000_0005
[1637006901.601110][50024:50029] CHIP:ZCL:   status: Success                (0x0000)
[1637006901.601114][50024:50029] CHIP:ZCL:   attribute TLV Type: 0x16
[1637006901.601120][50024:50029] CHIP:TOO: OnGeneralDiagnosticsActiveHardwareFaultsListAttributeResponse: 4 entries
[1637006901.601128][50024:50029] CHIP:TOO:   [1]: 1
[1637006901.601132][50024:50029] CHIP:TOO:   [2]: 2
[1637006901.601136][50024:50029] CHIP:TOO:   [3]: 5
[1637006901.601139][50024:50029] CHIP:TOO:   [4]: 8

@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11801: Size comparison from 8f23aa6 to 21b0c8b

Increases above 0.2%:

platform target config section 8f23aa6 21b0c8b change % change
linux all-clusters-app debug (read only) 1709953 1717809 7856 0.5
.text 1441154 1448754 7600 0.5
bridge-app debug+rpc (read only) 1305125 1312997 7872 0.6
.data.rel.ro 28024 28120 96 0.3
.text 1097461 1105077 7616 0.7
lighting-app debug+rpc (read only) 1574153 1582057 7904 0.5
.text 1311314 1318962 7648 0.6
tv-app debug (read only) 1846809 1854681 7872 0.4
.text 1547330 1554946 7616 0.5
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8f23aa6 21b0c8b change % change
efr32 lighting-app BRD4161A (read only) 746648 748040 1392 0.2
.text 746640 748032 1392 0.2
BRD4161A+rpc (read only) 734188 735564 1376 0.2
.text 734180 735556 1376 0.2
lock-app BRD4161A (read only) 723712 725104 1392 0.2
.text 723704 725096 1392 0.2
window-app BRD4161A (read only) 724704 726096 1392 0.2
.text 724696 726088 1392 0.2
esp32 all-clusters-app c3devkit (read only) 825820 826318 498 0.1
(read/write) 1220258 1220306 48 0.0
.flash.rodata 164408 164456 48 0.0
.flash.text 825820 826318 498 0.1
m5stack (read only) 896619 897211 592 0.1
(read/write) 419580 419628 48 0.0
.flash.rodata 192380 192428 48 0.0
.flash.text 891235 891827 592 0.1
k32w lighting-app k32w061+se05x+release (read/write) 705032 705520 488 0.1
.text 620332 620820 488 0.1
lock-app k32w061+debug (read/write) 596448 596936 488 0.1
.text 521268 521756 488 0.1
shell k32w061+debug (read/write) 661664 662152 488 0.1
.text 575452 575940 488 0.1
linux all-clusters-app debug (read only) 1709953 1717809 7856 0.5
(read/write) 126624 126688 64 0.1
.data.rel.ro 62784 62848 64 0.1
.rodata 135349 135605 256 0.2
.text 1441154 1448754 7600 0.5
bridge-app debug+rpc (read only) 1305125 1312997 7872 0.6
(read/write) 76816 76912 96 0.1
.data.rel.ro 28024 28120 96 0.3
.rodata 110764 111020 256 0.2
.text 1097461 1105077 7616 0.7
chip-tool debug (read only) 4900629 4905373 4744 0.1
(read/write) 166280 166504 224 0.1
.data.rel.ro 117936 118160 224 0.2
.rodata 265618 265970 352 0.1
.text 4326037 4329925 3888 0.1
lighting-app debug+rpc (read only) 1574153 1582057 7904 0.5
(read/write) 110064 110128 64 0.1
.data.rel.ro 55616 55680 64 0.1
.rodata 128337 128593 256 0.2
.text 1311314 1318962 7648 0.6
ota-provider-app debug (read only) 1260553 1260681 128 0.0
.rodata 113063 113191 128 0.1
ota-requestor-app debug (read only) 1343681 1343809 128 0.0
.rodata 123888 124016 128 0.1
shell debug (read only) 794665 794761 96 0.0
.rodata 78479 78575 96 0.1
tv-app debug (read only) 1846809 1854681 7872 0.4
(read/write) 405016 405112 96 0.0
.data.rel.ro 59600 59696 96 0.2
.rodata 155213 155469 256 0.2
.text 1547330 1554946 7616 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2285408 2286040 632 0.0
.text 1248008 1248640 632 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271408 2271976 568 0.0
.text 1234008 1234576 568 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2247248 2247816 568 0.0
.text 1209848 1210416 568 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861319 861807 488 0.1
rodata 95400 95456 56 0.1
text 579904 580344 440 0.1
nrf52840dk_nrf52840+rpc (read/write) 823691 824179 488 0.1
rodata 86588 86644 56 0.1
text 554076 554516 440 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786362 786850 488 0.1
rodata 90660 90716 56 0.1
text 509372 509812 440 0.1
lock-app nrf52840dk_nrf52840 (read/write) 836719 837207 488 0.1
rodata 91872 91928 56 0.1
text 560004 560440 436 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762038 762526 488 0.1
rodata 87176 87232 56 0.1
text 489564 490000 436 0.1
pump-app nrf52840dk_nrf52840 (read/write) 842859 843347 488 0.1
rodata 93580 93636 56 0.1
text 564184 564624 440 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 836451 836939 488 0.1
rodata 91828 91884 56 0.1
text 559624 560060 436 0.1
p6 all-clusters-app default (read/write) 2294024 2295400 1376 0.1
.text 1252288 1253664 1376 0.1
lock-app default (read/write) 2211448 2212824 1376 0.1
.text 1169712 1171088 1376 0.1
qpg lighting-app qpg6100+debug (read only) 491108 491604 496 0.1
.text 485788 486284 496 0.1
lock-app qpg6100+debug (read only) 466040 466536 496 0.1
.text 460720 461216 496 0.1
telink lighting-app tlsr9518adk80d (read/write) 764266 764726 460 0.1
text 530138 530532 394 0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8f23aa6 21b0c8b change % change
efr32 lighting-app BRD4161A (read only) 746648 748040 1392 0.2
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 746640 748032 1392 0.2
BRD4161A+rpc (read only) 734188 735564 1376 0.2
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 734180 735556 1376 0.2
lock-app BRD4161A (read only) 723712 725104 1392 0.2
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 723704 725096 1392 0.2
window-app BRD4161A (read only) 724704 726096 1392 0.2
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 724696 726088 1392 0.2
esp32 all-clusters-app c3devkit (read only) 825820 826318 498 0.1
(read/write) 1220258 1220306 48 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164408 164456 48 0.0
.flash.text 825820 826318 498 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896619 897211 592 0.1
(read/write) 419580 419628 48 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192380 192428 48 0.0
.flash.text 891235 891827 592 0.1
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705032 705520 488 0.1
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 620332 620820 488 0.1
lock-app k32w061+debug (read/write) 596448 596936 488 0.1
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 521268 521756 488 0.1
shell k32w061+debug (read/write) 661664 662152 488 0.1
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 575452 575940 488 0.1
linux all-clusters-app debug (read only) 1709953 1717809 7856 0.5
(read/write) 126624 126688 64 0.1
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62848 64 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135605 256 0.2
.text 1441154 1448754 7600 0.5
bridge-app debug+rpc (read only) 1305125 1312997 7872 0.6
(read/write) 76816 76912 96 0.1
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28120 96 0.3
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 111020 256 0.2
.text 1097461 1105077 7616 0.7
chip-tool debug (read only) 4900629 4905373 4744 0.1
(read/write) 166280 166504 224 0.1
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 118160 224 0.2
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265618 265970 352 0.1
.text 4326037 4329925 3888 0.1
lighting-app debug+rpc (read only) 1574153 1582057 7904 0.5
(read/write) 110064 110128 64 0.1
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55680 64 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128337 128593 256 0.2
.text 1311314 1318962 7648 0.6
ota-provider-app debug (read only) 1260553 1260681 128 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 113191 128 0.1
.text 1050402 1050402 0 0.0
ota-requestor-app debug (read only) 1343681 1343809 128 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123888 124016 128 0.1
.text 1120370 1120370 0 0.0
shell debug (read only) 794665 794761 96 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78575 96 0.1
.text 612674 612674 0 0.0
tv-app debug (read only) 1846809 1854681 7872 0.4
(read/write) 405016 405112 96 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59696 96 0.2
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155213 155469 256 0.2
.text 1547330 1554946 7616 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2285408 2286040 632 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1248008 1248640 632 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271408 2271976 568 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1234008 1234576 568 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247248 2247816 568 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1209848 1210416 568 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049456 2049456 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012056 1012056 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861319 861807 488 0.1
bss 110384 110384 0 0.0
rodata 95400 95456 56 0.1
text 579904 580344 440 0.1
nrf52840dk_nrf52840+rpc (read/write) 823691 824179 488 0.1
bss 106740 106740 0 0.0
rodata 86588 86644 56 0.1
text 554076 554516 440 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786362 786850 488 0.1
bss 111760 111760 0 0.0
rodata 90660 90716 56 0.1
text 509372 509812 440 0.1
lock-app nrf52840dk_nrf52840 (read/write) 836719 837207 488 0.1
bss 109408 109408 0 0.0
rodata 91872 91928 56 0.1
text 560004 560440 436 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762038 762526 488 0.1
bss 110820 110820 0 0.0
rodata 87176 87232 56 0.1
text 489564 490000 436 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842859 843347 488 0.1
bss 109548 109548 0 0.0
rodata 93580 93636 56 0.1
text 564184 564624 440 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 836451 836939 488 0.1
bss 109444 109444 0 0.0
rodata 91828 91884 56 0.1
text 559624 560060 436 0.1
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2294024 2295400 1376 0.1
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1252288 1253664 1376 0.1
lock-app default (read/write) 2211448 2212824 1376 0.1
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1169712 1171088 1376 0.1
qpg lighting-app qpg6100+debug (read only) 491108 491604 496 0.1
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 485788 486284 496 0.1
lock-app qpg6100+debug (read only) 466040 466536 496 0.1
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 460720 461216 496 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 764266 764726 460 0.1
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 530138 530532 394 0.1

Damian-Nordic
Damian-Nordic approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworking the iterator is optional, so approving.

@tcarmelveilleux tcarmelveilleux changed the title Implement missing optional attributes for general diagnostic cluster Implement missing optional attributes for general diagnostics cluster Nov 16, 2021
@github-actions
Copy link

PR #11801: Size comparison from 09f9837 to 953e1d7

Increases above 0.2%:

platform target config section 09f9837 953e1d7 change % change
linux all-clusters-app debug (read only) 1701841 1709105 7264 0.4
.text 1433138 1440210 7072 0.5
tv-app debug (read only) 1838569 1845801 7232 0.4
.text 1539154 1546226 7072 0.5
bridge-app debug+rpc (read only) 1297013 1304245 7232 0.6
.data.rel.ro 28024 28120 96 0.3
.text 1089445 1096517 7072 0.6
lighting-app debug+rpc (read only) 1566073 1573337 7264 0.5
.text 1303298 1310402 7104 0.5
Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 09f9837 953e1d7 change % change
efr32 lighting-app BRD4161A (read only) 745208 746584 1376 0.2
.text 745200 746576 1376 0.2
lock-app BRD4161A (read only) 722296 723656 1360 0.2
.text 722288 723648 1360 0.2
window-app BRD4161A (read only) 723272 724632 1360 0.2
.text 723264 724624 1360 0.2
lighting-app BRD4161A+rpc (read only) 732724 734100 1376 0.2
.text 732716 734092 1376 0.2
esp32 all-clusters-app c3devkit (read only) 824912 825448 536 0.1
(read/write) 1219650 1219698 48 0.0
.flash.rodata 163800 163848 48 0.0
.flash.text 824912 825448 536 0.1
m5stack (read only) 895819 896435 616 0.1
(read/write) 418980 419028 48 0.0
.flash.rodata 191780 191828 48 0.0
.flash.text 890435 891051 616 0.1
k32w lock-app k32w061+debug (read/write) 595020 595652 632 0.1
.text 519840 520472 632 0.1
shell k32w061+debug (read/write) 660252 660884 632 0.1
.text 574040 574672 632 0.1
lighting-app k32w061+se05x+release (read/write) 703576 704208 632 0.1
.text 618876 619508 632 0.1
linux all-clusters-app debug (read only) 1701841 1709105 7264 0.4
(read/write) 126624 126688 64 0.1
.data.rel.ro 62784 62848 64 0.1
.rodata 135253 135445 192 0.1
.text 1433138 1440210 7072 0.5
chip-tool debug (read only) 4892293 4896941 4648 0.1
(read/write) 166280 166504 224 0.1
.data.rel.ro 117936 118160 224 0.2
.rodata 265554 265810 256 0.1
.text 4317765 4321653 3888 0.1
tv-app debug (read only) 1838569 1845801 7232 0.4
(read/write) 405016 405112 96 0.0
.data.rel.ro 59600 59696 96 0.2
.rodata 155149 155309 160 0.1
.text 1539154 1546226 7072 0.5
bridge-app debug+rpc (read only) 1297013 1304245 7232 0.6
(read/write) 76816 76912 96 0.1
.data.rel.ro 28024 28120 96 0.3
.rodata 110668 110828 160 0.1
.text 1089445 1096517 7072 0.6
lighting-app debug+rpc (read only) 1566073 1573337 7264 0.5
(read/write) 110064 110128 64 0.1
.data.rel.ro 55616 55680 64 0.1
.rodata 128273 128433 160 0.1
.text 1303298 1310402 7104 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2283728 2284360 632 0.0
.text 1246328 1246960 632 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2269720 2270288 568 0.0
.text 1232320 1232888 568 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2245560 2246192 632 0.0
.text 1208160 1208792 632 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860799 616 0.1
rodata 95032 95088 56 0.1
text 579140 579704 564 0.1
lock-app nrf52840dk_nrf52840 (read/write) 835579 836195 616 0.1
rodata 91500 91556 56 0.1
text 559236 559804 568 0.1
pump-app nrf52840dk_nrf52840 (read/write) 841723 842339 616 0.1
rodata 93212 93268 56 0.1
text 563420 563984 564 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835931 616 0.1
rodata 91460 91516 56 0.1
text 558856 559424 568 0.1
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 823167 616 0.1
rodata 86216 86272 56 0.1
text 553312 553876 564 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785838 616 0.1
rodata 90288 90344 56 0.1
text 508608 509172 564 0.1
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 761534 632 0.1
rodata 86808 86864 56 0.1
text 488796 489364 568 0.1
p6 all-clusters-app default (read/write) 2292608 2293968 1360 0.1
.text 1250872 1252232 1360 0.1
lock-app default (read/write) 2210080 2211456 1376 0.1
.text 1168344 1169720 1376 0.1
qpg lighting-app qpg6100+debug (read only) 489736 490344 608 0.1
.text 484416 485024 608 0.1
lock-app qpg6100+debug (read only) 464692 465316 624 0.1
.text 459372 459996 624 0.1
telink lighting-app tlsr9518adk80d (read/write) 763014 763658 644 0.1
text 529210 529790 580 0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 09f9837 953e1d7 change % change
efr32 lighting-app BRD4161A (read only) 745208 746584 1376 0.2
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745200 746576 1376 0.2
lock-app BRD4161A (read only) 722296 723656 1360 0.2
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722288 723648 1360 0.2
window-app BRD4161A (read only) 723272 724632 1360 0.2
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723264 724624 1360 0.2
lighting-app BRD4161A+rpc (read only) 732724 734100 1376 0.2
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732716 734092 1376 0.2
esp32 all-clusters-app c3devkit (read only) 824912 825448 536 0.1
(read/write) 1219650 1219698 48 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163848 48 0.0
.flash.text 824912 825448 536 0.1
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 896435 616 0.1
(read/write) 418980 419028 48 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191828 48 0.0
.flash.text 890435 891051 616 0.1
.iram0.text 122943 122943 0 0.0
k32w lock-app k32w061+debug (read/write) 595020 595652 632 0.1
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 519840 520472 632 0.1
shell k32w061+debug (read/write) 660252 660884 632 0.1
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574040 574672 632 0.1
lighting-app k32w061+se05x+release (read/write) 703576 704208 632 0.1
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 618876 619508 632 0.1
linux all-clusters-app debug (read only) 1701841 1709105 7264 0.4
(read/write) 126624 126688 64 0.1
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62848 64 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135445 192 0.1
.text 1433138 1440210 7072 0.5
chip-tool debug (read only) 4892293 4896941 4648 0.1
(read/write) 166280 166504 224 0.1
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 118160 224 0.2
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 265810 256 0.1
.text 4317765 4321653 3888 0.1
ota-provider-app debug (read only) 1252473 1252473 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112999 0 0.0
.text 1042386 1042386 0 0.0
ota-requestor-app debug (read only) 1335393 1335393 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 123792 0 0.0
.text 1112178 1112178 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1838569 1845801 7232 0.4
(read/write) 405016 405112 96 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59696 96 0.2
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155309 160 0.1
.text 1539154 1546226 7072 0.5
bridge-app debug+rpc (read only) 1297013 1304245 7232 0.6
(read/write) 76816 76912 96 0.1
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28120 96 0.3
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110828 160 0.1
.text 1089445 1096517 7072 0.6
lighting-app debug+rpc (read only) 1566073 1573337 7264 0.5
(read/write) 110064 110128 64 0.1
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55680 64 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128433 160 0.1
.text 1303298 1310402 7104 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2284360 632 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246328 1246960 632 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2270288 568 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232320 1232888 568 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2246192 632 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208160 1208792 632 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860799 616 0.1
bss 110384 110384 0 0.0
rodata 95032 95088 56 0.1
text 579140 579704 564 0.1
lock-app nrf52840dk_nrf52840 (read/write) 835579 836195 616 0.1
bss 109408 109408 0 0.0
rodata 91500 91556 56 0.1
text 559236 559804 568 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 842339 616 0.1
bss 109548 109548 0 0.0
rodata 93212 93268 56 0.1
text 563420 563984 564 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835931 616 0.1
bss 109444 109444 0 0.0
rodata 91460 91516 56 0.1
text 558856 559424 568 0.1
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 823167 616 0.1
bss 106740 106740 0 0.0
rodata 86216 86272 56 0.1
text 553312 553876 564 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785838 616 0.1
bss 111760 111760 0 0.0
rodata 90288 90344 56 0.1
text 508608 509172 564 0.1
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 761534 632 0.1
bss 110820 110820 0 0.0
rodata 86808 86864 56 0.1
text 488796 489364 568 0.1
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292608 2293968 1360 0.1
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1250872 1252232 1360 0.1
lock-app default (read/write) 2210080 2211456 1376 0.1
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168344 1169720 1376 0.1
qpg lighting-app qpg6100+debug (read only) 489736 490344 608 0.1
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484416 485024 608 0.1
lock-app qpg6100+debug (read only) 464692 465316 624 0.1
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459372 459996 624 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763658 644 0.1
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529210 529790 580 0.1

bzbarsky-apple
bzbarsky-apple approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so this is unblocked once @tcarmelveilleux's issues are resolved.

@andy31415 andy31415 merged commit f7443d1 into project-chip:master Nov 17, 2021
@yufengwangca yufengwangca deleted the pr/cluster/general branch November 17, 2021 16:35
kpschoedel pushed a commit to kpschoedel/connectedhomeip that referenced this pull request Nov 18, 2021
@yufengwangca @kpschoedel
Implement missing optional attributes for general diagnostics cluster (…
149043e 
…project-chip#11801)

* Implement missing optional attributes for general diagnostic cluster

* Address review comments

* Run codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yufengwangca @tcarmelveilleux @andy31415 @bzbarsky-apple @Damian-Nordic