Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Identify cluster in Lighting-app, Perform actions on EFR32 #11672

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Enable Identify cluster in Lighting-app, Perform actions on EFR32 #11672

merged 4 commits into from
Nov 11, 2021

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Nov 11, 2021 •
edited
Loading

Problem

identify Cluster isn't supported in the lighting-app

Change overview

Enable the cluster for all lighting-app example.

[EFR32]
Instantiate the identify object in EFR32 lighting-app code.
Implement basic callbacks and functionnality to perform identify behaviour on Status LED (LED0)
Support standard identify (blink for identifyTime duration and Trigger Effects ( Fast blink, Breathe, Ok Pulse, Finish effect and Stop effect). Channel Change effect is not supported and differs to the given mEffectVariant

Testing

Execute TC-i instruction manually
./chip-tool identify read identify-time 1 1
./chip-tool identify write identify-time 10 1 1
./chip-tool identify identify 60 1 1
./chip-tool identify trigger-effect 0 0 1 1
./chip-tool identify trigger-effect 2 0 1 1
./chip-tool identify trigger-effect 3 0 1 1
./chip-tool identify trigger-effect 11 0 1 1
./chip-tool identify trigger-effect 254 0 1 1
./chip-tool identify trigger-effect 255 0 1 1

@jmartinez-silabs jmartinez-silabs changed the title Enable Identify cluster in Lighting-app, Perform action on EFR32 Enable Identify cluster in Lighting-app, Perform actions on EFR32 Nov 11, 2021
@jmartinez-silabs
instantiate identify object in lighting app task, Use status led for …
1b8a957 
…Identify standard and trigger effects

restyle
@github-actions
Copy link

github-actions bot commented Nov 11, 2021 •
edited
Loading

PR #11672: Size comparison from d45cfaa to 1b8a957

Increases above 0.2%:

platform target config section d45cfaa 1b8a957 change % change
efr32 lighting-app BRD4161A (read only) 742476 744940 2464 0.3
.text 742468 744932 2464 0.3
BRD4161A+rpc (read only) 730040 732488 2448 0.3
.data 1896 1908 12 0.6
.text 730032 732480 2448 0.3
linux lighting-app debug+rpc (read only) 1558113 1565209 7096 0.5
.init_array 528 536 8 1.5
.rodata 128369 128785 416 0.3
.text 1295634 1302194 6560 0.5
qpg lighting-app qpg6100+debug (read only) 490672 492172 1500 0.3
.text 485352 486852 1500 0.3
Increases (5 builds for efr32, k32w, linux, qpg)
platform target config section d45cfaa 1b8a957 change % change
efr32 lighting-app BRD4161A (read only) 742476 744940 2464 0.3
(read/write) 116280 116316 36 0.0
.bss 114500 114532 32 0.0
.data 1780 1784 4 0.2
.text 742468 744932 2464 0.3
BRD4161A+rpc (read only) 730040 732488 2448 0.3
(read/write) 132900 132948 48 0.0
.bss 131004 131036 32 0.0
.data 1896 1908 12 0.6
.text 730032 732480 2448 0.3
k32w lighting-app k32w061+se05x+release (read/write) 699396 700896 1500 0.2
.bss 78012 78028 16 0.0
.text 613676 615160 1484 0.2
linux lighting-app debug+rpc (read only) 1558113 1565209 7096 0.5
(read/write) 110376 110512 136 0.1
.data.rel.ro 55328 55456 128 0.2
.init_array 528 536 8 1.5
.rodata 128369 128785 416 0.3
.text 1295634 1302194 6560 0.5
qpg lighting-app qpg6100+debug (read only) 490672 492172 1500 0.3
.bss 51168 51176 8 0.0
.text 485352 486852 1500 0.3
Full report (22 builds for efr32, esp32, k32w, linux, p6, qpg)
platform target config section d45cfaa 1b8a957 change % change
efr32 lighting-app BRD4161A (read only) 742476 744940 2464 0.3
(read/write) 116280 116316 36 0.0
.bss 114500 114532 32 0.0
.data 1780 1784 4 0.2
.text 742468 744932 2464 0.3
BRD4161A+rpc (read only) 730040 732488 2448 0.3
(read/write) 132900 132948 48 0.0
.bss 131004 131036 32 0.0
.data 1896 1908 12 0.6
.text 730032 732480 2448 0.3
lock-app BRD4161A (read only) 721764 721764 0 0.0
(read/write) 114096 114096 0 0.0
.bss 112356 112356 0 0.0
.data 1740 1740 0 0.0
.text 721756 721756 0 0.0
window-app BRD4161A (read only) 722676 722676 0 0.0
(read/write) 114420 114420 0 0.0
.bss 112676 112676 0 0.0
.data 1744 1744 0 0.0
.text 722668 722668 0 0.0
esp32 all-clusters-app c3devkit (read only) 879114 879114 0 0.0
(read/write) 1305968 1305968 0 0.0
.dram0.bss 58440 58440 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197824 197824 0 0.0
.flash.text 879114 879114 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910683 910683 0 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204100 204100 0 0.0
.flash.text 910683 910683 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699396 700896 1500 0.2
.bss 78012 78028 16 0.0
.data 1908 1908 0 0.0
.text 613676 615160 1484 0.2
lock-app k32w061+debug (read/write) 592132 592132 0 0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515908 0 0.0
shell k32w061+debug (read/write) 657760 657760 0 0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570776 0 0.0
linux all-clusters-app debug (read only) 1698921 1698921 0 0.0
(read/write) 126432 126432 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139061 0 0.0
.text 1426370 1426370 0 0.0
bridge-app debug+rpc (read only) 1298741 1298741 0 0.0
(read/write) 77264 77264 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091365 1091365 0 0.0
chip-tool debug (read only) 4813069 4813069 0 0.0
(read/write) 136992 136992 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 103336 103336 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 248298 248298 0 0.0
.text 4288437 4288437 0 0.0
lighting-app debug+rpc (read only) 1558113 1565209 7096 0.5
(read/write) 110376 110512 136 0.1
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55328 55456 128 0.2
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 536 8 1.5
.rodata 128369 128785 416 0.3
.text 1295634 1302194 6560 0.5
ota-provider-app debug (read only) 1259977 1259977 0 0.0
(read/write) 75624 75624 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050562 1050562 0 0.0
ota-requestor-app debug (read only) 1345049 1345049 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123728 123728 0 0.0
.text 1121970 1121970 0 0.0
shell debug (read only) 788441 788441 0 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77519 0 0.0
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1842905 0 0.0
(read/write) 408216 408216 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155757 0 0.0
.text 1542674 1542674 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2211760 2211760 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170024 0 0.0
qpg lighting-app qpg6100+debug (read only) 490672 492172 1500 0.3
(read/write) 114144 114144 0 0.0
.bss 51168 51176 8 0.0
.data 1008 1008 0 0.0
.text 485352 486852 1500 0.3
lock-app qpg6100+debug (read only) 466900 466900 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461580 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking as this is a platform maintainer updating platform code (with code gen as well)

@jmartinez-silabs jmartinez-silabs merged commit 14c4c07 into project-chip:master Nov 11, 2021
@jmartinez-silabs jmartinez-silabs deleted the identifyCluster branch November 11, 2021 21:46
jmartinez-silabs added a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Nov 12, 2021
@jmartinez-silabs
Enable Identify cluster in Lighting-app, Perform actions on EFR32 (pr…
5d4f109 
…oject-chip#11672)

* Add identify cluster to light app

* regen

rebase regen

* instantiate identify object in lighting app task, Use status led for Identify standard and trigger effects

restyle

* Add missing file on mbed and telink CMakeList
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Nov 16, 2021
@jmartinez-silabs @mkardous-silabs
Enable Identify cluster in Lighting-app, Perform actions on EFR32 (pr…
236c003 
…oject-chip#11672)

* Add identify cluster to light app

* regen

rebase regen

* instantiate identify object in lighting app task, Use status led for Identify standard and trigger effects

restyle

* Add missing file on mbed and telink CMakeList
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Nov 16, 2021
@jmartinez-silabs @mkardous-silabs
Enable Identify cluster in Lighting-app, Perform actions on EFR32 (pr…
719382e 
…oject-chip#11672)

* Add identify cluster to light app

* regen

rebase regen

* instantiate identify object in lighting app task, Use status led for Identify standard and trigger effects

restyle

* Add missing file on mbed and telink CMakeList
jmeg-sfy pushed a commit to jmeg-sfy/connectedhomeip that referenced this pull request Nov 18, 2021
@jmartinez-silabs @jmeg-sfy
Enable Identify cluster in Lighting-app, Perform actions on EFR32 (pr…
d992f0f 
…oject-chip#11672)

* Add identify cluster to light app

* regen

rebase regen

* instantiate identify object in lighting app task, Use status led for Identify standard and trigger effects

restyle

* Add missing file on mbed and telink CMakeList
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@jmartinez-silabs
Enable Identify cluster in Lighting-app, Perform actions on EFR32 (pr…
ad29470 
…oject-chip#11672)

* Add identify cluster to light app

* regen

rebase regen

* instantiate identify object in lighting app task, Use status led for Identify standard and trigger effects

restyle

* Add missing file on mbed and telink CMakeList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcasallas-silabs rcasallas-silabs rcasallas-silabs approved these changes

@jepenven-silabs jepenven-silabs jepenven-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmartinez-silabs @woody-apple @jepenven-silabs @rcasallas-silabs