Fix test_suites.sh to fail if the chip-tool command fails. #11593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-apple
approved these changes
Nov 9, 2021
bzbarsky-apple
force-pushed
the
fix-failure-script
branch
from
105f50d to
0e33f96
Compare
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
wbschiller and
yunhanw-google
|
PR #11593: Size comparison from ff5f946 to 0e33f96 Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
Fast tracking to unblock logging for test failures. |
andy31415
approved these changes
Nov 9, 2021
Yes, it is! @krypton36 @vivien-apple is it intended that |
Test_TC_DM_1_3 is not intended to run in CI. it is a simulated device test. I don't have a problem re-naming the test. @vivien-apple I would think we should at least generate the code and compile for simulated device YAMLS. |
|
#11598 addressed the issue with the test that was not supposed to be running. Rebasing this to pick it up. |
|
/rebase |
If chip-tool crashed, the script was not treating this as a failure, because the default exit code of a pipeline is that of the last command in the pipeline and we are piping through tee.
woody-apple
force-pushed
the
fix-failure-script
branch
from
0e33f96 to
56131f2
Compare
|
PR #11593: Size comparison from 89898f8 to 56131f2 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…hip#11593) If chip-tool crashed, the script was not treating this as a failure, because the default exit code of a pipeline is that of the last command in the pipeline and we are piping through tee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If chip-tool crashed, the script was not treating this as a failure,
because the default exit code of a pipeline is that of the last
command in the pipeline and we are piping through tee.
Problem
chip-tool crashes not being detected as CI failure in the "Tests" job.
Change overview
Fix it so they are.
Testing
Introduced a crash into chip-tool locally and made sure that now we get a failure exit from the test script.