-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip tool add wait parameter to reportable attribute #11527
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_AddWaitParameterToReportableAttribute
Nov 9, 2021
Merged
Chip tool add wait parameter to reportable attribute #11527
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_AddWaitParameterToReportableAttribute
Nov 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
November 8, 2021 14:00
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
wbschiller,
woody-apple and
yunhanw-google
November 8, 2021 14:00
PR #11527: Size comparison from 3f82de1 to e479a40 Increases (2 builds for esp32, linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
approved these changes
Nov 8, 2021
Couldn't quite tell where |
vivien-apple
commented
Nov 8, 2021
bzbarsky-apple
approved these changes
Nov 8, 2021
Fast tracking, given this is unblock testing and in a test tool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool
report command does not work properly since "reports" has been updated to use IM. For instance it does not wait for the first generated report to comes, and so the failure/success of the command is not reported accurately.This PR also add a
wait
parameter to the report command in order to have a mechanism to listen for reports on the configured attribute.Change overview
report
command to match how it works now with IMwait
parameter in case the command needs to continue listening after the first reportTesting
It was tested locally using:
./out/debug/standalone/chip-tool onoff report on-off 1 3 1 0x12345 1