Add a way to run custom cluster logic for attribute write #11520

yufengwangca · 2021-11-08T06:15:36Z

Problem

What is being fixed? Examples:
Currently, we only have read API in AttributeAccessInterface to handle platform attributes (the attributes handled by SDK-internal logic, neither living in the "global" attribute store nor handled by an application-level callback by marking them "external".

We need to have a write API in AttributeAccessInterface to handle the write operation for those platform attributes using SDK-internal logic.

Change overview

Add a way to have SDK-internal logic run to write attribute values in TLV form to platform.

This mechanism, when it's used, if the attribute write is not handled by the SDK-nternal logic, we fall back to write it to the attribute store (which might call into the external attribute machinery).

Testing

How was this tested? (at least one bullet point required)

New yaml tests were added to test this API.

todo · 2021-11-08T06:15:38Z

Add yaml test case for NullablesAndOptionalsStruct list

connectedhomeip/src/app/clusters/test-cluster-server/test-cluster-server.cpp

Lines 340 to 345 in d38aee2

    
               // TODO Add yaml test case for NullablesAndOptionalsStruct list 
        
               return CHIP_NO_ERROR; 
        
           } 
        
           } // namespace 
        
           bool emberAfTestClusterClusterTestCallback(app::CommandHandler *, const app::ConcreteCommandPath & commandPath,

This comment was generated by todo based on a `TODO` comment in `d38aee2` in #11520. cc @yufengwangca.

todo · 2021-11-08T06:15:41Z

Refactor WriteSingleClusterData and all dependent functions to take ConcreteAttributePath instead of ClusterInfo

connectedhomeip/src/app/util/ember-compatibility-functions.cpp

Lines 482 to 492 in d38aee2

    
           // TODO: Refactor WriteSingleClusterData and all dependent functions to take ConcreteAttributePath instead of ClusterInfo 
        
           // as the input argument. 
        
           AttributeAccessInterface * attrOverride = findAttributeAccessOverride(aClusterInfo.mEndpointId, aClusterInfo.mClusterId); 
        
           if (attrOverride != nullptr) 
        
           { 
        
               bool dataWrite; 
        
               ConcreteAttributePath path(aClusterInfo.mEndpointId, aClusterInfo.mClusterId, aClusterInfo.mFieldId); 
        
               ReturnErrorOnFailure(attrOverride->Write(path, aReader, &dataWrite)); 
        
               if (dataWrite)

This comment was generated by todo based on a `TODO` comment in `d38aee2` in #11520. cc @yufengwangca.

github-actions · 2021-11-08T06:40:33Z

PR #11520: Size comparison from 3f82de1 to d38aee2

Increases above 0.2%:

platform	target	config	section	`3f82de1`	`d38aee2`	change	% change
linux	all-clusters-app	debug	(read only)	1704225	1709689	5464	0.3
			.bss	50608	50800	192	0.4
			.text	1431586	1436594	5008	0.3
	chip-tool	debug	(read only)	`4931485`	4950957	19472	0.4
			.text	4429077	4448357	19280	0.4

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`3f82de1`	`d38aee2`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745848	745944	96	0.0
			.text	745840	745936	96	0.0
		BRD4161A+rpc	(read only)	733384	733480	96	0.0
			.text	733376	733472	96	0.0
	lock-app	BRD4161A	(read only)	725136	725232	96	0.0
			.text	725128	725224	96	0.0
	window-app	BRD4161A	(read only)	726032	726128	96	0.0
			.text	726024	726120	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	882786	883554	768	0.1
			(read/write)	1306040	1306192	152	0.0
			.dram0.bss	57608	57720	112	0.2
			.flash.rodata	198712	198752	40	0.0
			.flash.text	882786	883554	768	0.1
		m5stack	(read only)	913623	914307	684	0.1
			(read/write)	423336	423496	160	0.0
			.dram0.bss	60112	60232	120	0.2
			.flash.rodata	204952	204992	40	0.0
			.flash.text	913623	914307	684	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	699560	699636	76	0.0
			.text	614044	614120	76	0.0
	lock-app	k32w061+debug	(read/write)	592364	592440	76	0.0
			.text	516348	516424	76	0.0
	shell	k32w061+debug	(read/write)	657860	657936	76	0.0
			.text	571236	571312	76	0.0
linux	all-clusters-app	debug	(read only)	1704225	1709689	5464	0.3
			(read/write)	119232	119456	224	0.2
			.bss	50608	50800	192	0.4
			.data.rel.ro	62304	62352	48	0.1
			.rodata	139221	139413	192	0.1
			.text	1431586	1436594	5008	0.3
	bridge-app	debug+rpc	(read only)	1292261	1292837	576	0.0
			(read/write)	69808	69872	64	0.1
			.data.rel.ro	27736	27800	64	0.2
			.rodata	111028	111124	96	0.1
			.text	1085365	1085653	288	0.0
	chip-tool	debug	(read only)	`4931485`	4950957	19472	0.4
			.rodata	233488	233680	192	0.1
			.text	4429077	4448357	19280	0.4
	lighting-app	debug+rpc	(read only)	1553257	1553833	576	0.0
			(read/write)	102776	102872	96	0.1
			.data.rel.ro	55136	55232	96	0.2
			.rodata	129649	129745	96	0.1
			.text	1290050	`1290338`	288	0.0
	ota-provider-app	debug	(read only)	1251465	1251801	336	0.0
			(read/write)	67976	68008	32	0.0
			.data.rel.ro	24536	24568	32	0.1
			.text	1043154	1043442	288	0.0
	ota-requestor-app	debug	(read only)	1329761	1330097	336	0.0
			.data.rel.ro	25544	25560	16	0.1
			.text	1107522	1107810	288	0.0
	tv-app	debug	(read only)	`1817233`	1818049	816	0.0
			(read/write)	290400	290528	128	0.0
			.data.rel.ro	58792	58920	128	0.2
			.rodata	155304	155496	192	0.1
			.text	1519666	1519954	288	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2291640	`2292376`	736	0.0
			.bss	178924	179044	120	0.1
			.text	1254240	1254976	736	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2271800	2271832	32	0.0
			.text	1234400	`1234432`	32	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2249456	2249544	88	0.0
			.text	1212056	1212144	88	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861635	861731	96	0.0
			rodata	96932	96964	32	0.0
			text	577804	577860	56	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	823983	824079	96	0.0
			rodata	88112	88144	32	0.0
			text	551952	552008	56	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786678	786774	96	0.0
			rodata	92192	92224	32	0.0
			text	507264	507320	56	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838359	838439	80	0.0
			rodata	93304	93336	32	0.0
			text	559284	559344	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763654	763734	80	0.0
			rodata	88608	88640	32	0.0
			text	488836	488896	60	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844451	844531	80	0.0
			rodata	95012	95044	32	0.0
			text	563448	563504	56	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838215	838311	96	0.0
			rodata	93304	93336	32	0.0
			text	559020	559080	60	0.0
p6	all-clusters-app	default	(read/write)	2301136	2302024	888	0.0
			.bss	106872	106984	112	0.1
			.text	1259400	`1260288`	888	0.1
	lock-app	default	(read/write)	`2213848`	`2213944`	96	0.0
			.text	1172112	1172208	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490896	490972	76	0.0
			.text	485576	485652	76	0.0
	lock-app	qpg6100+debug	(read only)	467236	467312	76	0.0
			.text	461916	461992	76	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663242	663326	84	0.0
			text	458250	458312	62	0.0

Decreases (2 builds for mbed, p6)

platform	target	config	section	`3f82de1`	`d38aee2`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	852296	852176	-120	-0.0
p6	all-clusters-app	default	.heap	923944	923832	-112	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`3f82de1`	`d38aee2`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745848	745944	96	0.0
			(read/write)	115740	115740	0	0.0
			.bss	113964	113964	0	0.0
			.data	1776	1776	0	0.0
			.text	745840	745936	96	0.0
		BRD4161A+rpc	(read only)	733384	733480	96	0.0
			(read/write)	132364	132364	0	0.0
			.bss	130468	130468	0	0.0
			.data	1892	1892	0	0.0
			.text	733376	733472	96	0.0
	lock-app	BRD4161A	(read only)	725136	725232	96	0.0
			(read/write)	113556	113556	0	0.0
			.bss	111820	111820	0	0.0
			.data	1736	1736	0	0.0
			.text	725128	725224	96	0.0
	window-app	BRD4161A	(read only)	726032	726128	96	0.0
			(read/write)	113884	113884	0	0.0
			.bss	112140	112140	0	0.0
			.data	1740	1740	0	0.0
			.text	726024	726120	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	882786	883554	768	0.1
			(read/write)	1306040	1306192	152	0.0
			.dram0.bss	57608	57720	112	0.2
			.dram0.data	16472	16472	0	0.0
			.flash.rodata	198712	198752	40	0.0
			.flash.text	882786	883554	768	0.1
			.iram0.text	57624	57624	0	0.0
		m5stack	(read only)	913623	914307	684	0.1
			(read/write)	423336	423496	160	0.0
			.dram0.bss	60112	60232	120	0.2
			.dram0.data	32108	32108	0	0.0
			.flash.rodata	204952	204992	40	0.0
			.flash.text	913623	914307	684	0.1
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699560	699636	76	0.0
			.bss	77808	77808	0	0.0
			.data	1908	1908	0	0.0
			.text	614044	614120	76	0.0
	lock-app	k32w061+debug	(read/write)	592364	592440	76	0.0
			.bss	68340	68340	0	0.0
			.data	1876	1876	0	0.0
			.text	516348	516424	76	0.0
	shell	k32w061+debug	(read/write)	657860	657936	76	0.0
			.bss	78980	78980	0	0.0
			.data	1844	1844	0	0.0
			.text	571236	571312	76	0.0
linux	all-clusters-app	debug	(read only)	1704225	1709689	5464	0.3
			(read/write)	119232	119456	224	0.2
			.bss	50608	50800	192	0.4
			.data	1042	1042	0	0.0
			.data.rel.ro	62304	62352	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139221	139413	192	0.1
			.text	1431586	1436594	5008	0.3
	bridge-app	debug+rpc	(read only)	1292261	1292837	576	0.0
			(read/write)	69808	69872	64	0.1
			.bss	35536	35536	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27736	27800	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111028	111124	96	0.1
			.text	1085365	1085653	288	0.0
	chip-tool	debug	(read only)	`4931485`	4950957	19472	0.4
			(read/write)	126664	126664	0	0.0
			.bss	18736	18736	0	0.0
			.data	2224	2224	0	0.0
			.data.rel.ro	100288	100288	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	432	432	0	0.0
			.rodata	233488	233680	192	0.1
			.text	4429077	4448357	19280	0.4
	lighting-app	debug+rpc	(read only)	1553257	1553833	576	0.0
			(read/write)	102776	102872	96	0.1
			.bss	41176	41176	0	0.0
			.data	1170	1170	0	0.0
			.data.rel.ro	55136	55232	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	129649	129745	96	0.1
			.text	1290050	`1290338`	288	0.0
	ota-provider-app	debug	(read only)	1251465	1251801	336	0.0
			(read/write)	67976	68008	32	0.0
			.bss	37600	37600	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24536	24568	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	112232	112232	0	0.0
			.text	1043154	1043442	288	0.0
	ota-requestor-app	debug	(read only)	1329761	1330097	336	0.0
			(read/write)	77232	77232	0	0.0
			.bss	45728	45728	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25544	25560	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	124208	124208	0	0.0
			.text	1107522	1107810	288	0.0
	shell	debug	(read only)	788041	788041	0	0.0
			(read/write)	58184	58184	0	0.0
			.bss	16648	16648	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36784	36784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	77935	77935	0	0.0
			.text	608642	608642	0	0.0
	tv-app	debug	(read only)	`1817233`	1818049	816	0.0
			(read/write)	290400	290528	128	0.0
			.bss	223248	223248	0	0.0
			.data	2704	2704	0	0.0
			.data.rel.ro	58792	58920	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	155304	155496	192	0.1
			.text	1519666	1519954	288	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2291640	`2292376`	736	0.0
			.bss	178924	179044	120	0.1
			.data	5224	5224	0	0.0
			.heap	852296	852176	-120	-0.0
			.text	1254240	1254976	736	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2271800	2271832	32	0.0
			.bss	171980	171980	0	0.0
			.data	5576	5576	0	0.0
			.heap	858888	858888	0	0.0
			.text	1234400	`1234432`	32	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2249456	2249544	88	0.0
			.bss	170876	170876	0	0.0
			.data	5560	5560	0	0.0
			.heap	860008	860008	0	0.0
			.text	1212056	1212144	88	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048912	2048912	0	0.0
			.bss	156256	156256	0	0.0
			.data	4968	4968	0	0.0
			.heap	875224	875224	0	0.0
			.text	1011512	1011512	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861635	861731	96	0.0
			bss	111280	111280	0	0.0
			rodata	96932	96964	32	0.0
			text	577804	577860	56	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	823983	824079	96	0.0
			bss	107632	107632	0	0.0
			rodata	88112	88144	32	0.0
			text	551952	552008	56	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786678	786774	96	0.0
			bss	112652	112652	0	0.0
			rodata	92192	92224	32	0.0
			text	507264	507320	56	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838359	838439	80	0.0
			bss	110312	110312	0	0.0
			rodata	93304	93336	32	0.0
			text	559284	559344	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763654	763734	80	0.0
			bss	111724	111724	0	0.0
			rodata	88608	88640	32	0.0
			text	488836	488896	60	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844451	844531	80	0.0
			bss	110452	110452	0	0.0
			rodata	95012	95044	32	0.0
			text	563448	563504	56	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838215	838311	96	0.0
			bss	110348	110348	0	0.0
			rodata	93304	93336	32	0.0
			text	559020	559080	60	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776231	776231	0	0.0
			bss	109100	109100	0	0.0
			rodata	72540	72540	0	0.0
			text	519988	519988	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691270	691270	0	0.0
			bss	110084	110084	0	0.0
			rodata	67184	67184	0	0.0
			text	440584	440584	0	0.0
p6	all-clusters-app	default	(read/write)	2301136	2302024	888	0.0
			.bss	106872	106984	112	0.1
			.data	2528	2528	0	0.0
			.heap	923944	923832	-112	-0.0
			.text	1259400	`1260288`	888	0.1
	lock-app	default	(read/write)	`2213848`	`2213944`	96	0.0
			.bss	95680	95680	0	0.0
			.data	2400	2400	0	0.0
			.heap	935264	935264	0	0.0
			.text	1172112	1172208	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490896	490972	76	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50968	50968	0	0.0
			.data	1008	1008	0	0.0
			.text	485576	485652	76	0.0
	lock-app	qpg6100+debug	(read only)	467236	467312	76	0.0
			(read/write)	114140	114140	0	0.0
			.bss	49912	49912	0	0.0
			.data	964	964	0	0.0
			.text	461916	461992	76	0.0
	persistent-storage-app	qpg6100+debug	(read only)	153316	153316	0	0.0
			(read/write)	114144	114144	0	0.0
			.bss	19448	19448	0	0.0
			.data	360	360	0	0.0
			.text	147996	147996	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663242	663326	84	0.0
			bss	69092	69092	0	0.0
			noinit	33216	33216	0	0.0
			text	458250	458312	62	0.0

src/app/AttributeAccessInterface.h

src/app/util/ember-compatibility-functions.cpp

src/app/AttributeAccessInterface.h

src/app/util/ember-compatibility-functions.cpp

src/app/clusters/test-cluster-server/test-cluster-server.cpp

github-actions · 2021-11-08T21:16:17Z

PR #11520: Size comparison from 86511a1 to c523fa9

Increases above 0.2%:

platform	target	config	section	`86511a1`	`c523fa9`	change	% change
linux	all-clusters-app	debug	(read only)	`1704545`	1710009	5464	0.3
			.bss	57360	57552	192	0.3
			.text	1431794	1436802	5008	0.3
	chip-tool	debug	(read only)	4921613	4941197	19584	0.4
			.text	4419125	`4438389`	19264	0.4

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`86511a1`	`c523fa9`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742336	742432	96	0.0
			.text	742328	742424	96	0.0
		BRD4161A+rpc	(read only)	729864	729960	96	0.0
			.text	729856	729952	96	0.0
	lock-app	BRD4161A	(read only)	721600	721712	112	0.0
			.text	721592	721704	112	0.0
	window-app	BRD4161A	(read only)	722496	722608	112	0.0
			.text	722488	722600	112	0.0
esp32	all-clusters-app	c3devkit	(read only)	880266	881034	768	0.1
			(read/write)	`1306488`	1306640	152	0.0
			.dram0.bss	58400	58512	112	0.2
			.flash.rodata	198376	198416	40	0.0
			.flash.text	880266	881034	768	0.1
		m5stack	(read only)	911395	912071	676	0.1
			(read/write)	423808	423968	160	0.0
			.dram0.bss	60904	61024	120	0.2
			.flash.rodata	204632	204672	40	0.0
			.flash.text	911395	912071	676	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	699128	699220	92	0.0
			.text	613440	613532	92	0.0
	lock-app	k32w061+debug	(read/write)	591952	592044	92	0.0
			.text	515764	515856	92	0.0
	shell	k32w061+debug	(read/write)	657608	657700	92	0.0
			.text	570652	570744	92	0.0
linux	all-clusters-app	debug	(read only)	`1704545`	1710009	5464	0.3
			(read/write)	125888	126112	224	0.2
			.bss	57360	57552	192	0.3
			.data.rel.ro	62208	62256	48	0.1
			.rodata	139477	139669	192	0.1
			.text	1431794	1436802	5008	0.3
	bridge-app	debug+rpc	(read only)	1292549	1293125	576	0.0
			(read/write)	76432	76496	64	0.1
			.data.rel.ro	27640	27704	64	0.2
			.rodata	111252	111348	96	0.1
			.text	1085573	1085861	288	0.0
	chip-tool	debug	(read only)	4921613	4941197	19584	0.4
			.rodata	233712	234032	320	0.1
			.text	4419125	`4438389`	19264	0.4
	lighting-app	debug+rpc	(read only)	1553545	1554121	576	0.0
			(read/write)	109432	109528	96	0.1
			.data.rel.ro	55040	55136	96	0.2
			.rodata	129873	129969	96	0.1
			.text	1290258	1290546	288	0.0
	ota-provider-app	debug	(read only)	`1251785`	1252121	336	0.0
			(read/write)	74632	74664	32	0.0
			.data.rel.ro	24440	24472	32	0.1
			.text	1043362	1043650	288	0.0
	ota-requestor-app	debug	(read only)	1330305	1330641	336	0.0
			.data.rel.ro	25448	25464	16	0.1
			.text	1107954	1108242	288	0.0
	tv-app	debug	(read only)	`1818705`	1819537	832	0.0
			(read/write)	297568	297696	128	0.0
			.data.rel.ro	58696	58824	128	0.2
			.rodata	155528	155720	192	0.1
			.text	1521058	1521362	304	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	`2291552`	2292288	736	0.0
			.bss	179404	179524	120	0.1
			.text	1254152	1254888	736	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2271648	2271744	96	0.0
			.text	1234248	1234344	96	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2249368	2249456	88	0.0
			.text	1211968	1212056	88	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861779	861875	96	0.0
			rodata	96932	96964	32	0.0
			text	577776	577836	60	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824127	824207	80	0.0
			rodata	88112	88144	32	0.0
			text	551924	551984	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786822	786918	96	0.0
			rodata	92192	92224	32	0.0
			text	507248	507308	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838487	838583	96	0.0
			rodata	93304	93336	32	0.0
			text	559256	559320	64	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763798	763894	96	0.0
			rodata	88608	88640	32	0.0
			text	488820	488884	64	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844579	844675	96	0.0
			rodata	95012	95044	32	0.0
			text	563420	563480	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838343	838439	96	0.0
			rodata	93304	93336	32	0.0
			text	558992	559056	64	0.0
p6	all-clusters-app	default	(read/write)	2298888	`2299768`	880	0.0
			.bss	111936	112048	112	0.1
			.text	1257152	1258032	880	0.1
	lock-app	default	(read/write)	2211592	`2211704`	112	0.0
			.text	`1169856`	1169968	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490276	490368	92	0.0
			.text	484956	485048	92	0.0
	lock-app	qpg6100+debug	(read only)	466616	466692	76	0.0
			.text	461296	461372	76	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663510	92	0.0
			text	458266	458330	64	0.0

Decreases (2 builds for mbed, p6)

platform	target	config	section	`86511a1`	`c523fa9`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851808	851688	-120	-0.0
p6	all-clusters-app	default	.heap	918872	918760	-112	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`86511a1`	`c523fa9`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742336	742432	96	0.0
			(read/write)	116236	116236	0	0.0
			.bss	114452	114452	0	0.0
			.data	1784	1784	0	0.0
			.text	742328	742424	96	0.0
		BRD4161A+rpc	(read only)	729864	729960	96	0.0
			(read/write)	132860	132860	0	0.0
			.bss	130956	130956	0	0.0
			.data	1900	1900	0	0.0
			.text	729856	729952	96	0.0
	lock-app	BRD4161A	(read only)	721600	721712	112	0.0
			(read/write)	114052	114052	0	0.0
			.bss	112308	112308	0	0.0
			.data	1744	1744	0	0.0
			.text	721592	721704	112	0.0
	window-app	BRD4161A	(read only)	722496	722608	112	0.0
			(read/write)	114380	114380	0	0.0
			.bss	112628	112628	0	0.0
			.data	1748	1748	0	0.0
			.text	722488	722600	112	0.0
esp32	all-clusters-app	c3devkit	(read only)	880266	881034	768	0.1
			(read/write)	`1306488`	1306640	152	0.0
			.dram0.bss	58400	58512	112	0.2
			.dram0.data	16472	16472	0	0.0
			.flash.rodata	198376	198416	40	0.0
			.flash.text	880266	881034	768	0.1
			.iram0.text	57526	57526	0	0.0
		m5stack	(read only)	911395	912071	676	0.1
			(read/write)	423808	423968	160	0.0
			.dram0.bss	60904	61024	120	0.2
			.dram0.data	32108	32108	0	0.0
			.flash.rodata	204632	204672	40	0.0
			.flash.text	911395	912071	676	0.1
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699128	699220	92	0.0
			.bss	77976	77976	0	0.0
			.data	1912	1912	0	0.0
			.text	613440	613532	92	0.0
	lock-app	k32w061+debug	(read/write)	591952	592044	92	0.0
			.bss	68508	68508	0	0.0
			.data	1880	1880	0	0.0
			.text	515764	515856	92	0.0
	shell	k32w061+debug	(read/write)	657608	657700	92	0.0
			.bss	79308	79308	0	0.0
			.data	1848	1848	0	0.0
			.text	570652	570744	92	0.0
linux	all-clusters-app	debug	(read only)	`1704545`	1710009	5464	0.3
			(read/write)	125888	126112	224	0.2
			.bss	57360	57552	192	0.3
			.data	1042	1042	0	0.0
			.data.rel.ro	62208	62256	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139477	139669	192	0.1
			.text	1431794	1436802	5008	0.3
	bridge-app	debug+rpc	(read only)	1292549	1293125	576	0.0
			(read/write)	76432	76496	64	0.1
			.bss	42256	42256	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27640	27704	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111252	111348	96	0.1
			.text	1085573	1085861	288	0.0
	chip-tool	debug	(read only)	4921613	4941197	19584	0.4
			(read/write)	133160	133160	0	0.0
			.bss	25328	25328	0	0.0
			.data	2224	2224	0	0.0
			.data.rel.ro	100192	100192	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	432	432	0	0.0
			.rodata	233712	234032	320	0.1
			.text	4419125	`4438389`	19264	0.4
	lighting-app	debug+rpc	(read only)	1553545	1554121	576	0.0
			(read/write)	109432	109528	96	0.1
			.bss	47928	47928	0	0.0
			.data	1170	1170	0	0.0
			.data.rel.ro	55040	55136	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	129873	129969	96	0.1
			.text	1290258	1290546	288	0.0
	ota-provider-app	debug	(read only)	`1251785`	1252121	336	0.0
			(read/write)	74632	74664	32	0.0
			.bss	44352	44352	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24440	24472	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	112488	112488	0	0.0
			.text	1043362	1043650	288	0.0
	ota-requestor-app	debug	(read only)	1330305	1330641	336	0.0
			(read/write)	83920	83920	0	0.0
			.bss	52512	52512	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25448	25464	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	124464	124464	0	0.0
			.text	1107954	1108242	288	0.0
	shell	debug	(read only)	788153	788153	0	0.0
			(read/write)	64808	64808	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36656	36656	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	78127	78127	0	0.0
			.text	608754	608754	0	0.0
	tv-app	debug	(read only)	`1818705`	1819537	832	0.0
			(read/write)	297568	297696	128	0.0
			.bss	230512	230512	0	0.0
			.data	2704	2704	0	0.0
			.data.rel.ro	58696	58824	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	155528	155720	192	0.1
			.text	1521058	1521362	304	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2291552`	2292288	736	0.0
			.bss	179404	179524	120	0.1
			.data	5232	5232	0	0.0
			.heap	851808	851688	-120	-0.0
			.text	1254152	1254888	736	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2271648	2271744	96	0.0
			.bss	172460	172460	0	0.0
			.data	5584	5584	0	0.0
			.heap	858400	858400	0	0.0
			.text	1234248	1234344	96	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2249368	2249456	88	0.0
			.bss	171356	171356	0	0.0
			.data	5568	5568	0	0.0
			.heap	859520	859520	0	0.0
			.text	1211968	1212056	88	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048760	2048760	0	0.0
			.bss	156424	156424	0	0.0
			.data	4976	4976	0	0.0
			.heap	875048	875048	0	0.0
			.text	1011360	1011360	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861779	861875	96	0.0
			bss	111444	111444	0	0.0
			rodata	96932	96964	32	0.0
			text	577776	577836	60	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824127	824207	80	0.0
			bss	107796	107796	0	0.0
			rodata	88112	88144	32	0.0
			text	551924	551984	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786822	786918	96	0.0
			bss	112816	112816	0	0.0
			rodata	92192	92224	32	0.0
			text	507248	507308	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838487	838583	96	0.0
			bss	110476	110476	0	0.0
			rodata	93304	93336	32	0.0
			text	559256	559320	64	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763798	763894	96	0.0
			bss	111888	111888	0	0.0
			rodata	88608	88640	32	0.0
			text	488820	488884	64	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844579	844675	96	0.0
			bss	110616	110616	0	0.0
			rodata	95012	95044	32	0.0
			text	563420	563480	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838343	838439	96	0.0
			bss	110512	110512	0	0.0
			rodata	93304	93336	32	0.0
			text	558992	559056	64	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776375	776375	0	0.0
			bss	109264	109264	0	0.0
			rodata	72540	72540	0	0.0
			text	519972	519972	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691430	691430	0	0.0
			bss	110248	110248	0	0.0
			rodata	67184	67184	0	0.0
			text	440580	440580	0	0.0
p6	all-clusters-app	default	(read/write)	2298888	`2299768`	880	0.0
			.bss	111936	112048	112	0.1
			.data	2536	2536	0	0.0
			.heap	918872	918760	-112	-0.0
			.text	1257152	1258032	880	0.1
	lock-app	default	(read/write)	2211592	`2211704`	112	0.0
			.bss	100744	100744	0	0.0
			.data	2408	2408	0	0.0
			.heap	930192	930192	0	0.0
			.text	`1169856`	1169968	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490276	490368	92	0.0
			(read/write)	114140	114140	0	0.0
			.bss	51136	51136	0	0.0
			.data	1012	1012	0	0.0
			.text	484956	485048	92	0.0
	lock-app	qpg6100+debug	(read only)	466616	466692	76	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50080	50080	0	0.0
			.data	968	968	0	0.0
			.text	461296	461372	76	0.0
	persistent-storage-app	qpg6100+debug	(read only)	153396	153396	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	19600	19600	0	0.0
			.data	364	364	0	0.0
			.text	148076	148076	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663510	92	0.0
			bss	69256	69256	0	0.0
			noinit	33216	33216	0	0.0
			text	458266	458330	64	0.0

github-actions · 2021-11-09T05:14:00Z

PR #11520: Size comparison from 94c5144 to 4ee1f61

Increases above 0.2%:

platform	target	config	section	`94c5144`	`4ee1f61`	change	% change
linux	all-clusters-app	debug	(read only)	1710033	`1715465`	5432	0.3
			(read/write)	125888	126144	256	0.2
			.bss	57360	57552	192	0.3
			.text	1436946	1441922	4976	0.3
	bridge-app	debug+rpc	.data.rel.ro	27640	27704	64	0.2
	chip-tool	debug	(read only)	4927909	4947349	19440	0.4
			.text	4423013	4442101	19088	0.4
	tv-app	debug	.data.rel.ro	59328	59456	128	0.2

Increases (19 builds for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`94c5144`	`4ee1f61`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742640	742752	112	0.0
			.text	742632	742744	112	0.0
		BRD4161A+rpc	(read only)	730184	730280	96	0.0
			.text	730176	730272	96	0.0
	lock-app	BRD4161A	(read only)	721920	722032	112	0.0
			.text	721912	722024	112	0.0
	window-app	BRD4161A	(read only)	722832	722928	96	0.0
			.text	722824	722920	96	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699576	699652	76	0.0
			.text	613884	613960	76	0.0
	lock-app	k32w061+debug	(read/write)	592288	592364	76	0.0
			.text	516100	516176	76	0.0
	shell	k32w061+debug	(read/write)	657944	658020	76	0.0
			.text	570988	571064	76	0.0
linux	all-clusters-app	debug	(read only)	1710033	`1715465`	5432	0.3
			(read/write)	125888	126144	256	0.2
			.bss	57360	57552	192	0.3
			.data.rel.ro	62224	62272	48	0.1
			.rodata	139765	139957	192	0.1
			.text	1436946	1441922	4976	0.3
	bridge-app	debug+rpc	(read only)	`1297685`	`1298261`	576	0.0
			(read/write)	76432	76496	64	0.1
			.data.rel.ro	27640	27704	64	0.2
			.rodata	111540	111636	96	0.1
			.text	`1090421`	1090709	288	0.0
	chip-tool	debug	(read only)	4927909	4947349	19440	0.4
			.rodata	234416	234768	352	0.2
			.text	4423013	4442101	19088	0.4
	lighting-app	debug+rpc	(read only)	`1557361`	1557937	576	0.0
			(read/write)	109448	109544	96	0.1
			.data.rel.ro	55040	55136	96	0.2
			.rodata	128977	129073	96	0.1
			.text	1294994	1295282	288	0.0
	ota-provider-app	debug	(read only)	1259137	1259473	336	0.0
			(read/write)	74696	74728	32	0.0
			.data.rel.ro	24488	24520	32	0.1
			.text	1049842	1050130	288	0.0
	ota-requestor-app	debug	(read only)	1343697	1344033	336	0.0
			(read/write)	78464	78496	32	0.0
			.data.rel.ro	25752	25768	16	0.1
			.text	1120834	1121122	288	0.0
	tv-app	debug	(read only)	1841649	1842465	816	0.0
			(read/write)	407328	407456	128	0.0
			.data.rel.ro	59328	59456	128	0.2
			.rodata	156456	156648	192	0.1
			.text	1541442	`1541730`	288	0.0
p6	all-clusters-app	default	(read/write)	`2299288`	`2300176`	888	0.0
			.bss	111936	112048	112	0.1
			.text	1257552	1258440	888	0.1
	lock-app	default	(read/write)	`2211928`	`2212024`	96	0.0
			.text	1170192	1170288	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490712	490788	76	0.0
			.text	485392	485468	76	0.0
	lock-app	qpg6100+debug	(read only)	466940	467016	76	0.0
			.text	461620	461696	76	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663682	663774	92	0.0
			text	458562	458626	64	0.0

Decreases (1 build for p6)

platform	target	config	section	`94c5144`	`4ee1f61`	change	% change
p6	all-clusters-app	default	.heap	918872	918760	-112	-0.0

Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`94c5144`	`4ee1f61`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742640	742752	112	0.0
			(read/write)	116236	116236	0	0.0
			.bss	114452	114452	0	0.0
			.data	1784	1784	0	0.0
			.text	742632	742744	112	0.0
		BRD4161A+rpc	(read only)	730184	730280	96	0.0
			(read/write)	132860	132860	0	0.0
			.bss	130956	130956	0	0.0
			.data	1900	1900	0	0.0
			.text	730176	730272	96	0.0
	lock-app	BRD4161A	(read only)	721920	722032	112	0.0
			(read/write)	114052	114052	0	0.0
			.bss	112308	112308	0	0.0
			.data	1744	1744	0	0.0
			.text	721912	722024	112	0.0
	window-app	BRD4161A	(read only)	722832	722928	96	0.0
			(read/write)	114380	114380	0	0.0
			.bss	112628	112628	0	0.0
			.data	1748	1748	0	0.0
			.text	722824	722920	96	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699576	699652	76	0.0
			.bss	77980	77980	0	0.0
			.data	1912	1912	0	0.0
			.text	613884	613960	76	0.0
	lock-app	k32w061+debug	(read/write)	592288	592364	76	0.0
			.bss	68508	68508	0	0.0
			.data	1880	1880	0	0.0
			.text	516100	516176	76	0.0
	shell	k32w061+debug	(read/write)	657944	658020	76	0.0
			.bss	79308	79308	0	0.0
			.data	1848	1848	0	0.0
			.text	570988	571064	76	0.0
linux	all-clusters-app	debug	(read only)	1710033	`1715465`	5432	0.3
			(read/write)	125888	126144	256	0.2
			.bss	57360	57552	192	0.3
			.data	1042	1042	0	0.0
			.data.rel.ro	62224	62272	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139765	139957	192	0.1
			.text	1436946	1441922	4976	0.3
	bridge-app	debug+rpc	(read only)	`1297685`	`1298261`	576	0.0
			(read/write)	76432	76496	64	0.1
			.bss	42256	42256	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27640	27704	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111540	111636	96	0.1
			.text	`1090421`	1090709	288	0.0
	chip-tool	debug	(read only)	4927909	4947349	19440	0.4
			(read/write)	133856	133856	0	0.0
			.bss	25328	25328	0	0.0
			.data	2256	2256	0	0.0
			.data.rel.ro	100856	100856	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	234416	234768	352	0.2
			.text	4423013	4442101	19088	0.4
	lighting-app	debug+rpc	(read only)	`1557361`	1557937	576	0.0
			(read/write)	109448	109544	96	0.1
			.bss	47920	47920	0	0.0
			.data	1202	1202	0	0.0
			.data.rel.ro	55040	55136	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	128977	129073	96	0.1
			.text	1294994	1295282	288	0.0
	ota-provider-app	debug	(read only)	1259137	1259473	336	0.0
			(read/write)	74696	74728	32	0.0
			.bss	44352	44352	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24520	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113216	113216	0	0.0
			.text	1049842	1050130	288	0.0
	ota-requestor-app	debug	(read only)	1343697	1344033	336	0.0
			(read/write)	78464	78496	32	0.0
			.bss	46816	46816	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25752	25768	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	124232	124232	0	0.0
			.text	1120834	1121122	288	0.0
	shell	debug	(read only)	788233	788233	0	0.0
			(read/write)	64808	64808	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36656	36656	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	78191	78191	0	0.0
			.text	608770	608770	0	0.0
	tv-app	debug	(read only)	1841649	1842465	816	0.0
			(read/write)	407328	407456	128	0.0
			.bss	339600	339600	0	0.0
			.data	2736	2736	0	0.0
			.data.rel.ro	59328	59456	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	156456	156648	192	0.1
			.text	1541442	`1541730`	288	0.0
p6	all-clusters-app	default	(read/write)	`2299288`	`2300176`	888	0.0
			.bss	111936	112048	112	0.1
			.data	2536	2536	0	0.0
			.heap	918872	918760	-112	-0.0
			.text	1257552	1258440	888	0.1
	lock-app	default	(read/write)	`2211928`	`2212024`	96	0.0
			.bss	100744	100744	0	0.0
			.data	2408	2408	0	0.0
			.heap	930192	930192	0	0.0
			.text	1170192	1170288	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490712	490788	76	0.0
			(read/write)	114140	114140	0	0.0
			.bss	51136	51136	0	0.0
			.data	1012	1012	0	0.0
			.text	485392	485468	76	0.0
	lock-app	qpg6100+debug	(read only)	466940	467016	76	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50080	50080	0	0.0
			.data	968	968	0	0.0
			.text	461620	461696	76	0.0
	persistent-storage-app	qpg6100+debug	(read only)	153400	153400	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	19600	19600	0	0.0
			.data	364	364	0	0.0
			.text	148080	148080	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663682	663774	92	0.0
			bss	69256	69256	0	0.0
			noinit	33216	33216	0	0.0
			text	458562	458626	64	0.0

github-actions · 2021-11-09T05:46:07Z

PR #11520: Size comparison from 94c5144 to f2c6661

Increases above 0.2%:

platform	target	config	section	`94c5144`	`f2c6661`	change	% change
linux	all-clusters-app	debug	(read only)	1710033	`1715465`	5432	0.3
			.bss	57360	57552	192	0.3
			.text	1436946	1441922	4976	0.3
	chip-tool	debug	(read only)	4927909	4947349	19440	0.4
			.text	4423013	4442101	19088	0.4

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`94c5144`	`f2c6661`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742640	742752	112	0.0
			.text	742632	742744	112	0.0
		BRD4161A+rpc	(read only)	730184	730280	96	0.0
			.text	730176	730272	96	0.0
	lock-app	BRD4161A	(read only)	721920	722032	112	0.0
			.text	721912	722024	112	0.0
	window-app	BRD4161A	(read only)	722832	722928	96	0.0
			.text	722824	722920	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	880650	881422	772	0.1
			(read/write)	`1306456`	1306608	152	0.0
			.dram0.bss	58400	58512	112	0.2
			.flash.rodata	198344	198384	40	0.0
			.flash.text	880650	881422	772	0.1
		m5stack	(read only)	911803	912507	704	0.1
			(read/write)	423776	423936	160	0.0
			.dram0.bss	60904	61024	120	0.2
			.flash.rodata	204600	204640	40	0.0
			.flash.text	911803	912507	704	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	699576	699652	76	0.0
			.text	613884	613960	76	0.0
	lock-app	k32w061+debug	(read/write)	592288	592364	76	0.0
			.text	516100	516176	76	0.0
	shell	k32w061+debug	(read/write)	657944	658020	76	0.0
			.text	570988	571064	76	0.0
linux	all-clusters-app	debug	(read only)	1710033	`1715465`	5432	0.3
			(read/write)	125888	126144	256	0.2
			.bss	57360	57552	192	0.3
			.data.rel.ro	62224	62272	48	0.1
			.rodata	139765	139957	192	0.1
			.text	1436946	1441922	4976	0.3
	bridge-app	debug+rpc	(read only)	`1297685`	`1298261`	576	0.0
			(read/write)	76432	76496	64	0.1
			.data.rel.ro	27640	27704	64	0.2
			.rodata	111540	111636	96	0.1
			.text	`1090421`	1090709	288	0.0
	chip-tool	debug	(read only)	4927909	4947349	19440	0.4
			.rodata	234416	234768	352	0.2
			.text	4423013	4442101	19088	0.4
	lighting-app	debug+rpc	(read only)	`1557361`	1557937	576	0.0
			(read/write)	109448	109544	96	0.1
			.data.rel.ro	55040	55136	96	0.2
			.rodata	128977	129073	96	0.1
			.text	1294994	1295282	288	0.0
	ota-provider-app	debug	(read only)	1259137	1259473	336	0.0
			(read/write)	74696	74728	32	0.0
			.data.rel.ro	24488	24520	32	0.1
			.text	1049842	1050130	288	0.0
	ota-requestor-app	debug	(read only)	1343697	1344033	336	0.0
			(read/write)	78464	78496	32	0.0
			.data.rel.ro	25752	25768	16	0.1
			.text	1120834	1121122	288	0.0
	tv-app	debug	(read only)	1841649	1842465	816	0.0
			(read/write)	407328	407456	128	0.0
			.data.rel.ro	59328	59456	128	0.2
			.rodata	156456	156648	192	0.1
			.text	1541442	`1541730`	288	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2290768	2291512	744	0.0
			.bss	179404	179524	120	0.1
			.text	1253368	1254112	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2270928	2270960	32	0.0
			.text	1233528	1233560	32	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2248584	2248672	88	0.0
			.text	1211184	`1211272`	88	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862071	862167	96	0.0
			rodata	96904	96936	32	0.0
			text	578100	578164	64	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824419	824515	96	0.0
			rodata	88084	88116	32	0.0
			text	552248	552312	64	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	787126	787222	96	0.0
			rodata	92160	92192	32	0.0
			text	507572	507636	64	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838795	838875	80	0.0
			rodata	93276	93308	32	0.0
			text	559584	559644	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	764090	764186	96	0.0
			rodata	88580	88612	32	0.0
			text	489148	489208	60	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844871	844967	96	0.0
			rodata	94984	95016	32	0.0
			text	563744	563808	64	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838647	838743	96	0.0
			rodata	93272	93304	32	0.0
			text	559320	559380	60	0.0
p6	all-clusters-app	default	(read/write)	`2299288`	`2300176`	888	0.0
			.bss	111936	112048	112	0.1
			.text	1257552	1258440	888	0.1
	lock-app	default	(read/write)	`2211928`	`2212024`	96	0.0
			.text	1170192	1170288	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490712	490788	76	0.0
			.text	485392	485468	76	0.0
	lock-app	qpg6100+debug	(read only)	466940	467016	76	0.0
			.text	461620	461696	76	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663682	663774	92	0.0
			text	458562	458626	64	0.0

Decreases (2 builds for mbed, p6)

platform	target	config	section	`94c5144`	`f2c6661`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851808	851688	-120	-0.0
p6	all-clusters-app	default	.heap	918872	918760	-112	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`94c5144`	`f2c6661`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742640	742752	112	0.0
			(read/write)	116236	116236	0	0.0
			.bss	114452	114452	0	0.0
			.data	1784	1784	0	0.0
			.text	742632	742744	112	0.0
		BRD4161A+rpc	(read only)	730184	730280	96	0.0
			(read/write)	132860	132860	0	0.0
			.bss	130956	130956	0	0.0
			.data	1900	1900	0	0.0
			.text	730176	730272	96	0.0
	lock-app	BRD4161A	(read only)	721920	722032	112	0.0
			(read/write)	114052	114052	0	0.0
			.bss	112308	112308	0	0.0
			.data	1744	1744	0	0.0
			.text	721912	722024	112	0.0
	window-app	BRD4161A	(read only)	722832	722928	96	0.0
			(read/write)	114380	114380	0	0.0
			.bss	112628	112628	0	0.0
			.data	1748	1748	0	0.0
			.text	722824	722920	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	880650	881422	772	0.1
			(read/write)	`1306456`	1306608	152	0.0
			.dram0.bss	58400	58512	112	0.2
			.dram0.data	16472	16472	0	0.0
			.flash.rodata	198344	198384	40	0.0
			.flash.text	880650	881422	772	0.1
			.iram0.text	57526	57526	0	0.0
		m5stack	(read only)	911803	912507	704	0.1
			(read/write)	423776	423936	160	0.0
			.dram0.bss	60904	61024	120	0.2
			.dram0.data	32108	32108	0	0.0
			.flash.rodata	204600	204640	40	0.0
			.flash.text	911803	912507	704	0.1
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699576	699652	76	0.0
			.bss	77980	77980	0	0.0
			.data	1912	1912	0	0.0
			.text	613884	613960	76	0.0
	lock-app	k32w061+debug	(read/write)	592288	592364	76	0.0
			.bss	68508	68508	0	0.0
			.data	1880	1880	0	0.0
			.text	516100	516176	76	0.0
	shell	k32w061+debug	(read/write)	657944	658020	76	0.0
			.bss	79308	79308	0	0.0
			.data	1848	1848	0	0.0
			.text	570988	571064	76	0.0
linux	all-clusters-app	debug	(read only)	1710033	`1715465`	5432	0.3
			(read/write)	125888	126144	256	0.2
			.bss	57360	57552	192	0.3
			.data	1042	1042	0	0.0
			.data.rel.ro	62224	62272	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139765	139957	192	0.1
			.text	1436946	1441922	4976	0.3
	bridge-app	debug+rpc	(read only)	`1297685`	`1298261`	576	0.0
			(read/write)	76432	76496	64	0.1
			.bss	42256	42256	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27640	27704	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111540	111636	96	0.1
			.text	`1090421`	1090709	288	0.0
	chip-tool	debug	(read only)	4927909	4947349	19440	0.4
			(read/write)	133856	133856	0	0.0
			.bss	25328	25328	0	0.0
			.data	2256	2256	0	0.0
			.data.rel.ro	100856	100856	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	234416	234768	352	0.2
			.text	4423013	4442101	19088	0.4
	lighting-app	debug+rpc	(read only)	`1557361`	1557937	576	0.0
			(read/write)	109448	109544	96	0.1
			.bss	47920	47920	0	0.0
			.data	1202	1202	0	0.0
			.data.rel.ro	55040	55136	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	128977	129073	96	0.1
			.text	1294994	1295282	288	0.0
	ota-provider-app	debug	(read only)	1259137	1259473	336	0.0
			(read/write)	74696	74728	32	0.0
			.bss	44352	44352	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24520	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113216	113216	0	0.0
			.text	1049842	1050130	288	0.0
	ota-requestor-app	debug	(read only)	1343697	1344033	336	0.0
			(read/write)	78464	78496	32	0.0
			.bss	46816	46816	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25752	25768	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	124232	124232	0	0.0
			.text	1120834	1121122	288	0.0
	shell	debug	(read only)	788233	788233	0	0.0
			(read/write)	64808	64808	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36656	36656	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	78191	78191	0	0.0
			.text	608770	608770	0	0.0
	tv-app	debug	(read only)	1841649	1842465	816	0.0
			(read/write)	407328	407456	128	0.0
			.bss	339600	339600	0	0.0
			.data	2736	2736	0	0.0
			.data.rel.ro	59328	59456	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	156456	156648	192	0.1
			.text	1541442	`1541730`	288	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2290768	2291512	744	0.0
			.bss	179404	179524	120	0.1
			.data	5232	5232	0	0.0
			.heap	851808	851688	-120	-0.0
			.text	1253368	1254112	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2270928	2270960	32	0.0
			.bss	172460	172460	0	0.0
			.data	5584	5584	0	0.0
			.heap	858400	858400	0	0.0
			.text	1233528	1233560	32	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2248584	2248672	88	0.0
			.bss	171356	171356	0	0.0
			.data	5568	5568	0	0.0
			.heap	859520	859520	0	0.0
			.text	1211184	`1211272`	88	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048760	2048760	0	0.0
			.bss	156424	156424	0	0.0
			.data	4976	4976	0	0.0
			.heap	875048	875048	0	0.0
			.text	1011360	1011360	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862071	862167	96	0.0
			bss	111444	111444	0	0.0
			rodata	96904	96936	32	0.0
			text	578100	578164	64	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824419	824515	96	0.0
			bss	107796	107796	0	0.0
			rodata	88084	88116	32	0.0
			text	552248	552312	64	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	787126	787222	96	0.0
			bss	112816	112816	0	0.0
			rodata	92160	92192	32	0.0
			text	507572	507636	64	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838795	838875	80	0.0
			bss	110476	110476	0	0.0
			rodata	93276	93308	32	0.0
			text	559584	559644	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	764090	764186	96	0.0
			bss	111888	111888	0	0.0
			rodata	88580	88612	32	0.0
			text	489148	489208	60	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844871	844967	96	0.0
			bss	110616	110616	0	0.0
			rodata	94984	95016	32	0.0
			text	563744	563808	64	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838647	838743	96	0.0
			bss	110512	110512	0	0.0
			rodata	93272	93304	32	0.0
			text	559320	559380	60	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776379	776379	0	0.0
			bss	109264	109264	0	0.0
			rodata	72544	72544	0	0.0
			text	519972	519972	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691430	691430	0	0.0
			bss	110248	110248	0	0.0
			rodata	67184	67184	0	0.0
			text	440580	440580	0	0.0
p6	all-clusters-app	default	(read/write)	`2299288`	`2300176`	888	0.0
			.bss	111936	112048	112	0.1
			.data	2536	2536	0	0.0
			.heap	918872	918760	-112	-0.0
			.text	1257552	1258440	888	0.1
	lock-app	default	(read/write)	`2211928`	`2212024`	96	0.0
			.bss	100744	100744	0	0.0
			.data	2408	2408	0	0.0
			.heap	930192	930192	0	0.0
			.text	1170192	1170288	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490712	490788	76	0.0
			(read/write)	114140	114140	0	0.0
			.bss	51136	51136	0	0.0
			.data	1012	1012	0	0.0
			.text	485392	485468	76	0.0
	lock-app	qpg6100+debug	(read only)	466940	467016	76	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50080	50080	0	0.0
			.data	968	968	0	0.0
			.text	461620	461696	76	0.0
	persistent-storage-app	qpg6100+debug	(read only)	153400	153400	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	19600	19600	0	0.0
			.data	364	364	0	0.0
			.text	148080	148080	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663682	663774	92	0.0
			bss	69256	69256	0	0.0
			noinit	33216	33216	0	0.0
			text	458562	458626	64	0.0

github-actions · 2021-11-09T18:44:21Z

PR #11520: Size comparison from e6dab37 to 09a4172

Increases above 0.2%:

platform	target	config	section	`e6dab37`	`09a4172`	change	% change
linux	all-clusters-app	debug	(read only)	1710601	1716049	5448	0.3
			.bss	57872	58064	192	0.3
			.text	1437346	1442338	4992	0.3
	chip-tool	debug	(read only)	4995029	5014453	19424	0.4
			.text	4481717	`4500821`	19104	0.4

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`e6dab37`	`09a4172`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742904	743000	96	0.0
			.text	742896	742992	96	0.0
		BRD4161A+rpc	(read only)	730440	730536	96	0.0
			.text	730432	730528	96	0.0
	lock-app	BRD4161A	(read only)	722192	722288	96	0.0
			.text	722184	722280	96	0.0
	window-app	BRD4161A	(read only)	723088	723184	96	0.0
			.text	723080	723176	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	880694	881466	772	0.1
			(read/write)	`1306536`	1306688	152	0.0
			.dram0.bss	58464	58576	112	0.2
			.flash.rodata	198360	198400	40	0.0
			.flash.text	880694	881466	772	0.1
		m5stack	(read only)	911867	912535	668	0.1
			(read/write)	423864	424024	160	0.0
			.dram0.bss	60968	61088	120	0.2
			.flash.rodata	204624	204664	40	0.0
			.flash.text	911867	912535	668	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	699648	699740	92	0.0
			.text	613940	614032	92	0.0
	lock-app	k32w061+debug	(read/write)	592360	592436	76	0.0
			.text	516156	516232	76	0.0
	shell	k32w061+debug	(read/write)	658016	658108	92	0.0
			.text	571044	571136	92	0.0
linux	all-clusters-app	debug	(read only)	1710601	1716049	5448	0.3
			(read/write)	126528	126784	256	0.2
			.bss	57872	58064	192	0.3
			.data.rel.ro	62352	62400	48	0.1
			.rodata	139765	139957	192	0.1
			.text	1437346	1442338	4992	0.3
	bridge-app	debug+rpc	(read only)	1298253	1298829	576	0.0
			(read/write)	77072	77136	64	0.1
			.data.rel.ro	27760	27824	64	0.2
			.rodata	111540	111636	96	0.1
			.text	`1090821`	1091109	288	0.0
	chip-tool	debug	(read only)	4995029	5014453	19424	0.4
			.rodata	242064	242384	320	0.1
			.text	4481717	`4500821`	19104	0.4
	lighting-app	debug+rpc	(read only)	`1557945`	1558521	576	0.0
			(read/write)	110088	110184	96	0.1
			.data.rel.ro	55168	55264	96	0.2
			.rodata	128977	129073	96	0.1
			.text	1295410	1295698	288	0.0
	ota-provider-app	debug	(read only)	1259721	1260057	336	0.0
			(read/write)	75336	75368	32	0.0
			.data.rel.ro	24616	24648	32	0.1
			.text	1050258	1050546	288	0.0
	ota-requestor-app	debug	(read only)	1344281	1344617	336	0.0
			(read/write)	79104	79136	32	0.0
			.data.rel.ro	25880	25896	16	0.1
			.text	`1121250`	1121538	288	0.0
	tv-app	debug	(read only)	1842281	1843113	832	0.0
			(read/write)	407936	408064	128	0.0
			.data.rel.ro	59448	59576	128	0.2
			.rodata	156456	156648	192	0.1
			.text	1541906	1542210	304	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2290856	2291600	744	0.0
			.bss	179436	179556	120	0.1
			.text	`1253456`	`1254200`	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2270952	2271048	96	0.0
			.text	1233552	1233648	96	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2248672	2248696	24	0.0
			.text	`1211272`	1211296	24	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862155	862251	96	0.0
			rodata	96924	96956	32	0.0
			text	578128	578192	64	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824503	824599	96	0.0
			rodata	88104	88136	32	0.0
			text	552276	552340	64	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	787162	787258	96	0.0
			rodata	92180	92212	32	0.0
			text	507600	507664	64	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838831	838927	96	0.0
			rodata	93296	93328	32	0.0
			text	559612	559672	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	764142	764238	96	0.0
			rodata	88600	88632	32	0.0
			text	489176	489236	60	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844955	845051	96	0.0
			rodata	95004	95036	32	0.0
			text	563772	563836	64	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838699	838779	80	0.0
			rodata	93292	93324	32	0.0
			text	559348	559408	60	0.0
p6	all-clusters-app	default	(read/write)	`2299528`	`2300424`	896	0.0
			.bss	112448	112560	112	0.1
			.text	1257792	1258688	896	0.1
	lock-app	default	(read/write)	2212184	2212280	96	0.0
			.text	1170448	1170544	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490776	490852	76	0.0
			.text	485456	485532	76	0.0
	lock-app	qpg6100+debug	(read only)	466988	467080	92	0.0
			.text	461668	461760	92	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663750	663842	92	0.0
			text	458596	458660	64	0.0

Decreases (2 builds for mbed, p6)

platform	target	config	section	`e6dab37`	`09a4172`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851776	851656	-120	-0.0
p6	all-clusters-app	default	.heap	918360	918248	-112	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`e6dab37`	`09a4172`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742904	743000	96	0.0
			(read/write)	116268	116268	0	0.0
			.bss	114484	114484	0	0.0
			.data	1784	1784	0	0.0
			.text	742896	742992	96	0.0
		BRD4161A+rpc	(read only)	730440	730536	96	0.0
			(read/write)	132892	132892	0	0.0
			.bss	130988	130988	0	0.0
			.data	1900	1900	0	0.0
			.text	730432	730528	96	0.0
	lock-app	BRD4161A	(read only)	722192	722288	96	0.0
			(read/write)	114084	114084	0	0.0
			.bss	112340	112340	0	0.0
			.data	1744	1744	0	0.0
			.text	722184	722280	96	0.0
	window-app	BRD4161A	(read only)	723088	723184	96	0.0
			(read/write)	114412	114412	0	0.0
			.bss	112660	112660	0	0.0
			.data	1748	1748	0	0.0
			.text	723080	723176	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	880694	881466	772	0.1
			(read/write)	`1306536`	1306688	152	0.0
			.dram0.bss	58464	58576	112	0.2
			.dram0.data	16472	16472	0	0.0
			.flash.rodata	198360	198400	40	0.0
			.flash.text	880694	881466	772	0.1
			.iram0.text	57526	57526	0	0.0
		m5stack	(read only)	911867	912535	668	0.1
			(read/write)	423864	424024	160	0.0
			.dram0.bss	60968	61088	120	0.2
			.dram0.data	32108	32108	0	0.0
			.flash.rodata	204624	204664	40	0.0
			.flash.text	911867	912535	668	0.1
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699648	699740	92	0.0
			.bss	77996	77996	0	0.0
			.data	1912	1912	0	0.0
			.text	613940	614032	92	0.0
	lock-app	k32w061+debug	(read/write)	592360	592436	76	0.0
			.bss	68524	68524	0	0.0
			.data	1880	1880	0	0.0
			.text	516156	516232	76	0.0
	shell	k32w061+debug	(read/write)	658016	658108	92	0.0
			.bss	79324	79324	0	0.0
			.data	1848	1848	0	0.0
			.text	571044	571136	92	0.0
linux	all-clusters-app	debug	(read only)	1710601	1716049	5448	0.3
			(read/write)	126528	126784	256	0.2
			.bss	57872	58064	192	0.3
			.data	1042	1042	0	0.0
			.data.rel.ro	62352	62400	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139765	139957	192	0.1
			.text	1437346	1442338	4992	0.3
	bridge-app	debug+rpc	(read only)	1298253	1298829	576	0.0
			(read/write)	77072	77136	64	0.1
			.bss	42768	42768	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27760	27824	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111540	111636	96	0.1
			.text	`1090821`	1091109	288	0.0
	chip-tool	debug	(read only)	4995029	5014453	19424	0.4
			(read/write)	134760	134760	0	0.0
			.bss	25840	25840	0	0.0
			.data	2256	2256	0	0.0
			.data.rel.ro	101232	101232	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	432	432	0	0.0
			.rodata	242064	242384	320	0.1
			.text	4481717	`4500821`	19104	0.4
	lighting-app	debug+rpc	(read only)	`1557945`	1558521	576	0.0
			(read/write)	110088	110184	96	0.1
			.bss	48432	48432	0	0.0
			.data	1202	1202	0	0.0
			.data.rel.ro	55168	55264	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	128977	129073	96	0.1
			.text	1295410	1295698	288	0.0
	ota-provider-app	debug	(read only)	1259721	1260057	336	0.0
			(read/write)	75336	75368	32	0.0
			.bss	44864	44864	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24616	24648	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	113216	113216	0	0.0
			.text	1050258	1050546	288	0.0
	ota-requestor-app	debug	(read only)	1344281	1344617	336	0.0
			(read/write)	79104	79136	32	0.0
			.bss	47328	47328	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25880	25896	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	124232	124232	0	0.0
			.text	`1121250`	1121538	288	0.0
	shell	debug	(read only)	789065	789065	0	0.0
			(read/write)	65480	65480	0	0.0
			.bss	23912	23912	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36816	36816	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	78191	78191	0	0.0
			.text	609362	609362	0	0.0
	tv-app	debug	(read only)	1842281	1843113	832	0.0
			(read/write)	407936	408064	128	0.0
			.bss	340112	340112	0	0.0
			.data	2736	2736	0	0.0
			.data.rel.ro	59448	59576	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	156456	156648	192	0.1
			.text	1541906	1542210	304	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2290856	2291600	744	0.0
			.bss	179436	179556	120	0.1
			.data	5232	5232	0	0.0
			.heap	851776	851656	-120	-0.0
			.text	`1253456`	`1254200`	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2270952	2271048	96	0.0
			.bss	172492	172492	0	0.0
			.data	5584	5584	0	0.0
			.heap	858368	858368	0	0.0
			.text	1233552	1233648	96	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2248672	2248696	24	0.0
			.bss	171388	171388	0	0.0
			.data	5568	5568	0	0.0
			.heap	859488	859488	0	0.0
			.text	`1211272`	1211296	24	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2048864`	`2048864`	0	0.0
			.bss	156456	156456	0	0.0
			.data	4976	4976	0	0.0
			.heap	875016	875016	0	0.0
			.text	1011464	1011464	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862155	862251	96	0.0
			bss	111460	111460	0	0.0
			rodata	96924	96956	32	0.0
			text	578128	578192	64	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824503	824599	96	0.0
			bss	107812	107812	0	0.0
			rodata	88104	88136	32	0.0
			text	552276	552340	64	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	787162	787258	96	0.0
			bss	112832	112832	0	0.0
			rodata	92180	92212	32	0.0
			text	507600	507664	64	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838831	838927	96	0.0
			bss	110492	110492	0	0.0
			rodata	93296	93328	32	0.0
			text	559612	559672	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	764142	764238	96	0.0
			bss	111904	111904	0	0.0
			rodata	88600	88632	32	0.0
			text	489176	489236	60	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844955	845051	96	0.0
			bss	110632	110632	0	0.0
			rodata	95004	95036	32	0.0
			text	563772	563836	64	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838699	838779	80	0.0
			bss	110528	110528	0	0.0
			rodata	93292	93324	32	0.0
			text	559348	559408	60	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776431	776431	0	0.0
			bss	109280	109280	0	0.0
			rodata	72564	72564	0	0.0
			text	520004	520004	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691482	691482	0	0.0
			bss	110264	110264	0	0.0
			rodata	67204	67204	0	0.0
			text	440612	440612	0	0.0
p6	all-clusters-app	default	(read/write)	`2299528`	`2300424`	896	0.0
			.bss	112448	112560	112	0.1
			.data	2536	2536	0	0.0
			.heap	918360	918248	-112	-0.0
			.text	1257792	1258688	896	0.1
	lock-app	default	(read/write)	2212184	2212280	96	0.0
			.bss	101256	101256	0	0.0
			.data	2408	2408	0	0.0
			.heap	929680	929680	0	0.0
			.text	1170448	1170544	96	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490776	490852	76	0.0
			(read/write)	114140	114140	0	0.0
			.bss	51152	51152	0	0.0
			.data	1012	1012	0	0.0
			.text	485456	485532	76	0.0
	lock-app	qpg6100+debug	(read only)	466988	467080	92	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50096	50096	0	0.0
			.data	968	968	0	0.0
			.text	461668	461760	92	0.0
	persistent-storage-app	qpg6100+debug	(read only)	153400	153400	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	19616	19616	0	0.0
			.data	364	364	0	0.0
			.text	148080	148080	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663750	663842	92	0.0
			bss	69272	69272	0	0.0
			noinit	33216	33216	0	0.0
			text	458596	458660	64	0.0

src/app/AttributeAccessInterface.h

src/app/clusters/test-cluster-server/test-cluster-server.cpp

src/app/util/ember-compatibility-functions.cpp

github-actions · 2021-11-11T07:16:25Z

PR #11520: Size comparison from d45cfaa to 49857da

Increases (8 builds for k32w, p6, qpg, telink)

platform	target	config	section	`d45cfaa`	`49857da`	change	% change
k32w	lighting-app	k32w061+se05x+release	(read/write)	699396	699488	92	0.0
			.text	613676	613768	92	0.0
	lock-app	k32w061+debug	(read/write)	592132	592224	92	0.0
			.text	515908	516000	92	0.0
	shell	k32w061+debug	(read/write)	657760	657852	92	0.0
			.text	570776	570868	92	0.0
p6	all-clusters-app	default	(read/write)	2297136	`2298040`	904	0.0
			.bss	112416	112528	112	0.1
			.text	`1255400`	`1256304`	904	0.1
	lock-app	default	(read/write)	2211760	2211872	112	0.0
			.text	1170024	`1170136`	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490672	490764	92	0.0
			.text	485352	485444	92	0.0
	lock-app	qpg6100+debug	(read only)	466900	466976	76	0.0
			.text	461580	461656	76	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663502	84	0.0
			text	458654	458712	58	0.0

Decreases (1 build for p6)

platform	target	config	section	`d45cfaa`	`49857da`	change	% change
p6	all-clusters-app	default	.heap	918408	918296	-112	-0.0

Full report (9 builds for k32w, p6, qpg, telink)

platform	target	config	section	`d45cfaa`	`49857da`	change	% change
k32w	lighting-app	k32w061+se05x+release	(read/write)	699396	699488	92	0.0
			.bss	78012	78012	0	0.0
			.data	1908	1908	0	0.0
			.text	613676	613768	92	0.0
	lock-app	k32w061+debug	(read/write)	592132	592224	92	0.0
			.bss	68548	68548	0	0.0
			.data	1876	1876	0	0.0
			.text	515908	516000	92	0.0
	shell	k32w061+debug	(read/write)	657760	657852	92	0.0
			.bss	79340	79340	0	0.0
			.data	1844	1844	0	0.0
			.text	570776	570868	92	0.0
p6	all-clusters-app	default	(read/write)	2297136	`2298040`	904	0.0
			.bss	112416	112528	112	0.1
			.data	2520	2520	0	0.0
			.heap	918408	918296	-112	-0.0
			.text	`1255400`	`1256304`	904	0.1
	lock-app	default	(read/write)	2211760	2211872	112	0.0
			.bss	101264	101264	0	0.0
			.data	2400	2400	0	0.0
			.heap	929680	929680	0	0.0
			.text	1170024	`1170136`	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490672	490764	92	0.0
			(read/write)	114144	114144	0	0.0
			.bss	51168	51168	0	0.0
			.data	1008	1008	0	0.0
			.text	485352	485444	92	0.0
	lock-app	qpg6100+debug	(read only)	466900	466976	76	0.0
			(read/write)	114140	114140	0	0.0
			.bss	50112	50112	0	0.0
			.data	964	964	0	0.0
			.text	461580	461656	76	0.0
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663502	84	0.0
			bss	69288	69288	0	0.0
			noinit	33216	33216	0	0.0
			text	458654	458712	58	0.0

github-actions · 2021-11-11T07:42:55Z

PR #11520: Size comparison from d45cfaa to e070547

Increases above 0.2%:

platform	target	config	section	`d45cfaa`	`e070547`	change	% change
linux	all-clusters-app	debug	(read only)	1698921	`1704721`	5800	0.3
			.bss	57904	58096	192	0.3
			.text	1426370	1431714	5344	0.4
	chip-tool	debug	(read only)	4813069	4832941	19872	0.4
			.text	4288437	4307925	19488	0.5

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`d45cfaa`	`e070547`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742476	742588	112	0.0
			.text	742468	742580	112	0.0
		BRD4161A+rpc	(read only)	730040	730152	112	0.0
			.text	730032	730144	112	0.0
	lock-app	BRD4161A	(read only)	721764	721876	112	0.0
			.text	721756	721868	112	0.0
	window-app	BRD4161A	(read only)	722676	722788	112	0.0
			.text	722668	722780	112	0.0
esp32	all-clusters-app	c3devkit	(read only)	879114	879874	760	0.1
			(read/write)	1305968	1306120	152	0.0
			.dram0.bss	58440	58560	120	0.2
			.flash.rodata	197824	197864	40	0.0
			.flash.text	879114	879874	760	0.1
		m5stack	(read only)	910683	911359	676	0.1
			(read/write)	423308	423468	160	0.0
			.dram0.bss	60952	61072	120	0.2
			.flash.rodata	204100	204140	40	0.0
			.flash.text	910683	911359	676	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	699396	699488	92	0.0
			.text	613676	613768	92	0.0
	lock-app	k32w061+debug	(read/write)	592132	592224	92	0.0
			.text	515908	516000	92	0.0
	shell	k32w061+debug	(read/write)	657760	657852	92	0.0
			.text	570776	570868	92	0.0
linux	all-clusters-app	debug	(read only)	1698921	`1704721`	5800	0.3
			(read/write)	126432	126688	256	0.2
			.bss	57904	58096	192	0.3
			.data.rel.ro	62256	62304	48	0.1
			.rodata	139061	139253	192	0.1
			.text	1426370	1431714	5344	0.4
	bridge-app	debug+rpc	(read only)	1298741	1299381	640	0.0
			(read/write)	77264	77328	64	0.1
			.data.rel.ro	27928	27992	64	0.2
			.rodata	110932	111028	96	0.1
			.text	1091365	1091717	352	0.0
	chip-tool	debug	(read only)	4813069	4832941	19872	0.4
			.rodata	248298	248682	384	0.2
			.text	4288437	4307925	19488	0.5
	lighting-app	debug+rpc	(read only)	1558113	`1558769`	656	0.0
			(read/write)	110376	110472	96	0.1
			.data.rel.ro	55328	55424	96	0.2
			.rodata	128369	128465	96	0.1
			.text	1295634	1296002	368	0.0
	ota-provider-app	debug	(read only)	`1259977`	1260393	416	0.0
			(read/write)	75624	75656	32	0.0
			.data.rel.ro	24776	24808	32	0.1
			.text	1050562	1050930	368	0.0
	ota-requestor-app	debug	(read only)	1345049	1345465	416	0.0
			(read/write)	79392	79424	32	0.0
			.data.rel.ro	26040	26056	16	0.1
			.text	`1121970`	1122338	368	0.0
	tv-app	debug	(read only)	1842905	1843785	880	0.0
			(read/write)	408216	408344	128	0.0
			.data.rel.ro	59600	59728	128	0.2
			.rodata	155757	155949	192	0.1
			.text	1542674	1543026	352	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	`2289248`	2289992	744	0.0
			.bss	179412	179532	120	0.1
			.text	1251848	`1252592`	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	`2270688`	2270784	96	0.0
			.text	1233288	1233384	96	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2248344	2248432	88	0.0
			.text	1210944	1211032	88	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861907	861987	80	0.0
			rodata	96532	96564	32	0.0
			text	578272	578332	60	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824267	824363	96	0.0
			rodata	87708	87740	32	0.0
			text	552444	552504	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786946	787042	96	0.0
			rodata	91788	91820	32	0.0
			text	507740	507800	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838615	838711	96	0.0
			rodata	92904	92936	32	0.0
			text	559756	559816	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763926	764006	80	0.0
			rodata	88208	88240	32	0.0
			text	489316	489376	60	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844707	844803	96	0.0
			rodata	94612	94644	32	0.0
			text	563916	563976	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838467	838563	96	0.0
			rodata	92900	92932	32	0.0
			text	559492	559552	60	0.0
p6	all-clusters-app	default	(read/write)	2297136	`2298040`	904	0.0
			.bss	112416	112528	112	0.1
			.text	`1255400`	`1256304`	904	0.1
	lock-app	default	(read/write)	2211760	2211872	112	0.0
			.text	1170024	`1170136`	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490672	490764	92	0.0
			.text	485352	485444	92	0.0
	lock-app	qpg6100+debug	(read only)	466900	466976	76	0.0
			.text	461580	461656	76	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663502	84	0.0
			text	458654	458712	58	0.0

Decreases (2 builds for mbed, p6)

platform	target	config	section	`d45cfaa`	`e070547`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851816	851696	-120	-0.0
p6	all-clusters-app	default	.heap	918408	918296	-112	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`d45cfaa`	`e070547`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742476	742588	112	0.0
			(read/write)	116280	116280	0	0.0
			.bss	114500	114500	0	0.0
			.data	1780	1780	0	0.0
			.text	742468	742580	112	0.0
		BRD4161A+rpc	(read only)	730040	730152	112	0.0
			(read/write)	132900	132900	0	0.0
			.bss	131004	131004	0	0.0
			.data	1896	1896	0	0.0
			.text	730032	730144	112	0.0
	lock-app	BRD4161A	(read only)	721764	721876	112	0.0
			(read/write)	114096	114096	0	0.0
			.bss	112356	112356	0	0.0
			.data	1740	1740	0	0.0
			.text	721756	721868	112	0.0
	window-app	BRD4161A	(read only)	722676	722788	112	0.0
			(read/write)	114420	114420	0	0.0
			.bss	112676	112676	0	0.0
			.data	1744	1744	0	0.0
			.text	722668	722780	112	0.0
esp32	all-clusters-app	c3devkit	(read only)	879114	879874	760	0.1
			(read/write)	1305968	1306120	152	0.0
			.dram0.bss	58440	58560	120	0.2
			.dram0.data	16456	16456	0	0.0
			.flash.rodata	197824	197864	40	0.0
			.flash.text	879114	879874	760	0.1
			.iram0.text	57526	57526	0	0.0
		m5stack	(read only)	910683	911359	676	0.1
			(read/write)	423308	423468	160	0.0
			.dram0.bss	60952	61072	120	0.2
			.dram0.data	32092	32092	0	0.0
			.flash.rodata	204100	204140	40	0.0
			.flash.text	910683	911359	676	0.1
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699396	699488	92	0.0
			.bss	78012	78012	0	0.0
			.data	1908	1908	0	0.0
			.text	613676	613768	92	0.0
	lock-app	k32w061+debug	(read/write)	592132	592224	92	0.0
			.bss	68548	68548	0	0.0
			.data	1876	1876	0	0.0
			.text	515908	516000	92	0.0
	shell	k32w061+debug	(read/write)	657760	657852	92	0.0
			.bss	79340	79340	0	0.0
			.data	1844	1844	0	0.0
			.text	570776	570868	92	0.0
linux	all-clusters-app	debug	(read only)	1698921	`1704721`	5800	0.3
			(read/write)	126432	126688	256	0.2
			.bss	57904	58096	192	0.3
			.data	1010	1010	0	0.0
			.data.rel.ro	62256	62304	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139061	139253	192	0.1
			.text	1426370	1431714	5344	0.4
	bridge-app	debug+rpc	(read only)	1298741	1299381	640	0.0
			(read/write)	77264	77328	64	0.1
			.bss	42800	42800	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27928	27992	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	110932	111028	96	0.1
			.text	1091365	1091717	352	0.0
	chip-tool	debug	(read only)	4813069	4832941	19872	0.4
			(read/write)	136992	136992	0	0.0
			.bss	25960	25960	0	0.0
			.data	2256	2256	0	0.0
			.data.rel.ro	103336	103336	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	432	432	0	0.0
			.rodata	248298	248682	384	0.2
			.text	4288437	4307925	19488	0.5
	lighting-app	debug+rpc	(read only)	1558113	`1558769`	656	0.0
			(read/write)	110376	110472	96	0.1
			.bss	48560	48560	0	0.0
			.data	1202	1202	0	0.0
			.data.rel.ro	55328	55424	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	128369	128465	96	0.1
			.text	1295634	1296002	368	0.0
	ota-provider-app	debug	(read only)	`1259977`	1260393	416	0.0
			(read/write)	75624	75656	32	0.0
			.bss	44992	44992	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24776	24808	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	112615	112615	0	0.0
			.text	1050562	1050930	368	0.0
	ota-requestor-app	debug	(read only)	1345049	1345465	416	0.0
			(read/write)	79392	79424	32	0.0
			.bss	47456	47456	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	26040	26056	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	123728	123728	0	0.0
			.text	`1121970`	1122338	368	0.0
	shell	debug	(read only)	788441	788441	0	0.0
			(read/write)	65608	65608	0	0.0
			.bss	23944	23944	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36928	36928	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	77519	77519	0	0.0
			.text	609026	609026	0	0.0
	tv-app	debug	(read only)	1842905	1843785	880	0.0
			(read/write)	408216	408344	128	0.0
			.bss	340232	340232	0	0.0
			.data	2736	2736	0	0.0
			.data.rel.ro	59600	59728	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	155757	155949	192	0.1
			.text	1542674	1543026	352	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2289248`	2289992	744	0.0
			.bss	179412	179532	120	0.1
			.data	5216	5216	0	0.0
			.heap	851816	851696	-120	-0.0
			.text	1251848	`1252592`	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2270688`	2270784	96	0.0
			.bss	172508	172508	0	0.0
			.data	5576	5576	0	0.0
			.heap	858360	858360	0	0.0
			.text	1233288	1233384	96	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2248344	2248432	88	0.0
			.bss	171404	171404	0	0.0
			.data	5568	5568	0	0.0
			.heap	859472	859472	0	0.0
			.text	1210944	1211032	88	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048296	2048296	0	0.0
			.bss	156464	156464	0	0.0
			.data	4968	4968	0	0.0
			.heap	875016	875016	0	0.0
			.text	1010896	1010896	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861907	861987	80	0.0
			bss	111476	111476	0	0.0
			rodata	96532	96564	32	0.0
			text	578272	578332	60	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824267	824363	96	0.0
			bss	107828	107828	0	0.0
			rodata	87708	87740	32	0.0
			text	552444	552504	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786946	787042	96	0.0
			bss	112848	112848	0	0.0
			rodata	91788	91820	32	0.0
			text	507740	507800	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838615	838711	96	0.0
			bss	110508	110508	0	0.0
			rodata	92904	92936	32	0.0
			text	559756	559816	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763926	764006	80	0.0
			bss	111920	111920	0	0.0
			rodata	88208	88240	32	0.0
			text	489316	489376	60	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844707	844803	96	0.0
			bss	110648	110648	0	0.0
			rodata	94612	94644	32	0.0
			text	563916	563976	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838467	838563	96	0.0
			bss	110544	110544	0	0.0
			rodata	92900	92932	32	0.0
			text	559492	559552	60	0.0
	shell	nrf52840dk_nrf52840	(read/write)	775955	775955	0	0.0
			bss	109288	109288	0	0.0
			rodata	72152	72152	0	0.0
			text	519904	519904	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	690962	690962	0	0.0
			bss	110272	110272	0	0.0
			rodata	66796	66796	0	0.0
			text	440512	440512	0	0.0
p6	all-clusters-app	default	(read/write)	2297136	`2298040`	904	0.0
			.bss	112416	112528	112	0.1
			.data	2520	2520	0	0.0
			.heap	918408	918296	-112	-0.0
			.text	`1255400`	`1256304`	904	0.1
	lock-app	default	(read/write)	2211760	2211872	112	0.0
			.bss	101264	101264	0	0.0
			.data	2400	2400	0	0.0
			.heap	929680	929680	0	0.0
			.text	1170024	`1170136`	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490672	490764	92	0.0
			(read/write)	114144	114144	0	0.0
			.bss	51168	51168	0	0.0
			.data	1008	1008	0	0.0
			.text	485352	485444	92	0.0
	lock-app	qpg6100+debug	(read only)	466900	466976	76	0.0
			(read/write)	114140	114140	0	0.0
			.bss	50112	50112	0	0.0
			.data	964	964	0	0.0
			.text	461580	461656	76	0.0
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663502	84	0.0
			bss	69288	69288	0	0.0
			noinit	33216	33216	0	0.0
			text	458654	458712	58	0.0

src/app/clusters/test-cluster-server/test-cluster-server.cpp

github-actions · 2021-11-11T21:34:04Z

PR #11520: Size comparison from 9164605 to 7d38e01

Increases above 0.2%:

platform	target	config	section	`9164605`	`7d38e01`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	55832	56000	168	0.3
		m5stack	.dram0.bss	60920	61088	168	0.3
linux	all-clusters-app	debug	(read only)	1699113	`1705313`	6200	0.4
			(read/write)	125856	126176	320	0.3
			.bss	57328	57584	256	0.4
			.text	1426498	1432242	5744	0.4
	chip-tool	debug	(read only)	`4813261`	4833133	19872	0.4
			.text	4288629	4308117	19488	0.5
	tv-app	debug	.data.rel.ro	59600	59728	128	0.2
	bridge-app	debug+rpc	.data.rel.ro	27928	27992	64	0.2

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`9164605`	`7d38e01`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745240	745352	112	0.0
			.text	745232	745344	112	0.0
	lock-app	BRD4161A	(read only)	722064	722176	112	0.0
			.text	722056	722168	112	0.0
	window-app	BRD4161A	(read only)	722992	723104	112	0.0
			.text	722984	723096	112	0.0
	lighting-app	BRD4161A+rpc	(read only)	732788	732884	96	0.0
			.text	732780	732876	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	821852	822550	698	0.1
			(read/write)	1221906	1222106	200	0.0
			.dram0.bss	55832	56000	168	0.3
			.flash.rodata	166728	166768	40	0.0
			.flash.text	821852	822550	698	0.1
		m5stack	(read only)	892951	893623	672	0.1
			(read/write)	420080	420288	208	0.0
			.dram0.bss	60920	61088	168	0.3
			.flash.rodata	193780	193820	40	0.0
			.flash.text	887567	888239	672	0.1
k32w	lock-app	k32w061+debug	(read/write)	591644	591736	92	0.0
			.text	515972	516064	92	0.0
	shell	k32w061+debug	(read/write)	657324	657416	92	0.0
			.text	570892	570984	92	0.0
	lighting-app	k32w061+se05x+release	(read/write)	700424	700516	92	0.0
			.text	615240	615332	92	0.0
linux	all-clusters-app	debug	(read only)	1699113	`1705313`	6200	0.4
			(read/write)	125856	126176	320	0.3
			.bss	57328	57584	256	0.4
			.data.rel.ro	62256	62304	48	0.1
			.rodata	139125	139317	192	0.1
			.text	1426498	1432242	5744	0.4
	chip-tool	debug	(read only)	`4813261`	4833133	19872	0.4
			.rodata	248298	248682	384	0.2
			.text	4288629	4308117	19488	0.5
	ota-provider-app	debug	(read only)	1260153	1260553	400	0.0
			(read/write)	75048	75080	32	0.0
			.data.rel.ro	24776	24808	32	0.1
			.text	1050706	1051058	352	0.0
	ota-requestor-app	debug	(read only)	1345225	1345625	400	0.0
			(read/write)	78816	78848	32	0.0
			.data.rel.ro	26040	26056	16	0.1
			.text	1122114	1122466	352	0.0
	tv-app	debug	(read only)	1843097	1843993	896	0.0
			(read/write)	407640	407768	128	0.0
			.data.rel.ro	59600	59728	128	0.2
			.rodata	155821	156013	192	0.1
			.text	1542802	1543170	368	0.0
	bridge-app	debug+rpc	(read only)	1298741	1299381	640	0.0
			(read/write)	77264	77328	64	0.1
			.data.rel.ro	27928	27992	64	0.2
			.rodata	110932	111028	96	0.1
			.text	1091365	1091717	352	0.0
	lighting-app	debug+rpc	(read only)	1565401	1566057	656	0.0
			(read/write)	109936	110032	96	0.1
			.data.rel.ro	55456	55552	96	0.2
			.rodata	128849	128945	96	0.1
			.text	1302322	1302690	368	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2289256	2289936	680	0.0
			.bss	179412	179580	168	0.1
			.text	1251856	1252536	680	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	`2272728`	2272816	88	0.0
			.text	1235328	1235416	88	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2248352	`2248440`	88	0.0
			.text	1210952	1211040	88	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862919	863015	96	0.0
			rodata	96856	96888	32	0.0
			text	579516	579576	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838151	838247	96	0.0
			rodata	92920	92952	32	0.0
			text	559816	559876	60	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844247	844343	96	0.0
			rodata	94632	94664	32	0.0
			text	563980	564040	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838007	838103	96	0.0
			rodata	92920	92952	32	0.0
			text	559552	559612	60	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	(read/write)	825307	825387	80	0.0
			rodata	88044	88076	32	0.0
			text	553688	553748	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	787974	788054	80	0.0
			rodata	92112	92144	32	0.0
			text	508984	509044	60	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	(read/write)	763450	763546	96	0.0
			rodata	88228	88260	32	0.0
			text	489376	489436	60	0.0
p6	all-clusters-app	default	(read/write)	`2297144`	2297984	840	0.0
			.bss	112416	112576	160	0.1
			.text	1255408	1256248	840	0.1
	lock-app	default	(read/write)	2211752	2211864	112	0.0
			.text	1170016	`1170128`	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	492240	492332	92	0.0
			.text	486920	487012	92	0.0
	lock-app	qpg6100+debug	(read only)	466976	467052	76	0.0
			.text	461656	461732	76	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	665114	665198	84	0.0
			text	459996	460054	58	0.0

Decreases (2 builds for mbed, p6)

platform	target	config	section	`9164605`	`7d38e01`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851816	851648	-168	-0.0
p6	all-clusters-app	default	.heap	918408	918248	-160	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`9164605`	`7d38e01`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745240	745352	112	0.0
			(read/write)	115764	115764	0	0.0
			.bss	113980	113980	0	0.0
			.data	1784	1784	0	0.0
			.text	745232	745344	112	0.0
	lock-app	BRD4161A	(read only)	722064	722176	112	0.0
			(read/write)	113548	113548	0	0.0
			.bss	111804	111804	0	0.0
			.data	1740	1740	0	0.0
			.text	722056	722168	112	0.0
	window-app	BRD4161A	(read only)	722992	723104	112	0.0
			(read/write)	113868	113868	0	0.0
			.bss	112124	112124	0	0.0
			.data	1744	1744	0	0.0
			.text	722984	723096	112	0.0
	lighting-app	BRD4161A+rpc	(read only)	732788	732884	96	0.0
			(read/write)	132392	132392	0	0.0
			.bss	130484	130484	0	0.0
			.data	1908	1908	0	0.0
			.text	732780	732876	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	821852	822550	698	0.1
			(read/write)	1221906	1222106	200	0.0
			.dram0.bss	55832	56000	168	0.3
			.dram0.data	14092	14092	0	0.0
			.flash.rodata	166728	166768	40	0.0
			.flash.text	821852	822550	698	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	892951	893623	672	0.1
			(read/write)	420080	420288	208	0.0
			.dram0.bss	60920	61088	168	0.3
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	193780	193820	40	0.0
			.flash.text	887567	888239	672	0.1
			.iram0.text	122987	122987	0	0.0
k32w	lock-app	k32w061+debug	(read/write)	591644	591736	92	0.0
			.bss	67996	67996	0	0.0
			.data	1876	1876	0	0.0
			.text	515972	516064	92	0.0
	shell	k32w061+debug	(read/write)	657324	657416	92	0.0
			.bss	78788	78788	0	0.0
			.data	1844	1844	0	0.0
			.text	570892	570984	92	0.0
	lighting-app	k32w061+se05x+release	(read/write)	700424	700516	92	0.0
			.bss	77476	77476	0	0.0
			.data	1908	1908	0	0.0
			.text	615240	615332	92	0.0
linux	all-clusters-app	debug	(read only)	1699113	`1705313`	6200	0.4
			(read/write)	125856	126176	320	0.3
			.bss	57328	57584	256	0.4
			.data	1010	1010	0	0.0
			.data.rel.ro	62256	62304	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139125	139317	192	0.1
			.text	1426498	1432242	5744	0.4
	chip-tool	debug	(read only)	`4813261`	4833133	19872	0.4
			(read/write)	136448	136448	0	0.0
			.bss	25416	25416	0	0.0
			.data	2256	2256	0	0.0
			.data.rel.ro	103336	103336	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	432	432	0	0.0
			.rodata	248298	248682	384	0.2
			.text	4288629	4308117	19488	0.5
	ota-provider-app	debug	(read only)	1260153	1260553	400	0.0
			(read/write)	75048	75080	32	0.0
			.bss	44416	44416	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24776	24808	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	112647	112647	0	0.0
			.text	1050706	1051058	352	0.0
	ota-requestor-app	debug	(read only)	1345225	1345625	400	0.0
			(read/write)	78816	78848	32	0.0
			.bss	46880	46880	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	26040	26056	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	123760	123760	0	0.0
			.text	1122114	1122466	352	0.0
	shell	debug	(read only)	788665	788665	0	0.0
			(read/write)	65064	65064	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36928	36928	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	77615	77615	0	0.0
			.text	609154	609154	0	0.0
	tv-app	debug	(read only)	1843097	1843993	896	0.0
			(read/write)	407640	407768	128	0.0
			.bss	339656	339656	0	0.0
			.data	2736	2736	0	0.0
			.data.rel.ro	59600	59728	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	155821	156013	192	0.1
			.text	1542802	1543170	368	0.0
	bridge-app	debug+rpc	(read only)	1298741	1299381	640	0.0
			(read/write)	77264	77328	64	0.1
			.bss	42800	42800	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27928	27992	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	110932	111028	96	0.1
			.text	1091365	1091717	352	0.0
	lighting-app	debug+rpc	(read only)	1565401	1566057	656	0.0
			(read/write)	109936	110032	96	0.1
			.bss	47984	47984	0	0.0
			.data	1202	1202	0	0.0
			.data.rel.ro	55456	55552	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	128849	128945	96	0.1
			.text	1302322	1302690	368	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2289256	2289936	680	0.0
			.bss	179412	179580	168	0.1
			.data	5216	5216	0	0.0
			.heap	851816	851648	-168	-0.0
			.text	1251856	1252536	680	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2272728`	2272816	88	0.0
			.bss	172524	172524	0	0.0
			.data	5576	5576	0	0.0
			.heap	858344	858344	0	0.0
			.text	1235328	1235416	88	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2248352	`2248440`	88	0.0
			.bss	171404	171404	0	0.0
			.data	5568	5568	0	0.0
			.heap	859472	859472	0	0.0
			.text	1210952	1211040	88	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048376	2048376	0	0.0
			.bss	155912	155912	0	0.0
			.data	4968	4968	0	0.0
			.heap	875568	875568	0	0.0
			.text	1010976	1010976	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862919	863015	96	0.0
			bss	110932	110932	0	0.0
			rodata	96856	96888	32	0.0
			text	579516	579576	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838151	838247	96	0.0
			bss	109956	109956	0	0.0
			rodata	92920	92952	32	0.0
			text	559816	559876	60	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844247	844343	96	0.0
			bss	110096	110096	0	0.0
			rodata	94632	94664	32	0.0
			text	563980	564040	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838007	838103	96	0.0
			bss	109992	109992	0	0.0
			rodata	92920	92952	32	0.0
			text	559552	559612	60	0.0
	shell	nrf52840dk_nrf52840	(read/write)	775483	775483	0	0.0
			bss	108736	108736	0	0.0
			rodata	72160	72160	0	0.0
			text	520008	520008	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	(read/write)	825307	825387	80	0.0
			bss	107284	107284	0	0.0
			rodata	88044	88076	32	0.0
			text	553688	553748	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	787974	788054	80	0.0
			bss	112304	112304	0	0.0
			rodata	92112	92144	32	0.0
			text	508984	509044	60	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	(read/write)	763450	763546	96	0.0
			bss	111368	111368	0	0.0
			rodata	88228	88260	32	0.0
			text	489376	489436	60	0.0
	shell	nrf5340dk_nrf5340_cpuapp	(read/write)	690538	690538	0	0.0
			bss	109720	109720	0	0.0
			rodata	66804	66804	0	0.0
			text	440616	440616	0	0.0
p6	all-clusters-app	default	(read/write)	`2297144`	2297984	840	0.0
			.bss	112416	112576	160	0.1
			.data	2520	2520	0	0.0
			.heap	918408	918248	-160	-0.0
			.text	1255408	1256248	840	0.1
	lock-app	default	(read/write)	2211752	2211864	112	0.0
			.bss	101264	101264	0	0.0
			.data	2400	2400	0	0.0
			.heap	929680	929680	0	0.0
			.text	1170016	`1170128`	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	492240	492332	92	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50624	50624	0	0.0
			.data	1008	1008	0	0.0
			.text	486920	487012	92	0.0
	lock-app	qpg6100+debug	(read only)	466976	467052	76	0.0
			(read/write)	114140	114140	0	0.0
			.bss	49560	49560	0	0.0
			.data	964	964	0	0.0
			.text	461656	461732	76	0.0
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	665114	665198	84	0.0
			bss	69304	69304	0	0.0
			noinit	33216	33216	0	0.0
			text	459996	460054	58	0.0

bzbarsky-apple

Looks great, thank you!

src/app/AttributeAccessInterface.h

src/app/clusters/test-cluster-server/test-cluster-server.cpp

github-actions · 2021-11-11T23:46:34Z

PR #11520: Size comparison from 4ae5f21 to b8852b5

Increases above 0.2%:

platform	target	config	section	`4ae5f21`	`b8852b5`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	55832	56000	168	0.3
		m5stack	.dram0.bss	60920	61088	168	0.3
linux	all-clusters-app	debug	(read only)	1701033	1707201	6168	0.4
			(read/write)	125856	126176	320	0.3
			.bss	57328	57584	256	0.4
			.text	`1428066`	`1433778`	5712	0.4
	chip-tool	debug	(read only)	4914173	4934237	20064	0.4
			.text	4375525	4395013	19488	0.4

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`4ae5f21`	`b8852b5`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745392	745504	112	0.0
			.text	745384	745496	112	0.0
		BRD4161A+rpc	(read only)	732916	733028	112	0.0
			.text	732908	733020	112	0.0
	lock-app	BRD4161A	(read only)	722208	722320	112	0.0
			.text	722200	722312	112	0.0
	window-app	BRD4161A	(read only)	723136	723232	96	0.0
			.text	723128	723224	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	821900	822644	744	0.1
			(read/write)	1221938	1222138	200	0.0
			.dram0.bss	55832	56000	168	0.3
			.flash.rodata	166760	166800	40	0.0
			.flash.text	821900	822644	744	0.1
		m5stack	(read only)	892991	893683	692	0.1
			(read/write)	420112	420320	208	0.0
			.dram0.bss	60920	61088	168	0.3
			.flash.rodata	193812	193852	40	0.0
			.flash.text	887607	888299	692	0.1
k32w	lighting-app	k32w061+se05x+release	(read/write)	700508	700600	92	0.0
			.text	615324	615416	92	0.0
	lock-app	k32w061+debug	(read/write)	591728	591820	92	0.0
			.text	516056	516148	92	0.0
	shell	k32w061+debug	(read/write)	657408	657500	92	0.0
			.text	570976	571068	92	0.0
linux	all-clusters-app	debug	(read only)	1701033	1707201	6168	0.4
			(read/write)	125856	126176	320	0.3
			.bss	57328	57584	256	0.4
			.data.rel.ro	62256	62304	48	0.1
			.rodata	139477	139669	192	0.1
			.text	`1428066`	`1433778`	5712	0.4
	bridge-app	debug+rpc	(read only)	`1300629`	1301269	640	0.0
			(read/write)	77264	77328	64	0.1
			.data.rel.ro	27928	27992	64	0.2
			.rodata	111252	111348	96	0.1
			.text	1092933	`1093285`	352	0.0
	chip-tool	debug	(read only)	4914173	4934237	20064	0.4
			.rodata	258474	259050	576	0.2
			.text	4375525	4395013	19488	0.4
	lighting-app	debug+rpc	(read only)	`1567289`	1567945	656	0.0
			(read/write)	109936	110032	96	0.1
			.data.rel.ro	55456	55552	96	0.2
			.rodata	129169	129265	96	0.1
			.text	1303890	`1304258`	368	0.0
	ota-provider-app	debug	(read only)	1260345	1260745	400	0.0
			(read/write)	75048	75080	32	0.0
			.data.rel.ro	24776	24808	32	0.1
			.text	1050706	1051058	352	0.0
	ota-requestor-app	debug	(read only)	`1345417`	1345817	400	0.0
			(read/write)	78816	78848	32	0.0
			.data.rel.ro	26040	26056	16	0.1
			.text	1122114	1122466	352	0.0
	tv-app	debug	(read only)	1845017	`1845913`	896	0.0
			(read/write)	407640	407768	128	0.0
			.data.rel.ro	59600	59728	128	0.2
			.rodata	156173	156365	192	0.1
			.text	1544370	1544738	368	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2289352	2290096	744	0.0
			.bss	179412	179580	168	0.1
			.text	`1251952`	`1252696`	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	`2272824`	2272912	88	0.0
			.text	1235424	`1235512`	88	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2248448	2248544	96	0.0
			.text	1211048	1211144	96	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	863015	863095	80	0.0
			rodata	96888	96920	32	0.0
			text	579568	579628	60	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	825391	825487	96	0.0
			rodata	88080	88112	32	0.0
			text	553740	553800	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	788058	788154	96	0.0
			rodata	92148	92180	32	0.0
			text	509036	509096	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838235	838331	96	0.0
			rodata	92956	92988	32	0.0
			text	559868	559928	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763546	763626	80	0.0
			rodata	88260	88292	32	0.0
			text	489428	489488	60	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844327	844423	96	0.0
			rodata	94664	94696	32	0.0
			text	564032	564092	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838087	838183	96	0.0
			rodata	92952	92984	32	0.0
			text	559604	559664	60	0.0
p6	all-clusters-app	default	(read/write)	2297296	2298176	880	0.0
			.bss	112416	112576	160	0.1
			.text	1255560	1256440	880	0.1
	lock-app	default	(read/write)	2211896	`2212008`	112	0.0
			.text	1170160	1170272	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	492324	492416	92	0.0
			.text	487004	487096	92	0.0
	lock-app	qpg6100+debug	(read only)	467060	467152	92	0.0
			.text	461740	461832	92	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	665202	665286	84	0.0
			text	460046	460104	58	0.0

Decreases (2 builds for mbed, p6)

platform	target	config	section	`4ae5f21`	`b8852b5`	change	% change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.heap	851816	851648	-168	-0.0
p6	all-clusters-app	default	.heap	918408	918248	-160	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`4ae5f21`	`b8852b5`	change	% change
efr32	lighting-app	BRD4161A	(read only)	745392	745504	112	0.0
			(read/write)	115764	115764	0	0.0
			.bss	113980	113980	0	0.0
			.data	1784	1784	0	0.0
			.text	745384	745496	112	0.0
		BRD4161A+rpc	(read only)	732916	733028	112	0.0
			(read/write)	132392	132392	0	0.0
			.bss	130484	130484	0	0.0
			.data	1908	1908	0	0.0
			.text	732908	733020	112	0.0
	lock-app	BRD4161A	(read only)	722208	722320	112	0.0
			(read/write)	113548	113548	0	0.0
			.bss	111804	111804	0	0.0
			.data	1740	1740	0	0.0
			.text	722200	722312	112	0.0
	window-app	BRD4161A	(read only)	723136	723232	96	0.0
			(read/write)	113868	113868	0	0.0
			.bss	112124	112124	0	0.0
			.data	1744	1744	0	0.0
			.text	723128	723224	96	0.0
esp32	all-clusters-app	c3devkit	(read only)	821900	822644	744	0.1
			(read/write)	1221938	1222138	200	0.0
			.dram0.bss	55832	56000	168	0.3
			.dram0.data	14092	14092	0	0.0
			.flash.rodata	166760	166800	40	0.0
			.flash.text	821900	822644	744	0.1
			.iram0.text	61394	61394	0	0.0
		m5stack	(read only)	892991	893683	692	0.1
			(read/write)	420112	420320	208	0.0
			.dram0.bss	60920	61088	168	0.3
			.dram0.data	34056	34056	0	0.0
			.flash.rodata	193812	193852	40	0.0
			.flash.text	887607	888299	692	0.1
			.iram0.text	122987	122987	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	700508	700600	92	0.0
			.bss	77476	77476	0	0.0
			.data	1908	1908	0	0.0
			.text	615324	615416	92	0.0
	lock-app	k32w061+debug	(read/write)	591728	591820	92	0.0
			.bss	67996	67996	0	0.0
			.data	1876	1876	0	0.0
			.text	516056	516148	92	0.0
	shell	k32w061+debug	(read/write)	657408	657500	92	0.0
			.bss	78788	78788	0	0.0
			.data	1844	1844	0	0.0
			.text	570976	571068	92	0.0
linux	all-clusters-app	debug	(read only)	1701033	1707201	6168	0.4
			(read/write)	125856	126176	320	0.3
			.bss	57328	57584	256	0.4
			.data	1010	1010	0	0.0
			.data.rel.ro	62256	62304	48	0.1
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139477	139669	192	0.1
			.text	`1428066`	`1433778`	5712	0.4
	bridge-app	debug+rpc	(read only)	`1300629`	1301269	640	0.0
			(read/write)	77264	77328	64	0.1
			.bss	42800	42800	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27928	27992	64	0.2
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111252	111348	96	0.1
			.text	1092933	`1093285`	352	0.0
	chip-tool	debug	(read only)	4914173	4934237	20064	0.4
			(read/write)	154120	154120	0	0.0
			.bss	41096	41096	0	0.0
			.data	2272	2272	0	0.0
			.data.rel.ro	105312	105312	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	258474	259050	576	0.2
			.text	4375525	4395013	19488	0.4
	lighting-app	debug+rpc	(read only)	`1567289`	1567945	656	0.0
			(read/write)	109936	110032	96	0.1
			.bss	47984	47984	0	0.0
			.data	1202	1202	0	0.0
			.data.rel.ro	55456	55552	96	0.2
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	129169	129265	96	0.1
			.text	1303890	`1304258`	368	0.0
	ota-provider-app	debug	(read only)	1260345	1260745	400	0.0
			(read/write)	75048	75080	32	0.0
			.bss	44416	44416	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24776	24808	32	0.1
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	112839	112839	0	0.0
			.text	1050706	1051058	352	0.0
	ota-requestor-app	debug	(read only)	`1345417`	1345817	400	0.0
			(read/write)	78816	78848	32	0.0
			.bss	46880	46880	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	26040	26056	16	0.1
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	472	472	0	0.0
			.rodata	123952	123952	0	0.0
			.text	1122114	1122466	352	0.0
	shell	debug	(read only)	788905	788905	0	0.0
			(read/write)	65064	65064	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36928	36928	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	77839	77839	0	0.0
			.text	609170	609170	0	0.0
	tv-app	debug	(read only)	1845017	`1845913`	896	0.0
			(read/write)	407640	407768	128	0.0
			.bss	339656	339656	0	0.0
			.data	2736	2736	0	0.0
			.data.rel.ro	59600	59728	128	0.2
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	156173	156365	192	0.1
			.text	1544370	1544738	368	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2289352	2290096	744	0.0
			.bss	179412	179580	168	0.1
			.data	5216	5216	0	0.0
			.heap	851816	851648	-168	-0.0
			.text	`1251952`	`1252696`	744	0.1
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2272824`	2272912	88	0.0
			.bss	172524	172524	0	0.0
			.data	5576	5576	0	0.0
			.heap	858344	858344	0	0.0
			.text	1235424	`1235512`	88	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2248448	2248544	96	0.0
			.bss	171404	171404	0	0.0
			.data	5568	5568	0	0.0
			.heap	859472	859472	0	0.0
			.text	1211048	1211144	96	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048376	2048376	0	0.0
			.bss	155912	155912	0	0.0
			.data	4968	4968	0	0.0
			.heap	875568	875568	0	0.0
			.text	1010976	1010976	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	863015	863095	80	0.0
			bss	110932	110932	0	0.0
			rodata	96888	96920	32	0.0
			text	579568	579628	60	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	825391	825487	96	0.0
			bss	107284	107284	0	0.0
			rodata	88080	88112	32	0.0
			text	553740	553800	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	788058	788154	96	0.0
			bss	112304	112304	0	0.0
			rodata	92148	92180	32	0.0
			text	509036	509096	60	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838235	838331	96	0.0
			bss	109956	109956	0	0.0
			rodata	92956	92988	32	0.0
			text	559868	559928	60	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763546	763626	80	0.0
			bss	111368	111368	0	0.0
			rodata	88260	88292	32	0.0
			text	489428	489488	60	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327	0	0.0
			bss	51824	51824	0	0.0
			rodata	45780	45780	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844327	844423	96	0.0
			bss	110096	110096	0	0.0
			rodata	94664	94696	32	0.0
			text	564032	564092	60	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838087	838183	96	0.0
			bss	109992	109992	0	0.0
			rodata	92952	92984	32	0.0
			text	559604	559664	60	0.0
	shell	nrf52840dk_nrf52840	(read/write)	775483	775483	0	0.0
			bss	108736	108736	0	0.0
			rodata	72160	72160	0	0.0
			text	520008	520008	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	690538	690538	0	0.0
			bss	109720	109720	0	0.0
			rodata	66804	66804	0	0.0
			text	440616	440616	0	0.0
p6	all-clusters-app	default	(read/write)	2297296	2298176	880	0.0
			.bss	112416	112576	160	0.1
			.data	2520	2520	0	0.0
			.heap	918408	918248	-160	-0.0
			.text	1255560	1256440	880	0.1
	lock-app	default	(read/write)	2211896	`2212008`	112	0.0
			.bss	101264	101264	0	0.0
			.data	2400	2400	0	0.0
			.heap	929680	929680	0	0.0
			.text	1170160	1170272	112	0.0
qpg	lighting-app	qpg6100+debug	(read only)	492324	492416	92	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50624	50624	0	0.0
			.data	1008	1008	0	0.0
			.text	487004	487096	92	0.0
	lock-app	qpg6100+debug	(read only)	467060	467152	92	0.0
			(read/write)	114140	114140	0	0.0
			.bss	49560	49560	0	0.0
			.data	964	964	0	0.0
			.text	461740	461832	92	0.0
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408	0	0.0
			(read/write)	114142	114142	0	0.0
			.bss	8978	8978	0	0.0
			.data	272	272	0	0.0
			.text	100088	100088	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	665202	665286	84	0.0
			bss	69304	69304	0	0.0
			noinit	33216	33216	0	0.0
			text	460046	460104	58	0.0

boring-cyborg bot added app darwin labels Nov 8, 2021

yunhanw-google approved these changes Nov 8, 2021

View reviewed changes

mrjerryjohns suggested changes Nov 8, 2021

View reviewed changes

boring-cyborg bot added the examples label Nov 8, 2021

yufengwangca requested a review from mrjerryjohns November 9, 2021 05:03

woody-apple approved these changes Nov 9, 2021

View reviewed changes

bzbarsky-apple requested changes Nov 10, 2021

View reviewed changes

yufengwangca requested a review from bzbarsky-apple November 11, 2021 07:26

mrjerryjohns reviewed Nov 11, 2021

View reviewed changes

src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved

src/app/clusters/test-cluster-server/test-cluster-server.cpp Show resolved Hide resolved

yufengwangca requested a review from mrjerryjohns November 11, 2021 19:06

bzbarsky-apple approved these changes Nov 11, 2021

View reviewed changes

src/app/AttributeAccessInterface.h Outdated Show resolved Hide resolved

src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved

src/app/clusters/test-cluster-server/test-cluster-server.cpp Outdated Show resolved Hide resolved

yufengwangca added 2 commits November 11, 2021 15:08

Add a way to run custom cluster logic for attribute write

e208d50

Address review comments

b8852b5

saurabhst approved these changes Nov 11, 2021

View reviewed changes

mrjerryjohns approved these changes Nov 12, 2021

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Nov 12, 2021

yufengwangca merged commit 2d0eb94 into project-chip:master Nov 12, 2021

This was referenced Nov 12, 2021

Add yaml test case for NullablesAndOptionalsStruct list #11708

Closed

Refactor WriteSingleClusterData and all dependent functions to take ConcreteAttr... #11709

Closed

yufengwangca deleted the pr/interceptor/write branch November 12, 2021 02:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a way to run custom cluster logic for attribute write #11520

Add a way to run custom cluster logic for attribute write #11520

yufengwangca commented Nov 8, 2021

todo bot commented Nov 8, 2021

todo bot commented Nov 8, 2021

github-actions bot commented Nov 8, 2021 •

edited

Loading

github-actions bot commented Nov 8, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 11, 2021 •

edited

Loading

github-actions bot commented Nov 11, 2021 •

edited

Loading

github-actions bot commented Nov 11, 2021

bzbarsky-apple left a comment

github-actions bot commented Nov 11, 2021 •

edited

Loading

Add a way to run custom cluster logic for attribute write #11520

Add a way to run custom cluster logic for attribute write #11520

Conversation

yufengwangca commented Nov 8, 2021

Problem

Change overview

Testing

todo bot commented Nov 8, 2021

Add yaml test case for NullablesAndOptionalsStruct list

This comment was generated by todo based on a TODO comment in d38aee2 in #11520. cc @yufengwangca.

todo bot commented Nov 8, 2021

Refactor WriteSingleClusterData and all dependent functions to take ConcreteAttributePath instead of ClusterInfo

This comment was generated by todo based on a TODO comment in d38aee2 in #11520. cc @yufengwangca.

github-actions bot commented Nov 8, 2021 • edited Loading

github-actions bot commented Nov 8, 2021 • edited Loading

github-actions bot commented Nov 9, 2021 • edited Loading

github-actions bot commented Nov 9, 2021 • edited Loading

github-actions bot commented Nov 9, 2021 • edited Loading

github-actions bot commented Nov 11, 2021 • edited Loading

github-actions bot commented Nov 11, 2021 • edited Loading

github-actions bot commented Nov 11, 2021

bzbarsky-apple left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 11, 2021 • edited Loading

This comment was generated by todo based on a `TODO` comment in `d38aee2` in #11520. cc @yufengwangca.

This comment was generated by todo based on a `TODO` comment in `d38aee2` in #11520. cc @yufengwangca.

github-actions bot commented Nov 8, 2021 •

edited

Loading

github-actions bot commented Nov 8, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 9, 2021 •

edited

Loading

github-actions bot commented Nov 11, 2021 •

edited

Loading

github-actions bot commented Nov 11, 2021 •

edited

Loading

github-actions bot commented Nov 11, 2021 •

edited

Loading