-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload application logs to artifacts from test_suites #11512
Merged
woody-apple
merged 4 commits into
project-chip:master
from
pan-apple:upload-test-suite-logs
Nov 6, 2021
Merged
Upload application logs to artifacts from test_suites #11512
woody-apple
merged 4 commits into
project-chip:master
from
pan-apple:upload-test-suite-logs
Nov 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-apple
force-pushed
the
upload-test-suite-logs
branch
from
November 6, 2021 00:57
c608559
to
62ebadb
Compare
PR #11512: Size comparison from a01b54d to 62ebadb Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
PR #11512: Size comparison from a01b54d to d8179fa Full report (26 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 6, 2021
PR #11512: Size comparison from a01b54d to 904d789 Full report (36 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel and
LuDuda
November 6, 2021 04:48
pullapprove
bot
requested review from
lzgrablic02,
mlepage-google,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
wbschiller and
yunhanw-google
November 6, 2021 04:48
PR #11512: Size comparison from a01b54d to 2ca0052 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fast tracking this, as this will add logs to our failing suites we're tying to debug. |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…1512) * Upload application logs to artifacts from test_suites * annotate log file with test name and iteration * annotate artifact name * upload logs on failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In CI, the application logs are interleaved with the controller logs. Sometimes when the controller fails due to an error, it doesn't upload all the application side logs.
Change overview
This change will upload the applications logs to CI artifacts. So the logs should be isolated and complete.
Testing
Ran test_suites.sh locally to ensure the logs are getting copied to the correct file and folder.
The CI run will test that the logs get uploaded to artifacts.