-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC: Improve setup instructions for ESP #11473
Merged
woody-apple
merged 1 commit into
project-chip:master
from
rgoliver:esp-rpc-setup-instructions
Nov 5, 2021
Merged
RPC: Improve setup instructions for ESP #11473
woody-apple
merged 1 commit into
project-chip:master
from
rgoliver:esp-rpc-setup-instructions
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple reports of people have incorrect uart setups and problems with CHIP_SHELL interfering with RPC. Create better instructions for ensuring the default configuration is correct.
PR #11473: Size comparison from 3f67119 to 9beea90 Increases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fast tracking given docs |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Multiple reports of people have incorrect uart setups and problems with CHIP_SHELL interfering with RPC. Create better instructions for ensuring the default configuration is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multiple reports of people have incorrect UART setups and problems with CHIP_SHELL interfering with RPC.
Change overview
Create better instructions for ensuring the default configuration is correct.
Testing
Tested both flows and ensured they built the RPC app correctly.