Restyle Account for KVS collisions in NVM identifiers #11464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
doru91
pushed a commit
to doru91/connectedhomeip
that referenced
this pull request
Nov 11, 2021
Co-authored-by: Restyled.io <[email protected]> Signed-off-by: Doru Gucea <[email protected]>
doru91
pushed a commit
that referenced
this pull request
Nov 11, 2021
Co-authored-by: Restyled.io <[email protected]> Signed-off-by: Doru Gucea <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Fix KVS implementation Old implementation was not taking into account collissions. The new implementation keeps an unorderded hash having as keys the matter string keys and as values the key ids used as PDM identifiers. Used key ids are saved in a list which is updated at each Put/Delete operation. Also, in order to be able to restore from flash the unordered hash, the matter string keys are saved in flash. Signed-off-by: Doru Gucea <[email protected]> * Fixes after review Signed-off-by: Doru Gucea <[email protected]> * Restyled by clang-format (#11433) Co-authored-by: Restyled.io <[email protected]> Signed-off-by: Doru Gucea <[email protected]> * Restyled by clang-format (#11464) Co-authored-by: Restyled.io <[email protected]> Signed-off-by: Doru Gucea <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Fix KVS implementation Old implementation was not taking into account collissions. The new implementation keeps an unorderded hash having as keys the matter string keys and as values the key ids used as PDM identifiers. Used key ids are saved in a list which is updated at each Put/Delete operation. Also, in order to be able to restore from flash the unordered hash, the matter string keys are saved in flash. Signed-off-by: Doru Gucea <[email protected]> * Fixes after review Signed-off-by: Doru Gucea <[email protected]> * Restyled by clang-format (project-chip#11433) Co-authored-by: Restyled.io <[email protected]> Signed-off-by: Doru Gucea <[email protected]> * Restyled by clang-format (project-chip#11464) Co-authored-by: Restyled.io <[email protected]> Signed-off-by: Doru Gucea <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated style fixes for #9489, created by Restyled.
The following restylers made fixes:
To incorporate these changes, merge this Pull Request into the original. We
recommend using the Squash or Rebase strategies.
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.