Fix Descriptor cluster when linking statically. #11392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
wbschiller,
woody-apple and
yufengwangca
|
PR #11392: Size comparison from 38fe11e to 9f4db8e Increases above 0.2%:
Increases (22 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
Decreases (12 builds for efr32, esp32, linux, mbed, nrfconnect, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Nov 4, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344
bzbarsky-apple
force-pushed
the
fix-descriptor-static-link
branch
from
9f4db8e to
4417e56
Compare
|
PR #11392: Size comparison from ee7682d to 4417e56 Increases (20 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
Decreases (4 builds for esp32, mbed, nrfconnect, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 4, 2021
andy31415
reviewed
Nov 4, 2021
andy31415
approved these changes
Nov 4, 2021
woody-apple
added a commit
that referenced
this pull request
Nov 4, 2021
This reverts commit abcae0d.
andy31415
added a commit
that referenced
this pull request
Nov 4, 2021
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 4, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 4, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Specific changes: 1) Stop using weak symbols for cluster init callbacks. The way things are, if a cluster has no commands its file might not get linked at all (because the weak symbols satisfy the linker), and hence its init callback would never be called. This was hitting the Descriptor cluster. 2) Add a bunch of no-op cluster init callbacks so we can link successfully. Add some files to the all-clusters-app link that were missing. Fixes project-chip#11344
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…#11392)" (project-chip#11445) This reverts commit abcae0d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
Stop using weak symbols for cluster init callbacks. The way things
are, if a cluster has no commands its file might not get linked at
all (because the weak symbols satisfy the linker), and hence its
init callback would never be called. This was hitting the
Descriptor cluster.
Add a bunch of no-op cluster init callbacks so we can link successfully.
Add some files to the all-clusters-app link that were missing.
Fixes #11344
Problem
See #11344.
Change overview
See above.
Testing
Note: This PR used to have changes to
src/app/chip_data_model.gnito usestatic_libraryinstead ofsource_set, but that fails to linkibCHIPAppServer.soon Android...