[avahi] Fix usage of searched address type #11377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Avahi-based service resolver mixes two things up: - searched address type (A or AAAA record) - IP protocol version to be used for doing the query. The service browse callbacks uses the latter as the former. Consequently, if an IPv6 commissionable service is published only via IPv4 mDNS server, it can't be properly discovered.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
vivien-apple,
wbschiller and
woody-apple
andy31415
approved these changes
Nov 3, 2021
jmeg-sfy
approved these changes
Nov 3, 2021
|
PR #11377: Size comparison from 1093d25 to 7ead1b7 Increases (13 builds for efr32, k32w, nrfconnect, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 3, 2021
bzbarsky-apple
approved these changes
Nov 3, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
The Avahi-based service resolver mixes two things up: - searched address type (A or AAAA record) - IP protocol version to be used for doing the query. The service browse callbacks uses the latter as the former. Consequently, if an IPv6 commissionable service is published only via IPv4 mDNS server, it can't be properly discovered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Avahi-based service resolver mixes two things up:
The service browse callback uses the latter as the former. Consequently, if an IPv6 commissionable service is published
only via IPv4 mDNS server, it can't be properly discovered.
Change overview
Don't pass the same value to
protocol(transport type) andaprotocol(searched address type) arguments of theavahi_service_resolver_newfunction. For the latter use the original value requested by a user when calling the browse method.Testing
Tested manually using Python CHIPController built with
chip_mdns="platform", and runningdiscover -allcommand.