Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Add refcount to CommandHandler for async commands #11367

Merged
merged 4 commits into from
Nov 12, 2021
Merged

[IM] Add refcount to CommandHandler for async commands #11367

merged 4 commits into from
Nov 12, 2021

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Nov 3, 2021 •
edited
Loading

Problem

Some cluster commands requires async works (i.e. several commands in NetworkCommissioningCluster)

Change overview

  • Adds AddRef and DecRef
  • When DecRef reached 0, it will send the response message.
  • Users are not expected to use AddRef and DecRef directly, added CommandHandler::Handle class for RAII management.
  • Calling CommandHandle() with active Handle-s should not happen, program will crash in this case.
    • TODO: Add real graceful period in shutdown functions.
      • It should look like: Reject all new commands, wait for a while, and call shutdown.

Testing

  • Adds unit test TestCommandSenderCommandAsyncSuccessResponseFlow

@boring-cyborg boring-cyborg bot added the app label Nov 3, 2021
mrjerryjohns
mrjerryjohns reviewed Nov 4, 2021
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
kghost
kghost reviewed Nov 5, 2021
View reviewed changes
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
@msandstedt msandstedt self-requested a review November 8, 2021 14:04
mrjerryjohns
mrjerryjohns suggested changes Nov 8, 2021
View reviewed changes
src/app/InteractionModelEngine.cpp Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Show resolved Hide resolved
src/app/CommandHandler.h Show resolved Hide resolved
@erjiaqing erjiaqing force-pushed the im/command-handler-hold branch from 1e25629 to e9035be Compare November 9, 2021 09:54
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11367: Size comparison from 372dc6a to e9035be

Increases above 0.2%:

platform target config section 372dc6a e9035be change % change
linux chip-tool debug .bss 25328 25392 64 0.3
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 372dc6a e9035be change % change
efr32 lighting-app BRD4161A (read only) 742640 743048 408 0.1
(read/write) 116236 116268 32 0.0
.bss 114452 114484 32 0.0
.text 742632 743040 408 0.1
BRD4161A+rpc (read only) 730184 730592 408 0.1
(read/write) 132860 132892 32 0.0
.bss 130956 130988 32 0.0
.text 730176 730584 408 0.1
lock-app BRD4161A (read only) 721920 722328 408 0.1
(read/write) 114052 114084 32 0.0
.bss 112308 112340 32 0.0
.text 721912 722320 408 0.1
window-app BRD4161A (read only) 722832 723240 408 0.1
(read/write) 114380 114412 32 0.0
.bss 112628 112660 32 0.0
.text 722824 723232 408 0.1
esp32 all-clusters-app c3devkit (read only) 880650 880934 284 0.0
(read/write) 1306456 1306640 184 0.0
.dram0.bss 58400 58416 16 0.0
.flash.rodata 198344 198512 168 0.1
.flash.text 880650 880934 284 0.0
m5stack (read only) 911819 912003 184 0.0
(read/write) 423776 423960 184 0.0
.dram0.bss 60904 60920 16 0.0
.flash.rodata 204600 204768 168 0.1
.flash.text 911819 912003 184 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699576 700000 424 0.1
.bss 77980 78012 32 0.0
.text 613884 614276 392 0.1
lock-app k32w061+debug (read/write) 592288 592708 420 0.1
.bss 68508 68540 32 0.0
.text 516100 516488 388 0.1
shell k32w061+debug (read/write) 657944 658364 420 0.1
.bss 79308 79340 32 0.0
.text 570988 571376 388 0.1
linux all-clusters-app debug (read only) 1710033 1710945 912 0.1
(read/write) 125888 125952 64 0.1
.bss 57360 57424 64 0.1
.rodata 139765 139957 192 0.1
.text 1436946 1437666 720 0.1
bridge-app debug+rpc (read only) 1297685 1298549 864 0.1
(read/write) 76432 76496 64 0.1
.bss 42256 42320 64 0.2
.rodata 111540 111700 160 0.1
.text 1090421 1091125 704 0.1
chip-tool debug (read only) 4927909 4928837 928 0.0
(read/write) 133856 133920 64 0.0
.bss 25328 25392 64 0.3
.rodata 234416 234608 192 0.1
.text 4423013 4423749 736 0.0
lighting-app debug+rpc (read only) 1557361 1558273 912 0.1
(read/write) 109448 109512 64 0.1
.bss 47920 47984 64 0.1
.rodata 128977 129169 192 0.1
.text 1294994 1295714 720 0.1
ota-provider-app debug (read only) 1259137 1260049 912 0.1
(read/write) 74696 74760 64 0.1
.bss 44352 44416 64 0.1
.rodata 113216 113408 192 0.2
.text 1049842 1050562 720 0.1
ota-requestor-app debug (read only) 1343697 1344593 896 0.1
(read/write) 78464 78528 64 0.1
.bss 46816 46880 64 0.1
.rodata 124232 124424 192 0.2
.text 1120834 1121538 704 0.1
tv-app debug (read only) 1841649 1842545 896 0.0
(read/write) 407328 407392 64 0.0
.bss 339600 339664 64 0.0
.rodata 156456 156616 160 0.1
.text 1541442 1542178 736 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290768 2291128 360 0.0
.bss 179404 179436 32 0.0
.text 1253368 1253728 360 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270928 2271224 296 0.0
.bss 172460 172492 32 0.0
.text 1233528 1233824 296 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248584 2248880 296 0.0
.bss 171356 171388 32 0.0
.text 1211184 1211480 296 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862071 862491 420 0.0
bss 111444 111476 32 0.0
rodata 96904 97068 164 0.2
text 578100 578324 224 0.0
nrf52840dk_nrf52840+rpc (read/write) 824419 824839 420 0.1
bss 107796 107828 32 0.0
rodata 88084 88248 164 0.2
text 552248 552472 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787126 787550 424 0.1
bss 112816 112848 32 0.0
rodata 92160 92328 168 0.2
text 507572 507796 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838795 839215 420 0.1
bss 110476 110508 32 0.0
rodata 93276 93440 164 0.2
text 559584 559808 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764090 764510 420 0.1
bss 111888 111920 32 0.0
rodata 88580 88744 164 0.2
text 489148 489372 224 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844871 845291 420 0.0
bss 110616 110648 32 0.0
rodata 94984 95148 164 0.2
text 563744 563968 224 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838647 839071 424 0.1
bss 110512 110544 32 0.0
rodata 93272 93440 168 0.2
text 559320 559544 224 0.0
p6 all-clusters-app default (read/write) 2299288 2299696 408 0.0
.bss 111936 111968 32 0.0
.text 1257552 1257960 408 0.0
lock-app default (read/write) 2211928 2212336 408 0.0
.bss 100744 100776 32 0.0
.text 1170192 1170600 408 0.0
qpg lighting-app qpg6100+debug (read only) 490712 490932 220 0.0
.bss 51136 51152 16 0.0
.text 485392 485612 220 0.0
lock-app qpg6100+debug (read only) 466940 467160 220 0.0
.bss 50080 50096 16 0.0
.text 461620 461840 220 0.0
telink lighting-app tlsr9518adk80d (read/write) 663682 664138 456 0.1
bss 69256 69272 16 0.0
text 458562 458834 272 0.1
Decreases (5 builds for mbed, p6)
platform target config section 372dc6a e9035be change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851808 851776 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858400 858368 -32 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859520 859488 -32 -0.0
p6 all-clusters-app default .heap 918872 918840 -32 -0.0
lock-app default .heap 930192 930160 -32 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 372dc6a e9035be change % change
efr32 lighting-app BRD4161A (read only) 742640 743048 408 0.1
(read/write) 116236 116268 32 0.0
.bss 114452 114484 32 0.0
.data 1784 1784 0 0.0
.text 742632 743040 408 0.1
BRD4161A+rpc (read only) 730184 730592 408 0.1
(read/write) 132860 132892 32 0.0
.bss 130956 130988 32 0.0
.data 1900 1900 0 0.0
.text 730176 730584 408 0.1
lock-app BRD4161A (read only) 721920 722328 408 0.1
(read/write) 114052 114084 32 0.0
.bss 112308 112340 32 0.0
.data 1744 1744 0 0.0
.text 721912 722320 408 0.1
window-app BRD4161A (read only) 722832 723240 408 0.1
(read/write) 114380 114412 32 0.0
.bss 112628 112660 32 0.0
.data 1748 1748 0 0.0
.text 722824 723232 408 0.1
esp32 all-clusters-app c3devkit (read only) 880650 880934 284 0.0
(read/write) 1306456 1306640 184 0.0
.dram0.bss 58400 58416 16 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198344 198512 168 0.1
.flash.text 880650 880934 284 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911819 912003 184 0.0
(read/write) 423776 423960 184 0.0
.dram0.bss 60904 60920 16 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204600 204768 168 0.1
.flash.text 911819 912003 184 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699576 700000 424 0.1
.bss 77980 78012 32 0.0
.data 1912 1912 0 0.0
.text 613884 614276 392 0.1
lock-app k32w061+debug (read/write) 592288 592708 420 0.1
.bss 68508 68540 32 0.0
.data 1880 1880 0 0.0
.text 516100 516488 388 0.1
shell k32w061+debug (read/write) 657944 658364 420 0.1
.bss 79308 79340 32 0.0
.data 1848 1848 0 0.0
.text 570988 571376 388 0.1
linux all-clusters-app debug (read only) 1710033 1710945 912 0.1
(read/write) 125888 125952 64 0.1
.bss 57360 57424 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 62224 62224 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139957 192 0.1
.text 1436946 1437666 720 0.1
bridge-app debug+rpc (read only) 1297685 1298549 864 0.1
(read/write) 76432 76496 64 0.1
.bss 42256 42320 64 0.2
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111700 160 0.1
.text 1090421 1091125 704 0.1
chip-tool debug (read only) 4927909 4928837 928 0.0
(read/write) 133856 133920 64 0.0
.bss 25328 25392 64 0.3
.data 2256 2256 0 0.0
.data.rel.ro 100856 100856 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 234416 234608 192 0.1
.text 4423013 4423749 736 0.0
lighting-app debug+rpc (read only) 1557361 1558273 912 0.1
(read/write) 109448 109512 64 0.1
.bss 47920 47984 64 0.1
.data 1202 1202 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 129169 192 0.1
.text 1294994 1295714 720 0.1
ota-provider-app debug (read only) 1259137 1260049 912 0.1
(read/write) 74696 74760 64 0.1
.bss 44352 44416 64 0.1
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113408 192 0.2
.text 1049842 1050562 720 0.1
ota-requestor-app debug (read only) 1343697 1344593 896 0.1
(read/write) 78464 78528 64 0.1
.bss 46816 46880 64 0.1
.data 816 816 0 0.0
.data.rel.ro 25752 25752 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124424 192 0.2
.text 1120834 1121538 704 0.1
shell debug (read only) 788233 788233 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 608770 608770 0 0.0
tv-app debug (read only) 1841649 1842545 896 0.0
(read/write) 407328 407392 64 0.0
.bss 339600 339664 64 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59328 59328 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156616 160 0.1
.text 1541442 1542178 736 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290768 2291128 360 0.0
.bss 179404 179436 32 0.0
.data 5232 5232 0 0.0
.heap 851808 851776 -32 -0.0
.text 1253368 1253728 360 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270928 2271224 296 0.0
.bss 172460 172492 32 0.0
.data 5584 5584 0 0.0
.heap 858400 858368 -32 -0.0
.text 1233528 1233824 296 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248584 2248880 296 0.0
.bss 171356 171388 32 0.0
.data 5568 5568 0 0.0
.heap 859520 859488 -32 -0.0
.text 1211184 1211480 296 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862071 862491 420 0.0
bss 111444 111476 32 0.0
rodata 96904 97068 164 0.2
text 578100 578324 224 0.0
nrf52840dk_nrf52840+rpc (read/write) 824419 824839 420 0.1
bss 107796 107828 32 0.0
rodata 88084 88248 164 0.2
text 552248 552472 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787126 787550 424 0.1
bss 112816 112848 32 0.0
rodata 92160 92328 168 0.2
text 507572 507796 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838795 839215 420 0.1
bss 110476 110508 32 0.0
rodata 93276 93440 164 0.2
text 559584 559808 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764090 764510 420 0.1
bss 111888 111920 32 0.0
rodata 88580 88744 164 0.2
text 489148 489372 224 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844871 845291 420 0.0
bss 110616 110648 32 0.0
rodata 94984 95148 164 0.2
text 563744 563968 224 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838647 839071 424 0.1
bss 110512 110544 32 0.0
rodata 93272 93440 168 0.2
text 559320 559544 224 0.0
shell nrf52840dk_nrf52840 (read/write) 776379 776379 0 0.0
bss 109264 109264 0 0.0
rodata 72544 72544 0 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2299288 2299696 408 0.0
.bss 111936 111968 32 0.0
.data 2536 2536 0 0.0
.heap 918872 918840 -32 -0.0
.text 1257552 1257960 408 0.0
lock-app default (read/write) 2211928 2212336 408 0.0
.bss 100744 100776 32 0.0
.data 2408 2408 0 0.0
.heap 930192 930160 -32 -0.0
.text 1170192 1170600 408 0.0
qpg lighting-app qpg6100+debug (read only) 490712 490932 220 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51152 16 0.0
.data 1012 1012 0 0.0
.text 485392 485612 220 0.0
lock-app qpg6100+debug (read only) 466940 467160 220 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50096 16 0.0
.data 968 968 0 0.0
.text 461620 461840 220 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663682 664138 456 0.1
bss 69256 69272 16 0.0
noinit 33216 33216 0 0.0
text 458562 458834 272 0.1

@erjiaqing erjiaqing force-pushed the im/command-handler-hold branch from e9035be to 0287191 Compare November 10, 2021 01:53
@todo
Copy link

todo bot commented Nov 10, 2021

(@kghost, #10332) Implement DeallocateAll and replace this.

connectedhomeip/src/app/InteractionModelEngine.cpp

Lines 73 to 78 in 0287191

// TODO(@kghost, #10332) Implement DeallocateAll and replace this.
mCommandHandlerObjs.Deallocate(obj);
return true;
});

This comment was generated by todo based on a TODO comment in 0287191 in #11367. cc @erjiaqing.

@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11367: Size comparison from 22e3e9d to 0287191

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22e3e9d 0287191 change % change
efr32 lighting-app BRD4161A (read only) 742140 742548 408 0.1
(read/write) 116268 116300 32 0.0
.bss 114484 114516 32 0.0
.text 742132 742540 408 0.1
BRD4161A+rpc (read only) 729664 730072 408 0.1
(read/write) 132892 132924 32 0.0
.bss 130988 131020 32 0.0
.text 729656 730064 408 0.1
lock-app BRD4161A (read only) 721420 721828 408 0.1
(read/write) 114084 114116 32 0.0
.bss 112340 112372 32 0.0
.text 721412 721820 408 0.1
window-app BRD4161A (read only) 722316 722724 408 0.1
(read/write) 114408 114440 32 0.0
.bss 112660 112692 32 0.0
.text 722308 722716 408 0.1
esp32 all-clusters-app c3devkit (read only) 878758 879042 284 0.0
(read/write) 1305904 1306088 184 0.0
.dram0.bss 58424 58440 16 0.0
.flash.rodata 197776 197944 168 0.1
.flash.text 878758 879042 284 0.0
m5stack (read only) 910199 910407 208 0.0
(read/write) 423228 423412 184 0.0
.dram0.bss 60928 60944 16 0.0
.flash.rodata 204044 204212 168 0.1
.flash.text 910199 910407 208 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698920 699344 424 0.1
.bss 77996 78028 32 0.0
.text 613212 613604 392 0.1
lock-app k32w061+debug (read/write) 591648 592068 420 0.1
.bss 68524 68556 32 0.0
.text 515444 515832 388 0.1
shell k32w061+debug (read/write) 657288 657708 420 0.1
.bss 79324 79356 32 0.0
.text 570316 570704 388 0.1
linux all-clusters-app debug (read only) 1696881 1697777 896 0.1
(read/write) 126144 126208 64 0.1
.bss 57776 57840 64 0.1
.rodata 138837 139029 192 0.1
.text 1425106 1425810 704 0.0
bridge-app debug+rpc (read only) 1296349 1297229 880 0.1
(read/write) 77072 77136 64 0.1
.bss 42768 42832 64 0.1
.rodata 110676 110836 160 0.1
.text 1089781 1090501 720 0.1
chip-tool debug (read only) 4613893 4614853 960 0.0
(read/write) 134760 134824 64 0.0
.bss 25840 25904 64 0.2
.rodata 240496 240688 192 0.1
.text 4102149 4102917 768 0.0
lighting-app debug+rpc (read only) 1556041 1556937 896 0.1
(read/write) 110088 110152 64 0.1
.bss 48432 48496 64 0.1
.rodata 128113 128305 192 0.1
.text 1294370 1295074 704 0.1
ota-provider-app debug (read only) 1257817 1258729 912 0.1
(read/write) 75336 75400 64 0.1
.bss 44864 44928 64 0.1
.rodata 112352 112544 192 0.2
.text 1049218 1049938 720 0.1
ota-requestor-app debug (read only) 1342377 1343289 912 0.1
(read/write) 79104 79168 64 0.1
.bss 47328 47392 64 0.1
.rodata 123368 123560 192 0.2
.text 1120210 1120930 720 0.1
tv-app debug (read only) 1840633 1841561 928 0.1
(read/write) 407936 408000 64 0.0
.bss 340112 340176 64 0.0
.rodata 155592 155752 160 0.1
.text 1541122 1541890 768 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288808 2289160 352 0.0
.bss 179396 179428 32 0.0
.text 1251408 1251760 352 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270240 2270528 288 0.0
.bss 172492 172524 32 0.0
.text 1232840 1233128 288 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2247896 2248248 352 0.0
.bss 171388 171420 32 0.0
.text 1210496 1210848 352 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861431 861851 420 0.0
bss 111460 111492 32 0.0
rodata 96472 96636 164 0.2
text 577860 578084 224 0.0
nrf52840dk_nrf52840+rpc (read/write) 823775 824195 420 0.1
bss 107812 107844 32 0.0
rodata 87648 87812 164 0.2
text 552008 552232 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786454 786878 424 0.1
bss 112832 112864 32 0.0
rodata 91728 91896 168 0.2
text 507332 507556 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838123 838543 420 0.1
bss 110492 110524 32 0.0
rodata 92844 93008 164 0.2
text 559344 559568 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763418 763838 420 0.1
bss 111904 111936 32 0.0
rodata 88148 88312 164 0.2
text 488908 489132 224 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844231 844651 420 0.0
bss 110632 110664 32 0.0
rodata 94552 94716 164 0.2
text 563504 563728 224 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837975 838399 424 0.1
bss 110528 110560 32 0.0
rodata 92840 93008 168 0.2
text 559080 559304 224 0.0
p6 all-clusters-app default (read/write) 2296800 2297208 408 0.0
.bss 112408 112440 32 0.0
.text 1255064 1255472 408 0.0
lock-app default (read/write) 2211416 2211824 408 0.0
.bss 101256 101288 32 0.0
.text 1169680 1170088 408 0.0
qpg lighting-app qpg6100+debug (read only) 490220 490448 228 0.0
.bss 51152 51168 16 0.0
.text 484900 485128 228 0.0
lock-app qpg6100+debug (read only) 466432 466660 228 0.0
.bss 50096 50112 16 0.0
.text 461112 461340 228 0.0
telink lighting-app tlsr9518adk80d (read/write) 662998 663454 456 0.1
bss 69272 69288 16 0.0
text 458304 458576 272 0.1
Decreases (5 builds for mbed, p6)
platform target config section 22e3e9d 0287191 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851832 851800 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858368 858336 -32 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859488 859456 -32 -0.0
p6 all-clusters-app default .heap 918416 918384 -32 -0.0
lock-app default .heap 929680 929648 -32 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22e3e9d 0287191 change % change
efr32 lighting-app BRD4161A (read only) 742140 742548 408 0.1
(read/write) 116268 116300 32 0.0
.bss 114484 114516 32 0.0
.data 1784 1784 0 0.0
.text 742132 742540 408 0.1
BRD4161A+rpc (read only) 729664 730072 408 0.1
(read/write) 132892 132924 32 0.0
.bss 130988 131020 32 0.0
.data 1900 1900 0 0.0
.text 729656 730064 408 0.1
lock-app BRD4161A (read only) 721420 721828 408 0.1
(read/write) 114084 114116 32 0.0
.bss 112340 112372 32 0.0
.data 1744 1744 0 0.0
.text 721412 721820 408 0.1
window-app BRD4161A (read only) 722316 722724 408 0.1
(read/write) 114408 114440 32 0.0
.bss 112660 112692 32 0.0
.data 1748 1748 0 0.0
.text 722308 722716 408 0.1
esp32 all-clusters-app c3devkit (read only) 878758 879042 284 0.0
(read/write) 1305904 1306088 184 0.0
.dram0.bss 58424 58440 16 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197776 197944 168 0.1
.flash.text 878758 879042 284 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910199 910407 208 0.0
(read/write) 423228 423412 184 0.0
.dram0.bss 60928 60944 16 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204044 204212 168 0.1
.flash.text 910199 910407 208 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698920 699344 424 0.1
.bss 77996 78028 32 0.0
.data 1912 1912 0 0.0
.text 613212 613604 392 0.1
lock-app k32w061+debug (read/write) 591648 592068 420 0.1
.bss 68524 68556 32 0.0
.data 1880 1880 0 0.0
.text 515444 515832 388 0.1
shell k32w061+debug (read/write) 657288 657708 420 0.1
.bss 79324 79356 32 0.0
.data 1848 1848 0 0.0
.text 570316 570704 388 0.1
linux all-clusters-app debug (read only) 1696881 1697777 896 0.1
(read/write) 126144 126208 64 0.1
.bss 57776 57840 64 0.1
.data 1010 1010 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138837 139029 192 0.1
.text 1425106 1425810 704 0.0
bridge-app debug+rpc (read only) 1296349 1297229 880 0.1
(read/write) 77072 77136 64 0.1
.bss 42768 42832 64 0.1
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110676 110836 160 0.1
.text 1089781 1090501 720 0.1
chip-tool debug (read only) 4613893 4614853 960 0.0
(read/write) 134760 134824 64 0.0
.bss 25840 25904 64 0.2
.data 2256 2256 0 0.0
.data.rel.ro 101232 101232 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240496 240688 192 0.1
.text 4102149 4102917 768 0.0
lighting-app debug+rpc (read only) 1556041 1556937 896 0.1
(read/write) 110088 110152 64 0.1
.bss 48432 48496 64 0.1
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128305 192 0.1
.text 1294370 1295074 704 0.1
ota-provider-app debug (read only) 1257817 1258729 912 0.1
(read/write) 75336 75400 64 0.1
.bss 44864 44928 64 0.1
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112352 112544 192 0.2
.text 1049218 1049938 720 0.1
ota-requestor-app debug (read only) 1342377 1343289 912 0.1
(read/write) 79104 79168 64 0.1
.bss 47328 47392 64 0.1
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123368 123560 192 0.2
.text 1120210 1120930 720 0.1
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1840633 1841561 928 0.1
(read/write) 407936 408000 64 0.0
.bss 340112 340176 64 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59432 59432 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155592 155752 160 0.1
.text 1541122 1541890 768 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288808 2289160 352 0.0
.bss 179396 179428 32 0.0
.data 5216 5216 0 0.0
.heap 851832 851800 -32 -0.0
.text 1251408 1251760 352 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270240 2270528 288 0.0
.bss 172492 172524 32 0.0
.data 5584 5584 0 0.0
.heap 858368 858336 -32 -0.0
.text 1232840 1233128 288 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247896 2248248 352 0.0
.bss 171388 171420 32 0.0
.data 5568 5568 0 0.0
.heap 859488 859456 -32 -0.0
.text 1210496 1210848 352 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048152 2048152 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1010752 1010752 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861431 861851 420 0.0
bss 111460 111492 32 0.0
rodata 96472 96636 164 0.2
text 577860 578084 224 0.0
nrf52840dk_nrf52840+rpc (read/write) 823775 824195 420 0.1
bss 107812 107844 32 0.0
rodata 87648 87812 164 0.2
text 552008 552232 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786454 786878 424 0.1
bss 112832 112864 32 0.0
rodata 91728 91896 168 0.2
text 507332 507556 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838123 838543 420 0.1
bss 110492 110524 32 0.0
rodata 92844 93008 164 0.2
text 559344 559568 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763418 763838 420 0.1
bss 111904 111936 32 0.0
rodata 88148 88312 164 0.2
text 488908 489132 224 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844231 844651 420 0.0
bss 110632 110664 32 0.0
rodata 94552 94716 164 0.2
text 563504 563728 224 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837975 838399 424 0.1
bss 110528 110560 32 0.0
rodata 92840 93008 168 0.2
text 559080 559304 224 0.0
shell nrf52840dk_nrf52840 (read/write) 775703 775703 0 0.0
bss 109280 109280 0 0.0
rodata 72108 72108 0 0.0
text 519736 519736 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690758 690758 0 0.0
bss 110264 110264 0 0.0
rodata 66752 66752 0 0.0
text 440344 440344 0 0.0
p6 all-clusters-app default (read/write) 2296800 2297208 408 0.0
.bss 112408 112440 32 0.0
.data 2520 2520 0 0.0
.heap 918416 918384 -32 -0.0
.text 1255064 1255472 408 0.0
lock-app default (read/write) 2211416 2211824 408 0.0
.bss 101256 101288 32 0.0
.data 2408 2408 0 0.0
.heap 929680 929648 -32 -0.0
.text 1169680 1170088 408 0.0
qpg lighting-app qpg6100+debug (read only) 490220 490448 228 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51168 16 0.0
.data 1012 1012 0 0.0
.text 484900 485128 228 0.0
lock-app qpg6100+debug (read only) 466432 466660 228 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50112 16 0.0
.data 968 968 0 0.0
.text 461112 461340 228 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662998 663454 456 0.1
bss 69272 69288 16 0.0
noinit 33216 33216 0 0.0
text 458304 458576 272 0.1

@erjiaqing erjiaqing force-pushed the im/command-handler-hold branch from 0287191 to faa0607 Compare November 10, 2021 06:29
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11367: Size comparison from 30e1b97 to faa0607

Increases above 0.2%:

platform target config section 30e1b97 faa0607 change % change
linux chip-tool debug .bss 25936 26032 96 0.4
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 30e1b97 faa0607 change % change
efr32 lighting-app BRD4161A (read only) 742308 742716 408 0.1
(read/write) 116276 116308 32 0.0
.bss 114492 114524 32 0.0
.text 742300 742708 408 0.1
BRD4161A+rpc (read only) 729832 730240 408 0.1
(read/write) 132900 132932 32 0.0
.bss 130996 131028 32 0.0
.text 729824 730232 408 0.1
lock-app BRD4161A (read only) 721588 721996 408 0.1
(read/write) 114092 114124 32 0.0
.bss 112348 112380 32 0.0
.text 721580 721988 408 0.1
window-app BRD4161A (read only) 722500 722908 408 0.1
(read/write) 114416 114448 32 0.0
.bss 112668 112700 32 0.0
.text 722492 722900 408 0.1
esp32 all-clusters-app c3devkit (read only) 878906 879190 284 0.0
(read/write) 1305920 1306104 184 0.0
.dram0.bss 58432 58448 16 0.0
.flash.rodata 197792 197960 168 0.1
.flash.text 878906 879190 284 0.0
m5stack (read only) 910299 910519 220 0.0
(read/write) 423252 423436 184 0.0
.dram0.bss 60936 60952 16 0.0
.flash.rodata 204060 204228 168 0.1
.flash.text 910299 910519 220 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699104 699528 424 0.1
.bss 78004 78036 32 0.0
.text 613388 613780 392 0.1
lock-app k32w061+debug (read/write) 591832 592252 420 0.1
.bss 68532 68564 32 0.0
.text 515620 516008 388 0.1
shell k32w061+debug (read/write) 657472 657892 420 0.1
.bss 79332 79364 32 0.0
.text 570492 570880 388 0.1
linux all-clusters-app debug (read only) 1697777 1698689 912 0.1
(read/write) 126304 126400 96 0.1
.bss 57872 57968 96 0.2
.rodata 138901 139093 192 0.1
.text 1425794 1426514 720 0.1
bridge-app debug+rpc (read only) 1297565 1298445 880 0.1
(read/write) 77104 77200 96 0.1
.bss 42768 42864 96 0.2
.rodata 110740 110900 160 0.1
.text 1090789 1091509 720 0.1
chip-tool debug (read only) 4615109 4616085 976 0.0
(read/write) 134888 134984 96 0.1
.bss 25936 26032 96 0.4
.rodata 240592 240784 192 0.1
.text 4103125 4103909 784 0.0
lighting-app debug+rpc (read only) 1556953 1557817 864 0.1
(read/write) 110216 110312 96 0.1
.bss 48528 48624 96 0.2
.rodata 128177 128337 160 0.1
.text 1295074 1295778 704 0.1
ota-provider-app debug (read only) 1258729 1259641 912 0.1
(read/write) 75464 75560 96 0.1
.bss 44960 45056 96 0.2
.rodata 112416 112608 192 0.2
.text 1049922 1050642 720 0.1
ota-requestor-app debug (read only) 1343289 1344185 896 0.1
(read/write) 79264 79360 96 0.1
.bss 47424 47520 96 0.2
.rodata 123432 123624 192 0.2
.text 1120914 1121618 704 0.1
tv-app debug (read only) 1841641 1842601 960 0.1
(read/write) 408064 408160 96 0.0
.bss 340208 340304 96 0.0
.rodata 155624 155816 192 0.1
.text 1541954 1542722 768 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288952 2289304 352 0.0
.bss 179404 179436 32 0.0
.text 1251552 1251904 352 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270384 2270672 288 0.0
.bss 172500 172532 32 0.0
.text 1232984 1233272 288 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248104 2248392 288 0.0
.bss 171396 171428 32 0.0
.text 1210704 1210992 288 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861607 862027 420 0.0
bss 111468 111500 32 0.0
rodata 96488 96652 164 0.2
text 578012 578236 224 0.0
nrf52840dk_nrf52840+rpc (read/write) 823935 824355 420 0.1
bss 107820 107852 32 0.0
rodata 87664 87828 164 0.2
text 552160 552384 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786646 787070 424 0.1
bss 112840 112872 32 0.0
rodata 91744 91912 168 0.2
text 507484 507708 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838315 838735 420 0.1
bss 110500 110532 32 0.0
rodata 92860 93024 164 0.2
text 559496 559720 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 764046 420 0.1
bss 111912 111944 32 0.0
rodata 88164 88328 164 0.2
text 489060 489284 224 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844407 844827 420 0.0
bss 110640 110672 32 0.0
rodata 94568 94732 164 0.2
text 563656 563880 224 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838167 838591 424 0.1
bss 110536 110568 32 0.0
rodata 92856 93024 168 0.2
text 559232 559456 224 0.0
p6 all-clusters-app default (read/write) 2296968 2297376 408 0.0
.bss 112416 112448 32 0.0
.text 1255232 1255640 408 0.0
lock-app default (read/write) 2211568 2211976 408 0.0
.bss 101264 101296 32 0.0
.text 1169832 1170240 408 0.0
qpg lighting-app qpg6100+debug (read only) 490396 490624 228 0.0
.bss 51160 51176 16 0.0
.text 485076 485304 228 0.0
lock-app qpg6100+debug (read only) 466608 466836 228 0.0
.bss 50104 50120 16 0.0
.text 461288 461516 228 0.0
telink lighting-app tlsr9518adk80d (read/write) 663174 663630 456 0.1
bss 69280 69296 16 0.0
text 458464 458738 274 0.1
Decreases (5 builds for mbed, p6)
platform target config section 30e1b97 faa0607 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851824 851792 -32 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858360 858328 -32 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859480 859448 -32 -0.0
p6 all-clusters-app default .heap 918408 918376 -32 -0.0
lock-app default .heap 929672 929640 -32 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 30e1b97 faa0607 change % change
efr32 lighting-app BRD4161A (read only) 742308 742716 408 0.1
(read/write) 116276 116308 32 0.0
.bss 114492 114524 32 0.0
.data 1784 1784 0 0.0
.text 742300 742708 408 0.1
BRD4161A+rpc (read only) 729832 730240 408 0.1
(read/write) 132900 132932 32 0.0
.bss 130996 131028 32 0.0
.data 1900 1900 0 0.0
.text 729824 730232 408 0.1
lock-app BRD4161A (read only) 721588 721996 408 0.1
(read/write) 114092 114124 32 0.0
.bss 112348 112380 32 0.0
.data 1744 1744 0 0.0
.text 721580 721988 408 0.1
window-app BRD4161A (read only) 722500 722908 408 0.1
(read/write) 114416 114448 32 0.0
.bss 112668 112700 32 0.0
.data 1748 1748 0 0.0
.text 722492 722900 408 0.1
esp32 all-clusters-app c3devkit (read only) 878906 879190 284 0.0
(read/write) 1305920 1306104 184 0.0
.dram0.bss 58432 58448 16 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197792 197960 168 0.1
.flash.text 878906 879190 284 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910299 910519 220 0.0
(read/write) 423252 423436 184 0.0
.dram0.bss 60936 60952 16 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204060 204228 168 0.1
.flash.text 910299 910519 220 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699104 699528 424 0.1
.bss 78004 78036 32 0.0
.data 1912 1912 0 0.0
.text 613388 613780 392 0.1
lock-app k32w061+debug (read/write) 591832 592252 420 0.1
.bss 68532 68564 32 0.0
.data 1880 1880 0 0.0
.text 515620 516008 388 0.1
shell k32w061+debug (read/write) 657472 657892 420 0.1
.bss 79332 79364 32 0.0
.data 1848 1848 0 0.0
.text 570492 570880 388 0.1
linux all-clusters-app debug (read only) 1697777 1698689 912 0.1
(read/write) 126304 126400 96 0.1
.bss 57872 57968 96 0.2
.data 1010 1010 0 0.0
.data.rel.ro 62144 62144 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138901 139093 192 0.1
.text 1425794 1426514 720 0.1
bridge-app debug+rpc (read only) 1297565 1298445 880 0.1
(read/write) 77104 77200 96 0.1
.bss 42768 42864 96 0.2
.data 1568 1568 0 0.0
.data.rel.ro 27808 27808 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110740 110900 160 0.1
.text 1090789 1091509 720 0.1
chip-tool debug (read only) 4615109 4616085 976 0.0
(read/write) 134888 134984 96 0.1
.bss 25936 26032 96 0.4
.data 2256 2256 0 0.0
.data.rel.ro 101280 101280 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240592 240784 192 0.1
.text 4103125 4103909 784 0.0
lighting-app debug+rpc (read only) 1556953 1557817 864 0.1
(read/write) 110216 110312 96 0.1
.bss 48528 48624 96 0.2
.data 1202 1202 0 0.0
.data.rel.ro 55216 55216 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128177 128337 160 0.1
.text 1295074 1295778 704 0.1
ota-provider-app debug (read only) 1258729 1259641 912 0.1
(read/write) 75464 75560 96 0.1
.bss 44960 45056 96 0.2
.data 752 752 0 0.0
.data.rel.ro 24664 24664 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112416 112608 192 0.2
.text 1049922 1050642 720 0.1
ota-requestor-app debug (read only) 1343289 1344185 896 0.1
(read/write) 79264 79360 96 0.1
.bss 47424 47520 96 0.2
.data 816 816 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123432 123624 192 0.2
.text 1120914 1121618 704 0.1
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1841641 1842601 960 0.1
(read/write) 408064 408160 96 0.0
.bss 340208 340304 96 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59480 59480 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155624 155816 192 0.1
.text 1541954 1542722 768 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288952 2289304 352 0.0
.bss 179404 179436 32 0.0
.data 5216 5216 0 0.0
.heap 851824 851792 -32 -0.0
.text 1251552 1251904 352 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270384 2270672 288 0.0
.bss 172500 172532 32 0.0
.data 5584 5584 0 0.0
.heap 858360 858328 -32 -0.0
.text 1232984 1233272 288 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248104 2248392 288 0.0
.bss 171396 171428 32 0.0
.data 5568 5568 0 0.0
.heap 859480 859448 -32 -0.0
.text 1210704 1210992 288 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048152 2048152 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1010752 1010752 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861607 862027 420 0.0
bss 111468 111500 32 0.0
rodata 96488 96652 164 0.2
text 578012 578236 224 0.0
nrf52840dk_nrf52840+rpc (read/write) 823935 824355 420 0.1
bss 107820 107852 32 0.0
rodata 87664 87828 164 0.2
text 552160 552384 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786646 787070 424 0.1
bss 112840 112872 32 0.0
rodata 91744 91912 168 0.2
text 507484 507708 224 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838315 838735 420 0.1
bss 110500 110532 32 0.0
rodata 92860 93024 164 0.2
text 559496 559720 224 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 764046 420 0.1
bss 111912 111944 32 0.0
rodata 88164 88328 164 0.2
text 489060 489284 224 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844407 844827 420 0.0
bss 110640 110672 32 0.0
rodata 94568 94732 164 0.2
text 563656 563880 224 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838167 838591 424 0.1
bss 110536 110568 32 0.0
rodata 92856 93024 168 0.2
text 559232 559456 224 0.0
shell nrf52840dk_nrf52840 (read/write) 775719 775719 0 0.0
bss 109280 109280 0 0.0
rodata 72108 72108 0 0.0
text 519752 519752 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690774 690774 0 0.0
bss 110264 110264 0 0.0
rodata 66752 66752 0 0.0
text 440360 440360 0 0.0
p6 all-clusters-app default (read/write) 2296968 2297376 408 0.0
.bss 112416 112448 32 0.0
.data 2520 2520 0 0.0
.heap 918408 918376 -32 -0.0
.text 1255232 1255640 408 0.0
lock-app default (read/write) 2211568 2211976 408 0.0
.bss 101264 101296 32 0.0
.data 2408 2408 0 0.0
.heap 929672 929640 -32 -0.0
.text 1169832 1170240 408 0.0
qpg lighting-app qpg6100+debug (read only) 490396 490624 228 0.0
(read/write) 114140 114140 0 0.0
.bss 51160 51176 16 0.0
.data 1012 1012 0 0.0
.text 485076 485304 228 0.0
lock-app qpg6100+debug (read only) 466608 466836 228 0.0
(read/write) 114144 114144 0 0.0
.bss 50104 50120 16 0.0
.data 968 968 0 0.0
.text 461288 461516 228 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663174 663630 456 0.1
bss 69280 69296 16 0.0
noinit 33216 33216 0 0.0
text 458464 458738 274 0.1

mrjerryjohns
mrjerryjohns reviewed Nov 11, 2021
View reviewed changes
src/controller/tests/data_model/TestCommands.cpp Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
@erjiaqing erjiaqing force-pushed the im/command-handler-hold branch from 9dc6170 to 0718507 Compare November 11, 2021 14:51
@github-actions
Copy link

github-actions bot commented Nov 11, 2021 •
edited
Loading

PR #11367: Size comparison from d45cfaa to 0718507

Increases above 0.2%:

platform target config section d45cfaa 0718507 change % change
linux bridge-app debug+rpc .bss 42800 42896 96 0.2
chip-tool debug .bss 25960 26056 96 0.4
ota-provider-app debug .bss 44992 45088 96 0.2
ota-requestor-app debug .bss 47456 47552 96 0.2
Increases (19 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section d45cfaa 0718507 change % change
efr32 lighting-app BRD4161A (read only) 742476 742884 408 0.1
(read/write) 116280 116312 32 0.0
.bss 114500 114532 32 0.0
.text 742468 742876 408 0.1
BRD4161A+rpc (read only) 730040 730448 408 0.1
(read/write) 132900 132932 32 0.0
.bss 131004 131036 32 0.0
.text 730032 730440 408 0.1
lock-app BRD4161A (read only) 721764 722172 408 0.1
(read/write) 114096 114128 32 0.0
.bss 112356 112388 32 0.0
.text 721756 722164 408 0.1
window-app BRD4161A (read only) 722676 723084 408 0.1
(read/write) 114420 114452 32 0.0
.bss 112676 112708 32 0.0
.text 722668 723076 408 0.1
k32w lighting-app k32w061+se05x+release (read/write) 699396 699820 424 0.1
.bss 78012 78044 32 0.0
.text 613676 614068 392 0.1
lock-app k32w061+debug (read/write) 592132 592552 420 0.1
.bss 68548 68580 32 0.0
.text 515908 516296 388 0.1
shell k32w061+debug (read/write) 657760 658180 420 0.1
.bss 79340 79372 32 0.0
.text 570776 571164 388 0.1
linux all-clusters-app debug (read only) 1698921 1699833 912 0.1
(read/write) 126432 126528 96 0.1
.bss 57904 58000 96 0.2
.rodata 139061 139253 192 0.1
.text 1426370 1427090 720 0.1
bridge-app debug+rpc (read only) 1298741 1299621 880 0.1
(read/write) 77264 77360 96 0.1
.bss 42800 42896 96 0.2
.rodata 110932 111092 160 0.1
.text 1091365 1092085 720 0.1
chip-tool debug (read only) 4813069 4814029 960 0.0
(read/write) 136992 137088 96 0.1
.bss 25960 26056 96 0.4
.rodata 248298 248490 192 0.1
.text 4288437 4289205 768 0.0
lighting-app debug+rpc (read only) 1558113 1558993 880 0.1
(read/write) 110376 110472 96 0.1
.bss 48560 48656 96 0.2
.rodata 128369 128529 160 0.1
.text 1295634 1296354 720 0.1
ota-provider-app debug (read only) 1259977 1260889 912 0.1
(read/write) 75624 75720 96 0.1
.bss 44992 45088 96 0.2
.rodata 112615 112807 192 0.2
.text 1050562 1051282 720 0.1
ota-requestor-app debug (read only) 1345049 1345961 912 0.1
(read/write) 79392 79488 96 0.1
.bss 47456 47552 96 0.2
.rodata 123728 123920 192 0.2
.text 1121970 1122690 720 0.1
tv-app debug (read only) 1842905 1843865 960 0.1
(read/write) 408216 408312 96 0.0
.bss 340232 340328 96 0.0
.rodata 155757 155949 192 0.1
.text 1542674 1543442 768 0.0
p6 all-clusters-app default (read/write) 2297136 2297544 408 0.0
.bss 112416 112448 32 0.0
.text 1255400 1255808 408 0.0
lock-app default (read/write) 2211760 2212168 408 0.0
.bss 101264 101296 32 0.0
.text 1170024 1170432 408 0.0
qpg lighting-app qpg6100+debug (read only) 490672 490900 228 0.0
.bss 51168 51184 16 0.0
.text 485352 485580 228 0.0
lock-app qpg6100+debug (read only) 466900 467128 228 0.0
.bss 50112 50128 16 0.0
.text 461580 461808 228 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663874 456 0.1
bss 69288 69304 16 0.0
text 458654 458928 274 0.1
Decreases (2 builds for p6)
platform target config section d45cfaa 0718507 change % change
p6 all-clusters-app default .heap 918408 918376 -32 -0.0
lock-app default .heap 929680 929648 -32 -0.0
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section d45cfaa 0718507 change % change
efr32 lighting-app BRD4161A (read only) 742476 742884 408 0.1
(read/write) 116280 116312 32 0.0
.bss 114500 114532 32 0.0
.data 1780 1780 0 0.0
.text 742468 742876 408 0.1
BRD4161A+rpc (read only) 730040 730448 408 0.1
(read/write) 132900 132932 32 0.0
.bss 131004 131036 32 0.0
.data 1896 1896 0 0.0
.text 730032 730440 408 0.1
lock-app BRD4161A (read only) 721764 722172 408 0.1
(read/write) 114096 114128 32 0.0
.bss 112356 112388 32 0.0
.data 1740 1740 0 0.0
.text 721756 722164 408 0.1
window-app BRD4161A (read only) 722676 723084 408 0.1
(read/write) 114420 114452 32 0.0
.bss 112676 112708 32 0.0
.data 1744 1744 0 0.0
.text 722668 723076 408 0.1
k32w lighting-app k32w061+se05x+release (read/write) 699396 699820 424 0.1
.bss 78012 78044 32 0.0
.data 1908 1908 0 0.0
.text 613676 614068 392 0.1
lock-app k32w061+debug (read/write) 592132 592552 420 0.1
.bss 68548 68580 32 0.0
.data 1876 1876 0 0.0
.text 515908 516296 388 0.1
shell k32w061+debug (read/write) 657760 658180 420 0.1
.bss 79340 79372 32 0.0
.data 1844 1844 0 0.0
.text 570776 571164 388 0.1
linux all-clusters-app debug (read only) 1698921 1699833 912 0.1
(read/write) 126432 126528 96 0.1
.bss 57904 58000 96 0.2
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139253 192 0.1
.text 1426370 1427090 720 0.1
bridge-app debug+rpc (read only) 1298741 1299621 880 0.1
(read/write) 77264 77360 96 0.1
.bss 42800 42896 96 0.2
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 111092 160 0.1
.text 1091365 1092085 720 0.1
chip-tool debug (read only) 4813069 4814029 960 0.0
(read/write) 136992 137088 96 0.1
.bss 25960 26056 96 0.4
.data 2256 2256 0 0.0
.data.rel.ro 103336 103336 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 248298 248490 192 0.1
.text 4288437 4289205 768 0.0
lighting-app debug+rpc (read only) 1558113 1558993 880 0.1
(read/write) 110376 110472 96 0.1
.bss 48560 48656 96 0.2
.data 1202 1202 0 0.0
.data.rel.ro 55328 55328 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128529 160 0.1
.text 1295634 1296354 720 0.1
ota-provider-app debug (read only) 1259977 1260889 912 0.1
(read/write) 75624 75720 96 0.1
.bss 44992 45088 96 0.2
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112807 192 0.2
.text 1050562 1051282 720 0.1
ota-requestor-app debug (read only) 1345049 1345961 912 0.1
(read/write) 79392 79488 96 0.1
.bss 47456 47552 96 0.2
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123728 123920 192 0.2
.text 1121970 1122690 720 0.1
shell debug (read only) 788441 788441 0 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77519 0 0.0
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1843865 960 0.1
(read/write) 408216 408312 96 0.0
.bss 340232 340328 96 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155949 192 0.1
.text 1542674 1543442 768 0.0
p6 all-clusters-app default (read/write) 2297136 2297544 408 0.0
.bss 112416 112448 32 0.0
.data 2520 2520 0 0.0
.heap 918408 918376 -32 -0.0
.text 1255400 1255808 408 0.0
lock-app default (read/write) 2211760 2212168 408 0.0
.bss 101264 101296 32 0.0
.data 2400 2400 0 0.0
.heap 929680 929648 -32 -0.0
.text 1170024 1170432 408 0.0
qpg lighting-app qpg6100+debug (read only) 490672 490900 228 0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51184 16 0.0
.data 1008 1008 0 0.0
.text 485352 485580 228 0.0
lock-app qpg6100+debug (read only) 466900 467128 228 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50128 16 0.0
.data 964 964 0 0.0
.text 461580 461808 228 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663874 456 0.1
bss 69288 69304 16 0.0
noinit 33216 33216 0 0.0
text 458654 458928 274 0.1

bzbarsky-apple
bzbarsky-apple approved these changes Nov 11, 2021
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.h Show resolved Hide resolved
src/app/CommandHandler.h Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Show resolved Hide resolved
@erjiaqing erjiaqing merged commit c6bf43b into project-chip:master Nov 12, 2021
@erjiaqing erjiaqing deleted the im/command-handler-hold branch November 12, 2021 05:05
@todo todo bot mentioned this pull request Nov 12, 2021
Closed
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@erjiaqing
[IM] Add refcount to CommandHandler for async commands (project-chip#…
f5d431c 
…11367)

* [IM] Add refcount methnism for async background work

* Invalid CommandHandler::Handle when chip stack shutdown

* mRefCount -> mPendingWork

* Upd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@kghost kghost kghost left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erjiaqing @kghost @tcarmelveilleux @msandstedt @mrjerryjohns @bzbarsky-apple