Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplfy the implementation of Mode Select Cluster #11359

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Simplfy the implementation of Mode Select Cluster #11359

merged 1 commit into from
Nov 9, 2021

Conversation

du48s03
Copy link
Contributor

@du48s03 du48s03 commented Nov 3, 2021 •
edited
Loading

Problem

What is being fixed? Examples:

Change overview

Removed the usage of std::map
Removed the abstract ModeOptionIterator and its implementation
Removed the abstract ModeOptionIteratorFactory and its implementation
Move the implementation of StaticSupportedModeOptionsManager to /example folders, as it contains app-specific logic.
Added the concrete class ModeOptionsProvider

Testing

How was this tested? (at least one bullet point required)

  • If manually tested, what platforms controller and device platforms were manually tested, and how?
    Manually tested on MacOs with chip-tool

@boring-cyborg boring-cyborg bot added the app label Nov 3, 2021
@todo
Copy link

todo bot commented Nov 3, 2021

Configure your options for each endpoint

connectedhomeip/src/app/clusters/mode-select-server/static-supported-modes-manager.cpp

Lines 26 to 36 in fda93f9

// TODO: Configure your options for each endpoint
storage_value_type StaticSupportedModesManager::coffeeOptions[] = {
buildModeOptionStruct("Black", 0, 0),
buildModeOptionStruct("Cappuccino", 4, 0),
buildModeOptionStruct("Espresso", 7, 0)
};
const StaticSupportedModesManager::EndpointSpanPair StaticSupportedModesManager::supportedOptionsByEndpoints[ENDPOINTS_WITH_MODES] = {
EndpointSpanPair(1, Span<storage_value_type>(StaticSupportedModesManager::coffeeOptions)) // Options for Endpoint 1
};
const StaticSupportedModesManager StaticSupportedModesManager::instance = StaticSupportedModesManager();

This comment was generated by todo based on a TODO comment in fda93f9 in #11359. cc @du48s03.

@restyled-io restyled-io bot mentioned this pull request Nov 3, 2021
Closed
@woody-apple
Copy link
Contributor

@saurabhst @msandstedt @andy31415 ?

@restyled-io restyled-io bot mentioned this pull request Nov 8, 2021
Closed
@du48s03 du48s03 force-pushed the simplify-mode-select branch 2 times, most recently from 51a9328 to c6c2d4b Compare November 8, 2021 21:32
@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #11359: Size comparison from 86511a1 to c6c2d4b

Increases (2 builds for mbed, p6)
platform target config section 86511a1 c6c2d4b change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851808 851864 56 0.0
p6 all-clusters-app default .heap 918872 918928 56 0.0
Decreases (5 builds for esp32, linux, mbed, p6)
platform target config section 86511a1 c6c2d4b change % change
esp32 all-clusters-app c3devkit (read only) 880266 878630 -1636 -0.2
(read/write) 1306488 1306320 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198376 198256 -120 -0.1
.flash.text 880266 878630 -1636 -0.2
m5stack (read only) 911395 909943 -1452 -0.2
(read/write) 423808 423628 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204632 204508 -124 -0.1
.flash.text 911395 909943 -1452 -0.2
linux all-clusters-app debug (read only) 1704545 1692713 -11832 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62208 61952 -256 -0.4
.rodata 139477 139413 -64 -0.0
.text 1431794 1420578 -11216 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291552 2290216 -1336 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.text 1254152 1252816 -1336 -0.1
p6 all-clusters-app default (read/write) 2298888 2296912 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.text 1257152 1255176 -1976 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 86511a1 c6c2d4b change % change
efr32 lighting-app BRD4161A (read only) 742336 742336 0 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742328 742328 0 0.0
BRD4161A+rpc (read only) 729864 729864 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 729856 729856 0 0.0
lock-app BRD4161A (read only) 721600 721600 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721592 721592 0 0.0
window-app BRD4161A (read only) 722496 722496 0 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722488 722488 0 0.0
esp32 all-clusters-app c3devkit (read only) 880266 878630 -1636 -0.2
(read/write) 1306488 1306320 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198376 198256 -120 -0.1
.flash.text 880266 878630 -1636 -0.2
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911395 909943 -1452 -0.2
(read/write) 423808 423628 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204632 204508 -124 -0.1
.flash.text 911395 909943 -1452 -0.2
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699128 0 0.0
.bss 77976 77976 0 0.0
.data 1912 1912 0 0.0
.text 613440 613440 0 0.0
lock-app k32w061+debug (read/write) 591952 591952 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 515764 515764 0 0.0
shell k32w061+debug (read/write) 657608 657608 0 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570652 570652 0 0.0
linux all-clusters-app debug (read only) 1704545 1692713 -11832 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62208 61952 -256 -0.4
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139477 139413 -64 -0.0
.text 1431794 1420578 -11216 -0.8
bridge-app debug+rpc (read only) 1292549 1292549 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111252 111252 0 0.0
.text 1085573 1085573 0 0.0
chip-tool debug (read only) 4921613 4921613 0 0.0
(read/write) 133160 133160 0 0.0
.bss 25328 25328 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100192 100192 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 233712 233712 0 0.0
.text 4419125 4419125 0 0.0
lighting-app debug+rpc (read only) 1553545 1553545 0 0.0
(read/write) 109432 109432 0 0.0
.bss 47928 47928 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129873 129873 0 0.0
.text 1290258 1290258 0 0.0
ota-provider-app debug (read only) 1251785 1251785 0 0.0
(read/write) 74632 74632 0 0.0
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24440 24440 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112488 112488 0 0.0
.text 1043362 1043362 0 0.0
ota-requestor-app debug (read only) 1330305 1330305 0 0.0
(read/write) 83920 83920 0 0.0
.bss 52512 52512 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25448 25448 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124464 124464 0 0.0
.text 1107954 1107954 0 0.0
shell debug (read only) 788153 788153 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78127 78127 0 0.0
.text 608754 608754 0 0.0
tv-app debug (read only) 1818705 1818705 0 0.0
(read/write) 297568 297568 0 0.0
.bss 230512 230512 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155528 155528 0 0.0
.text 1521058 1521058 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291552 2290216 -1336 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.heap 851808 851864 56 0.0
.text 1254152 1252816 -1336 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271648 2271648 0 0.0
.bss 172460 172460 0 0.0
.data 5584 5584 0 0.0
.heap 858400 858400 0 0.0
.text 1234248 1234248 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249368 2249368 0 0.0
.bss 171356 171356 0 0.0
.data 5568 5568 0 0.0
.heap 859520 859520 0 0.0
.text 1211968 1211968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861779 861779 0 0.0
bss 111444 111444 0 0.0
rodata 96932 96932 0 0.0
text 577776 577776 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824127 824127 0 0.0
bss 107796 107796 0 0.0
rodata 88112 88112 0 0.0
text 551924 551924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786822 786822 0 0.0
bss 112816 112816 0 0.0
rodata 92192 92192 0 0.0
text 507248 507248 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838487 838487 0 0.0
bss 110476 110476 0 0.0
rodata 93304 93304 0 0.0
text 559256 559256 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763798 763798 0 0.0
bss 111888 111888 0 0.0
rodata 88608 88608 0 0.0
text 488820 488820 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844579 844579 0 0.0
bss 110616 110616 0 0.0
rodata 95012 95012 0 0.0
text 563420 563420 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838343 838343 0 0.0
bss 110512 110512 0 0.0
rodata 93304 93304 0 0.0
text 558992 558992 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776375 776375 0 0.0
bss 109264 109264 0 0.0
rodata 72540 72540 0 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2298888 2296912 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.heap 918872 918928 56 0.0
.text 1257152 1255176 -1976 -0.2
lock-app default (read/write) 2211592 2211592 0 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1169856 1169856 0 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490276 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 484956 484956 0 0.0
lock-app qpg6100+debug (read only) 466616 466616 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461296 461296 0 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153396 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148076 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663418 0 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458266 458266 0 0.0

@du48s03 du48s03 force-pushed the simplify-mode-select branch from c6c2d4b to 823abda Compare November 8, 2021 23:51
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

PR #11359: Size comparison from a04576d to 823abda

Increases (1 build for p6)
platform target config section a04576d 823abda change % change
p6 all-clusters-app default .heap 918872 918928 56 0.0
Decreases (1 build for p6)
platform target config section a04576d 823abda change % change
p6 all-clusters-app default (read/write) 2299216 2297240 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.text 1257480 1255504 -1976 -0.2
Full report (9 builds for k32w, p6, qpg, telink)
platform target config section a04576d 823abda change % change
k32w lock-app k32w061+debug (read/write) 592284 592284 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 516096 516096 0 0.0
shell k32w061+debug (read/write) 657940 657940 0 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570984 570984 0 0.0
lighting-app k32w061+se05x+release (read/write) 699572 699572 0 0.0
.bss 77980 77980 0 0.0
.data 1912 1912 0 0.0
.text 613880 613880 0 0.0
p6 all-clusters-app default (read/write) 2299216 2297240 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.heap 918872 918928 56 0.0
.text 1257480 1255504 -1976 -0.2
lock-app default (read/write) 2211928 2211928 0 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1170192 1170192 0 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 485388 485388 0 0.0
lock-app qpg6100+debug (read only) 466936 466936 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461616 461616 0 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153396 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148076 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663678 663678 0 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458562 458562 0 0.0

@restyled-io restyled-io bot mentioned this pull request Nov 9, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11359: Size comparison from a04576d to 2aeede1

Increases (2 builds for mbed, p6)
platform target config section a04576d 2aeede1 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851808 851864 56 0.0
p6 all-clusters-app default .heap 918872 918928 56 0.0
Decreases (5 builds for esp32, linux, mbed, p6)
platform target config section a04576d 2aeede1 change % change
esp32 all-clusters-app c3devkit (read only) 880602 878966 -1636 -0.2
(read/write) 1306448 1306280 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198336 198216 -120 -0.1
.flash.text 880602 878966 -1636 -0.2
m5stack (read only) 911763 910391 -1372 -0.2
(read/write) 423768 423588 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204592 204468 -124 -0.1
.flash.text 911763 910391 -1372 -0.2
linux all-clusters-app debug (read only) 1709681 1697881 -11800 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62208 61952 -256 -0.4
.rodata 139765 139733 -32 -0.0
.text 1436642 1425426 -11216 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290768 2289496 -1272 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.text 1253368 1252096 -1272 -0.1
p6 all-clusters-app default (read/write) 2299216 2297240 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.text 1257480 1255504 -1976 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a04576d 2aeede1 change % change
efr32 lighting-app BRD4161A (read only) 742632 742632 0 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742624 742624 0 0.0
BRD4161A+rpc (read only) 730184 730184 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 730176 730176 0 0.0
lock-app BRD4161A (read only) 721920 721920 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721912 721912 0 0.0
window-app BRD4161A (read only) 722832 722832 0 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722824 722824 0 0.0
esp32 all-clusters-app c3devkit (read only) 880602 878966 -1636 -0.2
(read/write) 1306448 1306280 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198336 198216 -120 -0.1
.flash.text 880602 878966 -1636 -0.2
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911763 910391 -1372 -0.2
(read/write) 423768 423588 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204592 204468 -124 -0.1
.flash.text 911763 910391 -1372 -0.2
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699572 699572 0 0.0
.bss 77980 77980 0 0.0
.data 1912 1912 0 0.0
.text 613880 613880 0 0.0
lock-app k32w061+debug (read/write) 592284 592284 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 516096 516096 0 0.0
shell k32w061+debug (read/write) 657940 657940 0 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570984 570984 0 0.0
linux all-clusters-app debug (read only) 1709681 1697881 -11800 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62208 61952 -256 -0.4
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139733 -32 -0.0
.text 1436642 1425426 -11216 -0.8
bridge-app debug+rpc (read only) 1297685 1297685 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090421 1090421 0 0.0
chip-tool debug (read only) 4916461 4916461 0 0.0
(read/write) 133792 133792 0 0.0
.bss 25328 25328 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 100776 100776 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 234064 234064 0 0.0
.text 4412085 4412085 0 0.0
lighting-app debug+rpc (read only) 1557361 1557361 0 0.0
(read/write) 109448 109448 0 0.0
.bss 47920 47920 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1294994 1294994 0 0.0
ota-provider-app debug (read only) 1256905 1256905 0 0.0
(read/write) 74632 74632 0 0.0
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24440 24440 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112776 112776 0 0.0
.text 1048194 1048194 0 0.0
ota-requestor-app debug (read only) 1341433 1341433 0 0.0
(read/write) 78432 78432 0 0.0
.bss 46816 46816 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25704 25704 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123760 123760 0 0.0
.text 1119186 1119186 0 0.0
shell debug (read only) 788233 788233 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 608770 608770 0 0.0
tv-app debug (read only) 1841649 1841649 0 0.0
(read/write) 407328 407328 0 0.0
.bss 339600 339600 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59328 59328 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541442 1541442 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290768 2289496 -1272 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.heap 851808 851864 56 0.0
.text 1253368 1252096 -1272 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270928 2270928 0 0.0
.bss 172460 172460 0 0.0
.data 5584 5584 0 0.0
.heap 858400 858400 0 0.0
.text 1233528 1233528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248584 2248584 0 0.0
.bss 171356 171356 0 0.0
.data 5568 5568 0 0.0
.heap 859520 859520 0 0.0
.text 1211184 1211184 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862067 862067 0 0.0
bss 111444 111444 0 0.0
rodata 96900 96900 0 0.0
text 578100 578100 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824415 824415 0 0.0
bss 107796 107796 0 0.0
rodata 88080 88080 0 0.0
text 552248 552248 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787126 787126 0 0.0
bss 112816 112816 0 0.0
rodata 92160 92160 0 0.0
text 507572 507572 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838791 838791 0 0.0
bss 110476 110476 0 0.0
rodata 93272 93272 0 0.0
text 559584 559584 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764086 764086 0 0.0
bss 111888 111888 0 0.0
rodata 88576 88576 0 0.0
text 489148 489148 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844867 844867 0 0.0
bss 110616 110616 0 0.0
rodata 94980 94980 0 0.0
text 563744 563744 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838647 838647 0 0.0
bss 110512 110512 0 0.0
rodata 93272 93272 0 0.0
text 559320 559320 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776375 776375 0 0.0
bss 109264 109264 0 0.0
rodata 72540 72540 0 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2299216 2297240 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.heap 918872 918928 56 0.0
.text 1257480 1255504 -1976 -0.2
lock-app default (read/write) 2211928 2211928 0 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1170192 1170192 0 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 485388 485388 0 0.0
lock-app qpg6100+debug (read only) 466936 466936 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461616 461616 0 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153396 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148076 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663678 663678 0 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458562 458562 0 0.0

@du48s03 du48s03 force-pushed the simplify-mode-select branch from 2aeede1 to 499bbaf Compare November 9, 2021 03:53
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@du48s03 du48s03 force-pushed the simplify-mode-select branch from 499bbaf to 4b75caa Compare November 9, 2021 04:04
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11359: Size comparison from 94c5144 to 4b75caa

Increases (2 builds for mbed, p6)
platform target config section 94c5144 4b75caa change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851808 851864 56 0.0
p6 all-clusters-app default .heap 918872 918928 56 0.0
Decreases (5 builds for esp32, linux, mbed, p6)
platform target config section 94c5144 4b75caa change % change
esp32 all-clusters-app c3devkit (read only) 880650 879014 -1636 -0.2
(read/write) 1306456 1306288 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198344 198224 -120 -0.1
.flash.text 880650 879014 -1636 -0.2
m5stack (read only) 911803 910447 -1356 -0.1
(read/write) 423776 423596 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204600 204476 -124 -0.1
.flash.text 911803 910447 -1356 -0.1
linux all-clusters-app debug (read only) 1710033 1698233 -11800 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62224 61968 -256 -0.4
.rodata 139765 139733 -32 -0.0
.text 1436946 1425730 -11216 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290768 2289496 -1272 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.text 1253368 1252096 -1272 -0.1
p6 all-clusters-app default (read/write) 2299288 2297312 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.text 1257552 1255576 -1976 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 94c5144 4b75caa change % change
efr32 lighting-app BRD4161A (read only) 742640 742640 0 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742632 742632 0 0.0
BRD4161A+rpc (read only) 730184 730184 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 730176 730176 0 0.0
lock-app BRD4161A (read only) 721920 721920 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721912 721912 0 0.0
window-app BRD4161A (read only) 722832 722832 0 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722824 722824 0 0.0
esp32 all-clusters-app c3devkit (read only) 880650 879014 -1636 -0.2
(read/write) 1306456 1306288 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198344 198224 -120 -0.1
.flash.text 880650 879014 -1636 -0.2
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911803 910447 -1356 -0.1
(read/write) 423776 423596 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204600 204476 -124 -0.1
.flash.text 911803 910447 -1356 -0.1
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699576 699576 0 0.0
.bss 77980 77980 0 0.0
.data 1912 1912 0 0.0
.text 613884 613884 0 0.0
lock-app k32w061+debug (read/write) 592288 592288 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 516100 516100 0 0.0
shell k32w061+debug (read/write) 657944 657944 0 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570988 570988 0 0.0
linux all-clusters-app debug (read only) 1710033 1698233 -11800 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62224 61968 -256 -0.4
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139733 -32 -0.0
.text 1436946 1425730 -11216 -0.8
bridge-app debug+rpc (read only) 1297685 1297685 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090421 1090421 0 0.0
chip-tool debug (read only) 4927909 4927909 0 0.0
(read/write) 133856 133856 0 0.0
.bss 25328 25328 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 100856 100856 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 234416 234416 0 0.0
.text 4423013 4423013 0 0.0
lighting-app debug+rpc (read only) 1557361 1557361 0 0.0
(read/write) 109448 109448 0 0.0
.bss 47920 47920 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1294994 1294994 0 0.0
ota-provider-app debug (read only) 1259137 1259137 0 0.0
(read/write) 74696 74696 0 0.0
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1049842 1049842 0 0.0
ota-requestor-app debug (read only) 1343697 1343697 0 0.0
(read/write) 78464 78464 0 0.0
.bss 46816 46816 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25752 25752 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1120834 1120834 0 0.0
shell debug (read only) 788233 788233 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 608770 608770 0 0.0
tv-app debug (read only) 1841649 1841649 0 0.0
(read/write) 407328 407328 0 0.0
.bss 339600 339600 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59328 59328 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541442 1541442 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290768 2289496 -1272 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.heap 851808 851864 56 0.0
.text 1253368 1252096 -1272 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270928 2270928 0 0.0
.bss 172460 172460 0 0.0
.data 5584 5584 0 0.0
.heap 858400 858400 0 0.0
.text 1233528 1233528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248584 2248584 0 0.0
.bss 171356 171356 0 0.0
.data 5568 5568 0 0.0
.heap 859520 859520 0 0.0
.text 1211184 1211184 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862071 862071 0 0.0
bss 111444 111444 0 0.0
rodata 96904 96904 0 0.0
text 578100 578100 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824419 824419 0 0.0
bss 107796 107796 0 0.0
rodata 88084 88084 0 0.0
text 552248 552248 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787126 787126 0 0.0
bss 112816 112816 0 0.0
rodata 92160 92160 0 0.0
text 507572 507572 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838795 838795 0 0.0
bss 110476 110476 0 0.0
rodata 93276 93276 0 0.0
text 559584 559584 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764090 764090 0 0.0
bss 111888 111888 0 0.0
rodata 88580 88580 0 0.0
text 489148 489148 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844871 844871 0 0.0
bss 110616 110616 0 0.0
rodata 94984 94984 0 0.0
text 563744 563744 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838647 838647 0 0.0
bss 110512 110512 0 0.0
rodata 93272 93272 0 0.0
text 559320 559320 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776379 776379 0 0.0
bss 109264 109264 0 0.0
rodata 72544 72544 0 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2299288 2297312 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.heap 918872 918928 56 0.0
.text 1257552 1255576 -1976 -0.2
lock-app default (read/write) 2211928 2211928 0 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1170192 1170192 0 0.0
qpg lighting-app qpg6100+debug (read only) 490712 490712 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 485392 485392 0 0.0
lock-app qpg6100+debug (read only) 466940 466940 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461620 461620 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663682 663682 0 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458562 458562 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Nov 9, 2021
View reviewed changes
examples/all-clusters-app/linux/BUILD.gn Outdated Show resolved Hide resolved
examples/all-clusters-app/p6/BUILD.gn Outdated Show resolved Hide resolved
@du48s03 du48s03 force-pushed the simplify-mode-select branch from 4b75caa to dc21b2e Compare November 9, 2021 06:44
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11359: Size comparison from 372dc6a to dc21b2e

Increases (1 build for p6)
platform target config section 372dc6a dc21b2e change % change
p6 all-clusters-app default .heap 918872 918928 56 0.0
Decreases (2 builds for linux, p6)
platform target config section 372dc6a dc21b2e change % change
linux all-clusters-app debug (read only) 1710033 1698233 -11800 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62224 61968 -256 -0.4
.rodata 139765 139733 -32 -0.0
.text 1436946 1425730 -11216 -0.8
p6 all-clusters-app default (read/write) 2299288 2297312 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.text 1257552 1255576 -1976 -0.2
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 372dc6a dc21b2e change % change
efr32 lighting-app BRD4161A (read only) 742640 742640 0 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742632 742632 0 0.0
BRD4161A+rpc (read only) 730184 730184 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 730176 730176 0 0.0
lock-app BRD4161A (read only) 721920 721920 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721912 721912 0 0.0
window-app BRD4161A (read only) 722832 722832 0 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722824 722824 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699576 699576 0 0.0
.bss 77980 77980 0 0.0
.data 1912 1912 0 0.0
.text 613884 613884 0 0.0
lock-app k32w061+debug (read/write) 592288 592288 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 516100 516100 0 0.0
shell k32w061+debug (read/write) 657944 657944 0 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570988 570988 0 0.0
linux all-clusters-app debug (read only) 1710033 1698233 -11800 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62224 61968 -256 -0.4
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139733 -32 -0.0
.text 1436946 1425730 -11216 -0.8
bridge-app debug+rpc (read only) 1297685 1297685 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090421 1090421 0 0.0
chip-tool debug (read only) 4927909 4927909 0 0.0
(read/write) 133856 133856 0 0.0
.bss 25328 25328 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 100856 100856 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 234416 234416 0 0.0
.text 4423013 4423013 0 0.0
lighting-app debug+rpc (read only) 1557361 1557361 0 0.0
(read/write) 109448 109448 0 0.0
.bss 47920 47920 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1294994 1294994 0 0.0
ota-provider-app debug (read only) 1259137 1259137 0 0.0
(read/write) 74696 74696 0 0.0
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1049842 1049842 0 0.0
ota-requestor-app debug (read only) 1343697 1343697 0 0.0
(read/write) 78464 78464 0 0.0
.bss 46816 46816 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25752 25752 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1120834 1120834 0 0.0
shell debug (read only) 788233 788233 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 608770 608770 0 0.0
tv-app debug (read only) 1841649 1841649 0 0.0
(read/write) 407328 407328 0 0.0
.bss 339600 339600 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59328 59328 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541442 1541442 0 0.0
p6 all-clusters-app default (read/write) 2299288 2297312 -1976 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.heap 918872 918928 56 0.0
.text 1257552 1255576 -1976 -0.2
lock-app default (read/write) 2211928 2211928 0 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1170192 1170192 0 0.0
qpg lighting-app qpg6100+debug (read only) 490712 490712 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 485392 485392 0 0.0
lock-app qpg6100+debug (read only) 466940 466940 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461620 461620 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663682 663682 0 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458562 458562 0 0.0

@restyled-io restyled-io bot mentioned this pull request Nov 9, 2021
Closed
@du48s03 du48s03 force-pushed the simplify-mode-select branch from abe4379 to f3a42e9 Compare November 9, 2021 07:43
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11359: Size comparison from 372dc6a to f3a42e9

Increases (2 builds for mbed, p6)
platform target config section 372dc6a f3a42e9 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851808 851864 56 0.0
p6 all-clusters-app default .heap 918872 918928 56 0.0
Decreases (5 builds for esp32, linux, mbed, p6)
platform target config section 372dc6a f3a42e9 change % change
esp32 all-clusters-app c3devkit (read only) 880650 879014 -1636 -0.2
(read/write) 1306456 1306288 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198344 198224 -120 -0.1
.flash.text 880650 879014 -1636 -0.2
m5stack (read only) 911819 910447 -1372 -0.2
(read/write) 423776 423596 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204600 204476 -124 -0.1
.flash.text 911819 910447 -1372 -0.2
linux all-clusters-app debug (read only) 1710033 1698201 -11832 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62224 61968 -256 -0.4
.rodata 139765 139701 -64 -0.0
.text 1436946 1425730 -11216 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290768 2289496 -1272 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.text 1253368 1252096 -1272 -0.1
p6 all-clusters-app default (read/write) 2299288 2297320 -1968 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.text 1257552 1255584 -1968 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 372dc6a f3a42e9 change % change
efr32 lighting-app BRD4161A (read only) 742640 742640 0 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742632 742632 0 0.0
BRD4161A+rpc (read only) 730184 730184 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 730176 730176 0 0.0
lock-app BRD4161A (read only) 721920 721920 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721912 721912 0 0.0
window-app BRD4161A (read only) 722832 722832 0 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722824 722824 0 0.0
esp32 all-clusters-app c3devkit (read only) 880650 879014 -1636 -0.2
(read/write) 1306456 1306288 -168 -0.0
.dram0.bss 58400 58360 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198344 198224 -120 -0.1
.flash.text 880650 879014 -1636 -0.2
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911819 910447 -1372 -0.2
(read/write) 423776 423596 -180 -0.0
.dram0.bss 60904 60864 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204600 204476 -124 -0.1
.flash.text 911819 910447 -1372 -0.2
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699576 699576 0 0.0
.bss 77980 77980 0 0.0
.data 1912 1912 0 0.0
.text 613884 613884 0 0.0
lock-app k32w061+debug (read/write) 592288 592288 0 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 516100 516100 0 0.0
shell k32w061+debug (read/write) 657944 657944 0 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570988 570988 0 0.0
linux all-clusters-app debug (read only) 1710033 1698201 -11832 -0.7
(read/write) 125888 125504 -384 -0.3
.bss 57360 57264 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62224 61968 -256 -0.4
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139701 -64 -0.0
.text 1436946 1425730 -11216 -0.8
bridge-app debug+rpc (read only) 1297685 1297685 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090421 1090421 0 0.0
chip-tool debug (read only) 4927909 4927909 0 0.0
(read/write) 133856 133856 0 0.0
.bss 25328 25328 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 100856 100856 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 234416 234416 0 0.0
.text 4423013 4423013 0 0.0
lighting-app debug+rpc (read only) 1557361 1557361 0 0.0
(read/write) 109448 109448 0 0.0
.bss 47920 47920 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1294994 1294994 0 0.0
ota-provider-app debug (read only) 1259137 1259137 0 0.0
(read/write) 74696 74696 0 0.0
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1049842 1049842 0 0.0
ota-requestor-app debug (read only) 1343697 1343697 0 0.0
(read/write) 78464 78464 0 0.0
.bss 46816 46816 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25752 25752 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1120834 1120834 0 0.0
shell debug (read only) 788233 788233 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 608770 608770 0 0.0
tv-app debug (read only) 1841649 1841649 0 0.0
(read/write) 407328 407328 0 0.0
.bss 339600 339600 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59328 59328 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541442 1541442 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290768 2289496 -1272 -0.1
.bss 179404 179364 -40 -0.0
.data 5232 5216 -16 -0.3
.heap 851808 851864 56 0.0
.text 1253368 1252096 -1272 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270928 2270928 0 0.0
.bss 172460 172460 0 0.0
.data 5584 5584 0 0.0
.heap 858400 858400 0 0.0
.text 1233528 1233528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248584 2248584 0 0.0
.bss 171356 171356 0 0.0
.data 5568 5568 0 0.0
.heap 859520 859520 0 0.0
.text 1211184 1211184 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862071 862071 0 0.0
bss 111444 111444 0 0.0
rodata 96904 96904 0 0.0
text 578100 578100 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824419 824419 0 0.0
bss 107796 107796 0 0.0
rodata 88084 88084 0 0.0
text 552248 552248 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787126 787126 0 0.0
bss 112816 112816 0 0.0
rodata 92160 92160 0 0.0
text 507572 507572 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838795 838795 0 0.0
bss 110476 110476 0 0.0
rodata 93276 93276 0 0.0
text 559584 559584 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764090 764090 0 0.0
bss 111888 111888 0 0.0
rodata 88580 88580 0 0.0
text 489148 489148 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844871 844871 0 0.0
bss 110616 110616 0 0.0
rodata 94984 94984 0 0.0
text 563744 563744 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838647 838647 0 0.0
bss 110512 110512 0 0.0
rodata 93272 93272 0 0.0
text 559320 559320 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776379 776379 0 0.0
bss 109264 109264 0 0.0
rodata 72544 72544 0 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2299288 2297320 -1968 -0.1
.bss 111936 111896 -40 -0.0
.data 2536 2520 -16 -0.6
.heap 918872 918928 56 0.0
.text 1257552 1255584 -1968 -0.2
lock-app default (read/write) 2211928 2211928 0 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1170192 1170192 0 0.0
qpg lighting-app qpg6100+debug (read only) 490712 490712 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 485392 485392 0 0.0
lock-app qpg6100+debug (read only) 466940 466940 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461620 461620 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663682 663682 0 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458562 458562 0 0.0

@du48s03 @dinglamazon
Simplfy the implementation of Mode Select Cluster
327b91b 
Restyled by whitespace

Restyled by clang-format

Update submodules
@du48s03 du48s03 force-pushed the simplify-mode-select branch from f3a42e9 to 327b91b Compare November 9, 2021 17:42
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11359: Size comparison from ff5f946 to 327b91b

Increases (2 builds for mbed, p6)
platform target config section ff5f946 327b91b change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851776 851832 56 0.0
p6 all-clusters-app default .heap 918360 918416 56 0.0
Decreases (5 builds for esp32, linux, mbed, p6)
platform target config section ff5f946 327b91b change % change
esp32 all-clusters-app c3devkit (read only) 880694 879058 -1636 -0.2
(read/write) 1306536 1306368 -168 -0.0
.dram0.bss 58464 58424 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198360 198240 -120 -0.1
.flash.text 880694 879058 -1636 -0.2
m5stack (read only) 911863 910483 -1380 -0.2
(read/write) 423864 423684 -180 -0.0
.dram0.bss 60968 60928 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204624 204500 -124 -0.1
.flash.text 911863 910483 -1380 -0.2
linux all-clusters-app debug (read only) 1710601 1698785 -11816 -0.7
(read/write) 126528 126144 -384 -0.3
.bss 57872 57776 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62352 62096 -256 -0.4
.rodata 139765 139701 -64 -0.0
.text 1437346 1426146 -11200 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290856 2289584 -1272 -0.1
.bss 179436 179396 -40 -0.0
.data 5232 5216 -16 -0.3
.text 1253456 1252184 -1272 -0.1
p6 all-clusters-app default (read/write) 2299528 2297568 -1960 -0.1
.bss 112448 112408 -40 -0.0
.data 2536 2520 -16 -0.6
.text 1257792 1255832 -1960 -0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ff5f946 327b91b change % change
efr32 lighting-app BRD4161A (read only) 742904 742904 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742896 742896 0 0.0
BRD4161A+rpc (read only) 730440 730440 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 730432 730432 0 0.0
lock-app BRD4161A (read only) 722192 722192 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 722184 722184 0 0.0
window-app BRD4161A (read only) 723088 723088 0 0.0
(read/write) 114412 114412 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 723080 723080 0 0.0
esp32 all-clusters-app c3devkit (read only) 880694 879058 -1636 -0.2
(read/write) 1306536 1306368 -168 -0.0
.dram0.bss 58464 58424 -40 -0.1
.dram0.data 16472 16456 -16 -0.1
.flash.rodata 198360 198240 -120 -0.1
.flash.text 880694 879058 -1636 -0.2
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911863 910483 -1380 -0.2
(read/write) 423864 423684 -180 -0.0
.dram0.bss 60968 60928 -40 -0.1
.dram0.data 32108 32092 -16 -0.0
.flash.rodata 204624 204500 -124 -0.1
.flash.text 911863 910483 -1380 -0.2
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699648 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613940 613940 0 0.0
lock-app k32w061+debug (read/write) 592360 592360 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 516156 516156 0 0.0
shell k32w061+debug (read/write) 658016 658016 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 571044 571044 0 0.0
linux all-clusters-app debug (read only) 1710601 1698785 -11816 -0.7
(read/write) 126528 126144 -384 -0.3
.bss 57872 57776 -96 -0.2
.data 1042 1010 -32 -3.1
.data.rel.ro 62352 62096 -256 -0.4
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139701 -64 -0.0
.text 1437346 1426146 -11200 -0.8
bridge-app debug+rpc (read only) 1298253 1298253 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090821 1090821 0 0.0
chip-tool debug (read only) 4982309 4982309 0 0.0
(read/write) 134688 134688 0 0.0
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101184 101184 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 239760 239760 0 0.0
.text 4471397 4471397 0 0.0
lighting-app debug+rpc (read only) 1557945 1557945 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1295410 1295410 0 0.0
ota-provider-app debug (read only) 1259721 1259721 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1050258 1050258 0 0.0
ota-requestor-app debug (read only) 1344281 1344281 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1121250 1121250 0 0.0
shell debug (read only) 789065 789065 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 609362 609362 0 0.0
tv-app debug (read only) 1842217 1842217 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59448 59448 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541842 1541842 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290856 2289584 -1272 -0.1
.bss 179436 179396 -40 -0.0
.data 5232 5216 -16 -0.3
.heap 851776 851832 56 0.0
.text 1253456 1252184 -1272 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270952 2270952 0 0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1233552 1233552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248672 2248672 0 0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1211272 1211272 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048864 2048864 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1011464 1011464 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862155 862155 0 0.0
bss 111460 111460 0 0.0
rodata 96924 96924 0 0.0
text 578128 578128 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824503 824503 0 0.0
bss 107812 107812 0 0.0
rodata 88104 88104 0 0.0
text 552276 552276 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787162 787162 0 0.0
bss 112832 112832 0 0.0
rodata 92180 92180 0 0.0
text 507600 507600 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838831 838831 0 0.0
bss 110492 110492 0 0.0
rodata 93296 93296 0 0.0
text 559612 559612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764142 764142 0 0.0
bss 111904 111904 0 0.0
rodata 88600 88600 0 0.0
text 489176 489176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844955 844955 0 0.0
bss 110632 110632 0 0.0
rodata 95004 95004 0 0.0
text 563772 563772 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838699 838699 0 0.0
bss 110528 110528 0 0.0
rodata 93292 93292 0 0.0
text 559348 559348 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776431 776431 0 0.0
bss 109280 109280 0 0.0
rodata 72564 72564 0 0.0
text 520004 520004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691482 691482 0 0.0
bss 110264 110264 0 0.0
rodata 67204 67204 0 0.0
text 440612 440612 0 0.0
p6 all-clusters-app default (read/write) 2299528 2297568 -1960 -0.1
.bss 112448 112408 -40 -0.0
.data 2536 2520 -16 -0.6
.heap 918360 918416 56 0.0
.text 1257792 1255832 -1960 -0.2
lock-app default (read/write) 2212184 2212184 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1170448 1170448 0 0.0
qpg lighting-app qpg6100+debug (read only) 490776 490776 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 485456 485456 0 0.0
lock-app qpg6100+debug (read only) 466988 466988 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461668 461668 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663750 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458596 458596 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking as this has had > 3 days to review, and comments are addressed

@woody-apple woody-apple merged commit ca811e0 into project-chip:master Nov 9, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@du48s03
Simplfy the implementation of Mode Select Cluster (project-chip#11359)
bada4ce 
Restyled by whitespace

Restyled by clang-format

Update submodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
7 participants
@du48s03 @andy31415 @woody-apple @CLAassistant @tcarmelveilleux @bzbarsky-apple @jmartinez-silabs