Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Darwin APIs to use the rendezvous transport agnostic pairing API #11349

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update the Darwin APIs to use the rendezvous transport agnostic pairing API #11349

merged 1 commit into from
Nov 4, 2021

Conversation

sagar-apple
Copy link
Contributor

@sagar-apple sagar-apple commented Nov 3, 2021 •
edited
Loading

Problem

We have a unified pairing API that can automatically figure out which rendezvous mechanism to use.
The Darwin SDK doesn't use this API.

Change overview

Update the Darwin SDK to use this new pairing API in most cases.

Testing

How was this tested? (at least one bullet point required)

  • If manually tested, what platforms controller and device platforms were manually tested, and how?
    iOS CHIPTool with an M5Stack

@boring-cyborg boring-cyborg bot added the darwin label Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11349: Size comparison from 24902cc to b411c42

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 24902cc b411c42 change % change
efr32 lighting-app BRD4161A (read only) 737208 737208 0 0.0
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737200 737200 0 0.0
BRD4161A+rpc (read only) 724632 724632 0 0.0
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724624 724624 0 0.0
lock-app BRD4161A (read only) 716472 716472 0 0.0
(read/write) 112436 112436 0 0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716464 716464 0 0.0
window-app BRD4161A (read only) 717388 717388 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717380 717380 0 0.0
esp32 all-clusters-app c3devkit (read only) 880694 880694 0 0.0
(read/write) 1308072 1308072 0 0.0
.dram0.bss 58608 58608 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199768 199768 0 0.0
.flash.text 880694 880694 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911875 911875 0 0.0
(read/write) 427844 427844 0 0.0
.dram0.bss 61112 61112 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208468 208468 0 0.0
.flash.text 911875 911875 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699488 699488 0 0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613928 613928 0 0.0
lock-app k32w061+debug (read/write) 591796 591796 0 0.0
.bss 68372 68372 0 0.0
.data 1868 1868 0 0.0
.text 515756 515756 0 0.0
shell k32w061+debug (read/write) 424884 424884 0 0.0
.bss 63296 63296 0 0.0
.data 668 668 0 0.0
.text 359216 359216 0 0.0
linux all-clusters-app debug (read only) 1690945 1690945 0 0.0
(read/write) 119696 119696 0 0.0
.bss 51152 51152 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62240 62240 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139861 139861 0 0.0
.text 1417714 1417714 0 0.0
bridge-app debug+rpc (read only) 1283901 1283901 0 0.0
(read/write) 68520 68520 0 0.0
.bss 35056 35056 0 0.0
.data 992 992 0 0.0
.data.rel.ro 27496 27496 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1076885 1076885 0 0.0
chip-tool debug (read only) 4349173 4349173 0 0.0
(read/write) 124768 124768 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 98896 98896 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219528 219528 0 0.0
.text 3863941 3863941 0 0.0
lighting-app debug+rpc (read only) 1543225 1543225 0 0.0
(read/write) 101712 101712 0 0.0
.bss 40728 40728 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129553 129553 0 0.0
.text 1280978 1280978 0 0.0
ota-provider-app debug (read only) 1243721 1243721 0 0.0
(read/write) 67552 67552 0 0.0
.bss 37152 37152 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 112360 0 0.0
.text 1035282 1035282 0 0.0
ota-requestor-app debug (read only) 1311081 1311081 0 0.0
(read/write) 76872 76872 0 0.0
.bss 45408 45408 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 123328 0 0.0
.text 1089986 1089986 0 0.0
shell debug (read only) 786625 786625 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607298 607298 0 0.0
tv-app debug (read only) 1810577 1810577 0 0.0
(read/write) 289944 289944 0 0.0
.bss 222768 222768 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 155640 0 0.0
.text 1512674 1512674 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293216 2293216 0 0.0
.bss 179964 179964 0 0.0
.data 5216 5216 0 0.0
.heap 851264 851264 0 0.0
.text 1255816 1255816 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272216 2272216 0 0.0
.bss 172012 172012 0 0.0
.data 5568 5568 0 0.0
.heap 858864 858864 0 0.0
.text 1234816 1234816 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249872 2249872 0 0.0
.bss 170908 170908 0 0.0
.data 5560 5560 0 0.0
.heap 859976 859976 0 0.0
.text 1212472 1212472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048496 2048496 0 0.0
.bss 156256 156256 0 0.0
.data 4960 4960 0 0.0
.heap 875232 875232 0 0.0
.text 1011096 1011096 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861395 0 0.0
bss 111320 111320 0 0.0
rodata 96772 96772 0 0.0
text 577692 577692 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822267 822267 0 0.0
bss 107560 107560 0 0.0
rodata 87564 87564 0 0.0
text 550864 550864 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786434 0 0.0
bss 112696 112696 0 0.0
rodata 92028 92028 0 0.0
text 507152 507152 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 838099 0 0.0
bss 110356 110356 0 0.0
rodata 93140 93140 0 0.0
text 559168 559168 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763398 0 0.0
bss 111764 111764 0 0.0
rodata 88448 88448 0 0.0
text 488720 488720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844211 0 0.0
bss 110492 110492 0 0.0
rodata 94852 94852 0 0.0
text 563348 563348 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837955 0 0.0
bss 110392 110392 0 0.0
rodata 93140 93140 0 0.0
text 558904 558904 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775991 0 0.0
bss 109112 109112 0 0.0
rodata 72412 72412 0 0.0
text 519884 519884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 691026 0 0.0
bss 110092 110092 0 0.0
rodata 67052 67052 0 0.0
text 440480 440480 0 0.0
p6 lock-app default (read/write) 2168064 2168064 0 0.0
.bss 66360 66360 0 0.0
.data 2416 2416 0 0.0
.heap 964568 964568 0 0.0
.text 1126328 1126328 0 0.0
qpg lighting-app qpg6100+debug (read only) 490760 490760 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485440 485440 0 0.0
lock-app qpg6100+debug (read only) 467096 467096 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461776 461776 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 458028 0 0.0

@sagar-apple sagar-apple marked this pull request as ready for review November 3, 2021 23:08
@woody-apple
Copy link
Contributor

Fast tracking, given this is a platform change proposed by a platform maintainers.

@woody-apple woody-apple merged commit 6290269 into project-chip:master Nov 4, 2021
@sagar-apple sagar-apple deleted the use_universal_pairing_api branch November 4, 2021 15:59
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@sagar-apple
Update the Darwin APIs to use the rendezvous transport agnostic pairi…
84515ef 
…ng API (project-chip#11349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagar-apple @woody-apple