-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible for apps into the placeholder directory to have cust… #11332
Merged
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_Generate_Simulated_Device_Tests
Nov 3, 2021
Merged
Make it possible for apps into the placeholder directory to have cust… #11332
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YAML_Generate_Simulated_Device_Tests
Nov 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
YAML_Generate_Simulated_Device_Tests
branch
from
November 2, 2021 18:02
165d217
to
e8211de
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
pan-apple
November 2, 2021 18:03
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 2, 2021 18:03
PR #11332: Size comparison from e788c90 to e8211de Increases (6 builds for esp32, linux)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 2, 2021
bzbarsky-apple
approved these changes
Nov 2, 2021
/rebase |
woody-apple
force-pushed
the
YAML_Generate_Simulated_Device_Tests
branch
from
November 3, 2021 00:33
e8211de
to
2531dc4
Compare
PR #11332: Size comparison from c9db3dc to 2531dc4 Increases (5 builds for linux)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fast tracking this, as it's adding tests. |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…om tests
Problem
Applications from
examples/placeholder
, used as simulated devices, needs a way to specify custom tests to be generated.Change overview
examples/chip-tool/templates/partials/test_cluster.zapt
to supportwait
commandsgetTests
method to placeholder apps so they can specify tests individuallyTesting
The simulated device has some generated tests. I have manually validate that those expectations fails or succeeds depending on the commands sent to the device.