Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msg] Update message field order to match spec. #11330

Merged
merged 1 commit into from
Nov 3, 2021
Merged

[msg] Update message field order to match spec. #11330

merged 1 commit into from
Nov 3, 2021

Conversation

turon
Copy link
Contributor

@turon turon commented Nov 2, 2021

Problem

Recent field order correction in spec needs to be reflected in SDK.

Change overview

Implement proper message header field order.

Testing

  1. CI suite
  2. Added a unit test to verify PacketHeader::Encode and Decode against fixed test vectors.

@restyled-io restyled-io bot mentioned this pull request Nov 2, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11330: Size comparison from c3b3ee1 to ef22e3b

Increases (8 builds for esp32, k32w, nrfconnect, telink)
platform target config section c3b3ee1 ef22e3b change % change
esp32 all-clusters-app c3devkit (read only) 880486 880502 16 0.0
.flash.text 880486 880502 16 0.0
m5stack (read only) 911507 911515 8 0.0
.flash.text 911507 911515 8 0.0
k32w lock-app k32w061+debug (read/write) 591356 591372 16 0.0
.text 515320 515336 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 577512 577516 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837675 837691 16 0.0
text 558992 558996 4 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843783 843799 16 0.0
text 563172 563176 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 558728 558732 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 662382 662398 16 0.0
text 457774 457786 12 0.0
Decreases (2 builds for efr32)
platform target config section c3b3ee1 ef22e3b change % change
efr32 lighting-app BRD4161A+rpc (read only) 723988 723972 -16 -0.0
.text 723980 723964 -16 -0.0
lock-app BRD4161A (read only) 715828 715812 -16 -0.0
.text 715820 715804 -16 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c3b3ee1 ef22e3b change % change
efr32 lighting-app BRD4161A (read only) 736548 736548 0 0.0
(read/write) 114612 114612 0 0.0
.bss 112852 112852 0 0.0
.data 1760 1760 0 0.0
.text 736540 736540 0 0.0
BRD4161A+rpc (read only) 723988 723972 -16 -0.0
(read/write) 131216 131216 0 0.0
.bss 129356 129356 0 0.0
.data 1860 1860 0 0.0
.text 723980 723964 -16 -0.0
lock-app BRD4161A (read only) 715828 715812 -16 -0.0
(read/write) 112428 112428 0 0.0
.bss 110708 110708 0 0.0
.data 1720 1720 0 0.0
.text 715820 715804 -16 -0.0
window-app BRD4161A (read only) 716728 716728 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111028 111028 0 0.0
.data 1724 1724 0 0.0
.text 716720 716720 0 0.0
esp32 all-clusters-app c3devkit (read only) 880486 880502 16 0.0
(read/write) 1307784 1307784 0 0.0
.dram0.bss 58592 58592 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199496 199496 0 0.0
.flash.text 880486 880502 16 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911507 911515 8 0.0
(read/write) 427552 427552 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208200 208200 0 0.0
.flash.text 911507 911515 8 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699048 699048 0 0.0
.bss 77848 77848 0 0.0
.data 1908 1908 0 0.0
.text 613492 613492 0 0.0
lock-app k32w061+debug (read/write) 591356 591372 16 0.0
.bss 68364 68364 0 0.0
.data 1872 1872 0 0.0
.text 515320 515336 16 0.0
shell k32w061+debug (read/write) 424748 424748 0 0.0
.bss 63288 63288 0 0.0
.data 672 672 0 0.0
.text 359084 359084 0 0.0
linux all-clusters-app debug (read only) 1689665 1689665 0 0.0
(read/write) 119664 119664 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62240 62240 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139349 139349 0 0.0
.text 1416946 1416946 0 0.0
bridge-app debug+rpc (read only) 1282589 1282589 0 0.0
(read/write) 68488 68488 0 0.0
.bss 35024 35024 0 0.0
.data 992 992 0 0.0
.data.rel.ro 27496 27496 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110916 110916 0 0.0
.text 1076117 1076117 0 0.0
chip-tool debug (read only) 4325181 4325181 0 0.0
(read/write) 123936 123936 0 0.0
.bss 18192 18192 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98744 98744 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 218576 218576 0 0.0
.text 3841189 3841189 0 0.0
lighting-app debug+rpc (read only) 1541945 1541945 0 0.0
(read/write) 101680 101680 0 0.0
.bss 40696 40696 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129041 129041 0 0.0
.text 1280210 1280210 0 0.0
ota-provider-app debug (read only) 1242441 1242441 0 0.0
(read/write) 67520 67520 0 0.0
.bss 37120 37120 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111848 111848 0 0.0
.text 1034514 1034514 0 0.0
ota-requestor-app debug (read only) 1309721 1309721 0 0.0
(read/write) 76840 76840 0 0.0
.bss 45376 45376 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 122816 122816 0 0.0
.text 1089186 1089186 0 0.0
shell debug (read only) 785809 785809 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77551 77551 0 0.0
.text 606770 606770 0 0.0
tv-app debug (read only) 1789833 1789833 0 0.0
(read/write) 289240 289240 0 0.0
.bss 222736 222736 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 58784 58784 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154648 154648 0 0.0
.text 1492994 1492994 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2292664 0 0.0
.bss 179956 179956 0 0.0
.data 5224 5224 0 0.0
.heap 851264 851264 0 0.0
.text 1255264 1255264 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271608 2271608 0 0.0
.bss 172004 172004 0 0.0
.data 5576 5576 0 0.0
.heap 858864 858864 0 0.0
.text 1234208 1234208 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249328 2249328 0 0.0
.bss 170900 170900 0 0.0
.data 5560 5560 0 0.0
.heap 859984 859984 0 0.0
.text 1211928 1211928 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048392 2048392 0 0.0
.bss 156248 156248 0 0.0
.data 4968 4968 0 0.0
.heap 875232 875232 0 0.0
.text 1010992 1010992 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860983 860983 0 0.0
bss 111312 111312 0 0.0
rodata 96536 96536 0 0.0
text 577512 577516 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 821807 821807 0 0.0
bss 107552 107552 0 0.0
rodata 87312 87312 0 0.0
text 550688 550688 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786010 786010 0 0.0
bss 112688 112688 0 0.0
rodata 91780 91780 0 0.0
text 506980 506980 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837675 837691 16 0.0
bss 110348 110348 0 0.0
rodata 92892 92892 0 0.0
text 558992 558996 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762986 762986 0 0.0
bss 111756 111756 0 0.0
rodata 88196 88196 0 0.0
text 488552 488552 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843783 843799 16 0.0
bss 110484 110484 0 0.0
rodata 94600 94600 0 0.0
text 563172 563176 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837547 837547 0 0.0
bss 110384 110384 0 0.0
rodata 92892 92892 0 0.0
text 558728 558732 4 0.0
shell nrf52840dk_nrf52840 (read/write) 775867 775867 0 0.0
bss 109104 109104 0 0.0
rodata 72400 72400 0 0.0
text 519772 519772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690922 690922 0 0.0
bss 110084 110084 0 0.0
rodata 67044 67044 0 0.0
text 440372 440372 0 0.0
p6 lock-app default (read/write) 2167688 2167688 0 0.0
.bss 66352 66352 0 0.0
.data 2424 2424 0 0.0
.heap 964568 964568 0 0.0
.text 1125952 1125952 0 0.0
qpg lighting-app qpg6100+debug (read only) 490328 490328 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50408 50408 0 0.0
.data 1008 1008 0 0.0
.text 485008 485008 0 0.0
lock-app qpg6100+debug (read only) 466668 466668 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49352 49352 0 0.0
.data 964 964 0 0.0
.text 461348 461348 0 0.0
persistent-storage-app qpg6100+debug (read only) 155796 155796 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27760 27760 0 0.0
.data 372 372 0 0.0
.text 150476 150476 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662382 662398 16 0.0
bss 69116 69116 0 0.0
noinit 33216 33216 0 0.0
text 457774 457786 12 0.0

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11330: Size comparison from eddd4f7 to d03f833

Increases (10 builds for esp32, k32w, mbed, nrfconnect, telink)
platform target config section eddd4f7 d03f833 change % change
esp32 all-clusters-app c3devkit (read only) 880466 880482 16 0.0
.flash.text 880466 880482 16 0.0
m5stack (read only) 911571 911579 8 0.0
.flash.text 911571 911579 8 0.0
k32w lock-app k32w061+debug (read/write) 591412 591428 16 0.0
.text 515376 515392 16 0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2271648 2271712 64 0.0
.text 1234248 1234312 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840+rpc text 550720 550724 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786050 786066 16 0.0
text 507012 507016 4 0.0
lock-app nrf5340dk_nrf5340_cpuapp text 488584 488588 4 0.0
shell nrf52840dk_nrf52840 (read/write) 775911 775927 16 0.0
text 519804 519808 4 0.0
nrf5340dk_nrf5340_cpuapp text 440404 440408 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 662422 662438 16 0.0
text 457800 457812 12 0.0
Decreases (3 builds for efr32)
platform target config section eddd4f7 d03f833 change % change
efr32 lighting-app BRD4161A (read only) 736844 736828 -16 -0.0
.text 736836 736820 -16 -0.0
lock-app BRD4161A (read only) 716124 716108 -16 -0.0
.text 716116 716100 -16 -0.0
window-app BRD4161A (read only) 717024 717008 -16 -0.0
.text 717016 717000 -16 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eddd4f7 d03f833 change % change
efr32 lighting-app BRD4161A (read only) 736844 736828 -16 -0.0
(read/write) 114612 114612 0 0.0
.bss 112852 112852 0 0.0
.data 1760 1760 0 0.0
.text 736836 736820 -16 -0.0
BRD4161A+rpc (read only) 724268 724268 0 0.0
(read/write) 131216 131216 0 0.0
.bss 129356 129356 0 0.0
.data 1860 1860 0 0.0
.text 724260 724260 0 0.0
lock-app BRD4161A (read only) 716124 716108 -16 -0.0
(read/write) 112428 112428 0 0.0
.bss 110708 110708 0 0.0
.data 1720 1720 0 0.0
.text 716116 716100 -16 -0.0
window-app BRD4161A (read only) 717024 717008 -16 -0.0
(read/write) 112756 112756 0 0.0
.bss 111028 111028 0 0.0
.data 1724 1724 0 0.0
.text 717016 717000 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 880466 880482 16 0.0
(read/write) 1307824 1307824 0 0.0
.dram0.bss 58592 58592 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199536 199536 0 0.0
.flash.text 880466 880482 16 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911571 911579 8 0.0
(read/write) 427592 427592 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208240 208240 0 0.0
.flash.text 911571 911579 8 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699104 699104 0 0.0
.bss 77848 77848 0 0.0
.data 1908 1908 0 0.0
.text 613548 613548 0 0.0
lock-app k32w061+debug (read/write) 591412 591428 16 0.0
.bss 68364 68364 0 0.0
.data 1872 1872 0 0.0
.text 515376 515392 16 0.0
shell k32w061+debug (read/write) 424800 424800 0 0.0
.bss 63288 63288 0 0.0
.data 672 672 0 0.0
.text 359136 359136 0 0.0
linux all-clusters-app debug (read only) 1690385 1690385 0 0.0
(read/write) 119664 119664 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62240 62240 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139637 139637 0 0.0
.text 1417378 1417378 0 0.0
bridge-app debug+rpc (read only) 1283293 1283293 0 0.0
(read/write) 68488 68488 0 0.0
.bss 35024 35024 0 0.0
.data 992 992 0 0.0
.data.rel.ro 27496 27496 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111204 111204 0 0.0
.text 1076533 1076533 0 0.0
chip-tool debug (read only) 4329237 4329237 0 0.0
(read/write) 124064 124064 0 0.0
.bss 18192 18192 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98856 98856 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 218928 218928 0 0.0
.text 3844677 3844677 0 0.0
lighting-app debug+rpc (read only) 1542617 1542617 0 0.0
(read/write) 101680 101680 0 0.0
.bss 40696 40696 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129297 129297 0 0.0
.text 1280626 1280626 0 0.0
ota-provider-app debug (read only) 1243145 1243145 0 0.0
(read/write) 67520 67520 0 0.0
.bss 37120 37120 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112136 112136 0 0.0
.text 1034930 1034930 0 0.0
ota-requestor-app debug (read only) 1310441 1310441 0 0.0
(read/write) 76840 76840 0 0.0
.bss 45376 45376 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123104 123104 0 0.0
.text 1089618 1089618 0 0.0
shell debug (read only) 786529 786529 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607202 607202 0 0.0
tv-app debug (read only) 1790633 1790633 0 0.0
(read/write) 289240 289240 0 0.0
.bss 222736 222736 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 58784 58784 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155032 155032 0 0.0
.text 1493410 1493410 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292704 2292704 0 0.0
.bss 179956 179956 0 0.0
.data 5224 5224 0 0.0
.heap 851264 851264 0 0.0
.text 1255304 1255304 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271648 2271712 64 0.0
.bss 172004 172004 0 0.0
.data 5576 5576 0 0.0
.heap 858864 858864 0 0.0
.text 1234248 1234312 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249368 2249368 0 0.0
.bss 170900 170900 0 0.0
.data 5560 5560 0 0.0
.heap 859984 859984 0 0.0
.text 1211968 1211968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048432 2048432 0 0.0
.bss 156248 156248 0 0.0
.data 4968 4968 0 0.0
.heap 875232 875232 0 0.0
.text 1011032 1011032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861027 861027 0 0.0
bss 111312 111312 0 0.0
rodata 96548 96548 0 0.0
text 577548 577548 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 821851 821851 0 0.0
bss 107552 107552 0 0.0
rodata 87324 87324 0 0.0
text 550720 550724 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786050 786066 16 0.0
bss 112688 112688 0 0.0
rodata 91788 91788 0 0.0
text 507012 507016 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837731 837731 0 0.0
bss 110348 110348 0 0.0
rodata 92900 92900 0 0.0
text 559028 559028 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763030 763030 0 0.0
bss 111756 111756 0 0.0
rodata 88208 88208 0 0.0
text 488584 488588 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843843 843843 0 0.0
bss 110484 110484 0 0.0
rodata 94612 94612 0 0.0
text 563208 563208 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837587 837587 0 0.0
bss 110384 110384 0 0.0
rodata 92900 92900 0 0.0
text 558764 558764 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775911 775927 16 0.0
bss 109104 109104 0 0.0
rodata 72412 72412 0 0.0
text 519804 519808 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690962 0 0.0
bss 110084 110084 0 0.0
rodata 67052 67052 0 0.0
text 440404 440408 4 0.0
p6 lock-app default (read/write) 2167680 2167680 0 0.0
.bss 66352 66352 0 0.0
.data 2424 2424 0 0.0
.heap 964568 964568 0 0.0
.text 1125944 1125944 0 0.0
qpg lighting-app qpg6100+debug (read only) 490384 490384 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50408 50408 0 0.0
.data 1008 1008 0 0.0
.text 485064 485064 0 0.0
lock-app qpg6100+debug (read only) 466720 466720 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49352 49352 0 0.0
.data 964 964 0 0.0
.text 461400 461400 0 0.0
persistent-storage-app qpg6100+debug (read only) 155796 155796 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27760 27760 0 0.0
.data 372 372 0 0.0
.text 150476 150476 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662422 662438 16 0.0
bss 69116 69116 0 0.0
noinit 33216 33216 0 0.0
text 457800 457812 12 0.0

@andy31415
Copy link
Contributor

Fast track: small change with unit tests included.

@andy31415 andy31415 merged commit 165ac82 into project-chip:master Nov 3, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@turon
[msg] Update message field order to match spec. (project-chip#11330)
f50529b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@austinh0 austinh0 Awaiting requested review from austinh0

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turon @andy31415 @woody-apple @bzbarsky-apple