[IM] AttributePathExpandIterator for iterating over list of ClusterInfo-s with wildcard #11303

erjiaqing · 2021-11-02T05:05:08Z

Problem

We need to support wildcard read

Change overview

Implement PathIterator
The usage of this class can be found at [IM] Wildcard read and chunking #11304

Testing

Adds unit test for PathIterator
Introduce some mocked ember attribute storage api.

github-actions · 2021-11-04T10:45:23Z

PR #11303: Size comparison from ee7682d to 5c1103c

Increases (3 builds for mbed)

platform	target	config	section	`ee7682d`	`5c1103c`	change
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2293328	2293464	136
			.text	1255928	1256064	136
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	`2272760`	2272896	136
			.text	1235360	1235496	136
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2250480	2250616	136
			.text	1213080	1213216	136

Decreases (28 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`ee7682d`	`5c1103c`	change	% change
efr32	lighting-app	BRD4161A	(read only)	737432	736344	-1088	-0.1
			.text	737424	736336	-1088	-0.1
		BRD4161A+rpc	(read only)	726628	725540	-1088	-0.1
			.text	726620	725532	-1088	-0.1
	lock-app	BRD4161A	(read only)	716696	715628	-1068	-0.1
			(read/write)	112404	112400	-4	-0.0
			.text	716688	715620	-1068	-0.1
	window-app	BRD4161A	(read only)	717612	716524	-1088	-0.2
			.text	717604	716516	-1088	-0.2
esp32	all-clusters-app	c3devkit	(read only)	880890	880562	-328	-0.0
			(read/write)	1308120	1307672	-448	-0.0
			.flash.rodata	199832	199384	-448	-0.2
			.flash.text	880890	880562	-328	-0.0
		m5stack	(read only)	912007	911859	-148	-0.0
			(read/write)	427876	427436	-440	-0.1
			.flash.rodata	208524	208084	-440	-0.2
			.flash.text	912007	911859	-148	-0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699648	699536	-112	-0.0
			.text	614120	614008	-112	-0.0
	lock-app	k32w061+debug	(read/write)	591956	591844	-112	-0.0
			.text	515948	515836	-112	-0.0
	shell	k32w061+debug	(read/write)	657904	657792	-112	-0.0
			.text	571272	571160	-112	-0.0
linux	all-clusters-app	debug	(read only)	1697761	1695745	-2016	-0.1
			(read/write)	119696	119632	-64	-0.1
			.bss	51120	51056	-64	-0.1
			.rodata	140469	139477	-992	-0.7
			.text	1423874	`1422850`	-1024	-0.1
	bridge-app	debug+rpc	(read only)	1292477	1290461	-2016	-0.2
			(read/write)	69320	69256	-64	-0.1
			.bss	35024	34960	-64	-0.2
			.rodata	111780	110788	-992	-0.9
			.text	1084805	1083781	-1024	-0.1
	chip-tool	debug	(read only)	4429253	4415365	-13888	-0.3
			(read/write)	125888	125824	-64	-0.1
			.bss	18224	18160	-64	-0.4
			.rodata	226992	226032	-960	-0.4
			.text	3933941	3921013	-12928	-0.3
	lighting-app	debug+rpc	(read only)	`1553505`	1551489	-2016	-0.1
			(read/write)	102288	102224	-64	-0.1
			.bss	40664	40600	-64	-0.2
			.rodata	130449	129457	-992	-0.8
			.text	1289474	1288450	-1024	-0.1
	ota-provider-app	debug	(read only)	1251761	`1249745`	-2016	-0.2
			(read/write)	67488	67424	-64	-0.1
			.bss	37088	37024	-64	-0.2
			.rodata	113032	112040	-992	-0.9
			.text	`1042626`	1041602	-1024	-0.1
	ota-requestor-app	debug	(read only)	`1329497`	1327465	-2032	-0.2
			(read/write)	76744	76680	-64	-0.1
			.bss	45216	45152	-64	-0.1
			.rodata	124464	123440	-1024	-0.8
			.text	1106978	1105970	-1008	-0.1
	tv-app	debug	(read only)	`1817113`	1815097	-2016	-0.1
			(read/write)	289912	289848	-64	-0.0
			.bss	222736	222672	-64	-0.0
			.rodata	156040	155048	-992	-0.6
			.text	1518786	`1517762`	-1024	-0.1
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861623	861511	-112	-0.0
			text	577912	577800	-112	-0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824003	823891	-112	-0.0
			text	552100	551984	-116	-0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786662	786534	-128	-0.0
			text	507372	507256	-116	-0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838331	838219	-112	-0.0
			text	559388	559276	-112	-0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763626	763514	-112	-0.0
			text	488940	488824	-116	-0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844439	844327	-112	-0.0
			text	563568	563456	-112	-0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838183	838071	-112	-0.0
			text	559124	559012	-112	-0.0
p6	all-clusters-app	default	(read/write)	2301080	`2299992`	-1088	-0.0
			.text	1259344	1258256	-1088	-0.1
	lock-app	default	(read/write)	2213928	2212848	-1080	-0.0
			.text	1172192	1171112	-1080	-0.1
qpg	lighting-app	qpg6100+debug	(read only)	490932	490828	-104	-0.0
			.text	485612	485508	-104	-0.0
	lock-app	qpg6100+debug	(read only)	467280	467160	-120	-0.0
			.text	461960	461840	-120	-0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663086	662958	-128	-0.0
			text	458206	458084	-122	-0.0

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`ee7682d`	`5c1103c`	change	% change
efr32	lighting-app	BRD4161A	(read only)	737432	736344	-1088	-0.1
			(read/write)	114588	114588	0	0.0
			.bss	112828	112828	0	0.0
			.data	1756	1756	0	0.0
			.text	737424	736336	-1088	-0.1
		BRD4161A+rpc	(read only)	726628	725540	-1088	-0.1
			(read/write)	131204	131204	0	0.0
			.bss	129332	129332	0	0.0
			.data	1872	1872	0	0.0
			.text	726620	725532	-1088	-0.1
	lock-app	BRD4161A	(read only)	716696	715628	-1068	-0.1
			(read/write)	112404	112400	-4	-0.0
			.bss	110684	110684	0	0.0
			.data	1716	1716	0	0.0
			.text	716688	715620	-1068	-0.1
	window-app	BRD4161A	(read only)	717612	716524	-1088	-0.2
			(read/write)	112724	112724	0	0.0
			.bss	111004	111004	0	0.0
			.data	1720	1720	0	0.0
			.text	717604	716516	-1088	-0.2
esp32	all-clusters-app	c3devkit	(read only)	880890	880562	-328	-0.0
			(read/write)	1308120	1307672	-448	-0.0
			.dram0.bss	58584	58584	0	0.0
			.dram0.data	16464	16464	0	0.0
			.flash.rodata	199832	199384	-448	-0.2
			.flash.text	880890	880562	-328	-0.0
			.iram0.text	57554	57554	0	0.0
		m5stack	(read only)	912007	911859	-148	-0.0
			(read/write)	427876	427436	-440	-0.1
			.dram0.bss	61088	61088	0	0.0
			.dram0.data	32100	32100	0	0.0
			.flash.rodata	208524	208084	-440	-0.2
			.flash.text	912007	911859	-148	-0.0
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699648	699536	-112	-0.0
			.bss	77824	77824	0	0.0
			.data	1904	1904	0	0.0
			.text	614120	614008	-112	-0.0
	lock-app	k32w061+debug	(read/write)	591956	591844	-112	-0.0
			.bss	68340	68340	0	0.0
			.data	1868	1868	0	0.0
			.text	515948	515836	-112	-0.0
	shell	k32w061+debug	(read/write)	657904	657792	-112	-0.0
			.bss	78992	78992	0	0.0
			.data	1840	1840	0	0.0
			.text	571272	571160	-112	-0.0
linux	all-clusters-app	debug	(read only)	1697761	1695745	-2016	-0.1
			(read/write)	119696	119632	-64	-0.1
			.bss	51120	51056	-64	-0.1
			.data	1042	1042	0	0.0
			.data.rel.ro	62272	62272	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	140469	139477	-992	-0.7
			.text	1423874	`1422850`	-1024	-0.1
	bridge-app	debug+rpc	(read only)	1292477	1290461	-2016	-0.2
			(read/write)	69320	69256	-64	-0.1
			.bss	35024	34960	-64	-0.2
			.data	1568	1568	0	0.0
			.data.rel.ro	27768	27768	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	111780	110788	-992	-0.9
			.text	1084805	1083781	-1024	-0.1
	chip-tool	debug	(read only)	4429253	4415365	-13888	-0.3
			(read/write)	125888	125824	-64	-0.1
			.bss	18224	18160	-64	-0.4
			.data	2224	2224	0	0.0
			.data.rel.ro	100032	100032	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	226992	226032	-960	-0.4
			.text	3933941	3921013	-12928	-0.3
	lighting-app	debug+rpc	(read only)	`1553505`	1551489	-2016	-0.1
			(read/write)	102288	102224	-64	-0.1
			.bss	40664	40600	-64	-0.2
			.data	1170	1170	0	0.0
			.data.rel.ro	55168	55168	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	130449	129457	-992	-0.8
			.text	1289474	1288450	-1024	-0.1
	ota-provider-app	debug	(read only)	1251761	`1249745`	-2016	-0.2
			(read/write)	67488	67424	-64	-0.1
			.bss	37088	37024	-64	-0.2
			.data	752	752	0	0.0
			.data.rel.ro	24568	24568	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	113032	112040	-992	-0.9
			.text	`1042626`	1041602	-1024	-0.1
	ota-requestor-app	debug	(read only)	`1329497`	1327465	-2032	-0.2
			(read/write)	76744	76680	-64	-0.1
			.bss	45216	45152	-64	-0.1
			.data	816	816	0	0.0
			.data.rel.ro	25576	25576	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	124464	123440	-1024	-0.8
			.text	1106978	1105970	-1008	-0.1
	shell	debug	(read only)	786641	786641	0	0.0
			(read/write)	57600	57600	0	0.0
			.bss	16040	16040	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36816	36816	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	77839	77839	0	0.0
			.text	607314	607314	0	0.0
	tv-app	debug	(read only)	`1817113`	1815097	-2016	-0.1
			(read/write)	289912	289848	-64	-0.0
			.bss	222736	222672	-64	-0.0
			.data	2704	2704	0	0.0
			.data.rel.ro	58824	58824	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	156040	155048	-992	-0.6
			.text	1518786	`1517762`	-1024	-0.1
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2293328	2293464	136	0.0
			.bss	179940	179940	0	0.0
			.data	5216	5216	0	0.0
			.heap	851288	851288	0	0.0
			.text	1255928	1256064	136	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2272760`	2272896	136	0.0
			.bss	171980	171980	0	0.0
			.data	5568	5568	0	0.0
			.heap	858896	858896	0	0.0
			.text	1235360	1235496	136	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2250480	2250616	136	0.0
			.bss	170876	170876	0	0.0
			.data	5560	5560	0	0.0
			.heap	860008	860008	0	0.0
			.text	1213080	1213216	136	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048368	2048368	0	0.0
			.bss	156224	156224	0	0.0
			.data	4960	4960	0	0.0
			.heap	875264	875264	0	0.0
			.text	1010968	1010968	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861623	861511	-112	-0.0
			bss	111288	111288	0	0.0
			rodata	96808	96808	0	0.0
			text	577912	577800	-112	-0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824003	823891	-112	-0.0
			bss	107640	107640	0	0.0
			rodata	87988	87988	0	0.0
			text	552100	551984	-116	-0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786662	786534	-128	-0.0
			bss	112664	112664	0	0.0
			rodata	92064	92064	0	0.0
			text	507372	507256	-116	-0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	838331	838219	-112	-0.0
			bss	110324	110324	0	0.0
			rodata	93180	93180	0	0.0
			text	559388	559276	-112	-0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763626	763514	-112	-0.0
			bss	111732	111732	0	0.0
			rodata	88484	88484	0	0.0
			text	488940	488824	-116	-0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844439	844327	-112	-0.0
			bss	110460	110460	0	0.0
			rodata	94888	94888	0	0.0
			text	563568	563456	-112	-0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838183	838071	-112	-0.0
			bss	110360	110360	0	0.0
			rodata	93176	93176	0	0.0
			text	559124	559012	-112	-0.0
	shell	nrf52840dk_nrf52840	(read/write)	775975	775975	0	0.0
			bss	109080	109080	0	0.0
			rodata	72412	72412	0	0.0
			text	519904	519904	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691010	691010	0	0.0
			bss	110060	110060	0	0.0
			rodata	67052	67052	0	0.0
			text	440496	440496	0	0.0
p6	all-clusters-app	default	(read/write)	2301080	`2299992`	-1088	-0.0
			.bss	107880	107880	0	0.0
			.data	2520	2520	0	0.0
			.heap	922944	922944	0	0.0
			.text	1259344	1258256	-1088	-0.1
	lock-app	default	(read/write)	2213928	2212848	-1080	-0.0
			.bss	95680	95680	0	0.0
			.data	2392	2392	0	0.0
			.heap	935272	935272	0	0.0
			.text	1172192	1171112	-1080	-0.1
qpg	lighting-app	qpg6100+debug	(read only)	490932	490828	-104	-0.0
			(read/write)	114140	114140	0	0.0
			.bss	50968	50968	0	0.0
			.data	1004	1004	0	0.0
			.text	485612	485508	-104	-0.0
	lock-app	qpg6100+debug	(read only)	467280	467160	-120	-0.0
			(read/write)	114144	114144	0	0.0
			.bss	49912	49912	0	0.0
			.data	960	960	0	0.0
			.text	461960	461840	-120	-0.0
	persistent-storage-app	qpg6100+debug	(read only)	153212	153212	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	18920	18920	0	0.0
			.data	356	356	0	0.0
			.text	147892	147892	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663086	662958	-128	-0.0
			bss	69100	69100	0	0.0
			noinit	33216	33216	0	0.0
			text	458206	458084	-122	-0.0

todo · 2021-11-05T04:25:22Z

Here we use forward declaration for these symbols used, there should be some reorganize for code in app/util so they can be

connectedhomeip/src/app/AttributePathExpandIterator.cpp

Lines 40 to 50 in f72a610

    
           // TODO: Here we use forward declaration for these symbols used, there should be some reorganize for code in app/util so they can be 
        
           // used with generated files or some mock files. 
        
           typedef uint8_t EmberAfClusterMask; 
        
           #define CLUSTER_MASK_SERVER (0x40) 
        
           extern uint16_t emberAfEndpointCount(void); 
        
           extern uint16_t emberAfIndexFromEndpoint(EndpointId endpoint); 
        
           extern uint8_t emberAfClusterCount(EndpointId endpoint, bool server); 
        
           extern uint16_t emberAfGetServerAttributeCount(chip::EndpointId endpoint, chip::ClusterId cluster); 
        
           extern uint16_t emberAfGetServerAttributeIndexByAttributeId(chip::EndpointId endpoint, chip::ClusterId cluster, 
        
                                                                       chip::AttributeId attributeId);

This comment was generated by todo based on a `TODO` comment in `f72a610` in #11303. cc @erjiaqing.

github-actions · 2021-11-09T06:54:23Z

PR #11303: Size comparison from 372dc6a to 85b1830

Full report (9 builds for k32w, p6, qpg, telink)

platform	target	config	section	`372dc6a`	`85b1830`
k32w	lock-app	k32w061+debug	(read/write)	592288	592288
			.bss	68508	68508
			.data	1880	1880
			.text	516100	516100
	shell	k32w061+debug	(read/write)	657944	657944
			.bss	79308	79308
			.data	1848	1848
			.text	570988	570988
	lighting-app	k32w061+se05x+release	(read/write)	699576	699576
			.bss	77980	77980
			.data	1912	1912
			.text	613884	613884
p6	all-clusters-app	default	(read/write)	`2299288`	`2299288`
			.bss	111936	111936
			.data	2536	2536
			.heap	918872	918872
			.text	1257552	1257552
	lock-app	default	(read/write)	`2211928`	`2211928`
			.bss	100744	100744
			.data	2408	2408
			.heap	930192	930192
			.text	1170192	1170192
qpg	lighting-app	qpg6100+debug	(read only)	490712	490712
			(read/write)	114140	114140
			.bss	51136	51136
			.data	1012	1012
			.text	485392	485392
	lock-app	qpg6100+debug	(read only)	466940	466940
			(read/write)	114144	114144
			.bss	50080	50080
			.data	968	968
			.text	461620	461620
	persistent-storage-app	qpg6100+debug	(read only)	153400	153400
			(read/write)	114140	114140
			.bss	19600	19600
			.data	364	364
			.text	148080	148080
telink	lighting-app	tlsr9518adk80d	(read/write)	663682	663682
			bss	69256	69256
			noinit	33216	33216
			text	458562	458562

todo · 2021-11-09T06:56:47Z

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

connectedhomeip/src/app/AttributePathExpandIterator.cpp

Lines 34 to 44 in d25f053

    
           // TODO: Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with 
        
           // dependencies on generated files, so we don't have to re-declare things here. 
        
           // Note: Some of the generated files that depended by af.h are gen_config.h and gen_tokens.h 
        
           typedef uint8_t EmberAfClusterMask; 
        
           extern uint16_t emberAfEndpointCount(void); 
        
           extern uint16_t emberAfIndexFromEndpoint(EndpointId endpoint); 
        
           extern uint8_t emberAfClusterCount(EndpointId endpoint, bool server); 
        
           extern uint16_t emberAfGetServerAttributeCount(chip::EndpointId endpoint, chip::ClusterId cluster); 
        
           extern uint16_t emberAfGetServerAttributeIndexByAttributeId(chip::EndpointId endpoint, chip::ClusterId cluster, 
        
                                                                       chip::AttributeId attributeId);

This comment was generated by todo based on a `TODO` comment in `d25f053` in #11303. cc @erjiaqing.

github-actions · 2021-11-09T07:22:02Z

PR #11303: Size comparison from 372dc6a to d25f053

Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`372dc6a`	`d25f053`
efr32	lighting-app	BRD4161A	(read only)	742640	742640
			(read/write)	116236	116236
			.bss	114452	114452
			.data	1784	1784
			.text	742632	742632
		BRD4161A+rpc	(read only)	730184	730184
			(read/write)	132860	132860
			.bss	130956	130956
			.data	1900	1900
			.text	730176	730176
	lock-app	BRD4161A	(read only)	721920	721920
			(read/write)	114052	114052
			.bss	112308	112308
			.data	1744	1744
			.text	721912	721912
	window-app	BRD4161A	(read only)	722832	722832
			(read/write)	114380	114380
			.bss	112628	112628
			.data	1748	1748
			.text	722824	722824
k32w	lighting-app	k32w061+se05x+release	(read/write)	699576	699576
			.bss	77980	77980
			.data	1912	1912
			.text	613884	613884
	lock-app	k32w061+debug	(read/write)	592288	592288
			.bss	68508	68508
			.data	1880	1880
			.text	516100	516100
	shell	k32w061+debug	(read/write)	657944	657944
			.bss	79308	79308
			.data	1848	1848
			.text	570988	570988
linux	all-clusters-app	debug	(read only)	1710033	1710033
			(read/write)	125888	125888
			.bss	57360	57360
			.data	1042	1042
			.data.rel.ro	62224	62224
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	552	552
			.rodata	139765	139765
			.text	1436946	1436946
	bridge-app	debug+rpc	(read only)	`1297685`	`1297685`
			(read/write)	76432	76432
			.bss	42256	42256
			.data	1568	1568
			.data.rel.ro	27640	27640
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	408	408
			.rodata	111540	111540
			.text	`1090421`	`1090421`
	chip-tool	debug	(read only)	`4927909`	`4927909`
			(read/write)	133856	133856
			.bss	25328	25328
			.data	2256	2256
			.data.rel.ro	100856	100856
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	424	424
			.rodata	234416	234416
			.text	4423013	4423013
	lighting-app	debug+rpc	(read only)	`1557361`	`1557361`
			(read/write)	109448	109448
			.bss	47920	47920
			.data	1202	1202
			.data.rel.ro	55040	55040
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	128977	128977
			.text	1294994	1294994
	ota-provider-app	debug	(read only)	1259137	1259137
			(read/write)	74696	74696
			.bss	44352	44352
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	113216	113216
			.text	1049842	1049842
	ota-requestor-app	debug	(read only)	1343697	1343697
			(read/write)	78464	78464
			.bss	46816	46816
			.data	816	816
			.data.rel.ro	25752	25752
			.dynamic	592	592
			.got	3992	3992
			.init	27	27
			.init_array	472	472
			.rodata	124232	124232
			.text	1120834	1120834
	shell	debug	(read only)	788233	788233
			(read/write)	64808	64808
			.bss	23400	23400
			.data	242	242
			.data.rel.ro	36656	36656
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	344	344
			.rodata	78191	78191
			.text	608770	608770
	tv-app	debug	(read only)	1841649	1841649
			(read/write)	407328	407328
			.bss	339600	339600
			.data	2736	2736
			.data.rel.ro	59328	59328
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	616	616
			.rodata	156456	156456
			.text	1541442	1541442
p6	all-clusters-app	default	(read/write)	`2299288`	`2299288`
			.bss	111936	111936
			.data	2536	2536
			.heap	918872	918872
			.text	1257552	1257552
	lock-app	default	(read/write)	`2211928`	`2211928`
			.bss	100744	100744
			.data	2408	2408
			.heap	930192	930192
			.text	1170192	1170192
qpg	lighting-app	qpg6100+debug	(read only)	490712	490712
			(read/write)	114140	114140
			.bss	51136	51136
			.data	1012	1012
			.text	485392	485392
	lock-app	qpg6100+debug	(read only)	466940	466940
			(read/write)	114144	114144
			.bss	50080	50080
			.data	968	968
			.text	461620	461620
	persistent-storage-app	qpg6100+debug	(read only)	153400	153400
			(read/write)	114140	114140
			.bss	19600	19600
			.data	364	364
			.text	148080	148080
telink	lighting-app	tlsr9518adk80d	(read/write)	663682	663682
			bss	69256	69256
			noinit	33216	33216
			text	458562	458562

todo · 2021-11-09T08:01:30Z

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

connectedhomeip/src/app/AttributePathExpandIterator.cpp

Lines 34 to 44 in f71a794

    
           // TODO: Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with 
        
           // dependencies on generated files, so we don't have to re-declare things here. 
        
           // Note: Some of the generated files that depended by af.h are gen_config.h and gen_tokens.h 
        
           typedef uint8_t EmberAfClusterMask; 
        
           extern uint16_t emberAfEndpointCount(void); 
        
           extern uint16_t emberAfIndexFromEndpoint(EndpointId endpoint); 
        
           extern uint8_t emberAfClusterCount(EndpointId endpoint, bool server); 
        
           extern uint16_t emberAfGetServerAttributeCount(chip::EndpointId endpoint, chip::ClusterId cluster); 
        
           extern uint16_t emberAfGetServerAttributeIndexByAttributeId(chip::EndpointId endpoint, chip::ClusterId cluster, 
        
                                                                       chip::AttributeId attributeId);

This comment was generated by todo based on a `TODO` comment in `f71a794` in #11303. cc @erjiaqing.

github-actions · 2021-11-09T08:28:41Z

PR #11303: Size comparison from 372dc6a to f71a794

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`372dc6a`	`f71a794`
efr32	lighting-app	BRD4161A	(read only)	742640	742640
			(read/write)	116236	116236
			.bss	114452	114452
			.data	1784	1784
			.text	742632	742632
		BRD4161A+rpc	(read only)	730184	730184
			(read/write)	132860	132860
			.bss	130956	130956
			.data	1900	1900
			.text	730176	730176
	lock-app	BRD4161A	(read only)	721920	721920
			(read/write)	114052	114052
			.bss	112308	112308
			.data	1744	1744
			.text	721912	721912
	window-app	BRD4161A	(read only)	722832	722832
			(read/write)	114380	114380
			.bss	112628	112628
			.data	1748	1748
			.text	722824	722824
esp32	all-clusters-app	c3devkit	(read only)	880650	880650
			(read/write)	`1306456`	`1306456`
			.dram0.bss	58400	58400
			.dram0.data	16472	16472
			.flash.rodata	198344	198344
			.flash.text	880650	880650
			.iram0.text	57526	57526
		m5stack	(read only)	911819	911819
			(read/write)	423776	423776
			.dram0.bss	60904	60904
			.dram0.data	32108	32108
			.flash.rodata	204600	204600
			.flash.text	911819	911819
			.iram0.text	125115	125115
k32w	lighting-app	k32w061+se05x+release	(read/write)	699576	699576
			.bss	77980	77980
			.data	1912	1912
			.text	613884	613884
	lock-app	k32w061+debug	(read/write)	592288	592288
			.bss	68508	68508
			.data	1880	1880
			.text	516100	516100
	shell	k32w061+debug	(read/write)	657944	657944
			.bss	79308	79308
			.data	1848	1848
			.text	570988	570988
linux	all-clusters-app	debug	(read only)	1710033	1710033
			(read/write)	125888	125888
			.bss	57360	57360
			.data	1042	1042
			.data.rel.ro	62224	62224
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	552	552
			.rodata	139765	139765
			.text	1436946	1436946
	bridge-app	debug+rpc	(read only)	`1297685`	`1297685`
			(read/write)	76432	76432
			.bss	42256	42256
			.data	1568	1568
			.data.rel.ro	27640	27640
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	408	408
			.rodata	111540	111540
			.text	`1090421`	`1090421`
	chip-tool	debug	(read only)	`4927909`	`4927909`
			(read/write)	133856	133856
			.bss	25328	25328
			.data	2256	2256
			.data.rel.ro	100856	100856
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	424	424
			.rodata	234416	234416
			.text	4423013	4423013
	lighting-app	debug+rpc	(read only)	`1557361`	`1557361`
			(read/write)	109448	109448
			.bss	47920	47920
			.data	1202	1202
			.data.rel.ro	55040	55040
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	128977	128977
			.text	1294994	1294994
	ota-provider-app	debug	(read only)	1259137	1259137
			(read/write)	74696	74696
			.bss	44352	44352
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	113216	113216
			.text	1049842	1049842
	ota-requestor-app	debug	(read only)	1343697	1343697
			(read/write)	78464	78464
			.bss	46816	46816
			.data	816	816
			.data.rel.ro	25752	25752
			.dynamic	592	592
			.got	3992	3992
			.init	27	27
			.init_array	472	472
			.rodata	124232	124232
			.text	1120834	1120834
	shell	debug	(read only)	788233	788233
			(read/write)	64808	64808
			.bss	23400	23400
			.data	242	242
			.data.rel.ro	36656	36656
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	344	344
			.rodata	78191	78191
			.text	608770	608770
	tv-app	debug	(read only)	1841649	1841649
			(read/write)	407328	407328
			.bss	339600	339600
			.data	2736	2736
			.data.rel.ro	59328	59328
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	616	616
			.rodata	156456	156456
			.text	1541442	1541442
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2290768	2290768
			.bss	179404	179404
			.data	5232	5232
			.heap	851808	851808
			.text	1253368	1253368
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2270928	2270928
			.bss	172460	172460
			.data	5584	5584
			.heap	858400	858400
			.text	1233528	1233528
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2248584	2248584
			.bss	171356	171356
			.data	5568	5568
			.heap	859520	859520
			.text	1211184	1211184
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139744	1139744
			.bss	11752	11752
			.data	4368	4368
			.heap	1020328	1020328
			.text	103128	103128
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2048760	2048760
			.bss	156424	156424
			.data	4976	4976
			.heap	875048	875048
			.text	1011360	1011360
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862071	862071
			bss	111444	111444
			rodata	96904	96904
			text	578100	578100
		nrf52840dk_nrf52840+rpc	(read/write)	824419	824419
			bss	107796	107796
			rodata	88084	88084
			text	552248	552248
		nrf5340dk_nrf5340_cpuapp	(read/write)	787126	787126
			bss	112816	112816
			rodata	92160	92160
			text	507572	507572
	lock-app	nrf52840dk_nrf52840	(read/write)	838795	838795
			bss	110476	110476
			rodata	93276	93276
			text	559584	559584
		nrf5340dk_nrf5340_cpuapp	(read/write)	764090	764090
			bss	111888	111888
			rodata	88580	88580
			text	489148	489148
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327
			bss	51824	51824
			rodata	45780	45780
			text	339436	339436
	pump-app	nrf52840dk_nrf52840	(read/write)	844871	844871
			bss	110616	110616
			rodata	94984	94984
			text	563744	563744
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838647	838647
			bss	110512	110512
			rodata	93272	93272
			text	559320	559320
	shell	nrf52840dk_nrf52840	(read/write)	776379	776379
			bss	109264	109264
			rodata	72544	72544
			text	519972	519972
		nrf5340dk_nrf5340_cpuapp	(read/write)	691430	691430
			bss	110248	110248
			rodata	67184	67184
			text	440580	440580
p6	all-clusters-app	default	(read/write)	`2299288`	`2299288`
			.bss	111936	111936
			.data	2536	2536
			.heap	918872	918872
			.text	1257552	1257552
	lock-app	default	(read/write)	`2211928`	`2211928`
			.bss	100744	100744
			.data	2408	2408
			.heap	930192	930192
			.text	1170192	1170192
qpg	lighting-app	qpg6100+debug	(read only)	490712	490712
			(read/write)	114140	114140
			.bss	51136	51136
			.data	1012	1012
			.text	485392	485392
	lock-app	qpg6100+debug	(read only)	466940	466940
			(read/write)	114144	114144
			.bss	50080	50080
			.data	968	968
			.text	461620	461620
	persistent-storage-app	qpg6100+debug	(read only)	153400	153400
			(read/write)	114140	114140
			.bss	19600	19600
			.data	364	364
			.text	148080	148080
telink	lighting-app	tlsr9518adk80d	(read/write)	663682	663682
			bss	69256	69256
			noinit	33216	33216
			text	458562	458562

src/app/AttributePathExpandIterator.h

src/app/ConcreteAttributePath.h

todo · 2021-11-11T01:53:54Z

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

connectedhomeip/src/app/AttributePathExpandIterator.cpp

Lines 34 to 44 in c2d1952

    
           // TODO: Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with 
        
           // dependencies on generated files, so we don't have to re-declare things here. 
        
           // Note: Some of the generated files that depended by af.h are gen_config.h and gen_tokens.h 
        
           typedef uint8_t EmberAfClusterMask; 
        
           extern uint16_t emberAfEndpointCount(void); 
        
           extern uint16_t emberAfIndexFromEndpoint(EndpointId endpoint); 
        
           extern uint8_t emberAfClusterCount(EndpointId endpoint, bool server); 
        
           extern uint16_t emberAfGetServerAttributeCount(chip::EndpointId endpoint, chip::ClusterId cluster); 
        
           extern uint16_t emberAfGetServerAttributeIndexByAttributeId(chip::EndpointId endpoint, chip::ClusterId cluster, 
        
                                                                       chip::AttributeId attributeId);

This comment was generated by todo based on a `TODO` comment in `c2d1952` in #11303. cc @erjiaqing.

erjiaqing · 2021-11-11T01:54:30Z

@mrjerryjohns @Damian-Nordic @msandstedt PTAL, thanks

erjiaqing · 2021-11-11T14:12:58Z

/rebase

…dcard fields

todo · 2021-11-11T14:13:43Z

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

connectedhomeip/src/app/AttributePathExpandIterator.cpp

Lines 34 to 44 in 5fedfa7

    
           // TODO: Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with 
        
           // dependencies on generated files, so we don't have to re-declare things here. 
        
           // Note: Some of the generated files that depended by af.h are gen_config.h and gen_tokens.h 
        
           typedef uint8_t EmberAfClusterMask; 
        
           extern uint16_t emberAfEndpointCount(void); 
        
           extern uint16_t emberAfIndexFromEndpoint(EndpointId endpoint); 
        
           extern uint8_t emberAfClusterCount(EndpointId endpoint, bool server); 
        
           extern uint16_t emberAfGetServerAttributeCount(chip::EndpointId endpoint, chip::ClusterId cluster); 
        
           extern uint16_t emberAfGetServerAttributeIndexByAttributeId(chip::EndpointId endpoint, chip::ClusterId cluster, 
        
                                                                       chip::AttributeId attributeId);

This comment was generated by todo based on a `TODO` comment in `5fedfa7` in #11303. cc @erjiaqing.

github-actions · 2021-11-11T14:32:50Z

PR #11303: Size comparison from d45cfaa to 5fedfa7

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`d45cfaa`	`5fedfa7`
efr32	lighting-app	BRD4161A	(read only)	742476	742476
			(read/write)	116280	116280
			.bss	114500	114500
			.data	1780	1780
			.text	742468	742468
		BRD4161A+rpc	(read only)	730040	730040
			(read/write)	132900	132900
			.bss	131004	131004
			.data	1896	1896
			.text	730032	730032
	lock-app	BRD4161A	(read only)	721764	721764
			(read/write)	114096	114096
			.bss	112356	112356
			.data	1740	1740
			.text	721756	721756
	window-app	BRD4161A	(read only)	722676	722676
			(read/write)	114420	114420
			.bss	112676	112676
			.data	1744	1744
			.text	722668	722668
esp32	all-clusters-app	c3devkit	(read only)	879114	879114
			(read/write)	1305968	1305968
			.dram0.bss	58440	58440
			.dram0.data	16456	16456
			.flash.rodata	197824	197824
			.flash.text	879114	879114
			.iram0.text	57526	57526
		m5stack	(read only)	910683	910683
			(read/write)	423308	423308
			.dram0.bss	60952	60952
			.dram0.data	32092	32092
			.flash.rodata	204100	204100
			.flash.text	910683	910683
			.iram0.text	125115	125115
k32w	lighting-app	k32w061+se05x+release	(read/write)	699396	699396
			.bss	78012	78012
			.data	1908	1908
			.text	613676	613676
	lock-app	k32w061+debug	(read/write)	592132	592132
			.bss	68548	68548
			.data	1876	1876
			.text	515908	515908
	shell	k32w061+debug	(read/write)	657760	657760
			.bss	79340	79340
			.data	1844	1844
			.text	570776	570776
linux	all-clusters-app	debug	(read only)	1698921	1698921
			(read/write)	126432	126432
			.bss	57904	57904
			.data	1010	1010
			.data.rel.ro	62256	62256
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	552	552
			.rodata	139061	139061
			.text	1426370	1426370
	bridge-app	debug+rpc	(read only)	1298741	1298741
			(read/write)	77264	77264
			.bss	42800	42800
			.data	1568	1568
			.data.rel.ro	27928	27928
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	408	408
			.rodata	110932	110932
			.text	1091365	1091365
	chip-tool	debug	(read only)	4813069	4813069
			(read/write)	136992	136992
			.bss	25960	25960
			.data	2256	2256
			.data.rel.ro	103336	103336
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	432	432
			.rodata	248298	248298
			.text	4288437	4288437
	lighting-app	debug+rpc	(read only)	1558113	1558113
			(read/write)	110376	110376
			.bss	48560	48560
			.data	1202	1202
			.data.rel.ro	55328	55328
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	128369	128369
			.text	1295634	1295634
	ota-provider-app	debug	(read only)	`1259977`	`1259977`
			(read/write)	75624	75624
			.bss	44992	44992
			.data	752	752
			.data.rel.ro	24776	24776
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	112615	112615
			.text	1050562	1050562
	ota-requestor-app	debug	(read only)	1345049	1345049
			(read/write)	79392	79392
			.bss	47456	47456
			.data	816	816
			.data.rel.ro	26040	26040
			.dynamic	592	592
			.got	3992	3992
			.init	27	27
			.init_array	472	472
			.rodata	123728	123728
			.text	`1121970`	`1121970`
	shell	debug	(read only)	788441	788441
			(read/write)	65608	65608
			.bss	23944	23944
			.data	242	242
			.data.rel.ro	36928	36928
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	344	344
			.rodata	77519	77519
			.text	609026	609026
	tv-app	debug	(read only)	1842905	1842905
			(read/write)	408216	408216
			.bss	340232	340232
			.data	2736	2736
			.data.rel.ro	59600	59600
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	616	616
			.rodata	155757	155757
			.text	1542674	1542674
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2289248`	`2289248`
			.bss	179412	179412
			.data	5216	5216
			.heap	851816	851816
			.text	1251848	1251848
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2270688`	`2270688`
			.bss	172508	172508
			.data	5576	5576
			.heap	858360	858360
			.text	1233288	1233288
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2248344	2248344
			.bss	171404	171404
			.data	5568	5568
			.heap	859472	859472
			.text	1210944	1210944
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139744	1139744
			.bss	11752	11752
			.data	4368	4368
			.heap	1020328	1020328
			.text	103128	103128
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2048296	2048296
			.bss	156464	156464
			.data	4968	4968
			.heap	875016	875016
			.text	1010896	1010896
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861907	861907
			bss	111476	111476
			rodata	96532	96532
			text	578272	578272
		nrf52840dk_nrf52840+rpc	(read/write)	824267	824267
			bss	107828	107828
			rodata	87708	87708
			text	552444	552444
		nrf5340dk_nrf5340_cpuapp	(read/write)	786946	786946
			bss	112848	112848
			rodata	91788	91788
			text	507740	507740
	lock-app	nrf52840dk_nrf52840	(read/write)	838615	838615
			bss	110508	110508
			rodata	92904	92904
			text	559756	559756
		nrf5340dk_nrf5340_cpuapp	(read/write)	763926	763926
			bss	111920	111920
			rodata	88208	88208
			text	489316	489316
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327
			bss	51824	51824
			rodata	45780	45780
			text	339436	339436
	pump-app	nrf52840dk_nrf52840	(read/write)	844707	844707
			bss	110648	110648
			rodata	94612	94612
			text	563916	563916
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838467	838467
			bss	110544	110544
			rodata	92900	92900
			text	559492	559492
	shell	nrf52840dk_nrf52840	(read/write)	775955	775955
			bss	109288	109288
			rodata	72152	72152
			text	519904	519904
		nrf5340dk_nrf5340_cpuapp	(read/write)	690962	690962
			bss	110272	110272
			rodata	66796	66796
			text	440512	440512
p6	all-clusters-app	default	(read/write)	2297136	2297136
			.bss	112416	112416
			.data	2520	2520
			.heap	918408	918408
			.text	`1255400`	`1255400`
	lock-app	default	(read/write)	2211760	2211760
			.bss	101264	101264
			.data	2400	2400
			.heap	929680	929680
			.text	1170024	1170024
qpg	lighting-app	qpg6100+debug	(read only)	490672	490672
			(read/write)	114144	114144
			.bss	51168	51168
			.data	1008	1008
			.text	485352	485352
	lock-app	qpg6100+debug	(read only)	466900	466900
			(read/write)	114140	114140
			.bss	50112	50112
			.data	964	964
			.text	461580	461580
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408
			(read/write)	114142	114142
			.bss	8978	8978
			.data	272	272
			.text	100088	100088
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663418
			bss	69288	69288
			noinit	33216	33216
			text	458654	458654

andy31415 · 2021-11-12T13:56:52Z

Fast track: 10 day old PR, created and reviewed by domain owners.

…fo-s with wildcard (project-chip#11303) * [IM] Implementing PathIterator for iterating attribute paths with wildcard fields * Address comments * Update Test case, remove TODO for group path * Fix * Update * Fix

boring-cyborg bot added app examples labels Nov 2, 2021

erjiaqing force-pushed the im/read-wildcard branch 2 times, most recently from 0838d7b to 5c1103c Compare November 4, 2021 10:29

erjiaqing force-pushed the im/read-wildcard branch from 5c1103c to f72a610 Compare November 5, 2021 04:25

erjiaqing marked this pull request as ready for review November 5, 2021 04:25

erjiaqing requested review from bzbarsky-apple and mrjerryjohns November 9, 2021 06:31

erjiaqing force-pushed the im/read-wildcard branch from 85b1830 to d25f053 Compare November 9, 2021 06:56

erjiaqing force-pushed the im/read-wildcard branch from d25f053 to f71a794 Compare November 9, 2021 08:01

bzbarsky-apple approved these changes Nov 10, 2021

View reviewed changes

src/app/AttributePathExpandIterator.h Outdated Show resolved Hide resolved

src/app/ConcreteAttributePath.h Outdated Show resolved Hide resolved

bzbarsky-apple mentioned this pull request Nov 10, 2021

Add example implementation of access control #11550

Merged

mrjerryjohns approved these changes Nov 11, 2021

View reviewed changes

erjiaqing added 6 commits November 11, 2021 14:13

[IM] Implementing PathIterator for iterating attribute paths with wil…

87b9e41

…dcard fields

Address comments

9a22478

Update Test case, remove TODO for group path

5118523

Fix

463b064

Update

92b9865

Fix

5fedfa7

woody-apple force-pushed the im/read-wildcard branch from c2d1952 to 5fedfa7 Compare November 11, 2021 14:13

andy31415 added the fast track label Nov 12, 2021

andy31415 merged commit 09736d3 into project-chip:master Nov 12, 2021

This was referenced Nov 12, 2021

Need to make it so that declarations of things that don't depend on generated fi... #11731

Closed

The ClusterInfo may support a group id, the iterator should be able to call grou... #11732

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IM] AttributePathExpandIterator for iterating over list of ClusterInfo-s with wildcard #11303

[IM] AttributePathExpandIterator for iterating over list of ClusterInfo-s with wildcard #11303

erjiaqing commented Nov 2, 2021 •

edited

Loading

github-actions bot commented Nov 4, 2021 •

edited

Loading

todo bot commented Nov 5, 2021

github-actions bot commented Nov 9, 2021

todo bot commented Nov 9, 2021

github-actions bot commented Nov 9, 2021 •

edited

Loading

todo bot commented Nov 9, 2021

github-actions bot commented Nov 9, 2021 •

edited

Loading

todo bot commented Nov 11, 2021

erjiaqing commented Nov 11, 2021

erjiaqing commented Nov 11, 2021

todo bot commented Nov 11, 2021

github-actions bot commented Nov 11, 2021 •

edited

Loading

andy31415 commented Nov 12, 2021

[IM] AttributePathExpandIterator for iterating over list of ClusterInfo-s with wildcard #11303

[IM] AttributePathExpandIterator for iterating over list of ClusterInfo-s with wildcard #11303

Conversation

erjiaqing commented Nov 2, 2021 • edited Loading

Problem

Change overview

Testing

github-actions bot commented Nov 4, 2021 • edited Loading

todo bot commented Nov 5, 2021

Here we use forward declaration for these symbols used, there should be some reorganize for code in app/util so they can be

This comment was generated by todo based on a TODO comment in f72a610 in #11303. cc @erjiaqing.

github-actions bot commented Nov 9, 2021

todo bot commented Nov 9, 2021

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

This comment was generated by todo based on a TODO comment in d25f053 in #11303. cc @erjiaqing.

github-actions bot commented Nov 9, 2021 • edited Loading

todo bot commented Nov 9, 2021

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

This comment was generated by todo based on a TODO comment in f71a794 in #11303. cc @erjiaqing.

github-actions bot commented Nov 9, 2021 • edited Loading

todo bot commented Nov 11, 2021

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

This comment was generated by todo based on a TODO comment in c2d1952 in #11303. cc @erjiaqing.

erjiaqing commented Nov 11, 2021

erjiaqing commented Nov 11, 2021

todo bot commented Nov 11, 2021

Need to make it so that declarations of things that don't depend on generated files are not intermixed in af.h with

This comment was generated by todo based on a TODO comment in 5fedfa7 in #11303. cc @erjiaqing.

github-actions bot commented Nov 11, 2021 • edited Loading

andy31415 commented Nov 12, 2021

erjiaqing commented Nov 2, 2021 •

edited

Loading

github-actions bot commented Nov 4, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `f72a610` in #11303. cc @erjiaqing.

This comment was generated by todo based on a `TODO` comment in `d25f053` in #11303. cc @erjiaqing.

github-actions bot commented Nov 9, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `f71a794` in #11303. cc @erjiaqing.

github-actions bot commented Nov 9, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `c2d1952` in #11303. cc @erjiaqing.

This comment was generated by todo based on a `TODO` comment in `5fedfa7` in #11303. cc @erjiaqing.

github-actions bot commented Nov 11, 2021 •

edited

Loading