Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh IM Invoke encoding with latest spec #11169

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Refresh IM Invoke encoding with latest spec #11169

merged 1 commit into from
Nov 2, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Oct 29, 2021 •
edited
Loading

Problem

Refresh IM Invoke encoding with latest spec, and update commandSender and CommandHandler.
Note: Since InvokeRequest is not similar with InvokeRespnse in latest encoding spec, the common logic in Command.cpp and MessageDef has been removed, in follow-up PR, we would remove the Command.cpp and fully split CommandSender and CommandHandler.

https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/Encoding-Specification.adoc#encoding-InvokeRequestMessage

Change overview

See above

Testing

All existing Command related test covers.
Add new unit test for InvokeRequest/Response related tlv encoding.

@boring-cyborg boring-cyborg bot added the app label Oct 29, 2021
@yunhanw-google yunhanw-google force-pushed the feature/update_im_command_messagedef branch from 53662b6 to 9641dcc Compare October 29, 2021 01:36
@boring-cyborg boring-cyborg bot added the lib label Oct 29, 2021
@yunhanw-google yunhanw-google force-pushed the feature/update_im_command_messagedef branch from 9641dcc to 5669f1b Compare October 29, 2021 02:07
@restyled-io restyled-io bot mentioned this pull request Oct 29, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/update_im_command_messagedef branch 2 times, most recently from ddeb870 to ae1e20d Compare October 29, 2021 02:20
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11169: Size comparison from 1e27d92 to ae1e20d

Increases above 0.2%:

platform target config section 1e27d92 ae1e20d change % change
linux all-clusters-app debug (read only) 1655073 1658561 3488 0.2
(read/write) 119104 119584 480 0.4
.bss 51376 51888 512 1.0
.rodata 138069 138773 704 0.5
.text 1384738 1387522 2784 0.2
bridge-app debug+rpc (read only) 1283341 1286813 3472 0.3
(read/write) 85160 85640 480 0.6
.bss 51856 52368 512 1.0
.rodata 111044 111780 736 0.7
.text 1076981 1079717 2736 0.3
chip-tool debug (read only) 4266229 4283469 17240 0.4
(read/write) 122176 122688 512 0.4
.bss 17680 18192 512 2.9
.rodata 214704 215792 1088 0.5
.text 3788725 3804901 16176 0.4
lighting-app debug+rpc (read only) 1542281 1545721 3440 0.2
(read/write) 102000 102512 512 0.5
.bss 41208 41720 512 1.2
.rodata 129169 129873 704 0.5
.text 1280658 1283394 2736 0.2
ota-provider-app debug (read only) 1239849 1243289 3440 0.3
(read/write) 67872 68352 480 0.7
.bss 37440 37952 512 1.4
.rodata 111208 111912 704 0.6
.text 1032466 1035202 2736 0.3
ota-requestor-app debug (read only) 1301465 1318609 17144 1.3
(read/write) 76616 77096 480 0.6
.bss 45216 45728 512 1.1
.rodata 127424 128608 1184 0.9
.text 1076226 1092210 15984 1.5
shell debug .rodata 77519 77743 224 0.3
tv-app debug (read only) 1774929 1792041 17112 1.0
.bss 223280 223792 512 0.2
.rodata 154488 155640 1152 0.7
.text 1478178 1494162 15984 1.1
Increases (18 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1e27d92 ae1e20d change % change
efr32 lighting-app BRD4161A (read only) 738120 738624 504 0.1
(read/write) 115428 115588 160 0.1
.bss 113676 113836 160 0.1
.text 738112 738616 504 0.1
BRD4161A+rpc (read only) 725560 726064 504 0.1
(read/write) 132036 132196 160 0.1
.bss 130180 130340 160 0.1
.text 725552 726056 504 0.1
lock-app BRD4161A (read only) 717400 717904 504 0.1
(read/write) 113244 113404 160 0.1
.bss 111532 111692 160 0.1
.text 717392 717896 504 0.1
window-app BRD4161A (read only) 718304 718808 504 0.1
(read/write) 113572 113732 160 0.1
.bss 111852 112012 160 0.1
.text 718296 718800 504 0.1
k32w lighting-app k32w061+se05x+release (read/write) 701656 702160 504 0.1
.bss 78688 78848 160 0.2
.text 615268 615612 344 0.1
lock-app k32w061+debug (read/write) 593612 594116 504 0.1
.bss 69172 69332 160 0.2
.text 516776 517120 344 0.1
linux all-clusters-app debug (read only) 1655073 1658561 3488 0.2
(read/write) 119104 119584 480 0.4
.bss 51376 51888 512 1.0
.rodata 138069 138773 704 0.5
.text 1384738 1387522 2784 0.2
bridge-app debug+rpc (read only) 1283341 1286813 3472 0.3
(read/write) 85160 85640 480 0.6
.bss 51856 52368 512 1.0
.rodata 111044 111780 736 0.7
.text 1076981 1079717 2736 0.3
chip-tool debug (read only) 4266229 4283469 17240 0.4
(read/write) 122176 122688 512 0.4
.bss 17680 18192 512 2.9
.rodata 214704 215792 1088 0.5
.text 3788725 3804901 16176 0.4
lighting-app debug+rpc (read only) 1542281 1545721 3440 0.2
(read/write) 102000 102512 512 0.5
.bss 41208 41720 512 1.2
.rodata 129169 129873 704 0.5
.text 1280658 1283394 2736 0.2
ota-provider-app debug (read only) 1239849 1243289 3440 0.3
(read/write) 67872 68352 480 0.7
.bss 37440 37952 512 1.4
.rodata 111208 111912 704 0.6
.text 1032466 1035202 2736 0.3
ota-requestor-app debug (read only) 1301465 1318609 17144 1.3
(read/write) 76616 77096 480 0.6
.bss 45216 45728 512 1.1
.rodata 127424 128608 1184 0.9
.text 1076226 1092210 15984 1.5
shell debug (read only) 787153 787441 288 0.0
.rodata 77519 77743 224 0.3
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1792041 17112 1.0
(read/write) 289624 290136 512 0.2
.bss 223280 223792 512 0.2
.rodata 154488 155640 1152 0.7
.text 1478178 1494162 15984 1.1
p6 lock-app default (read/write) 2169744 2170248 504 0.0
.bss 67168 67328 160 0.2
.text 1128008 1128512 504 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491584 360 0.1
.bss 51288 51368 80 0.2
.text 485904 486264 360 0.1
lock-app qpg6100+debug (read only) 467556 467924 368 0.1
.bss 50240 50320 80 0.2
.text 462236 462604 368 0.1
telink lighting-app tlsr9518adk80d (read/write) 665202 665802 600 0.1
bss 69944 70104 160 0.2
text 458454 458900 446 0.1
Decreases (8 builds for linux, p6)
platform target config section 1e27d92 ae1e20d change % change
linux all-clusters-app debug .data.rel.ro 61504 61488 -16 -0.0
bridge-app debug+rpc .data.rel.ro 27336 27320 -16 -0.1
chip-tool debug .data.rel.ro 97504 97480 -24 -0.0
lighting-app debug+rpc .data.rel.ro 54416 54400 -16 -0.0
ota-provider-app debug .data.rel.ro 24584 24568 -16 -0.1
ota-requestor-app debug .data.rel.ro 25464 25432 -32 -0.1
tv-app debug .data.rel.ro 58672 58656 -16 -0.0
p6 lock-app default .heap 963760 963600 -160 -0.0
Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1e27d92 ae1e20d change % change
efr32 lighting-app BRD4161A (read only) 738120 738624 504 0.1
(read/write) 115428 115588 160 0.1
.bss 113676 113836 160 0.1
.data 1752 1752 0 0.0
.text 738112 738616 504 0.1
BRD4161A+rpc (read only) 725560 726064 504 0.1
(read/write) 132036 132196 160 0.1
.bss 130180 130340 160 0.1
.data 1852 1852 0 0.0
.text 725552 726056 504 0.1
lock-app BRD4161A (read only) 717400 717904 504 0.1
(read/write) 113244 113404 160 0.1
.bss 111532 111692 160 0.1
.data 1712 1712 0 0.0
.text 717392 717896 504 0.1
window-app BRD4161A (read only) 718304 718808 504 0.1
(read/write) 113572 113732 160 0.1
.bss 111852 112012 160 0.1
.data 1716 1716 0 0.0
.text 718296 718800 504 0.1
k32w lighting-app k32w061+se05x+release (read/write) 701656 702160 504 0.1
.bss 78688 78848 160 0.2
.data 1900 1900 0 0.0
.text 615268 615612 344 0.1
lock-app k32w061+debug (read/write) 593612 594116 504 0.1
.bss 69172 69332 160 0.2
.data 1864 1864 0 0.0
.text 516776 517120 344 0.1
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1655073 1658561 3488 0.2
(read/write) 119104 119584 480 0.4
.bss 51376 51888 512 1.0
.data 978 978 0 0.0
.data.rel.ro 61504 61488 -16 -0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 138069 138773 704 0.5
.text 1384738 1387522 2784 0.2
bridge-app debug+rpc (read only) 1283341 1286813 3472 0.3
(read/write) 85160 85640 480 0.6
.bss 51856 52368 512 1.0
.data 976 976 0 0.0
.data.rel.ro 27336 27320 -16 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111044 111780 736 0.7
.text 1076981 1079717 2736 0.3
chip-tool debug (read only) 4266229 4283469 17240 0.4
(read/write) 122176 122688 512 0.4
.bss 17680 18192 512 2.9
.data 1584 1584 0 0.0
.data.rel.ro 97504 97480 -24 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214704 215792 1088 0.5
.text 3788725 3804901 16176 0.4
lighting-app debug+rpc (read only) 1542281 1545721 3440 0.2
(read/write) 102000 102512 512 0.5
.bss 41208 41720 512 1.2
.data 1106 1106 0 0.0
.data.rel.ro 54416 54400 -16 -0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129169 129873 704 0.5
.text 1280658 1283394 2736 0.2
ota-provider-app debug (read only) 1239849 1243289 3440 0.3
(read/write) 67872 68352 480 0.7
.bss 37440 37952 512 1.4
.data 752 752 0 0.0
.data.rel.ro 24584 24568 -16 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111208 111912 704 0.6
.text 1032466 1035202 2736 0.3
ota-requestor-app debug (read only) 1301465 1318609 17144 1.3
(read/write) 76616 77096 480 0.6
.bss 45216 45728 512 1.1
.data 816 816 0 0.0
.data.rel.ro 25464 25432 -32 -0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127424 128608 1184 0.9
.text 1076226 1092210 15984 1.5
shell debug (read only) 787153 787441 288 0.0
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77743 224 0.3
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1792041 17112 1.0
(read/write) 289624 290136 512 0.2
.bss 223280 223792 512 0.2
.data 2032 2032 0 0.0
.data.rel.ro 58672 58656 -16 -0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154488 155640 1152 0.7
.text 1478178 1494162 15984 1.1
p6 lock-app default (read/write) 2169744 2170248 504 0.0
.bss 67168 67328 160 0.2
.data 2416 2416 0 0.0
.heap 963760 963600 -160 -0.0
.text 1128008 1128512 504 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491584 360 0.1
(read/write) 114144 114144 0 0.0
.bss 51288 51368 80 0.2
.data 1000 1000 0 0.0
.text 485904 486264 360 0.1
lock-app qpg6100+debug (read only) 467556 467924 368 0.1
(read/write) 114140 114140 0 0.0
.bss 50240 50320 80 0.2
.data 956 956 0 0.0
.text 462236 462604 368 0.1
persistent-storage-app qpg6100+debug (read only) 155236 155236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149916 149916 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665802 600 0.1
bss 69944 70104 160 0.2
noinit 33216 33216 0 0.0
text 458454 458900 446 0.1

@yunhanw-google yunhanw-google force-pushed the feature/update_im_command_messagedef branch from ae1e20d to 90175e0 Compare October 29, 2021 03:08
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11169: Size comparison from 1e27d92 to 90175e0

Increases above 0.2%:

platform target config section 1e27d92 90175e0 change % change
esp32 all-clusters-app c3devkit .dram0.bss 59248 59408 160 0.3
m5stack .dram0.bss 61744 61904 160 0.3
linux all-clusters-app debug (read/write) 119104 119584 480 0.4
.bss 51376 51888 512 1.0
.rodata 138069 138773 704 0.5
bridge-app debug+rpc (read only) 1283341 1286813 3472 0.3
(read/write) 85160 85640 480 0.6
.bss 51856 52368 512 1.0
.rodata 111044 111780 736 0.7
.text 1076981 1079717 2736 0.3
chip-tool debug (read only) 4266229 4283469 17240 0.4
(read/write) 122176 122688 512 0.4
.bss 17680 18192 512 2.9
.rodata 214704 215792 1088 0.5
.text 3788725 3804901 16176 0.4
lighting-app debug+rpc (read/write) 102000 102512 512 0.5
.bss 41208 41720 512 1.2
.rodata 129169 129873 704 0.5
ota-provider-app debug (read only) 1239849 1243289 3440 0.3
(read/write) 67872 68352 480 0.7
.bss 37440 37952 512 1.4
.rodata 111208 111912 704 0.6
.text 1032466 1035202 2736 0.3
ota-requestor-app debug (read only) 1301465 1318609 17144 1.3
(read/write) 76616 77096 480 0.6
.bss 45216 45728 512 1.1
.rodata 127424 128608 1184 0.9
.text 1076226 1092210 15984 1.5
shell debug .rodata 77519 77743 224 0.3
tv-app debug (read only) 1774929 1792041 17112 1.0
.rodata 154488 155640 1152 0.7
.text 1478178 1494162 15984 1.1
Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1e27d92 90175e0 change % change
efr32 lighting-app BRD4161A (read only) 738120 738624 504 0.1
(read/write) 115428 115588 160 0.1
.bss 113676 113836 160 0.1
.text 738112 738616 504 0.1
BRD4161A+rpc (read only) 725560 726064 504 0.1
(read/write) 132036 132196 160 0.1
.bss 130180 130340 160 0.1
.text 725552 726056 504 0.1
lock-app BRD4161A (read only) 717400 717904 504 0.1
(read/write) 113244 113404 160 0.1
.bss 111532 111692 160 0.1
.text 717392 717896 504 0.1
window-app BRD4161A (read only) 718304 718808 504 0.1
(read/write) 113572 113732 160 0.1
.bss 111852 112012 160 0.1
.text 718296 718800 504 0.1
esp32 all-clusters-app c3devkit (read only) 876382 876774 392 0.0
(read/write) 1308944 1309096 152 0.0
.dram0.bss 59248 59408 160 0.3
.flash.text 876382 876774 392 0.0
m5stack (read only) 907747 908215 468 0.1
(read/write) 428724 428876 152 0.0
.dram0.bss 61744 61904 160 0.3
.flash.text 907747 908215 468 0.1
k32w lighting-app k32w061+se05x+release (read/write) 701656 702160 504 0.1
.bss 78688 78848 160 0.2
.text 615268 615612 344 0.1
lock-app k32w061+debug (read/write) 593612 594116 504 0.1
.bss 69172 69332 160 0.2
.text 516776 517120 344 0.1
linux all-clusters-app debug (read only) 1655073 1658561 3488 0.2
(read/write) 119104 119584 480 0.4
.bss 51376 51888 512 1.0
.rodata 138069 138773 704 0.5
.text 1384738 1387522 2784 0.2
bridge-app debug+rpc (read only) 1283341 1286813 3472 0.3
(read/write) 85160 85640 480 0.6
.bss 51856 52368 512 1.0
.rodata 111044 111780 736 0.7
.text 1076981 1079717 2736 0.3
chip-tool debug (read only) 4266229 4283469 17240 0.4
(read/write) 122176 122688 512 0.4
.bss 17680 18192 512 2.9
.rodata 214704 215792 1088 0.5
.text 3788725 3804901 16176 0.4
lighting-app debug+rpc (read only) 1542281 1545721 3440 0.2
(read/write) 102000 102512 512 0.5
.bss 41208 41720 512 1.2
.rodata 129169 129873 704 0.5
.text 1280658 1283394 2736 0.2
ota-provider-app debug (read only) 1239849 1243289 3440 0.3
(read/write) 67872 68352 480 0.7
.bss 37440 37952 512 1.4
.rodata 111208 111912 704 0.6
.text 1032466 1035202 2736 0.3
ota-requestor-app debug (read only) 1301465 1318609 17144 1.3
(read/write) 76616 77096 480 0.6
.bss 45216 45728 512 1.1
.rodata 127424 128608 1184 0.9
.text 1076226 1092210 15984 1.5
shell debug (read only) 787153 787441 288 0.0
.rodata 77519 77743 224 0.3
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1792041 17112 1.0
(read/write) 289624 290136 512 0.2
.bss 223280 223792 512 0.2
.rodata 154488 155640 1152 0.7
.text 1478178 1494162 15984 1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 180620 180780 160 0.1
lighting-app CY8CPROTO_062_4343W+release .bss 172820 172980 160 0.1
lock-app CY8CPROTO_062_4343W+release .bss 171724 171884 160 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863535 864039 504 0.1
bss 112132 112292 160 0.1
text 577960 578312 352 0.1
nrf52840dk_nrf52840+rpc (read/write) 824363 824867 504 0.1
bss 108372 108532 160 0.1
text 551136 551484 348 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788526 789030 504 0.1
bss 113504 113664 160 0.1
text 507428 507780 352 0.1
lock-app nrf52840dk_nrf52840 (read/write) 840211 840715 504 0.1
bss 111168 111328 160 0.1
text 559444 559796 352 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 765506 766010 504 0.1
bss 112576 112736 160 0.1
text 489004 489356 352 0.1
pump-app nrf52840dk_nrf52840 (read/write) 844911 845415 504 0.1
bss 111304 111464 160 0.1
text 562656 563004 348 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 840199 840687 488 0.1
bss 111200 111360 160 0.1
text 559288 559636 348 0.1
p6 lock-app default (read/write) 2169744 2170248 504 0.0
.bss 67168 67328 160 0.2
.text 1128008 1128512 504 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491584 360 0.1
.bss 51288 51368 80 0.2
.text 485904 486264 360 0.1
lock-app qpg6100+debug (read only) 467556 467924 368 0.1
.bss 50240 50320 80 0.2
.text 462236 462604 368 0.1
telink lighting-app tlsr9518adk80d (read/write) 665202 665802 600 0.1
bss 69944 70104 160 0.2
text 458454 458900 446 0.1
Decreases (20 builds for esp32, linux, mbed, nrfconnect, p6)
platform target config section 1e27d92 90175e0 change % change
esp32 all-clusters-app c3devkit .flash.rodata 200016 200008 -8 -0.0
m5stack .flash.rodata 208732 208724 -8 -0.0
linux all-clusters-app debug .data.rel.ro 61504 61488 -16 -0.0
bridge-app debug+rpc .data.rel.ro 27336 27320 -16 -0.1
chip-tool debug .data.rel.ro 97504 97480 -24 -0.0
lighting-app debug+rpc .data.rel.ro 54416 54400 -16 -0.0
ota-provider-app debug .data.rel.ro 24584 24568 -16 -0.1
ota-requestor-app debug .data.rel.ro 25464 25432 -32 -0.1
tv-app debug .data.rel.ro 58672 58656 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291400 2290168 -1232 -0.1
.heap 850632 850472 -160 -0.0
.text 1254000 1252768 -1232 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2275608 2274440 -1168 -0.1
.heap 858056 857896 -160 -0.0
.text 1238208 1237040 -1168 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2253328 2252160 -1168 -0.1
.heap 859168 859008 -160 -0.0
.text 1215928 1214760 -1168 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 97816 97808 -8 -0.0
nrf52840dk_nrf52840+rpc rodata 88596 88588 -8 -0.0
nrf5340dk_nrf5340_cpuapp rodata 93056 93048 -8 -0.0
lock-app nrf52840dk_nrf52840 rodata 94172 94164 -8 -0.0
nrf5340dk_nrf5340_cpuapp rodata 89476 89468 -8 -0.0
pump-app nrf52840dk_nrf52840 rodata 95416 95408 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 rodata 94192 94184 -8 -0.0
p6 lock-app default .heap 963760 963600 -160 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1e27d92 90175e0 change % change
efr32 lighting-app BRD4161A (read only) 738120 738624 504 0.1
(read/write) 115428 115588 160 0.1
.bss 113676 113836 160 0.1
.data 1752 1752 0 0.0
.text 738112 738616 504 0.1
BRD4161A+rpc (read only) 725560 726064 504 0.1
(read/write) 132036 132196 160 0.1
.bss 130180 130340 160 0.1
.data 1852 1852 0 0.0
.text 725552 726056 504 0.1
lock-app BRD4161A (read only) 717400 717904 504 0.1
(read/write) 113244 113404 160 0.1
.bss 111532 111692 160 0.1
.data 1712 1712 0 0.0
.text 717392 717896 504 0.1
window-app BRD4161A (read only) 718304 718808 504 0.1
(read/write) 113572 113732 160 0.1
.bss 111852 112012 160 0.1
.data 1716 1716 0 0.0
.text 718296 718800 504 0.1
esp32 all-clusters-app c3devkit (read only) 876382 876774 392 0.0
(read/write) 1308944 1309096 152 0.0
.dram0.bss 59248 59408 160 0.3
.dram0.data 16448 16448 0 0.0
.flash.rodata 200016 200008 -8 -0.0
.flash.text 876382 876774 392 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907747 908215 468 0.1
(read/write) 428724 428876 152 0.0
.dram0.bss 61744 61904 160 0.3
.dram0.data 32084 32084 0 0.0
.flash.rodata 208732 208724 -8 -0.0
.flash.text 907747 908215 468 0.1
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701656 702160 504 0.1
.bss 78688 78848 160 0.2
.data 1900 1900 0 0.0
.text 615268 615612 344 0.1
lock-app k32w061+debug (read/write) 593612 594116 504 0.1
.bss 69172 69332 160 0.2
.data 1864 1864 0 0.0
.text 516776 517120 344 0.1
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1655073 1658561 3488 0.2
(read/write) 119104 119584 480 0.4
.bss 51376 51888 512 1.0
.data 978 978 0 0.0
.data.rel.ro 61504 61488 -16 -0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 138069 138773 704 0.5
.text 1384738 1387522 2784 0.2
bridge-app debug+rpc (read only) 1283341 1286813 3472 0.3
(read/write) 85160 85640 480 0.6
.bss 51856 52368 512 1.0
.data 976 976 0 0.0
.data.rel.ro 27336 27320 -16 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111044 111780 736 0.7
.text 1076981 1079717 2736 0.3
chip-tool debug (read only) 4266229 4283469 17240 0.4
(read/write) 122176 122688 512 0.4
.bss 17680 18192 512 2.9
.data 1584 1584 0 0.0
.data.rel.ro 97504 97480 -24 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214704 215792 1088 0.5
.text 3788725 3804901 16176 0.4
lighting-app debug+rpc (read only) 1542281 1545721 3440 0.2
(read/write) 102000 102512 512 0.5
.bss 41208 41720 512 1.2
.data 1106 1106 0 0.0
.data.rel.ro 54416 54400 -16 -0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129169 129873 704 0.5
.text 1280658 1283394 2736 0.2
ota-provider-app debug (read only) 1239849 1243289 3440 0.3
(read/write) 67872 68352 480 0.7
.bss 37440 37952 512 1.4
.data 752 752 0 0.0
.data.rel.ro 24584 24568 -16 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111208 111912 704 0.6
.text 1032466 1035202 2736 0.3
ota-requestor-app debug (read only) 1301465 1318609 17144 1.3
(read/write) 76616 77096 480 0.6
.bss 45216 45728 512 1.1
.data 816 816 0 0.0
.data.rel.ro 25464 25432 -32 -0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127424 128608 1184 0.9
.text 1076226 1092210 15984 1.5
shell debug (read only) 787153 787441 288 0.0
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77743 224 0.3
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1792041 17112 1.0
(read/write) 289624 290136 512 0.2
.bss 223280 223792 512 0.2
.data 2032 2032 0 0.0
.data.rel.ro 58672 58656 -16 -0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154488 155640 1152 0.7
.text 1478178 1494162 15984 1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291400 2290168 -1232 -0.1
.bss 180620 180780 160 0.1
.data 5192 5192 0 0.0
.heap 850632 850472 -160 -0.0
.text 1254000 1252768 -1232 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275608 2274440 -1168 -0.1
.bss 172820 172980 160 0.1
.data 5568 5568 0 0.0
.heap 858056 857896 -160 -0.0
.text 1238208 1237040 -1168 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253328 2252160 -1168 -0.1
.bss 171724 171884 160 0.1
.data 5552 5552 0 0.0
.heap 859168 859008 -160 -0.0
.text 1215928 1214760 -1168 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048976 2048976 0 0.0
.bss 156208 156208 0 0.0
.data 4968 4968 0 0.0
.heap 875272 875272 0 0.0
.text 1011576 1011576 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863535 864039 504 0.1
bss 112132 112292 160 0.1
rodata 97816 97808 -8 -0.0
text 577960 578312 352 0.1
nrf52840dk_nrf52840+rpc (read/write) 824363 824867 504 0.1
bss 108372 108532 160 0.1
rodata 88596 88588 -8 -0.0
text 551136 551484 348 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788526 789030 504 0.1
bss 113504 113664 160 0.1
rodata 93056 93048 -8 -0.0
text 507428 507780 352 0.1
lock-app nrf52840dk_nrf52840 (read/write) 840211 840715 504 0.1
bss 111168 111328 160 0.1
rodata 94172 94164 -8 -0.0
text 559444 559796 352 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 765506 766010 504 0.1
bss 112576 112736 160 0.1
rodata 89476 89468 -8 -0.0
text 489004 489356 352 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844911 845415 504 0.1
bss 111304 111464 160 0.1
rodata 95416 95408 -8 -0.0
text 562656 563004 348 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 840199 840687 488 0.1
bss 111200 111360 160 0.1
rodata 94192 94184 -8 -0.0
text 559288 559636 348 0.1
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520236 520236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440848 440848 0 0.0
p6 lock-app default (read/write) 2169744 2170248 504 0.0
.bss 67168 67328 160 0.2
.data 2416 2416 0 0.0
.heap 963760 963600 -160 -0.0
.text 1128008 1128512 504 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491584 360 0.1
(read/write) 114144 114144 0 0.0
.bss 51288 51368 80 0.2
.data 1000 1000 0 0.0
.text 485904 486264 360 0.1
lock-app qpg6100+debug (read only) 467556 467924 368 0.1
(read/write) 114140 114140 0 0.0
.bss 50240 50320 80 0.2
.data 956 956 0 0.0
.text 462236 462604 368 0.1
persistent-storage-app qpg6100+debug (read only) 155236 155236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149916 149916 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665802 600 0.1
bss 69944 70104 160 0.2
noinit 33216 33216 0 0.0
text 458454 458900 446 0.1

@yunhanw-google yunhanw-google force-pushed the feature/update_im_command_messagedef branch 2 times, most recently from 9a74b0e to d89fc4d Compare November 1, 2021 18:07
yufengwangca
yufengwangca approved these changes Nov 1, 2021
View reviewed changes
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
src/app/CommandSender.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11169: Size comparison from 1722625 to d89fc4d

Increases above 0.2%:

platform target config section 1722625e d89fc4d change % change
esp32 all-clusters-app c3devkit .dram0.bss 58424 58584 160 0.3
m5stack .dram0.bss 60920 61080 160 0.3
linux all-clusters-app debug (read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.rodata 137749 138901 1152 0.8
bridge-app debug+rpc (read only) 1279349 1282661 3312 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.rodata 109668 110756 1088 1.0
chip-tool debug (read only) 4313901 4329877 15976 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.rodata 217552 218640 1088 0.5
.text 3830693 3845605 14912 0.4
lighting-app debug+rpc (read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.rodata 127793 128913 1120 0.9
ota-provider-app debug (read only) 1236329 1239705 3376 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.rodata 110056 111208 1152 1.0
ota-requestor-app debug (read only) 1293777 1309561 15784 1.2
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.rodata 121344 122496 1152 0.9
.text 1074642 1089298 14656 1.4
shell debug .rodata 77423 77647 224 0.3
tv-app debug (read only) 1771177 1786961 15784 0.9
.rodata 153048 154200 1152 0.8
.text 1476226 1490882 14656 1.0
Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1722625e d89fc4d change % change
efr32 lighting-app BRD4161A (read only) 735656 736096 440 0.1
(read/write) 114444 114604 160 0.1
.bss 112692 112852 160 0.1
.text 735648 736088 440 0.1
BRD4161A+rpc (read only) 723096 723520 424 0.1
(read/write) 131052 131212 160 0.1
.bss 129196 129356 160 0.1
.text 723088 723512 424 0.1
lock-app BRD4161A (read only) 714940 715364 424 0.1
(read/write) 112260 112420 160 0.1
.bss 110548 110708 160 0.1
.text 714932 715356 424 0.1
window-app BRD4161A (read only) 715852 716276 424 0.1
(read/write) 112584 112744 160 0.1
.bss 110868 111028 160 0.1
.text 715844 716268 424 0.1
esp32 all-clusters-app c3devkit (read only) 880122 880446 324 0.0
(read/write) 1307472 1307624 152 0.0
.dram0.bss 58424 58584 160 0.3
.flash.text 880122 880446 324 0.0
m5stack (read only) 910983 911511 528 0.1
(read/write) 427248 427400 152 0.0
.dram0.bss 60920 61080 160 0.3
.flash.text 910983 911511 528 0.1
k32w lighting-app k32w061+se05x+release (read/write) 698460 698900 440 0.1
.bss 77688 77848 160 0.2
.text 613072 613352 280 0.0
lock-app k32w061+debug (read/write) 590756 591196 440 0.1
.bss 68188 68348 160 0.2
.text 514904 515184 280 0.1
linux all-clusters-app debug (read only) 1684409 1687849 3440 0.2
(read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.rodata 137749 138901 1152 0.8
.text 1413602 1415890 2288 0.2
bridge-app debug+rpc (read only) 1279349 1282661 3312 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.rodata 109668 110756 1088 1.0
.text 1074437 1076661 2224 0.2
chip-tool debug (read only) 4313901 4329877 15976 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.rodata 217552 218640 1088 0.5
.text 3830693 3845605 14912 0.4
lighting-app debug+rpc (read only) 1538289 1541633 3344 0.2
(read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.rodata 127793 128913 1120 0.9
.text 1278114 1280338 2224 0.2
ota-provider-app debug (read only) 1236329 1239705 3376 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.rodata 110056 111208 1152 1.0
.text 1030146 1032370 2224 0.2
ota-requestor-app debug (read only) 1293777 1309561 15784 1.2
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.rodata 121344 122496 1152 0.9
.text 1074642 1089298 14656 1.4
shell debug (read only) 785665 785953 288 0.0
.rodata 77423 77647 224 0.3
.text 606706 606770 64 0.0
tv-app debug (read only) 1771177 1786961 15784 0.9
(read/write) 288536 289048 512 0.2
.bss 222192 222704 512 0.2
.rodata 153048 154200 1152 0.8
.text 1476226 1490882 14656 1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179796 179956 160 0.1
lighting-app CY8CPROTO_062_4343W+release .bss 171836 171996 160 0.1
lock-app CY8CPROTO_062_4343W+release .bss 170740 170900 160 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860399 860855 456 0.1
bss 111148 111308 160 0.1
text 577160 577456 296 0.1
nrf52840dk_nrf52840+rpc (read/write) 821223 821663 440 0.1
bss 107392 107552 160 0.1
text 550336 550628 292 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785426 785882 456 0.1
bss 112524 112684 160 0.1
text 506628 506924 296 0.1
lock-app nrf52840dk_nrf52840 (read/write) 837091 837547 456 0.1
bss 110184 110344 160 0.1
text 558640 558936 296 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762402 762842 440 0.1
bss 111596 111756 160 0.1
text 488200 488496 296 0.1
pump-app nrf52840dk_nrf52840 (read/write) 841779 842219 440 0.1
bss 110320 110480 160 0.1
text 561852 562144 292 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 837083 837539 456 0.1
bss 110220 110380 160 0.1
text 558484 558776 292 0.1
p6 lock-app default (read/write) 2166800 2167240 440 0.0
.bss 66184 66344 160 0.2
.text 1125064 1125504 440 0.0
telink lighting-app tlsr9518adk80d (read/write) 661838 662358 520 0.1
bss 68960 69120 160 0.2
text 457442 457814 372 0.1
Decreases (20 builds for esp32, linux, mbed, nrfconnect, p6)
platform target config section 1722625e d89fc4d change % change
esp32 all-clusters-app c3devkit .flash.rodata 199344 199336 -8 -0.0
m5stack .flash.rodata 208064 208056 -8 -0.0
linux all-clusters-app debug .data.rel.ro 62112 62096 -16 -0.0
bridge-app debug+rpc .data.rel.ro 27368 27352 -16 -0.1
chip-tool debug .data.rel.ro 98880 98856 -24 -0.0
lighting-app debug+rpc .data.rel.ro 54448 54432 -16 -0.0
ota-provider-app debug .data.rel.ro 24616 24600 -16 -0.1
ota-requestor-app debug .data.rel.ro 25576 25544 -32 -0.1
tv-app debug .data.rel.ro 58672 58656 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293672 2292336 -1336 -0.1
.heap 851432 851272 -160 -0.0
.text 1256272 1254936 -1336 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2273112 2271784 -1328 -0.1
.heap 859040 858880 -160 -0.0
.text 1235712 1234384 -1328 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2250768 2249440 -1328 -0.1
.heap 860152 859992 -160 -0.0
.text 1213368 1212040 -1328 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 96472 96464 -8 -0.0
nrf52840dk_nrf52840+rpc rodata 87248 87240 -8 -0.0
nrf5340dk_nrf5340_cpuapp rodata 91716 91708 -8 -0.0
lock-app nrf52840dk_nrf52840 rodata 92828 92820 -8 -0.0
nrf5340dk_nrf5340_cpuapp rodata 88132 88124 -8 -0.0
pump-app nrf52840dk_nrf52840 rodata 94076 94068 -8 -0.0
pump-controller-app nrf52840dk_nrf52840 rodata 92852 92844 -8 -0.0
p6 lock-app default .heap 964744 964584 -160 -0.0
Full report (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1722625e d89fc4d change % change
efr32 lighting-app BRD4161A (read only) 735656 736096 440 0.1
(read/write) 114444 114604 160 0.1
.bss 112692 112852 160 0.1
.data 1752 1752 0 0.0
.text 735648 736088 440 0.1
BRD4161A+rpc (read only) 723096 723520 424 0.1
(read/write) 131052 131212 160 0.1
.bss 129196 129356 160 0.1
.data 1852 1852 0 0.0
.text 723088 723512 424 0.1
lock-app BRD4161A (read only) 714940 715364 424 0.1
(read/write) 112260 112420 160 0.1
.bss 110548 110708 160 0.1
.data 1712 1712 0 0.0
.text 714932 715356 424 0.1
window-app BRD4161A (read only) 715852 716276 424 0.1
(read/write) 112584 112744 160 0.1
.bss 110868 111028 160 0.1
.data 1716 1716 0 0.0
.text 715844 716268 424 0.1
esp32 all-clusters-app c3devkit (read only) 880122 880446 324 0.0
(read/write) 1307472 1307624 152 0.0
.dram0.bss 58424 58584 160 0.3
.dram0.data 16464 16464 0 0.0
.flash.rodata 199344 199336 -8 -0.0
.flash.text 880122 880446 324 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 910983 911511 528 0.1
(read/write) 427248 427400 152 0.0
.dram0.bss 60920 61080 160 0.3
.dram0.data 32100 32100 0 0.0
.flash.rodata 208064 208056 -8 -0.0
.flash.text 910983 911511 528 0.1
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698460 698900 440 0.1
.bss 77688 77848 160 0.2
.data 1900 1900 0 0.0
.text 613072 613352 280 0.0
lock-app k32w061+debug (read/write) 590756 591196 440 0.1
.bss 68188 68348 160 0.2
.data 1864 1864 0 0.0
.text 514904 515184 280 0.1
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1684409 1687849 3440 0.2
(read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62096 -16 -0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137749 138901 1152 0.8
.text 1413602 1415890 2288 0.2
bridge-app debug+rpc (read only) 1279349 1282661 3312 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.data 976 976 0 0.0
.data.rel.ro 27368 27352 -16 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109668 110756 1088 1.0
.text 1074437 1076661 2224 0.2
chip-tool debug (read only) 4313901 4329877 15976 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.data 1584 1584 0 0.0
.data.rel.ro 98880 98856 -24 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217552 218640 1088 0.5
.text 3830693 3845605 14912 0.4
lighting-app debug+rpc (read only) 1538289 1541633 3344 0.2
(read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.data 1106 1106 0 0.0
.data.rel.ro 54448 54432 -16 -0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127793 128913 1120 0.9
.text 1278114 1280338 2224 0.2
ota-provider-app debug (read only) 1236329 1239705 3376 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.data 752 752 0 0.0
.data.rel.ro 24616 24600 -16 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110056 111208 1152 1.0
.text 1030146 1032370 2224 0.2
ota-requestor-app debug (read only) 1293777 1309561 15784 1.2
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.data 816 816 0 0.0
.data.rel.ro 25576 25544 -32 -0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121344 122496 1152 0.9
.text 1074642 1089298 14656 1.4
shell debug (read only) 785665 785953 288 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77647 224 0.3
.text 606706 606770 64 0.0
tv-app debug (read only) 1771177 1786961 15784 0.9
(read/write) 288536 289048 512 0.2
.bss 222192 222704 512 0.2
.data 2032 2032 0 0.0
.data.rel.ro 58672 58656 -16 -0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153048 154200 1152 0.8
.text 1476226 1490882 14656 1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293672 2292336 -1336 -0.1
.bss 179796 179956 160 0.1
.data 5216 5216 0 0.0
.heap 851432 851272 -160 -0.0
.text 1256272 1254936 -1336 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273112 2271784 -1328 -0.1
.bss 171836 171996 160 0.1
.data 5568 5568 0 0.0
.heap 859040 858880 -160 -0.0
.text 1235712 1234384 -1328 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250768 2249440 -1328 -0.1
.bss 170740 170900 160 0.1
.data 5552 5552 0 0.0
.heap 860152 859992 -160 -0.0
.text 1213368 1212040 -1328 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048592 2048592 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011192 1011192 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860399 860855 456 0.1
bss 111148 111308 160 0.1
rodata 96472 96464 -8 -0.0
text 577160 577456 296 0.1
nrf52840dk_nrf52840+rpc (read/write) 821223 821663 440 0.1
bss 107392 107552 160 0.1
rodata 87248 87240 -8 -0.0
text 550336 550628 292 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785426 785882 456 0.1
bss 112524 112684 160 0.1
rodata 91716 91708 -8 -0.0
text 506628 506924 296 0.1
lock-app nrf52840dk_nrf52840 (read/write) 837091 837547 456 0.1
bss 110184 110344 160 0.1
rodata 92828 92820 -8 -0.0
text 558640 558936 296 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762402 762842 440 0.1
bss 111596 111756 160 0.1
rodata 88132 88124 -8 -0.0
text 488200 488496 296 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841779 842219 440 0.1
bss 110320 110480 160 0.1
rodata 94076 94068 -8 -0.0
text 561852 562144 292 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 837083 837539 456 0.1
bss 110220 110380 160 0.1
rodata 92852 92844 -8 -0.0
text 558484 558776 292 0.1
shell nrf52840dk_nrf52840 (read/write) 776099 776099 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519868 519868 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691122 691122 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440476 440476 0 0.0
p6 lock-app default (read/write) 2166800 2167240 440 0.0
.bss 66184 66344 160 0.2
.data 2416 2416 0 0.0
.heap 964744 964584 -160 -0.0
.text 1125064 1125504 440 0.0
telink lighting-app tlsr9518adk80d (read/write) 661838 662358 520 0.1
bss 68960 69120 160 0.2
noinit 33216 33216 0 0.0
text 457442 457814 372 0.1

@yunhanw-google yunhanw-google force-pushed the feature/update_im_command_messagedef branch from d89fc4d to 04f017e Compare November 2, 2021 02:30
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11169: Size comparison from 2fe9024 to 04f017e

Increases above 0.2%:

platform target config section 2fe9024 04f017e change % change
linux all-clusters-app debug (read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.rodata 137749 138901 1152 0.8
bridge-app debug+rpc (read only) 1278437 1281669 3232 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.rodata 109508 110596 1088 1.0
chip-tool debug (read only) 4312861 4329301 16440 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.rodata 217424 218512 1088 0.5
.text 3829781 3845157 15376 0.4
lighting-app debug+rpc (read only) 1537409 1540641 3232 0.2
(read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.rodata 127665 128753 1088 0.9
ota-provider-app debug (read only) 1236329 1239593 3264 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.rodata 110280 111400 1120 1.0
.text 1029922 1032066 2144 0.2
ota-requestor-app debug (read only) 1293601 1309849 16248 1.3
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.rodata 121504 122656 1152 0.9
.text 1074306 1089426 15120 1.4
shell debug .rodata 77295 77519 224 0.3
tv-app debug (read only) 1770809 1787057 16248 0.9
.bss 222192 222704 512 0.2
.rodata 153080 154232 1152 0.8
.text 1475826 1490946 15120 1.0
Increases (18 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 2fe9024 04f017e change % change
efr32 lighting-app BRD4161A (read only) 735380 735976 596 0.1
(read/write) 114444 114604 160 0.1
.bss 112692 112852 160 0.1
.text 735372 735968 596 0.1
BRD4161A+rpc (read only) 722820 723400 580 0.1
(read/write) 131048 131212 164 0.1
.bss 129196 129356 160 0.1
.text 722812 723392 580 0.1
lock-app BRD4161A (read only) 714664 715256 592 0.1
(read/write) 112260 112420 160 0.1
.bss 110548 110708 160 0.1
.text 714656 715248 592 0.1
window-app BRD4161A (read only) 715576 716172 596 0.1
(read/write) 112588 112744 156 0.1
.bss 110868 111028 160 0.1
.text 715568 716164 596 0.1
k32w lighting-app k32w061+se05x+release (read/write) 698212 698812 600 0.1
.bss 77688 77848 160 0.2
.text 612824 613264 440 0.1
lock-app k32w061+debug (read/write) 590508 591108 600 0.1
.bss 68188 68348 160 0.2
.text 514656 515096 440 0.1
linux all-clusters-app debug (read only) 1684009 1687353 3344 0.2
(read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.rodata 137749 138901 1152 0.8
.text 1413202 1415394 2192 0.2
bridge-app debug+rpc (read only) 1278437 1281669 3232 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.rodata 109508 110596 1088 1.0
.text 1073685 1075829 2144 0.2
chip-tool debug (read only) 4312861 4329301 16440 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.rodata 217424 218512 1088 0.5
.text 3829781 3845157 15376 0.4
lighting-app debug+rpc (read only) 1537409 1540641 3232 0.2
(read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.rodata 127665 128753 1088 0.9
.text 1277362 1279506 2144 0.2
ota-provider-app debug (read only) 1236329 1239593 3264 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.rodata 110280 111400 1120 1.0
.text 1029922 1032066 2144 0.2
ota-requestor-app debug (read only) 1293601 1309849 16248 1.3
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.rodata 121504 122656 1152 0.9
.text 1074306 1089426 15120 1.4
shell debug (read only) 785041 785329 288 0.0
.rodata 77295 77519 224 0.3
.text 606210 606274 64 0.0
tv-app debug (read only) 1770809 1787057 16248 0.9
(read/write) 288536 289048 512 0.2
.bss 222192 222704 512 0.2
.rodata 153080 154232 1152 0.8
.text 1475826 1490946 15120 1.0
p6 lock-app default (read/write) 2166544 2167112 568 0.0
.bss 66184 66344 160 0.2
.text 1124808 1125376 568 0.1
qpg lighting-app qpg6100+debug (read only) 489664 490104 440 0.1
.bss 50320 50400 80 0.2
.text 484344 484784 440 0.1
lock-app qpg6100+debug (read only) 465992 466428 436 0.1
.bss 49272 49352 80 0.2
.text 460672 461108 436 0.1
telink lighting-app tlsr9518adk80d (read/write) 661586 662210 624 0.1
bss 68960 69120 160 0.2
text 457328 457754 426 0.1
Decreases (8 builds for linux, p6)
platform target config section 2fe9024 04f017e change % change
linux all-clusters-app debug .data.rel.ro 62112 62096 -16 -0.0
bridge-app debug+rpc .data.rel.ro 27368 27352 -16 -0.1
chip-tool debug .data.rel.ro 98880 98856 -24 -0.0
lighting-app debug+rpc .data.rel.ro 54448 54432 -16 -0.0
ota-provider-app debug .data.rel.ro 24616 24600 -16 -0.1
ota-requestor-app debug .data.rel.ro 25576 25544 -32 -0.1
tv-app debug .data.rel.ro 58672 58656 -16 -0.0
p6 lock-app default .heap 964744 964584 -160 -0.0
Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 2fe9024 04f017e change % change
efr32 lighting-app BRD4161A (read only) 735380 735976 596 0.1
(read/write) 114444 114604 160 0.1
.bss 112692 112852 160 0.1
.data 1752 1752 0 0.0
.text 735372 735968 596 0.1
BRD4161A+rpc (read only) 722820 723400 580 0.1
(read/write) 131048 131212 164 0.1
.bss 129196 129356 160 0.1
.data 1852 1852 0 0.0
.text 722812 723392 580 0.1
lock-app BRD4161A (read only) 714664 715256 592 0.1
(read/write) 112260 112420 160 0.1
.bss 110548 110708 160 0.1
.data 1712 1712 0 0.0
.text 714656 715248 592 0.1
window-app BRD4161A (read only) 715576 716172 596 0.1
(read/write) 112588 112744 156 0.1
.bss 110868 111028 160 0.1
.data 1716 1716 0 0.0
.text 715568 716164 596 0.1
k32w lighting-app k32w061+se05x+release (read/write) 698212 698812 600 0.1
.bss 77688 77848 160 0.2
.data 1900 1900 0 0.0
.text 612824 613264 440 0.1
lock-app k32w061+debug (read/write) 590508 591108 600 0.1
.bss 68188 68348 160 0.2
.data 1864 1864 0 0.0
.text 514656 515096 440 0.1
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
linux all-clusters-app debug (read only) 1684009 1687353 3344 0.2
(read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62096 -16 -0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137749 138901 1152 0.8
.text 1413202 1415394 2192 0.2
bridge-app debug+rpc (read only) 1278437 1281669 3232 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.data 976 976 0 0.0
.data.rel.ro 27368 27352 -16 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109508 110596 1088 1.0
.text 1073685 1075829 2144 0.2
chip-tool debug (read only) 4312861 4329301 16440 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.data 1584 1584 0 0.0
.data.rel.ro 98880 98856 -24 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217424 218512 1088 0.5
.text 3829781 3845157 15376 0.4
lighting-app debug+rpc (read only) 1537409 1540641 3232 0.2
(read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.data 1106 1106 0 0.0
.data.rel.ro 54448 54432 -16 -0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127665 128753 1088 0.9
.text 1277362 1279506 2144 0.2
ota-provider-app debug (read only) 1236329 1239593 3264 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.data 752 752 0 0.0
.data.rel.ro 24616 24600 -16 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110280 111400 1120 1.0
.text 1029922 1032066 2144 0.2
ota-requestor-app debug (read only) 1293601 1309849 16248 1.3
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.data 816 816 0 0.0
.data.rel.ro 25576 25544 -32 -0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121504 122656 1152 0.9
.text 1074306 1089426 15120 1.4
shell debug (read only) 785041 785329 288 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77295 77519 224 0.3
.text 606210 606274 64 0.0
tv-app debug (read only) 1770809 1787057 16248 0.9
(read/write) 288536 289048 512 0.2
.bss 222192 222704 512 0.2
.data 2032 2032 0 0.0
.data.rel.ro 58672 58656 -16 -0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153080 154232 1152 0.8
.text 1475826 1490946 15120 1.0
p6 lock-app default (read/write) 2166544 2167112 568 0.0
.bss 66184 66344 160 0.2
.data 2416 2416 0 0.0
.heap 964744 964584 -160 -0.0
.text 1124808 1125376 568 0.1
qpg lighting-app qpg6100+debug (read only) 489664 490104 440 0.1
(read/write) 114144 114144 0 0.0
.bss 50320 50400 80 0.2
.data 1000 1000 0 0.0
.text 484344 484784 440 0.1
lock-app qpg6100+debug (read only) 465992 466428 436 0.1
(read/write) 114140 114140 0 0.0
.bss 49272 49352 80 0.2
.data 956 956 0 0.0
.text 460672 461108 436 0.1
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 662210 624 0.1
bss 68960 69120 160 0.2
noinit 33216 33216 0 0.0
text 457328 457754 426 0.1

@yunhanw-google yunhanw-google force-pushed the feature/update_im_command_messagedef branch from 04f017e to 04b297d Compare November 2, 2021 03:10
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11169: Size comparison from 12ec702 to 04b297d

Increases above 0.2%:

platform target config section 12ec702 04b297d change % change
esp32 all-clusters-app c3devkit .dram0.bss 58424 58584 160 0.3
m5stack .dram0.bss 60920 61080 160 0.3
linux all-clusters-app debug (read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.rodata 137845 138997 1152 0.8
bridge-app debug+rpc (read only) 1278533 1281797 3264 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.rodata 109604 110724 1120 1.0
chip-tool debug (read only) 4312925 4329397 16472 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.rodata 217488 218608 1120 0.5
.text 3829781 3845157 15376 0.4
lighting-app debug+rpc (read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.rodata 127761 128849 1088 0.9
ota-provider-app debug (read only) 1236425 1239689 3264 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.rodata 110376 111496 1120 1.0
ota-requestor-app debug (read only) 1293697 1309945 16248 1.3
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.rodata 121600 122752 1152 0.9
.text 1074306 1089426 15120 1.4
shell debug .rodata 77295 77519 224 0.3
tv-app debug (read only) 1770905 1787153 16248 0.9
.rodata 153176 154328 1152 0.8
.text 1475826 1490946 15120 1.0
Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ec702 04b297d change % change
efr32 lighting-app BRD4161A (read only) 735400 735996 596 0.1
(read/write) 114444 114604 160 0.1
.bss 112692 112852 160 0.1
.text 735392 735988 596 0.1
BRD4161A+rpc (read only) 722840 723420 580 0.1
(read/write) 131052 131208 156 0.1
.bss 129196 129356 160 0.1
.text 722832 723412 580 0.1
lock-app BRD4161A (read only) 714684 715276 592 0.1
(read/write) 112260 112420 160 0.1
.bss 110548 110708 160 0.1
.text 714676 715268 592 0.1
window-app BRD4161A (read only) 715596 716192 596 0.1
(read/write) 112584 112748 164 0.1
.bss 110868 111028 160 0.1
.text 715588 716184 596 0.1
esp32 all-clusters-app c3devkit (read only) 880170 880546 376 0.0
(read/write) 1307552 1307792 240 0.0
.dram0.bss 58424 58584 160 0.3
.flash.rodata 199424 199504 80 0.0
.flash.text 880170 880546 376 0.0
m5stack (read only) 911115 911531 416 0.0
(read/write) 427312 427552 240 0.1
.dram0.bss 60920 61080 160 0.3
.flash.rodata 208128 208208 80 0.0
.flash.text 911115 911531 416 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698232 698832 600 0.1
.bss 77688 77848 160 0.2
.text 612844 613284 440 0.1
lock-app k32w061+debug (read/write) 590524 591124 600 0.1
.bss 68188 68348 160 0.2
.text 514672 515112 440 0.1
linux all-clusters-app debug (read only) 1684105 1687449 3344 0.2
(read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.rodata 137845 138997 1152 0.8
.text 1413202 1415394 2192 0.2
bridge-app debug+rpc (read only) 1278533 1281797 3264 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.rodata 109604 110724 1120 1.0
.text 1073685 1075829 2144 0.2
chip-tool debug (read only) 4312925 4329397 16472 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.rodata 217488 218608 1120 0.5
.text 3829781 3845157 15376 0.4
lighting-app debug+rpc (read only) 1537505 1540737 3232 0.2
(read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.rodata 127761 128849 1088 0.9
.text 1277362 1279506 2144 0.2
ota-provider-app debug (read only) 1236425 1239689 3264 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.rodata 110376 111496 1120 1.0
.text 1029922 1032066 2144 0.2
ota-requestor-app debug (read only) 1293697 1309945 16248 1.3
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.rodata 121600 122752 1152 0.9
.text 1074306 1089426 15120 1.4
shell debug (read only) 785041 785329 288 0.0
.rodata 77295 77519 224 0.3
.text 606210 606274 64 0.0
tv-app debug (read only) 1770905 1787153 16248 0.9
(read/write) 288536 289048 512 0.2
.bss 222192 222704 512 0.2
.rodata 153176 154328 1152 0.8
.text 1475826 1490946 15120 1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179796 179956 160 0.1
lighting-app CY8CPROTO_062_4343W+release .bss 171836 171996 160 0.1
lock-app CY8CPROTO_062_4343W+release .bss 170740 170900 160 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860175 860727 552 0.1
bss 111148 111308 160 0.1
rodata 96360 96400 40 0.0
text 577052 577396 344 0.1
nrf52840dk_nrf52840+rpc (read/write) 820999 821551 552 0.1
bss 107392 107552 160 0.1
rodata 87136 87176 40 0.0
text 550224 550572 348 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785218 785754 536 0.1
bss 112524 112684 160 0.1
rodata 91604 91644 40 0.0
text 506520 506864 344 0.1
lock-app nrf52840dk_nrf52840 (read/write) 836883 837419 536 0.1
bss 110184 110344 160 0.1
rodata 92716 92756 40 0.0
text 558532 558876 344 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762178 762730 552 0.1
bss 111596 111756 160 0.1
rodata 88020 88060 40 0.0
text 488092 488436 344 0.1
pump-app nrf52840dk_nrf52840 (read/write) 842863 843415 552 0.1
bss 110320 110480 160 0.1
rodata 94424 94464 40 0.0
text 562588 562936 348 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 836739 837275 536 0.1
bss 110220 110380 160 0.1
rodata 92716 92756 40 0.0
text 558268 558612 344 0.1
p6 lock-app default (read/write) 2166560 2167136 576 0.0
.bss 66184 66344 160 0.2
.text 1124824 1125400 576 0.1
qpg lighting-app qpg6100+debug (read only) 489680 490120 440 0.1
.bss 50320 50400 80 0.2
.text 484360 484800 440 0.1
lock-app qpg6100+debug (read only) 466008 466444 436 0.1
.bss 49272 49352 80 0.2
.text 460688 461124 436 0.1
telink lighting-app tlsr9518adk80d (read/write) 661606 662230 624 0.1
bss 68960 69120 160 0.2
text 457328 457754 426 0.1
Decreases (11 builds for linux, mbed, p6)
platform target config section 12ec702 04b297d change % change
linux all-clusters-app debug .data.rel.ro 62112 62096 -16 -0.0
bridge-app debug+rpc .data.rel.ro 27368 27352 -16 -0.1
chip-tool debug .data.rel.ro 98880 98856 -24 -0.0
lighting-app debug+rpc .data.rel.ro 54448 54432 -16 -0.0
ota-provider-app debug .data.rel.ro 24616 24600 -16 -0.1
ota-requestor-app debug .data.rel.ro 25576 25544 -32 -0.1
tv-app debug .data.rel.ro 58672 58656 -16 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293608 2292272 -1336 -0.1
.heap 851432 851272 -160 -0.0
.text 1256208 1254872 -1336 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272736 2271344 -1392 -0.1
.heap 859040 858880 -160 -0.0
.text 1235336 1233944 -1392 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2250392 2249064 -1328 -0.1
.heap 860152 859992 -160 -0.0
.text 1212992 1211664 -1328 -0.1
p6 lock-app default .heap 964744 964584 -160 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ec702 04b297d change % change
efr32 lighting-app BRD4161A (read only) 735400 735996 596 0.1
(read/write) 114444 114604 160 0.1
.bss 112692 112852 160 0.1
.data 1752 1752 0 0.0
.text 735392 735988 596 0.1
BRD4161A+rpc (read only) 722840 723420 580 0.1
(read/write) 131052 131208 156 0.1
.bss 129196 129356 160 0.1
.data 1852 1852 0 0.0
.text 722832 723412 580 0.1
lock-app BRD4161A (read only) 714684 715276 592 0.1
(read/write) 112260 112420 160 0.1
.bss 110548 110708 160 0.1
.data 1712 1712 0 0.0
.text 714676 715268 592 0.1
window-app BRD4161A (read only) 715596 716192 596 0.1
(read/write) 112584 112748 164 0.1
.bss 110868 111028 160 0.1
.data 1716 1716 0 0.0
.text 715588 716184 596 0.1
esp32 all-clusters-app c3devkit (read only) 880170 880546 376 0.0
(read/write) 1307552 1307792 240 0.0
.dram0.bss 58424 58584 160 0.3
.dram0.data 16464 16464 0 0.0
.flash.rodata 199424 199504 80 0.0
.flash.text 880170 880546 376 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911115 911531 416 0.0
(read/write) 427312 427552 240 0.1
.dram0.bss 60920 61080 160 0.3
.dram0.data 32100 32100 0 0.0
.flash.rodata 208128 208208 80 0.0
.flash.text 911115 911531 416 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698232 698832 600 0.1
.bss 77688 77848 160 0.2
.data 1900 1900 0 0.0
.text 612844 613284 440 0.1
lock-app k32w061+debug (read/write) 590524 591124 600 0.1
.bss 68188 68348 160 0.2
.data 1864 1864 0 0.0
.text 514672 515112 440 0.1
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
linux all-clusters-app debug (read only) 1684105 1687449 3344 0.2
(read/write) 118992 119472 480 0.4
.bss 50608 51120 512 1.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62096 -16 -0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137845 138997 1152 0.8
.text 1413202 1415394 2192 0.2
bridge-app debug+rpc (read only) 1278533 1281797 3264 0.3
(read/write) 84104 84584 480 0.6
.bss 50768 51280 512 1.0
.data 976 976 0 0.0
.data.rel.ro 27368 27352 -16 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109604 110724 1120 1.0
.text 1073685 1075829 2144 0.2
chip-tool debug (read only) 4312925 4329397 16472 0.4
(read/write) 123552 124064 512 0.4
.bss 17680 18192 512 2.9
.data 1584 1584 0 0.0
.data.rel.ro 98880 98856 -24 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217488 218608 1120 0.5
.text 3829781 3845157 15376 0.4
lighting-app debug+rpc (read only) 1537505 1540737 3232 0.2
(read/write) 100976 101488 512 0.5
.bss 40152 40664 512 1.3
.data 1106 1106 0 0.0
.data.rel.ro 54448 54432 -16 -0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127761 128849 1088 0.9
.text 1277362 1279506 2144 0.2
ota-provider-app debug (read only) 1236425 1239689 3264 0.3
(read/write) 67072 67552 480 0.7
.bss 36608 37120 512 1.4
.data 752 752 0 0.0
.data.rel.ro 24616 24600 -16 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110376 111496 1120 1.0
.text 1029922 1032066 2144 0.2
ota-requestor-app debug (read only) 1293697 1309945 16248 1.3
(read/write) 76392 76872 480 0.6
.bss 44864 45376 512 1.1
.data 816 816 0 0.0
.data.rel.ro 25576 25544 -32 -0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121600 122752 1152 0.9
.text 1074306 1089426 15120 1.4
shell debug (read only) 785041 785329 288 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77295 77519 224 0.3
.text 606210 606274 64 0.0
tv-app debug (read only) 1770905 1787153 16248 0.9
(read/write) 288536 289048 512 0.2
.bss 222192 222704 512 0.2
.data 2032 2032 0 0.0
.data.rel.ro 58672 58656 -16 -0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153176 154328 1152 0.8
.text 1475826 1490946 15120 1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293608 2292272 -1336 -0.1
.bss 179796 179956 160 0.1
.data 5216 5216 0 0.0
.heap 851432 851272 -160 -0.0
.text 1256208 1254872 -1336 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272736 2271344 -1392 -0.1
.bss 171836 171996 160 0.1
.data 5568 5568 0 0.0
.heap 859040 858880 -160 -0.0
.text 1235336 1233944 -1392 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250392 2249064 -1328 -0.1
.bss 170740 170900 160 0.1
.data 5552 5552 0 0.0
.heap 860152 859992 -160 -0.0
.text 1212992 1211664 -1328 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048328 2048328 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1010928 1010928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860175 860727 552 0.1
bss 111148 111308 160 0.1
rodata 96360 96400 40 0.0
text 577052 577396 344 0.1
nrf52840dk_nrf52840+rpc (read/write) 820999 821551 552 0.1
bss 107392 107552 160 0.1
rodata 87136 87176 40 0.0
text 550224 550572 348 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785218 785754 536 0.1
bss 112524 112684 160 0.1
rodata 91604 91644 40 0.0
text 506520 506864 344 0.1
lock-app nrf52840dk_nrf52840 (read/write) 836883 837419 536 0.1
bss 110184 110344 160 0.1
rodata 92716 92756 40 0.0
text 558532 558876 344 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 762178 762730 552 0.1
bss 111596 111756 160 0.1
rodata 88020 88060 40 0.0
text 488092 488436 344 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842863 843415 552 0.1
bss 110320 110480 160 0.1
rodata 94424 94464 40 0.0
text 562588 562936 348 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 836739 837275 536 0.1
bss 110220 110380 160 0.1
rodata 92716 92756 40 0.0
text 558268 558612 344 0.1
shell nrf52840dk_nrf52840 (read/write) 775903 775903 0 0.0
bss 109096 109096 0 0.0
rodata 72404 72404 0 0.0
text 519792 519792 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690906 690906 0 0.0
bss 110080 110080 0 0.0
rodata 67044 67044 0 0.0
text 440400 440400 0 0.0
p6 lock-app default (read/write) 2166560 2167136 576 0.0
.bss 66184 66344 160 0.2
.data 2416 2416 0 0.0
.heap 964744 964584 -160 -0.0
.text 1124824 1125400 576 0.1
qpg lighting-app qpg6100+debug (read only) 489680 490120 440 0.1
(read/write) 114144 114144 0 0.0
.bss 50320 50400 80 0.2
.data 1000 1000 0 0.0
.text 484360 484800 440 0.1
lock-app qpg6100+debug (read only) 466008 466444 436 0.1
(read/write) 114140 114140 0 0.0
.bss 49272 49352 80 0.2
.data 956 956 0 0.0
.text 460688 461124 436 0.1
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661606 662230 624 0.1
bss 68960 69120 160 0.2
noinit 33216 33216 0 0.0
text 457328 457754 426 0.1

@woody-apple
Copy link
Contributor

Fast tracking, given this has had enough time to get reviews.

@woody-apple woody-apple merged commit 36e61e3 into project-chip:master Nov 2, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yunhanw-google
Refresh IM Invoke encoding with latest spec (project-chip#11169)
1a137d7
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @woody-apple @yufengwangca