Multiple IP address support in ResolvedNodeData structure and cache #11149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added expiry time to ResolvedNodeId, which the resolvers should set as appropriate from the TTL. Using ResolvedNodeData for the DNS-SD cache directly means we don't need to copy everything over, which is becoming more cumbersome as we add support for more addresses. Also change test to use test time structure.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda and
mlepage-google
Maintaining size for darwin, linux and android, other have the cache size called out explicitly in the platform config so the platform maintainers can set this as appropriate.
|
PR #11149: Size comparison from eddd4f7 to 2ebc4fa Increases above 0.2%:
Increases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg)
Decreases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 2, 2021
andy31415
approved these changes
Nov 4, 2021
yunhanw-google
approved these changes
Nov 8, 2021
Damian-Nordic
approved these changes
Nov 9, 2021
|
@cecille Can you resolve the conflicts? Should be able to get this in then! |
…tiple_addresses Includes changes to previous code to deal with clock changes.
|
PR #11149: Size comparison from 613f27f to e195b11 Increases above 0.2%:
Increases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg)
Decreases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
This is rebased now. If we're happy to continue the discussion on the linked issue, I think we can resolve the conversation from earlier and put this in. |
This was referenced Nov 11, 2021
Closed
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…roject-chip#11149) * Add multiple addresses to ResolvedNodeData * Use ResolvedNodeData directly for cache. Added expiry time to ResolvedNodeId, which the resolvers should set as appropriate from the TTL. Using ResolvedNodeData for the DNS-SD cache directly means we don't need to copy everything over, which is becoming more cumbersome as we add support for more addresses. Also change test to use test time structure. * Update src/lib/dnssd/DnssdCache.h Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments. * Reduce mdns cache size for platforms. Maintaining size for darwin, linux and android, other have the cache size called out explicitly in the platform config so the platform maintainers can set this as appropriate. * Restyled by whitespace Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Two(ish) related issues (in two commits)
Change overview
Not yet done - any time of multiple address support in device or session layers
Testing
Cache tests cover cache changes, operational addresses covered by cirque tests. Also tested manually.