Use System::Clock::Timeout for ExchangeContext::Timeout

[kpschoedel]

Problem

Code uses plain integers to represent time values and relies on
users to get the unit scale correct.

Part of #10062 Some operations on System::Clock types are not safe

Change overview

Change ExchangeContext::Timeout and affected code.

Testing

CI; no change to functionality intended.

[github-actions]

PR #10846: Size comparison from 0c16976 to c73ef64

16 builds (for k32w, linux, p6, qpg, telink)

platform	target	config	section	0c16976	c73ef64	change	% change
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	516068	516100	32	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	359544	359556	12	0.0
	lighting-app	k32w061+se05x+release	.bss	78592	78592	0	0.0
			.data	1900	1900	0	0.0
			.text	614836	614868	32	0.0
linux	all-clusters-app	debug	.bss	52208	52208	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	60384	60384	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136405	136405	0	0.0
			.text	1352290	1352514	224	0.0
	chip-tool	debug	.bss	17712	17712	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	93504	93504	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	193860	193860	0	0.0
			.text	3502693	3503573	880	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110248	110280	32	0.0
			.text	1022226	1022450	224	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	25800	25800	0	0.0
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128392	128392	0	0.0
			.text	1140786	1141010	224	0.0
	shell	debug	.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76463	76463	0	0.0
			.text	597346	597570	224	0.0
	tv-app	debug	.bss	216592	216592	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	57408	57408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152904	152904	0	0.0
			.text	1452706	1452946	240	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27112	27112	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110748	110764	16	0.0
			.text	1063173	1063397	224	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53808	53808	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127921	127921	0	0.0
			.text	1261170	1261394	224	0.0
p6	lock-app	default	.bss	68216	68216	0	0.0
			.data	2416	2416	0	0.0
			.heap	962712	962712	0	0.0
			.text	1126688	1126712	24	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	1004	1004	0	0.0
			.text	485972	486012	40	0.0
	lock-app	qpg6100+debug	.bss	52496	52496	0	0.0
			.data	960	960	0	0.0
			.text	462060	462092	32	0.0
	persistent-storage-app	qpg6100+debug	.bss	27840	27840	0	0.0
			.data	372	372	0	0.0
			.text	149896	149896	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70996	70996	0	0.0
			noinit	33216	33216	0	0.0
			text	457630	457640	10	0.0

6 builds (for efr32, mbed)

platform	target	config	section	0c16976	c73ef64	change	% change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0	0.0
			.data	1800	1800	0	0.0
			.text	784328	784364	36	0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	763456	763484	28	0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	764380	764400	20	0.0
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0	0.0
			.data	1852	1852	0	0.0
			.text	764028	764056	28	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172100	172100	0	0.0
			.data	5464	5464	0	0.0
			.heap	858880	858880	0	0.0
			.text	1220088	1220104	16	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171020	171020	0	0.0
			.data	5432	5432	0	0.0
			.heap	859992	859992	0	0.0
			.text	1197984	1198000	16	0.0

12 builds (for esp32, nrfconnect)

platform	target	config	section	0c16976	c73ef64	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0	0.0
			.dram0.data	16440	16456	16	0.1
			.flash.rodata	199864	199864	0	0.0
			.flash.text	874330	874326	-4	-0.0
			.iram0.text	57564	57564	0	0.0
		m5stack	.dram0.bss	62800	62800	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	208600	208616	16	0.0
			.flash.text	905263	905279	16	0.0
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113176	113176	0	0.0
			rodata	98076	98092	16	0.0
			text	577104	577120	16	0.0
	lock-app	nrf52840dk_nrf52840	bss	112244	112244	0	0.0
			rodata	94412	94428	16	0.0
			text	558592	558608	16	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	112312	112312	0	0.0
			rodata	95396	95412	16	0.0
			text	561744	561764	20	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	112252	112252	0	0.0
			rodata	94472	94488	16	0.0
			text	558384	558400	16	0.0
	shell	nrf52840dk_nrf52840	bss	109072	109072	0	0.0
			rodata	72524	72536	12	0.0
			text	520208	520224	16	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109420	109420	0	0.0
			rodata	88856	88872	16	0.0
			text	550296	550312	16	0.0
		nrf5340dk_nrf5340_cpuapp	bss	114552	114552	0	0.0
			rodata	93316	93332	16	0.0
			text	506572	506592	20	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113616	113616	0	0.0
			rodata	89672	89688	16	0.0
			text	488056	488072	16	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056	0	0.0
			rodata	67168	67180	12	0.0
			text	440816	440832	16	0.0

[woody-apple]

@mspang @andy31415 @Damian-Nordic ?