-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out cloudbuild 'all' vs smoke test (smaller build subset). #10719
Merged
+135
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows cloudbuild to selectively 'build evetyhing' vs a smaller subset. Smaller subset (smoke test) allows for: - less chances for failed builds due to new platforms being added - faster builds because not taking into account as many platform and build variations (like ipv6 or rpc) Build all is still available for scheduled builds
andy31415
changed the title
Separatte out cloudbuild 'all' vs smoke test (smaller build subset).
Separate out cloudbuild 'all' vs smoke test (smaller build subset).
Oct 20, 2021
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk and
sagar-apple
October 20, 2021 18:16
pullapprove
bot
requested review from
saurabhst,
shana-apple,
turon,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
October 20, 2021 18:16
PR #10719: Size comparison from e865f1d to 8979297 8 builds (for k32w, p6, qpg, telink)
14 builds (for efr32, linux, mbed)
12 builds (for esp32, nrfconnect)
|
bzbarsky-apple
approved these changes
Oct 20, 2021
msandstedt
approved these changes
Oct 21, 2021
saurabhst
approved these changes
Oct 21, 2021
tcarmelveilleux
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cloudbuild is slow (nearing 2h) and easily fails on new platform additions (e.g. AmebaD recently).
This allows cloudbuild to selectively 'build evetyhing' vs a smaller
subset. Smaller subset (smoke test) allows for:
and build variations (like ipv6 or rpc)
Build all is still available for scheduled builds
Change overview
Have both smoke and build-all yamls for cloudbuild
Testing
Tested locally using: