-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TE7]:Support read attribute with complex type for general diagnostic cluster #10641
[TE7]:Support read attribute with complex type for general diagnostic cluster #10641
Conversation
PR #10641: Size comparison from 551e53f to e0807c2 Increases (20 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
Decreases (2 builds for esp32, telink)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Size increase report for "gn_qpg-example-build" from 551e53f
Full report output
|
src/app/clusters/general_diagnostics_server/general_diagnostics_server.cpp
Outdated
Show resolved
Hide resolved
/rebase |
1 similar comment
/rebase |
PR #10641: Size comparison from a449d18 to 7d126dc Increases (3 builds for k32w, p6, telink)
Decreases (1 build for telink)
Full report (8 builds for k32w, p6, qpg, telink)
|
/rebase |
PR #10641: Size comparison from 4e2eeab to 2c6c0f7 Increases (19 builds for efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (2 builds for esp32, telink)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Size increase report for "esp32-example-build" from 4e2eeab
Full report output
|
Size increase report for "nrfconnect-example-build" from 4e2eeab
Full report output
|
PR #10641: Size comparison from 837bd28 to 672017b Increases above 0.2%:
Increases (11 builds for efr32, esp32, linux, p6, telink)
Decreases (3 builds for esp32, telink)
Full report (26 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
src/app/clusters/general_diagnostics_server/general_diagnostics_server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general_diagnostics_server/general_diagnostics_server.cpp
Outdated
Show resolved
Hide resolved
PR #10641: Size comparison from 837bd28 to ede9273 Increases above 0.2%:
Increases (15 builds for esp32, linux, mbed, p6)
Decreases (19 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (26 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
PR #10641: Size comparison from cb5818f to 9c003dd Increases above 0.2%:
Increases (23 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
… cluster (project-chip#10641) * Support read attribute with complex type for general diagnostic cluster * Update src/app/clusters/general_diagnostics_server/general_diagnostics_server.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Encode an empty list if GetNetworkInterfaces fails Co-authored-by: Boris Zbarsky <[email protected]>
… cluster (project-chip#10641) * Support read attribute with complex type for general diagnostic cluster * Update src/app/clusters/general_diagnostics_server/general_diagnostics_server.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Encode an empty list if GetNetworkInterfaces fails Co-authored-by: Boris Zbarsky <[email protected]>
Problem
What is being fixed? Examples:
Change overview
Support read attribute with complex type for general diagnostic cluster
Please note, this PR contains the platform change in #10622.
Testing
How was this tested? (at least one bullet point required)