-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange code in InetInterface #10502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Code for different Inet implementations is scattered across many `#if`s. #### Change overview - Groups code by implementation. - Moves doxygen comments to the header. Since comparing moved code in diff format is difficult, this change explicitly does NOT make any changes to function bodies, with one exception: incorporating the CloseIOSocket() bug fix from PR#10452 to avoid conflicts. This is a step toward project-chip#7715 _Virtualize System and Inet interfaces_. #### Testing CI; no change to functionality.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
vivien-apple
October 14, 2021 15:06
pullapprove
bot
requested review from
wbschiller,
woody-apple and
yufengwangca
October 14, 2021 15:06
andy31415
approved these changes
Oct 14, 2021
PR #10502: Size comparison from a654c82 to baf3ff4 24 builds
10 builds
|
msandstedt
approved these changes
Oct 14, 2021
yufengwangca
approved these changes
Oct 14, 2021
Damian-Nordic
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code for different Inet implementations is scattered across many
#if
s.Change overview
Since comparing moved code in diff format is difficult, this change
explicitly does NOT make any changes to function bodies, with one
exception: incorporating the
CloseIOSocket()
bug fix from PR#10452to avoid conflicts.
This is a step toward #7715 Virtualize System and Inet interfaces.
Testing
CI; no change to functionality.