[CI] Add Matter[Pre/Post]CommandReceivedCallback #10500

vivien-apple · 2021-10-14T14:16:28Z

Problem

It uses to be a emberAfPreCommandReceived callback. This is useful in some contexts, notably in CI where you want to observer what is happening on the device.
This PR adds it back as Matter[Pre/Post]CommandReceivedCallback(const chip::app::ConcreteCommandPath & commandPath)

Change overview

Add Matter[Pre/Post]CommandReceivedCallback(const chip::app::ConcreteCommandPath & commandPath)
Update generated content

Testing

At the moment there is no consumer of this API but I'm planning to add some into some accessory test.

github-actions · 2021-10-14T15:45:15Z

PR #10500: Size comparison from 267951c to cd9f00a

34 builds

platform	target	config	section	`267951c`	`cd9f00a`	change	% change
efr32	lighting-app	BRD4161A	.bss	118004	118004	0	0.0
			.data	1800	1800	0	0.0
			.text	780924	780396	-528	-0.1
	lock-app	BRD4161A	.bss	115876	115876	0	0.0
			.data	1760	1760	0	0.0
			.text	760172	760188	16	0.0
	window-app	BRD4161A	.bss	116196	116196	0	0.0
			.data	1764	1764	0	0.0
			.text	761088	761104	16	0.0
	lighting-app	BRD4161A+rpc	.bss	131332	131332	0	0.0
			.data	1852	1852	0	0.0
			.text	760656	760112	-544	-0.1
esp32	all-clusters-app	c3devkit	.dram0.bss	60248	60248	0	0.0
			.dram0.data	16232	16232	0	0.0
			.flash.rodata	198144	198144	0	0.0
			.flash.text	868962	868982	20	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62752	62752	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	206732	206732	0	0.0
			.flash.text	900003	900115	112	0.0
			.iram0.text	125115	125115	0	0.0
k32w	lock-app	k32w061+debug	.bss	69036	69036	0	0.0
			.data	1864	1864	0	0.0
			.text	514056	514072	16	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	356808	356808	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78552	78552	0	0.0
			.data	1900	1900	0	0.0
			.text	612732	612476	-256	-0.0
linux	all-clusters-app	debug	.bss	52144	52144	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58352	58352	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	134773	134901	128	0.1
			.text	1318226	1318338	112	0.0
	chip-tool	debug	.bss	17584	17584	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	77392	77392	0	0.0
			.dynamic	592	592	0	0.0
			.got	4328	4328	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	173664	173792	128	0.1
			.text	2425109	2425317	208	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23112	23112	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	108824	108952	128	0.1
			.text	1005410	`1005522`	112	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24408	24408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	126864	126992	128	0.1
			.text	1125042	1125250	208	0.0
	shell	debug	.bss	16104	16104	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35184	35184	0	0.0
			.dynamic	592	592	0	0.0
			.got	3504	3504	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	71343	71343	0	0.0
			.text	574322	574322	0	0.0
	tv-app	debug	.bss	216368	216368	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55536	55536	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	150536	150632	96	0.1
			.text	1463730	1463938	208	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25480	25480	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	109492	109588	96	0.1
			.text	1047493	1047605	112	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52192	52192	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	126641	127217	576	0.5
			.text	`1248642`	1245554	-3088	-0.2
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172132	172132	0	0.0
			.data	5464	5464	0	0.0
			.heap	858848	858848	0	0.0
			.text	1218656	1218400	-256	-0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171068	171068	0	0.0
			.data	5432	5432	0	0.0
			.heap	859944	859944	0	0.0
			.text	`1196648`	`1196648`	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112304	112304	0	0.0
			rodata	97160	97160	0	0.0
			text	576856	576596	-260	-0.0
	lock-app	nrf52840dk_nrf52840	bss	111336	111336	0	0.0
			rodata	93656	93656	0	0.0
			text	558300	558312	12	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0	0.0
			rodata	45772	45772	0	0.0
			text	339392	339392	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111404	111404	0	0.0
			rodata	94640	94640	0	0.0
			text	561468	561480	12	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111344	111344	0	0.0
			rodata	93716	93716	0	0.0
			text	558076	558088	12	0.0
	shell	nrf52840dk_nrf52840	bss	107320	107320	0	0.0
			rodata	71336	71336	0	0.0
			text	518964	518964	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108544	108544	0	0.0
			rodata	87940	87940	0	0.0
			text	550060	549800	-260	-0.0
		nrf5340dk_nrf5340_cpuapp	bss	113676	113676	0	0.0
			rodata	92400	92400	0	0.0
			text	506316	506056	-260	-0.1
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112708	112708	0	0.0
			rodata	88916	88916	0	0.0
			text	487752	487764	12	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108304	108304	0	0.0
			rodata	65980	65980	0	0.0
			text	439564	439564	0	0.0
p6	lock-app	default	.bss	68208	68208	0	0.0
			.data	2416	2416	0	0.0
			.heap	962720	962720	0	0.0
			.text	1124840	1124856	16	0.0
qpg	lighting-app	qpg6100+debug	.bss	53520	53520	0	0.0
			.data	996	996	0	0.0
			.text	485252	484980	-272	-0.1
	lock-app	qpg6100+debug	.bss	52472	52472	0	0.0
			.data	952	952	0	0.0
			.text	461436	461452	16	0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102704	102704	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70972	70972	0	0.0
			noinit	33216	33216	0	0.0
			text	457428	457132	-296	-0.1

src/app/zap-templates/templates/app/callback-stub-src.zapt

src/app/zap-templates/templates/app/callback.zapt

src/app/zap-templates/templates/app/im-cluster-command-handler.zapt

github-actions · 2021-10-15T08:00:26Z

PR #10500: Size comparison from a56c83e to 36fda10

8 builds

platform	target	config	section	`a56c83e`	`36fda10`	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515572	515588	16
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357680	357680	0
	lighting-app	k32w061+se05x+release	.bss	78568	78568	0
			.data	1900	1900	0
			.text	614244	614260	16
p6	lock-app	default	.bss	68224	68224	0
			.data	2416	2416	0
			.heap	962704	962704	0
			.text	1126784	1126800	16
qpg	lighting-app	qpg6100+debug	.bss	53536	53536	0
			.data	996	996	0
			.text	486504	486520	16
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462696	462712	16
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	70988	70988	0
			noinit	33216	33216	0
			text	458530	458550	20

14 builds

platform	target	config	section	`a56c83e`	`36fda10`	change	% change
efr32	lighting-app	BRD4161A	.bss	118020	118020	0	0.0
			.data	1800	1800	0	0.0
			.text	782924	782940	16	0.0
	lock-app	BRD4161A	.bss	115892	115892	0	0.0
			.data	1760	1760	0	0.0
			.text	762180	762196	16	0.0
	window-app	BRD4161A	.bss	116212	116212	0	0.0
			.data	1764	1764	0	0.0
			.text	763088	763104	16	0.0
	lighting-app	BRD4161A+rpc	.bss	131348	131348	0	0.0
			.data	1852	1852	0	0.0
			.text	762668	762684	16	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58416	58416	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	135797	135925	128	0.1
			.text	1322610	1322722	112	0.0
	chip-tool	debug	.bss	17584	17584	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	83312	83312	0	0.0
			.dynamic	592	592	0	0.0
			.got	4328	4328	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	174560	174688	128	0.1
			.text	`2423429`	`2423557`	128	0.0
	ota-provider-app	debug	.bss	37504	37504	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23192	23192	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	109856	109984	128	0.1
			.text	1010258	1010370	112	0.0
	ota-requestor-app	debug	.bss	205760	205760	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	127936	128064	128	0.1
			.text	`1129922`	1130034	112	0.0
	shell	debug	.bss	16104	16104	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35184	35184	0	0.0
			.dynamic	592	592	0	0.0
			.got	3504	3504	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	72143	72143	0	0.0
			.text	575314	575314	0	0.0
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55568	55568	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	151560	151656	96	0.1
			.text	1468146	1468274	128	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25512	25512	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	110548	110676	128	0.1
			.text	`1051877`	1051989	112	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52256	52256	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	127665	127793	128	0.1
			.text	1253026	1253138	112	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148	0	0.0
			.data	5464	5464	0	0.0
			.heap	858832	858832	0	0.0
			.text	1220096	1220096	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0	0.0
			.data	5432	5432	0	0.0
			.heap	859928	859928	0	0.0
			.text	1198080	1198080	0	0.0

2 builds

platform	target	config	section	`a56c83e`	`36fda10`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60264	60264	0	0.0
			.dram0.data	16232	16232	0	0.0
			.flash.rodata	198632	198632	0	0.0
			.flash.text	870358	870378	20	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62768	62768	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207212	207212	0	0.0
			.flash.text	901511	901439	-72	-0.0
			.iram0.text	125115	125115	0	0.0

10 builds

platform	target	config	section	`a56c83e`	`36fda10`	change
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112320	112320	0
			rodata	97632	97632	0
			text	577824	577836	12
	lock-app	nrf52840dk_nrf52840	bss	111352	111352	0
			rodata	94128	94128	0
			text	559264	559280	16
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111420	111420	0
			rodata	95112	95112	0
			text	562436	562444	8
	pump-controller-app	nrf52840dk_nrf52840	bss	111360	111360	0
			rodata	94188	94188	0
			text	559040	559056	16
	shell	nrf52840dk_nrf52840	bss	107320	107320	0
			rodata	71788	71788	0
			text	519308	519308	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108560	108560	0
			rodata	88416	88416	0
			text	551028	551040	12
		nrf5340dk_nrf5340_cpuapp	bss	113692	113692	0
			rodata	92872	92872	0
			text	507284	507300	16
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112724	112724	0
			rodata	89388	89388	0
			text	488720	488736	16
	shell	nrf5340dk_nrf5340_cpuapp	bss	108304	108304	0
			rodata	66432	66432	0
			text	439908	439908	0

src/app/zap-templates/templates/app/im-cluster-command-handler.zapt

zzz_generated/pump-app/zap-generated/callback-stub.cpp

vivien-apple · 2021-10-18T08:17:38Z

@mrjerryjohns I'm re-requesting review, not because I disagree with your comments, but because I think this is a more general tasks than adding back some features that were existing before IM takes over the command sending/handling.

As said I would be happy to work on it as soon as possible (likely in a few weeks though :/ )

github-actions · 2021-10-18T08:29:58Z

PR #10500: Size comparison from f0b6cbc to 36fda10

8 builds

platform	target	config	section	`f0b6cbc`	`36fda10`	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515176	515192	16
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357172	357172	0
	lighting-app	k32w061+se05x+release	.bss	78560	78560	0
			.data	1900	1900	0
			.text	613800	613816	16
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126280	`1126296`	16
qpg	lighting-app	qpg6100+debug	.bss	53536	53536	0
			.data	996	996	0
			.text	486104	486120	16
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462352	462368	16
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	70984	70984	0
			noinit	33216	33216	0
			text	458146	458164	18

14 builds

platform	target	config	section	`f0b6cbc`	`36fda10`	change	% change
efr32	lighting-app	BRD4161A	.bss	118020	118020	0	0.0
			.data	1800	1800	0	0.0
			.text	782420	782436	16	0.0
	lock-app	BRD4161A	.bss	115892	115892	0	0.0
			.data	1760	1760	0	0.0
			.text	761724	761740	16	0.0
	window-app	BRD4161A	.bss	116212	116212	0	0.0
			.data	1764	1764	0	0.0
			.text	762632	762664	32	0.0
	lighting-app	BRD4161A+rpc	.bss	131348	131348	0	0.0
			.data	1852	1852	0	0.0
			.text	762148	762180	32	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58432	58432	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	135989	136117	128	0.1
			.text	1326066	`1326178`	112	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	83312	83312	0	0.0
			.dynamic	592	592	0	0.0
			.got	4336	4336	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	174560	174656	96	0.1
			.text	2422885	`2422997`	112	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	109848	110008	160	0.1
			.text	1009314	`1009442`	128	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	127896	128024	128	0.1
			.text	1128626	`1128738`	112	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71855	71855	0	0.0
			.text	568898	568898	0	0.0
	tv-app	debug	.bss	216368	216368	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55536	55536	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	151464	151560	96	0.1
			.text	1462818	`1462930`	112	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25496	25496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110484	110612	128	0.1
			.text	`1050821`	1050933	112	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52240	52240	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127665	127793	128	0.1
			.text	1252226	1252338	112	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148	0	0.0
			.data	5464	5464	0	0.0
			.heap	858832	858832	0	0.0
			.text	1219384	1219384	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0	0.0
			.data	5432	5432	0	0.0
			.heap	859928	859928	0	0.0
			.text	1197440	1197440	0	0.0

12 builds

platform	target	config	section	`f0b6cbc`	`36fda10`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60280	60280	0
			.dram0.data	16192	16192	0
			.flash.rodata	198624	198624	0
			.flash.text	870142	870158	16
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62776	62776	0
			.dram0.data	32084	32084	0
			.flash.rodata	207056	207056	0
			.flash.text	900507	900527	20
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112316	112316	0
			rodata	97528	97528	0
			text	577428	577444	16
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0
			rodata	94028	94028	0
			text	558928	558944	16
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0
			rodata	95008	95008	0
			text	562084	562092	8
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0
			rodata	94088	94088	0
			text	558720	558736	16
	shell	nrf52840dk_nrf52840	bss	107316	107316	0
			rodata	71640	71640	0
			text	518908	518908	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108556	108556	0
			rodata	88320	88320	0
			text	550632	550648	16
		nrf5340dk_nrf5340_cpuapp	bss	113688	113688	0
			rodata	92772	92772	0
			text	506888	506900	12
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0
			rodata	89284	89284	0
			text	488380	488396	16
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0
			rodata	66284	66284	0
			text	439504	439504	0

github-actions · 2021-10-19T09:09:30Z

PR #10500: Size comparison from 4c7f664 to 8ec6d8b

2 builds (for p6, telink)

platform	target	config	section	`4c7f664`	`8ec6d8b`	change
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126624	1126640	16
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0
			noinit	33216	33216	0
			text	458304	458320	16

18 builds (for efr32, k32w, linux, qpg)

platform	target	config	section	`4c7f664`	`8ec6d8b`	change	% change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0	0.0
			.data	1800	1800	0	0.0
			.text	782944	782960	16	0.0
	lock-app	BRD4161A	.bss	115892	115892	0	0.0
			.data	1760	1760	0	0.0
			.text	762088	762104	16	0.0
	window-app	BRD4161A	.bss	116212	116212	0	0.0
			.data	1764	1764	0	0.0
			.text	763012	763028	16	0.0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0	0.0
			.data	1852	1852	0	0.0
			.text	762700	762716	16	0.0
k32w	lock-app	k32w061+debug	.bss	69052	69052	0	0.0
			.data	1864	1864	0	0.0
			.text	515520	515536	16	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357332	357332	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0	0.0
			.data	1900	1900	0	0.0
			.text	614304	614304	0	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136373	136501	128	0.1
			.text	1345186	1345298	112	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	86192	86192	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	178892	178988	96	0.1
			.text	`2859941`	2860053	112	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110056	110184	128	0.1
			.text	1010594	1010706	112	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128744	128872	128	0.1
			.text	1130130	`1130258`	128	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71855	71855	0	0.0
			.text	569858	569858	0	0.0
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152264	152360	96	0.1
			.text	1464706	1464834	128	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110644	110772	128	0.1
			.text	1052629	`1052741`	112	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127857	127985	128	0.1
			.text	1253906	1254018	112	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486616	486616	0	0.0
	lock-app	qpg6100+debug	.bss	52488	52488	0	0.0
			.data	952	952	0	0.0
			.text	462684	462700	16	0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102704	102704	0	0.0

2 builds (for mbed)

platform	target	config	section	`4c7f664`	`8ec6d8b`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164
			.data	5464	5464
			.heap	858816	858816
			.text	1219944	1219944
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197840	1197840

12 builds (for esp32, nrfconnect)

platform	target	config	section	`4c7f664`	`8ec6d8b`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0
			.dram0.data	16192	16192	0
			.flash.rodata	199008	199008	0
			.flash.text	872638	872654	16
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62792	62792	0
			.dram0.data	32084	32084	0
			.flash.rodata	207432	207432	0
			.flash.text	902739	902851	112
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0
			rodata	97776	97776	0
			text	577652	577660	8
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0
			rodata	94112	94112	0
			text	559152	559164	12
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0
			rodata	95092	95092	0
			text	562308	562312	4
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0
			rodata	94172	94172	0
			text	558944	558952	8
	shell	nrf52840dk_nrf52840	bss	107316	107316	0
			rodata	71640	71640	0
			text	519032	519032	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0
			rodata	88560	88560	0
			text	550856	550864	8
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0
			rodata	93016	93016	0
			text	507116	507124	8
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0
			rodata	89372	89372	0
			text	488612	488620	8
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0
			rodata	66284	66284	0
			text	439632	439632	0

github-actions · 2021-10-19T10:11:28Z

Size increase report for "nrfconnect-example-build" from 4c7f664

File	Section	File	VM
chip-lock.elf	text	12	12
chip-lock.elf	device_handles	4	4

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,118
.debug_str,0,114
.debug_line,0,109
.debug_loc,0,106
.strtab,0,81
.debug_abbrev,0,37
.symtab,0,32
.debug_frame,0,20
text,12,12
.debug_aranges,0,8
.debug_ranges,0,8
device_handles,4,4
.shstrtab,0,3

github-actions · 2021-10-19T10:11:39Z

Size increase report for "esp32-example-build" from 4c7f664

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	16	16

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_str,0,114
.debug_line,0,104
.strtab,0,81
.debug_loc,0,50
.debug_ranges,0,32
.debug_frame,0,28
.debug_abbrev,0,22
.flash.text,16,16
.symtab,0,16
.debug_aranges,0,8
.riscv.attributes,0,2
.shstrtab,0,-1
.debug_info,0,-16
[Unmapped],0,-16

woody-apple · 2021-10-22T16:39:15Z

Fast tracking this, given we're past 3 days, and this is blocking testing.

@vivien-apple can you resolve conflicts please?

woody-apple · 2021-10-27T01:56:50Z

Fast tracking pending CI, given enough time for review has passed and comments seem resolved

woody-apple · 2021-10-27T06:51:59Z

/rebase

…is happening onto the stack

vivien-apple · 2021-11-02T16:20:07Z

I have updated a bit the code so there is no stub generation anymore, but instead hardcoded stubs. This is not the final solution I would like but this will unlock CI so it is probably better to not wait for the final solution and land that as if.

github-actions · 2021-11-02T16:48:12Z

PR #10500: Size comparison from e24e76c to 7033115

Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`e24e76c`	`7033115`	change
efr32	lighting-app	BRD4161A	(read only)	736548	736628	80
			.text	736540	736620	80
		BRD4161A+rpc	(read only)	723988	724068	80
			.text	723980	724060	80
	lock-app	BRD4161A	(read only)	715828	715908	80
			.text	715820	715900	80
	window-app	BRD4161A	(read only)	716728	716808	80
			.text	716720	716800	80
esp32	all-clusters-app	c3devkit	(read only)	880486	880586	100
			.flash.text	880486	880586	100
		m5stack	(read only)	911583	911663	80
			.flash.text	911583	911663	80
k32w	lighting-app	k32w061+se05x+release	(read/write)	699048	699128	80
			.text	613492	613572	80
	lock-app	k32w061+debug	(read/write)	591356	591436	80
			.text	515320	515400	80
linux	all-clusters-app	debug	(read only)	1689169	1689473	304
			.text	1416514	1416818	304
	bridge-app	debug+rpc	(read only)	1282077	1282381	304
			.text	`1075669`	1075973	304
	chip-tool	debug	(read only)	4324637	4324941	304
			.text	3840709	3841013	304
	lighting-app	debug+rpc	(read only)	1541433	1541753	320
			.text	1279762	`1280082`	320
	ota-provider-app	debug	(read only)	1241929	1242249	320
			.text	1034066	1034386	320
	ota-requestor-app	debug	(read only)	`1309225`	1309529	304
			.text	1088754	1089058	304
	tv-app	debug	(read only)	1789321	1789625	304
			.text	1492546	`1492850`	304
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read/write)	2292664	2292872	208
			.text	1255264	1255472	208
	lighting-app	CY8CPROTO_062_4343W+release	(read/write)	2271608	`2271816`	208
			.text	`1234208`	`1234416`	208
	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2249328	2249536	208
			.text	`1211928`	`1212136`	208
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	860983	861063	80
			text	577512	577584	72
		nrf52840dk_nrf52840+rpc	(read/write)	821807	821871	64
			text	550688	550756	68
		nrf5340dk_nrf5340_cpuapp	(read/write)	786010	786090	80
			text	506980	507048	68
	lock-app	nrf52840dk_nrf52840	(read/write)	837675	837755	80
			text	558992	559064	72
		nrf5340dk_nrf5340_cpuapp	(read/write)	762986	763050	64
			text	488552	488620	68
	pump-app	nrf52840dk_nrf52840	(read/write)	843783	843863	80
			text	563172	563244	72
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	837547	837611	64
			text	558728	558800	72
p6	lock-app	default	(read/write)	2167688	2167768	80
			.text	1125952	1126032	80
qpg	lighting-app	qpg6100+debug	(read only)	490328	490400	72
			.text	485008	485080	72
	lock-app	qpg6100+debug	(read only)	466668	466740	72
			.text	461348	461420	72
telink	lighting-app	tlsr9518adk80d	(read/write)	662382	662486	104
			text	457774	457876	102

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`e24e76c`	`7033115`	change
efr32	lighting-app	BRD4161A	(read only)	736548	736628	80
			(read/write)	114612	114612	0
			.bss	112852	112852	0
			.data	1760	1760	0
			.text	736540	736620	80
		BRD4161A+rpc	(read only)	723988	724068	80
			(read/write)	131216	131216	0
			.bss	129356	129356	0
			.data	1860	1860	0
			.text	723980	724060	80
	lock-app	BRD4161A	(read only)	715828	715908	80
			(read/write)	112428	112428	0
			.bss	110708	110708	0
			.data	1720	1720	0
			.text	715820	715900	80
	window-app	BRD4161A	(read only)	716728	716808	80
			(read/write)	112756	112756	0
			.bss	111028	111028	0
			.data	1724	1724	0
			.text	716720	716800	80
esp32	all-clusters-app	c3devkit	(read only)	880486	880586	100
			(read/write)	1307776	1307776	0
			.dram0.bss	58592	58592	0
			.dram0.data	16464	16464	0
			.flash.rodata	199488	199488	0
			.flash.text	880486	880586	100
			.iram0.text	57554	57554	0
		m5stack	(read only)	911583	911663	80
			(read/write)	427544	427544	0
			.dram0.bss	61088	61088	0
			.dram0.data	32100	32100	0
			.flash.rodata	208192	208192	0
			.flash.text	911583	911663	80
			.iram0.text	125115	125115	0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699048	699128	80
			.bss	77848	77848	0
			.data	1908	1908	0
			.text	613492	613572	80
	lock-app	k32w061+debug	(read/write)	591356	591436	80
			.bss	68364	68364	0
			.data	1872	1872	0
			.text	515320	515400	80
	shell	k32w061+debug	(read/write)	424748	424748	0
			.bss	63288	63288	0
			.data	672	672	0
			.text	359084	359084	0
linux	all-clusters-app	debug	(read only)	1689169	1689473	304
			(read/write)	119664	119664	0
			.bss	51120	51120	0
			.data	1042	1042	0
			.data.rel.ro	62240	62240	0
			.dynamic	592	592	0
			.got	4088	4088	0
			.init	27	27	0
			.init_array	536	536	0
			.rodata	139285	139285	0
			.text	1416514	1416818	304
	bridge-app	debug+rpc	(read only)	1282077	1282381	304
			(read/write)	68488	68488	0
			.bss	35024	35024	0
			.data	992	992	0
			.data.rel.ro	27496	27496	0
			.dynamic	592	592	0
			.got	3952	3952	0
			.init	27	27	0
			.init_array	400	400	0
			.rodata	110852	110852	0
			.text	`1075669`	1075973	304
	chip-tool	debug	(read only)	4324637	4324941	304
			(read/write)	123936	123936	0
			.bss	18192	18192	0
			.data	1584	1584	0
			.data.rel.ro	98744	98744	0
			.dynamic	592	592	0
			.got	4368	4368	0
			.init	27	27	0
			.init_array	424	424	0
			.rodata	218512	218512	0
			.text	3840709	3841013	304
	lighting-app	debug+rpc	(read only)	1541433	1541753	320
			(read/write)	101680	101680	0
			.bss	40696	40696	0
			.data	1138	1138	0
			.data.rel.ro	54560	54560	0
			.dynamic	608	608	0
			.got	4112	4112	0
			.init	27	27	0
			.init_array	528	528	0
			.rodata	128977	128977	0
			.text	1279762	`1280082`	320
	ota-provider-app	debug	(read only)	1241929	1242249	320
			(read/write)	67520	67520	0
			.bss	37120	37120	0
			.data	752	752	0
			.data.rel.ro	24568	24568	0
			.dynamic	592	592	0
			.got	4016	4016	0
			.init	27	27	0
			.init_array	440	440	0
			.rodata	111784	111784	0
			.text	1034066	1034386	320
	ota-requestor-app	debug	(read only)	`1309225`	1309529	304
			(read/write)	76840	76840	0
			.bss	45376	45376	0
			.data	816	816	0
			.data.rel.ro	25512	25512	0
			.dynamic	592	592	0
			.got	3984	3984	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	122752	122752	0
			.text	1088754	1089058	304
	shell	debug	(read only)	785809	785809	0
			(read/write)	57664	57664	0
			.bss	16104	16104	0
			.data	242	242	0
			.data.rel.ro	36816	36816	0
			.dynamic	592	592	0
			.got	3528	3528	0
			.init	27	27	0
			.init_array	336	336	0
			.rodata	77551	77551	0
			.text	606770	606770	0
	tv-app	debug	(read only)	1789321	1789625	304
			(read/write)	289240	289240	0
			.bss	222736	222736	0
			.data	2064	2064	0
			.data.rel.ro	58784	58784	0
			.dynamic	592	592	0
			.got	4408	4408	0
			.init	27	27	0
			.init_array	608	608	0
			.rodata	154584	154584	0
			.text	1492546	`1492850`	304
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2292664	2292872	208
			.bss	179956	179956	0
			.data	5224	5224	0
			.heap	851264	851264	0
			.text	1255264	1255472	208
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2271608	`2271816`	208
			.bss	172004	172004	0
			.data	5576	5576	0
			.heap	858864	858864	0
			.text	`1234208`	`1234416`	208
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2249328	2249536	208
			.bss	170900	170900	0
			.data	5560	5560	0
			.heap	859984	859984	0
			.text	`1211928`	`1212136`	208
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	1139744	1139744	0
			.bss	11752	11752	0
			.data	4368	4368	0
			.heap	1020328	1020328	0
			.text	103128	103128	0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2048392	2048392	0
			.bss	156248	156248	0
			.data	4968	4968	0
			.heap	875232	875232	0
			.text	1010992	1010992	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	860983	861063	80
			bss	111312	111312	0
			rodata	96536	96536	0
			text	577512	577584	72
		nrf52840dk_nrf52840+rpc	(read/write)	821807	821871	64
			bss	107552	107552	0
			rodata	87312	87312	0
			text	550688	550756	68
		nrf5340dk_nrf5340_cpuapp	(read/write)	786010	786090	80
			bss	112688	112688	0
			rodata	91780	91780	0
			text	506980	507048	68
	lock-app	nrf52840dk_nrf52840	(read/write)	837675	837755	80
			bss	110348	110348	0
			rodata	92892	92892	0
			text	558992	559064	72
		nrf5340dk_nrf5340_cpuapp	(read/write)	762986	763050	64
			bss	111756	111756	0
			rodata	88196	88196	0
			text	488552	488620	68
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0
			bss	51824	51824	0
			rodata	45776	45776	0
			text	339436	339436	0
	pump-app	nrf52840dk_nrf52840	(read/write)	843783	843863	80
			bss	110484	110484	0
			rodata	94600	94600	0
			text	563172	563244	72
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	837547	837611	64
			bss	110384	110384	0
			rodata	92892	92892	0
			text	558728	558800	72
	shell	nrf52840dk_nrf52840	(read/write)	775867	775867	0
			bss	109104	109104	0
			rodata	72400	72400	0
			text	519772	519772	0
		nrf5340dk_nrf5340_cpuapp	(read/write)	690922	690922	0
			bss	110084	110084	0
			rodata	67044	67044	0
			text	440372	440372	0
p6	lock-app	default	(read/write)	2167688	2167768	80
			.bss	66352	66352	0
			.data	2424	2424	0
			.heap	964568	964568	0
			.text	1125952	1126032	80
qpg	lighting-app	qpg6100+debug	(read only)	490328	490400	72
			(read/write)	114144	114144	0
			.bss	50408	50408	0
			.data	1008	1008	0
			.text	485008	485080	72
	lock-app	qpg6100+debug	(read only)	466668	466740	72
			(read/write)	114140	114140	0
			.bss	49352	49352	0
			.data	964	964	0
			.text	461348	461420	72
	persistent-storage-app	qpg6100+debug	(read only)	155796	155796	0
			(read/write)	114140	114140	0
			.bss	27760	27760	0
			.data	372	372	0
			.text	150476	150476	0
telink	lighting-app	tlsr9518adk80d	(read/write)	662382	662486	104
			bss	69116	69116	0
			noinit	33216	33216	0
			text	457774	457876	102

…is happening onto the stack (project-chip#10500)

vivien-apple self-assigned this Oct 14, 2021

boring-cyborg bot added the app label Oct 14, 2021

pullapprove bot requested review from wbschiller and woody-apple October 14, 2021 14:17

pullapprove bot added the review - pending label Oct 14, 2021

vivien-apple changed the title ~~Ci matter pre post received command~~ [CI] Add Matter[Pre/Post]CommandReceivedCallback Oct 14, 2021

bzbarsky-apple approved these changes Oct 14, 2021

View reviewed changes

src/app/zap-templates/templates/app/callback-stub-src.zapt Outdated Show resolved Hide resolved

src/app/zap-templates/templates/app/callback.zapt Outdated Show resolved Hide resolved

src/app/zap-templates/templates/app/im-cluster-command-handler.zapt Outdated Show resolved Hide resolved

vivien-apple force-pushed the CI_MatterPrePostReceivedCommand branch from cd9f00a to 36fda10 Compare October 15, 2021 07:39

mrjerryjohns suggested changes Oct 15, 2021

View reviewed changes

src/app/zap-templates/templates/app/im-cluster-command-handler.zapt Outdated Show resolved Hide resolved

zzz_generated/pump-app/zap-generated/callback-stub.cpp Outdated Show resolved Hide resolved

vivien-apple force-pushed the CI_MatterPrePostReceivedCommand branch 2 times, most recently from 9c4d67d to 36fda10 Compare October 18, 2021 08:10

vivien-apple requested a review from mrjerryjohns October 18, 2021 08:17

vivien-apple force-pushed the CI_MatterPrePostReceivedCommand branch from 36fda10 to 8ec6d8b Compare October 19, 2021 08:50

woody-apple added the fast track label Oct 22, 2021

woody-apple approved these changes Oct 22, 2021

View reviewed changes

woody-apple added the has conflicts label Oct 27, 2021

Add src/app/MatterCallbacks.h for allowing applications to know what …

7033115

…is happening onto the stack

vivien-apple force-pushed the CI_MatterPrePostReceivedCommand branch from 8ec6d8b to 7033115 Compare November 2, 2021 16:19

bzbarsky-apple merged commit 24902cc into project-chip:master Nov 2, 2021

PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021

Add src/app/MatterCallbacks.h for allowing applications to know what …

c21e564

…is happening onto the stack (project-chip#10500)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Add Matter[Pre/Post]CommandReceivedCallback #10500

[CI] Add Matter[Pre/Post]CommandReceivedCallback #10500

vivien-apple commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 15, 2021 •

edited

Loading

vivien-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021

github-actions bot commented Oct 19, 2021

woody-apple commented Oct 22, 2021

woody-apple commented Oct 27, 2021

woody-apple commented Oct 27, 2021

vivien-apple commented Nov 2, 2021

github-actions bot commented Nov 2, 2021 •

edited

Loading

[CI] Add Matter[Pre/Post]CommandReceivedCallback #10500

[CI] Add Matter[Pre/Post]CommandReceivedCallback #10500

Conversation

vivien-apple commented Oct 14, 2021

Problem

Change overview

Testing

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 15, 2021 • edited Loading

vivien-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 • edited Loading

github-actions bot commented Oct 19, 2021 • edited Loading

github-actions bot commented Oct 19, 2021

github-actions bot commented Oct 19, 2021

woody-apple commented Oct 22, 2021

woody-apple commented Oct 27, 2021

woody-apple commented Oct 27, 2021

vivien-apple commented Nov 2, 2021

github-actions bot commented Nov 2, 2021 • edited Loading

github-actions bot commented Oct 15, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Nov 2, 2021 •

edited

Loading